3afc3b58d0
Add dartfix protocol integration tests
...
... and address comments in https://dart-review.googlesource.com/c/sdk/+/91780
Change-Id: Ibd01a0de575065cf18822b806a9c687de2667add
Reviewed-on: https://dart-review.googlesource.com/c/92243
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
2019-02-07 06:21:57 +00:00
d4b8e0696d
Add the capability in analysis server protocol for clients to express
...
interest in receiving not yet imported code completions from specific
packages and libraries.
The design of this interaction aims to avoid forcing analysis server
to send every public symbol from dependent packages at every completion.
Instead, clients express interest in certain packages and/or libraries
and analysis server will notify with the entire set of symbols for
each of them only once. Then it is the client's responsibility to save
these pre-computed completions in memory, and analysis server can
instruct the client on how to union them with the base set of completion
suggestions at code completion time.
Bug: https://github.com/dart-lang/sdk/issues/35680
Change-Id: I42c6fddc5d8daa2b546daa81456c0992e3ef547d
Reviewed-on: https://dart-review.googlesource.com/c/90125
Commit-Queue: Ari Aye <ariaye@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-01-31 19:56:18 +00:00
db44a727e5
Extend the edit.dartfix protocol
...
This CL extends the dartfix protocol to allow specifying which
fixes should be applied. In summary:
* includedFixes - list of fix names to be applied
* includeRequiredFixes - bool indicating required fixes should be applied
* excludedFixes - list of fix names that should not be applied
Given that the client can specify the fixes to be included/excluded,
then the dartfix cmdline help text should include the list of known fixes.
Rather than hard code this in the dartfix client, a new edit.getDartfix
request has been added to return the list of known fixes.
Change-Id: I319f6f405a5d29757bf28b70b778a449f901bbef
Reviewed-on: https://dart-review.googlesource.com/c/91700
Commit-Queue: Dan Rubel <danrubel@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-01-31 01:53:32 +00:00
c624f8b0a9
First cut dartfix protocol
...
and address comments in https://dart-review.googlesource.com/c/sdk/+/76320
Change-Id: I5c7ab40810d4116b1d36de90b7234d0a932bae82
Reviewed-on: https://dart-review.googlesource.com/76400
Commit-Queue: Dan Rubel <danrubel@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-09-25 16:56:48 +00:00
ebb033cb72
Add signature information to spec and add basic implementation for functions
...
Bug: https://github.com/dart-lang/sdk/issues/27034
Change-Id: I8d3f1a9c9a824b4b80f9cfa0370a439fa897b226
Reviewed-on: https://dart-review.googlesource.com/64689
Commit-Queue: Danny Tuppeny <dantup@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-07-25 07:16:52 +00:00
e3966fcfb9
Protocol for runtime completion.
...
This protocol will be used to support "Evaluate Expression" and "Watch"
window features in IDEs.
Change-Id: Ibde1e88507a66d8c487836a227dfeb13ffd77d9d
Reviewed-on: https://dart-review.googlesource.com/54629
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Jacob Richman <jacobr@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-05-11 22:23:42 +00:00
6e25b9b2d3
Add flutter.getChangeAddForDesignTimeConstructor to API.
...
R=brianwilkerson@google.com
Change-Id: I91e40c447d32e603026de337ec2d36983174a8cd
Reviewed-on: https://dart-review.googlesource.com/49826
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-04-06 02:40:00 +00:00
8fa5567edb
API for search.getElementDeclarations.
...
The goal is to provide clients (specifically VS Code) with API that
is fast, and can search top-level and class member declarations.
I'm not sure whether we want ElementKind, it has kinds that we will
not use, e.g. I don't think we will return local variables or
parameters.
It would be probably still a lot of information, maybe we should use
single string table in response?
R=brianwilkerson@google.com
Bug: https://github.com/dart-lang/sdk/issues/29510
Change-Id: Ie31bb398a08d462c1cb08c7d82c4443c0c09932a
Reviewed-on: https://dart-review.googlesource.com/42105
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-02-17 04:27:52 +00:00
402af4db46
Add a new experimental 'flutter' domain and move FLUTTER_OUTLINE there.
...
R=brianwilkerson@google.com , devoncarew@google.com
Change-Id: I8f829f10a630e38c5a3f1638d077e37832a08daa
Reviewed-on: https://dart-review.googlesource.com/36320
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-01-23 00:57:55 +00:00
a971aa8472
Add basic Flutter outline subscription/notification to the protocol.
...
R=brianwilkerson@google.com , devoncarew@google.com
Change-Id: I50d7e4507c58854b4f2afc6048285c68ee873b8b
Reviewed-on: https://dart-review.googlesource.com/36024
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-01-19 23:22:17 +00:00
37042bb59b
Add an integration test for kythe support with bug fixes
...
R=jwren@google.com
Review-Url: https://codereview.chromium.org/3006693002 .
2017-08-28 10:07:04 -07:00
305e84f70a
Fix the buildbots by adding a line for kythe.getKytheEntries to the coverage.md file
...
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/2993353002 .
2017-08-09 13:40:09 -07:00
973d0e1bd1
Add analysis server notifications to the api coverage doc.
...
BUG=
R=brianwilkerson@google.com , scheglov@google.com
Review-Url: https://codereview.chromium.org/3000563002 .
2017-08-09 10:28:35 -07:00
d9754a58e9
Initial implementation of copy/paste support
...
R=devoncarew@google.com
Review-Url: https://codereview.chromium.org/2972833002 .
2017-07-05 14:02:07 -07:00
8c8a177f3c
Fix failing test (TBR)
...
Review-Url: https://codereview.chromium.org/2964343002 .
2017-07-01 12:55:17 -07:00
8c50e08e64
Add integration tests for postfix serer api
...
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/2961683002 .
2017-06-26 13:13:21 -07:00
4c8e1b9132
Update coverage.md
...
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/2960683002 .
2017-06-26 11:21:50 -07:00
4da8380881
Convert more tests to use the new driver
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2939803002 .
2017-06-13 12:04:25 -07:00
511963d715
Add an analytics domain to the analysis server.
...
BUG=
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/2922603002 .
2017-06-02 14:38:53 -07:00
3d2d913969
Add analysis server integration tests.
...
BUG=
R=brianwilkerson@google.com , messick@google.com
Review-Url: https://codereview.chromium.org/2909823002 .
2017-05-27 15:55:53 -07:00
d02519aec4
Make the analysis server integration tests driver only.
...
BUG=
R=brianwilkerson@google.com , scheglov@google.com
Review-Url: https://codereview.chromium.org/2820893002 .
2017-04-17 11:23:38 -07:00
fb4828d2e1
Add integration tests for edit.getAssists and edit.getFixes.
...
BUG=
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2812483002 .
2017-04-10 07:50:12 -07:00
e572bf93ec
Add 4 integration tests for the analysis domain.
...
BUG=
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2808623002 .
2017-04-08 20:56:00 -07:00
543d0dc20e
Update coverage testing
...
R=devoncarew@google.com
Review-Url: https://codereview.chromium.org/2780393004 .
2017-03-30 11:15:55 -07:00
a83e7fd18e
Add analysis server integration tests for the search domain.
...
BUG=
R=brianwilkerson@google.com , scheglov@google.com
Review-Url: https://codereview.chromium.org/2747893004 .
2017-03-13 17:06:13 -07:00
25dfd0fa80
Deprecate execution.setSubscriptions.
...
BUG=
R=brianwilkerson@google.com , scheglov@google.com
Review-Url: https://codereview.chromium.org/2713513007 .
2017-02-24 11:01:00 -08:00
fbb613a3fe
Update the statuses of various analysis server integration tests.
...
BUG=
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2717523003 .
2017-02-23 14:23:55 -08:00
7f83d9d173
Add a diagnostic.getServerPort analysis server request.
...
BUG=
R=brianwilkerson@google.com , scheglov@google.com
Review-Url: https://codereview.chromium.org/2703033002 .
2017-02-19 15:19:40 -08:00
7c7c895345
Add an integration test for execution.setSubscriptions.
...
BUG=
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/2703723002 .
2017-02-17 07:41:03 -08:00
5e0710617d
Tests for analysis.navigation.
...
BUG=
R=brianwilkerson@google.com , scheglov@google.com
Review-Url: https://codereview.chromium.org/2696323004 .
2017-02-16 14:35:20 -08:00
3a345935bf
Add tests for edit.sortMembers and edit.organizeDirectives.
...
BUG=
R=brianwilkerson@google.com , scheglov@google.com
Review-Url: https://codereview.chromium.org/2700563003 .
2017-02-15 16:15:10 -08:00
b1bc83b6d2
Add an integration test for edit.format.
...
BUG=
R=brianwilkerson@google.com , scheglov@google.com
Review-Url: https://codereview.chromium.org/2695253002 .
2017-02-15 07:23:21 -08:00
90bd4652aa
Add an integration test for diagnostics.getDiagnostics.
...
BUG=
R=brianwilkerson@google.com , scheglov@google.com
Review-Url: https://codereview.chromium.org/2697833005 .
2017-02-14 14:36:38 -08:00
4667e59e85
Add integration tests for the execution domain.
...
BUG=
R=brianwilkerson@google.com , scheglov@google.com
Review-Url: https://codereview.chromium.org/2691763002 .
2017-02-12 11:23:33 -08:00
bc9cadac04
Add tests to vaildate the analysis server's integration test coverage.
...
BUG=
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/2685883005 .
2017-02-09 14:26:26 -08:00
danrubel