1c1497ff98
Another tweak for displaying performance.
...
1. It is still interesting to see performance tags, even with the next task model.
2. Factor out "WorkOrder.moveNext" as a separate performance tag, something like "intertask" for new tasks.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1161183004
2015-06-05 09:19:28 -07:00
4224b9c049
fix ENUM_CONSTANT suggestions
...
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1157283004
2015-06-04 18:01:06 -04:00
3cbd3e2e96
Tweak ADD_PART_OF quick fix to support both new/old task models.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1165943003
2015-06-04 14:28:35 -07:00
c1e2448928
Tweak for the new task statistics formatting.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1147043006
2015-06-04 11:49:37 -07:00
4b082cb871
cleanup local reference contributor
...
BUG=
R=paulberry@google.com
Review URL: https://codereview.chromium.org//1163973004
2015-06-04 14:18:03 -04:00
aec339a767
Expose timing data for the new task model in the status pages
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1169573003
2015-06-04 10:47:04 -07:00
a567814119
Replace 'Element.node' with 'Element.computeNode()'.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1164823003
2015-06-02 13:25:04 -07:00
8e439849b3
Issue 23573. Catch exception during indexing.
...
R=paulberry@google.com
BUG=https://code.google.com/p/dart/issues/detail?id=23573
Review URL: https://codereview.chromium.org//1168473003
2015-06-02 09:40:20 -07:00
40e925078f
Bug fixes for the new task model
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1144393006
2015-06-01 16:42:36 -07:00
aad76fdcbf
Issue 23568. Fix for NPE in index when unresolved field formal parameter.
...
R=brianwilkerson@google.com
BUG=https://code.google.com/p/dart/issues/detail?id=23568
Review URL: https://codereview.chromium.org//1162853004
2015-06-01 15:08:33 -07:00
b9cdbace93
Issue 23545. Replace unaccessible type parameters with 'dynamic'.
...
R=brianwilkerson@google.com
BUG=https://code.google.com/p/dart/issues/detail?id=23545
Review URL: https://codereview.chromium.org//1147213005
2015-06-01 14:50:39 -07:00
a3a40c9ef6
Issue 11200. Quick Fix for adding required/positional parameters.
...
R=brianwilkerson@google.com
BUG=https://code.google.com/p/dart/issues/detail?id=11200
Review URL: https://codereview.chromium.org//1159273004
2015-06-01 14:48:50 -07:00
be9cd1c165
Issue 23551. Fix for using type parameters of the enclosed classes in 'Create Missing Overrides' Quick Fix.
...
R=brianwilkerson@google.com
BUG=https://code.google.com/p/dart/issues/detail?id=23551
Review URL: https://codereview.chromium.org//1151183003
2015-06-01 14:19:33 -07:00
717da6731b
Eliminate Modifier.TYPEDEF and deprecate ClassElement.isTypedef.
...
Modifier.TYPEDEF was redundant with Modifier.MIXIN_APPLICATION and
ClassElement.isTypedef was redundant with
ClassElement.isMixinApplication.
Since Modifier.TYPEDEF was private to analyzer, it has been
eliminated. Since ClassElement.isTypedef is part of the public API to
analyzer, it is retained, but with a "@deprecated" annotation.
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1158193008
2015-06-01 14:17:40 -07:00
c1c0354014
Issue 23239. Fix for 'Create Class' Quick Fix i case of prefixed names.
...
R=brianwilkerson@google.com
BUG=https://code.google.com/p/dart/issues/detail?id=23239
Review URL: https://codereview.chromium.org//1161333002
2015-06-01 12:26:39 -07:00
f118546d06
Issue 23332. Don't compute overrides for static members.
...
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=23332
Review URL: https://codereview.chromium.org//1151573011
2015-06-01 10:42:22 -07:00
5b44136f2a
Issue 23389. Report error in the renamed element be invisible after rename.
...
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=23389
Review URL: https://codereview.chromium.org//1153253004
2015-06-01 10:40:59 -07:00
213f0322f9
Fix missed version number
...
R=jwren@google.com
Review URL: https://codereview.chromium.org//1165763002
2015-06-01 09:50:57 -07:00
07dd6b7649
Add lineLength parameter to edit.format request (issue 23519)
...
R=jwren@google.com
Review URL: https://codereview.chromium.org//1154303005
2015-06-01 09:39:02 -07:00
0e39092fd0
add enum suggestions
...
and update LocalDeclarationVisitor to visit enum declarations
BUG=
R=paulberry@google.com
Review URL: https://codereview.chromium.org//1157113004
2015-06-01 12:10:46 -04:00
089038b085
Move index closer to the plugin API
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1156493004
2015-06-01 08:25:40 -07:00
ecf44e960d
remove keyword suggestions in constructor names and prefixed expressions
...
BUG=
R=paulberry@google.com
Review URL: https://codereview.chromium.org//1158413003
2015-05-29 13:28:34 -04:00
535394c265
Remove debugging print statements.
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1149063005
2015-05-27 20:24:06 -07:00
45862f401e
Send 'execution.launchData' only after full resolution.
...
We don't need to send them after each and every notice.
This information becomes ready somewhere in between parsing and full resolution.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1157823002
2015-05-24 10:39:21 -07:00
ad52c9eab9
Add support for specifying files needing analysis
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1152013002
2015-05-21 14:34:04 -07:00
0ce6fb29a6
Propogate and handle lint analysis option.
...
BUG=
R=brianwilkerson@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//1131373004
2015-05-19 15:13:26 -07:00
d5774c5402
Issue 23481. Fix for creating a new class referenced from an inner local function.
...
R=paulberry@google.com , brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=23481
Review URL: https://codereview.chromium.org//1144893002
2015-05-19 12:10:50 -07:00
8851388c43
Check for null in 'Create Class' Quick Fix.
...
I don't know how to reproduce it.
How is it possible to have a type name outside a CompilationUnitMember?
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1149473002
2015-05-19 09:35:40 -07:00
4013b08863
Quick Fix for missing 'part of' directive.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1146573003
2015-05-18 16:32:23 -07:00
7e8f650d35
Use short names in 'Create File' Quick Fix messages.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1147733002
2015-05-18 12:47:40 -07:00
4936eb8d5d
Fix for 'Create part' Quick Fix.
...
1. NonExistingSource.modificationStamp should return -1.
2. NonExistingSource.fullName should be always an absolute path, not a URI.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1135073004
2015-05-18 11:55:23 -07:00
d798e3e262
Issue 23477. Fix for Quick Fixes in overlay-only files.
...
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=23477
Review URL: https://codereview.chromium.org//1145443003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45826 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-15 20:47:03 +00:00
2c27356c32
Sort imports by package names, then by file paths.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1131523005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45822 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-15 20:00:44 +00:00
7344dcc35c
[WEB-16445] When create a missing imported library/part, add the edit once.
...
R=brianwilkerson@google.com
BUG= https://youtrack.jetbrains.com/issue/WEB-16445
Review URL: https://codereview.chromium.org//1147543002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45813 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-15 16:22:01 +00:00
f058a6ad33
Tweaks for using task model in Editor.
...
It works in general, bug currently it is buggy and slow.
Notes:
1. Implicit dependencies backfire.
If the cache size is not big enough and we end up flushing some CU, then recreating it, it looses its LibraryElement.
We need an explicit dependency on it.
2. If the cache size is not big enough, this still may cause an infinite analysis cycle.
3. We need to implement activating / deactivating cache partitions to change cache size.
4. Probably we need to set LineInfo into ChangeNotice always.
5. There are bugs in type hierarchy.
6. Semantic highlighting takes too long to display.
7. Overlay changes are not used.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1125303008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45811 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-15 15:04:50 +00:00
ee3263c22c
reduce rethrow keyword relevance
...
so that return is prioritized over rethrow
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1135243006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45809 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-15 02:35:23 +00:00
0bf3812043
Fix exception in code completion (issue 23439)
...
R=danrubel@google.com
Review URL: https://codereview.chromium.org//1138963005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45805 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-15 00:00:59 +00:00
3ffb42cd22
Sort enum declarations.
...
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org//1136413003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45801 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-14 22:42:16 +00:00
e73c0efc45
Fix server error messages
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1141773002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45775 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-13 20:05:45 +00:00
6e25226a0d
Issue 23444. Use ConstructorMember(s) for super constructor fixes.
...
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=23444
Review URL: https://codereview.chromium.org//1140963002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45765 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-13 16:13:09 +00:00
a0099fc922
suggest async for closures
...
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1135613004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45711 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-11 19:30:35 +00:00
4e3e55276a
suggest keywords for more expressions
...
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1141443002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45708 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-11 19:17:44 +00:00
d2164273da
check for package lib exist before making package suggestions
...
BUG=dartbug.com/23428
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1128833003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45706 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-11 18:48:15 +00:00
81e474c43e
Clean up many generated constructors
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1131423002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45676 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-09 19:06:12 +00:00
654c4b4675
More renames
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1126353004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45592 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-07 13:19:04 +00:00
1124eaacd8
Rename EMPTY_ARRAY to EMPTY_LIST
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1127183003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45579 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-06 23:47:59 +00:00
4d0cce227d
Sort the containing method first in completions following super
...
BUG=dartbug.com/22850
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//1121773003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45539 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-05 21:11:11 +00:00
b05fb8ba98
suggest only superclass elements for "super."
...
BUG=dartbug.com/23208
R=paulberry@google.com
Review URL: https://codereview.chromium.org//1127643003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45535 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-05 19:09:51 +00:00
c464ba7dda
Use server.getContainingContext() in execution domain.
...
It works even for folders.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1126613004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45504 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-04 20:15:40 +00:00
be90dce1de
fix file uri suggestions on Windows
...
BUG=dartbug.com/23073
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1120113002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45500 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-04 18:16:46 +00:00
Konstantin Shcheglov