dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
71,140 Commits 2 Branches 0 Tags
d2950737b8a295664e9da8df3710722215e1cc1e
Commit Graph

3549 Commits

Author SHA1 Message Date
pq a6a879577d remove non_const_const fix 
Change-Id: Ib2c96b06416b4f392f726de9af22bbf6700dd9dd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139487
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Jaime Wren <jwren@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-13 22:08:16 +00:00
Brian Wilkerson 1d959fad1b Refactor the way context type is computed to improve performance 
Change-Id: Icab69d66d30c616c4800d18ae7543059a21e5e7f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139484
Reviewed-by: Jaime Wren <jwren@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-13 20:34:06 +00:00
Brian Wilkerson cf4b7d312a Add a flutter-specific fix for ARGUMENT_TYPE_NOT_ASSIGNABLE. 
Change-Id: I1687f88a274c69dd2fb6af5bcca7425378b9fd61
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139480
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-03-13 17:33:01 +00:00
Paul Berry c3a0bb086a Migration: Add "why not nullable" traces where "!"s are inserted. 
Change-Id: I0367f869d59da0397589df7df43170f1ecbcb69c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139401
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2020-03-13 16:31:11 +00:00
Mike Fairhurst 4cdd7ec7be [nnbd_migration] Enable apply edit links by default. 
Change-Id: I06731286a049a58c8ba968423b0629a0800825f8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139310
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2020-03-13 16:16:21 +00:00
Mike Fairhurst 624b135cf0 [nnbd_migration] Add a rerunning pane to enforce consistency on hinting 
Change-Id: Ie1f08f5a7bb73e9e73783326c4efcfc6b5f75dfa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139309
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2020-03-13 16:16:21 +00:00
Mike Fairhurst f1452fc2d9 [nnbd_migration] Apply hint block until rerun; refresh preview after. 
Change-Id: I49df050ec05099742510aa78584bfd15d9e9f840
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139321
Reviewed-by: Paul Berry <paulberry@google.com>
 2020-03-13 16:16:21 +00:00
Mike Fairhurst 563aebd5c7 [nnbd_migration] Rerun migration after performing edits. 
The way the server is managed is not 100% ideal, filed here: #41018

Change-Id: Idca6dd56e8375b2e8ea7cbb2f2bf329f2643a442
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139308
Reviewed-by: Paul Berry <paulberry@google.com>
 2020-03-13 16:16:21 +00:00
Mike Fairhurst 2ee07c3193 [nnbd_migration] Fix issue creating two PreviewSite's for GET/POST 
This caused an issue where the POST request to add a hint would trigger
a rerun and update the state of the POST handler, but the GET handler
still had the old state.

Make just one PreviewSite so that state can be updated and stay
consistent.

Change-Id: I9f984708fd95954b1d8d2c0b8fc2e3bce8350053
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139307
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2020-03-13 16:16:21 +00:00
Mike Fairhurst 546acb1e8e [nnbd_migration] Split apart running tasks from sending dartfix response 
This enables us to get code that we can execute to rerun dartfix in
later CLs.

One note is that this won't pick up on certain file changes, etc. I
think a better long-term solution is to rerun the entire DartFix code on
rerun, and that dartfix response can be returned directly to the js
front end. Its possible that the types of file changes this will miss
are extremely rare, such as changed .packages files only etc.

This would require a bit more untangling, things like managing the way that
dartfix will start a server each time, and ensuring that we get a
DartFix respnse *and* a migration state, so this CL seems worth landing
in the meantime. Filed as #41017

Change-Id: If629cac41149728b34f6eb9785a7cea543a23a6f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139306
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Janice Collins <jcollins@google.com>
 2020-03-13 16:16:21 +00:00
Paul Berry 8361357e6e Fix assertion failure in stack trace builder. 
Fixes #41020.

Change-Id: I6cf52c3a5aac545c352f653def53508356676d71
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139317
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2020-03-13 12:27:40 +00:00
Brian Wilkerson b31445c0f8 Improve the relevance scores for instance type members 
The "super matches" feature should have been disabled (-1.0) when the
target wasn't `super`, but it wasn't. That artificially lowered the
score for methods. But it wasn't being used (even when it should have
been) for getters and setters, so their scores weren't being lowered.
That accounted for the poor mrr I was seeing. This fixes both problems
so that the feature is now used everywhere when it should be and not
when it shouldn't be.

Change-Id: I541a9b1ed524e8b2ed2c0c7f39e7bca786e12ea9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139380
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Jaime Wren <jwren@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-13 01:12:41 +00:00
Konstantin Shcheglov a42efec049 Don't suggest ADD_RETURN_TYPE for setters. 
R=brianwilkerson@google.com, pquitslund@google.com

Change-Id: Ia584be1de6d6e4237f316bdd8cef77ae841a15ae
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139315
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-12 22:54:36 +00:00
Konstantin Shcheglov 68b0b83bfe Issue 40842. Fix for getter return type location. 
R=brianwilkerson@google.com, pquitslund@google.com

Bug: https://github.com/dart-lang/sdk/issues/40842
Change-Id: Ifc8343a6df62d64d05b3870255b4602ab898d4cc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139260
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-12 17:44:26 +00:00
Konstantin Shcheglov d5eb515a88 Extract AddReturnType producer. 
As a preparation to fix the bug.

R=brianwilkerson@google.com, pquitslund@google.com

Bug: https://github.com/dart-lang/sdk/issues/40842
Change-Id: I9b448ebb79520e1f0f79cb008feeecd657e5b596
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139148
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
 2020-03-12 16:20:58 +00:00
Konstantin Shcheglov 009d27b081 Extract AddFieldFormalParameters. 
Here I also add forCode(ErrorCode) method with the same goal - keep
all the knowledge about one issue in one place. Producers already
have to know which error they handle, because the have expectations
about the target node.

R=brianwilkerson@google.com, pquitslund@google.com

Change-Id: I584521b3a6e79cc126b5ff152dab26a397535463
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139181
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-12 15:34:42 +00:00
Konstantin Shcheglov 51f5636daf Report FLUTTER_GET_WIDGET_DESCRIPTION_CONTENT_MODIFIED when a file is changed during the request. 
R=brianwilkerson@google.com

Change-Id: I9d77df28dd16fdaf30ba4dd04fe8cfff221c236d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139144
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-12 01:09:00 +00:00
Paul Berry 93448a47c6 Migration: change trace view to alternate between edges and nodes. 
Previously, we only included edges in the trace view, which resulted
in a lot of missing information.  Generally the reasoning process
looks like "type at A is nullable because of an expression at B, which
propagates nullability from a type at C, which is nullable because of
an expression at D, etc."  This change makes the trace reflect that
reasoning process better.

Change-Id: I27d1b7aac736529b6f1fa2f7be8dea0d3eca9a6c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139064
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2020-03-11 21:30:40 +00:00
Konstantin Shcheglov 4e55949fa6 Refactor RemoveUnusedLocalVariable and fix for locals outside of function bodies. 
R=brianwilkerson@google.com, pquitslund@google.com

Change-Id: Idfb85bbe97a48055fc96dc5441618b7889a7cc00
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139060
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-11 18:19:40 +00:00
Jaime Wren 60dd17d053 Add the void keyword into additional missing portions of the AST in the keyword_contributor.dart - type arguments and method invocation type arguments 
Related PR: https://dart-review.googlesource.com/c/sdk/+/138743

Change-Id: I085cb0718ae00867e245fc13ef219e738306f14e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138914
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Jaime Wren <jwren@google.com>
 2020-03-11 15:29:59 +00:00
Konstantin Shcheglov 37530145ff Extract RemoveUnusedLocalVariable producer. 
R=brianwilkerson@google.com, pquitslund@google.com

Change-Id: I0d0d7cccd0adb064f87bb1b9e656cad49f03a2e0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139033
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-11 06:01:29 +00:00
Janice Collins ace1d9b921 Do not repeatedly analyze a full library per part when dartfixing. 
Migration performance improves 10x on web_ui with this CL.
Also fixes a heisenbug in the linter code where identical uniqueNames
for LintCodes could wind up in objects that compare differently.

Bug: https://github.com/dart-lang/sdk/issues/40915
Change-Id: Iddddfd7659f4bc724ddf21ebae41750a0ee51e74
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138940
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Janice Collins <jcollins@google.com>
 2020-03-10 21:16:11 +00:00
Sam Rawlins cc85d28e60 Migrator: Add preliminary styles to stack trace 
Change-Id: Iac8fdccb18b5ba04b058236ac1ee9b60643f67cf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138924
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2020-03-10 21:06:10 +00:00
Brian Wilkerson d673c176ae Start implementing new relevance scores for members of a type 
Change-Id: I5594da6c9f1b71d239593131c02b5b10a57a4725
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138907
Reviewed-by: Jaime Wren <jwren@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-10 17:28:51 +00:00
Konstantin Shcheglov b311a0052e Fixes REMOVE_UNUSED_FIELD and optional field formal parameters. 
R=brianwilkerson@google.com

Change-Id: I15587001262ed70fb6e4b740fee12542acb6b1a9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138905
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-10 15:50:00 +00:00
Konstantin Shcheglov 83378633e1 Add the attachment with the content of the file being analyzed. 
Change-Id: I75b1c61e2d04cd5e03ef4375e97ef3c9f4add874
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138384
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-10 04:57:20 +00:00
Paul Berry 043af430c1 Migraiton: Add function names to trace output. 
This makes them look a lot more like real stacktraces.

Change-Id: I0c060f72f8676ab6d5c0272532b90931b815fddf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138607
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
 2020-03-09 22:00:59 +00:00
Konstantin Shcheglov f8792406d8 Extract RemoveUnusedElement and RemoveUnusedField producers. 
There is an exception that we see internally, and I'd like to try to
refactor the code a bit.

R=brianwilkerson@google.com

Change-Id: I276e009437fd3cac82391126bde95c73225bca0c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138784
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-09 20:06:10 +00:00
Jaime Wren 54e96f6ccf Add the dynamic keyword into additional missing portions of the AST (in method and constructor parameters) in the keyword_contributor.dart 
Change-Id: Idd394dc19992fa6406783a53ad50ebf58cf8f60f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138785
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Jaime Wren <jwren@google.com>
 2020-03-09 19:36:34 +00:00
Keerti Parthasarathy 8329bd7ca8 Do not check for '.analysis_options' for default options file in builder. 
Change-Id: I9decba4d0db318caedcfd3695f41c127b66f416f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138660
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Keerti Parthasarathy <keertip@google.com>
 2020-03-09 19:31:24 +00:00
Sam Rawlins fa2df01895 Null Safety preview: Fix description for uninitialized field 
Fixes #40773

Change-Id: I7639364820785f5a877917afbbb62ab9c09eff00
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138781
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2020-03-09 18:34:17 +00:00
Sam Rawlins 4e79175ee8 Fix per-line highlighting in Null Safety preview tool 
Screenshot: https://screenshot.googleplex.com/Wi59xaxaEpx

Change-Id: Ib0fc98dafe77f49443b024af1b2fa2f505e470ab
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138780
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Janice Collins <jcollins@google.com>
 2020-03-09 16:23:37 +00:00
Brian Wilkerson a629dbf073 Add a fix to inline a typedef 
I needed to fix AST nodes for parameters to know about the required
token when computing the beginning token and child entities.

Change-Id: Icb0fc27bc1e9f6650376f5870944fb8f592a5e8c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138744
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-03-09 14:17:07 +00:00
Jaime Wren 7e815546ac Add the dynamic keyword into additional missing portions of the AST in the keyword_contributor.dart 
Change-Id: I64ff9721c151e3e51841ea638e8b2fd2b472ac27
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138743
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Jaime Wren <jwren@google.com>
 2020-03-09 05:34:00 +00:00
Jaime Wren de493465c8 Include 'dynamic' in the list of suggested keywords for type names, i.e. the 'dynamic' in "dynamic contents = ..." 
Change-Id: I8e388a2b8077140cb7e0047e1f16c36ea12aded5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138612
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Jaime Wren <jwren@google.com>
 2020-03-06 23:09:54 +00:00
Mike Fairhurst 48c6180b46 [nnbd_migration] Hide hint insertion links after the migration is applied. 
Change-Id: If89b16ec1c4e26e4aa1fb03fc262075c75eac526
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138389
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2020-03-05 19:26:44 +00:00
Mike Fairhurst 123a1ea517 [nnbd_migration] Fix 'apply edit' links. 
Previously we would do a POST, but not prevent the default action of
clicking on the link, which is to navigate the browser.

Also, the URLs we generate begin with 'http' and therefore the
absolutePath call is not needed, and in fact, breaks the URL.

Change-Id: Iff0c2820ee0cdc951f82807f9535900a1e0e7ae1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138383
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2020-03-05 19:26:44 +00:00
Mike Fairhurst 3629658722 [nnbd_migration] Handle POST requests 
Change-Id: I4e609c249e99366177f5e35861986eef4b683eee
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138332
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2020-03-05 19:26:44 +00:00
Paul Berry a74253987b Migration: add trace functionality to the preview tool. 
This establishes the base functionality.  A lot of follow-up work is
needed from here:

- Each trace should have an entry at the top of it pointing to the
  thing that was made nullable.

- The source code links in traces don't include lengths, so we can't
  highlight whole identifiers when the user clicks on a link.

- Description strings are currently generated by running toString() on
  the individual nullability nodes and edges, resulting in long-winded
  and useless descriptions.

Change-Id: Ibb370bae6bedc7a8c86092462785023002a48ac3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138481
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2020-03-05 17:21:54 +00:00
Devon Carew c2fc5f9756 [dart migrate] tweak the verbiage for dart migrate 
Bug: https://github.com/dart-lang/sdk/issues/40881
Change-Id: Ie5b63410a926462352858f8d4341e79a8c332be5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138480
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Janice Collins <jcollins@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2020-03-05 16:51:04 +00:00
Konstantin Shcheglov d3fd44182d Fix crash in declaredParameterElement(). 
R=brianwilkerson@google.com

Bug: b/150742402
Change-Id: Ia72179f934579f1eb6861bf8b6cc955168e10136
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138360
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-04 19:42:16 +00:00
Mike Fairhurst d83efc38f9 [nnbd_migration] Apply the changes to disk on apply-migration request 
This integrates fairly well with the new dartdev ux. We may be able to
improve the wording, etc., but given the fact that it has to be rerun
with --apply-edits, there is no need to notify anyone that the edits
occurred (currently). I'll take another look at potential wording
improvements in a follow-up CL.

In the dartfix ux, the dartfix driver doesn't get notified of the
changes and will ask if you want to apply, and this is not as good :) If
you say yes, you will apply the edits twice. Given that there is already
a CL to delete that code, I didn't change this in dartfix and don't plan
to.

Change-Id: Ie822a5761d05b3dd08b5a793f812a331d4657598
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138203
Reviewed-by: Paul Berry <paulberry@google.com>
 2020-03-04 18:42:56 +00:00
Mike Fairhurst 9eb655ee66 [nnbd_migration] Preserve "migration applied" state across reload. 
Change-Id: I30e0dd282b4d50ad416cd1ac9aa3d1c0bc58037f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138202
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2020-03-04 18:42:56 +00:00
Mike Fairhurst 28a607c598 [nnbd_migration] Send request to server from apply migration button. 
There are existing TODOs about how we should only handle POST and not
GET. In my tests, it looks like POST is not currently wired up at all.
This will make the apply migration button work, and from what I can tell
will also  make the "add hint" buttons work (they likely aren't working
right now).

I'll revisit this and switch it to POST in a later CL. It requires a bit
of rewiring in the preview server.

Change-Id: Ie8541d29b3b9cbcc151c4b57b26b36e8a7a92246
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138201
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2020-03-04 18:42:56 +00:00
Mike Fairhurst 99d02a1ef8 [nnbd_migration] "Apply migration" button ux/styles 
Change-Id: I28d474bf07f66cb5f582e8a190046fea78e7d7b9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138107
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2020-03-04 18:42:56 +00:00
Paul Berry bb40d68956 quote fix 
In accordance w/ `prefer_single_quotes`.

Change-Id: I2df4522c437a305ae5e43814295e507388de3027
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138320
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2020-03-04 18:20:36 +00:00
Brian Wilkerson ed1091af3e Add two fixes for avoid_returning_null_for_future 
Change-Id: I6ece892025233fe3dd51ececb7b92368be9669ae
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138321
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-04 17:26:45 +00:00
Brian Wilkerson 027f9588e1 Fix replace_null_with_closure when the parameter type has no parameter names (issue 40578) 
Change-Id: Ie85294e1925a1d3880416ef4ceed86052e1534e7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138140
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-03 18:51:23 +00:00
Janice Collins 48ae192635 Prevent a crash when we have a -1 offset. 
Bug: https://github.com/dart-lang/sdk/issues/40827
Change-Id: I1d76655410945bb0e8f7a58f71cc00aaf97d375e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138047
Commit-Queue: Janice Collins <jcollins@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2020-03-03 17:46:01 +00:00
Paul Berry 8fa6e9d20e Migration: separate EditLink and TargetLink models for preview tool. 
The preview tool's "edit details" box handles two kinds of links:
links allowing the user to request a change to the source file
(i.e. adding/removing hints), and links allowing the user to navigate
to a target.  Use separate data structures for these two kinds of
links, because they store different data.

Change-Id: I41bdf7fc9c94fc28e703da34d67d8c20f6f86108
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138012
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2020-03-03 16:42:51 +00:00