Commit Graph

465 Commits

Author SHA1 Message Date
zundel@google.com cffb776ddf More support of library privacy for analyzer
See http://code.google.com/p/dart/issues/detail?id=2383

Committed: https://code.google.com/p/dart/source/detail?r=8926

Review URL: https://chromiumcodereview.appspot.com//10583036

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@8933 260f80e4-7a28-3924-810f-c04153c831b5
2012-06-20 18:43:32 +00:00
zundel@google.com f12d219558 Revert "More support of library privacy for analyzer"
Review URL: https://chromiumcodereview.appspot.com//10578047

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@8931 260f80e4-7a28-3924-810f-c04153c831b5
2012-06-20 18:16:17 +00:00
zundel@google.com cda927b48f More support of library privacy for analyzer
See http://code.google.com/p/dart/issues/detail?id=2383

Review URL: https://chromiumcodereview.appspot.com//10583036

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@8926 260f80e4-7a28-3924-810f-c04153c831b5
2012-06-20 17:40:56 +00:00
brianwilkerson@google.com fc2e4153a1 Fix for issue 3541 and a small debugging improvement
Review URL: https://chromiumcodereview.appspot.com//10536211

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@8907 260f80e4-7a28-3924-810f-c04153c831b5
2012-06-20 15:00:23 +00:00
zundel@google.com 6a781fbebe Dart Editor overlooks assignment to final fields scoped by "this"
See issue http://code.google.com/p/dart/issues/detail?id=2213

Review URL: https://chromiumcodereview.appspot.com//10592016

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@8898 260f80e4-7a28-3924-810f-c04153c831b5
2012-06-20 11:42:30 +00:00
scheglov@google.com 9613a3810a Issue 2382. Using a variable in a scope before its declared that shadows another variable
http://code.google.com/p/dart/issues/detail?id=2382

R=brianwilkerson@google.com
BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com//10581024

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@8876 260f80e4-7a28-3924-810f-c04153c831b5
2012-06-19 21:42:41 +00:00
scheglov@google.com 047d50d5f3 Issue 2373. 'v is Unknown' is compile-time warning, not error
http://code.google.com/p/dart/issues/detail?id=2373

...but 'v is Known<No, Paramaters>' is error.
Illogical, but so says the Spec.

R=brianwilkerson@google.com
BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com//10536203

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@8872 260f80e4-7a28-3924-810f-c04153c831b5
2012-06-19 21:26:38 +00:00
scheglov@google.com 89222499be Issue 2379. Can't use type variable with const constructor
http://code.google.com/p/dart/issues/detail?id=2379

R=brianwilkerson@google.com
BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com//10574024

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@8865 260f80e4-7a28-3924-810f-c04153c831b5
2012-06-19 19:48:54 +00:00
scheglov@google.com aab2cad8ec Issue 2378. Function expressions with no name should cause warnings, not errors
http://code.google.com/p/dart/issues/detail?id=2378

R=brianwilkerson@google.com
BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com//10576016

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@8862 260f80e4-7a28-3924-810f-c04153c831b5
2012-06-19 18:40:18 +00:00
zundel@google.com 26f4d623e4 Gets rid of some warnings in the analyzer for unused code and unused imports
Ironically, the code to detect dead code in switch statements was itself
dead (holdover from a change I did yesterday)

Review URL: https://chromiumcodereview.appspot.com//10575019

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@8853 260f80e4-7a28-3924-810f-c04153c831b5
2012-06-19 15:45:19 +00:00
scheglov@google.com 4884ce068b Issue 1655. Check initializer values of const constructors
http://code.google.com/p/dart/issues/detail?id=1655

R=brianwilkerson@google.com
BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com//10582013

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@8848 260f80e4-7a28-3924-810f-c04153c831b5
2012-06-19 14:23:40 +00:00
scheglov@google.com ba116549a0 Issue 1355. Support for call(). Tweaks for element locator and rename refactoring
R=brianwilkerson@google.com
BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com//10582003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@8826 260f80e4-7a28-3924-810f-c04153c831b5
2012-06-18 22:03:44 +00:00
zundel@google.com 5695d00452 Fix parse error on dead code in a switch statement
http://code.google.com/p/dart/issues/detail?id=2149

Review URL: https://chromiumcodereview.appspot.com//10555034

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@8822 260f80e4-7a28-3924-810f-c04153c831b5
2012-06-18 21:03:35 +00:00
brianwilkerson@google.com a9160e1ca4 Fix for issues 1473 and 3521
Review URL: https://chromiumcodereview.appspot.com//10574003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@8821 260f80e4-7a28-3924-810f-c04153c831b5
2012-06-18 20:52:56 +00:00
scheglov@google.com 450cbee4d3 Issue 1197. Support for using 'static' as method name
http://code.google.com/p/dart/issues/detail?id=1197

R=brianwilkerson@google.com
BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com//10557037

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@8801 260f80e4-7a28-3924-810f-c04153c831b5
2012-06-18 15:58:56 +00:00
scheglov@google.com 4e72987380 Issue 963. Check default values for parameters of local functions. Support for string interpolation.
http://code.google.com/p/dart/issues/detail?id=963

R=brianwilkerson@google.com
BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com//10553037

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@8799 260f80e4-7a28-3924-810f-c04153c831b5
2012-06-18 15:09:35 +00:00
scheglov@google.com 63ef07e3dd Issue 2339. Fix for parsing function expression inside of new expression inside of initializer
http://code.google.com/p/dart/issues/detail?id=2339

R=brianwilkerson@google.com
BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com//10558016

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@8761 260f80e4-7a28-3924-810f-c04153c831b5
2012-06-16 14:26:56 +00:00
scheglov@google.com fe292655fe Use operator location for operator resolving problems
R=brianwilkerson@google.com
BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com//10558014

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@8760 260f80e4-7a28-3924-810f-c04153c831b5
2012-06-16 14:25:42 +00:00
scheglov@google.com 22511e7851 Clean up DartAstUtilities.getElement(), analysis should provide element for every identifier
R=brianwilkerson@google.com
BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com//10562020

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@8757 260f80e4-7a28-3924-810f-c04153c831b5
2012-06-16 01:44:24 +00:00
scheglov@google.com 3a67e7ad10 Improve 'as' support with negation
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@8745 260f80e4-7a28-3924-810f-c04153c831b5
2012-06-15 20:49:18 +00:00
scheglov@google.com 35436b06b5 Issue 3643. Changes for review comments
Initially https://chromiumcodereview.appspot.com/10545189/

R=brianwilkerson@google.com
BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com//10562013

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@8737 260f80e4-7a28-3924-810f-c04153c831b5
2012-06-15 20:04:07 +00:00
scheglov@google.com fedb10fc52 Test for 'if (v as T)' and fix to make 'if as' check useful
R=brianwilkerson@google.com
BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com//10556014

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@8735 260f80e4-7a28-3924-810f-c04153c831b5
2012-06-15 19:48:59 +00:00
devoncarew@google.com 57f28932e9 Fix for http://code.google.com/p/dart/issues/detail?id=3616 - missing dartdoc tooltips for getters and setters; also, poorly formatter tooltips for functions as parameters.
Review URL: https://chromiumcodereview.appspot.com//10542177

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@8727 260f80e4-7a28-3924-810f-c04153c831b5
2012-06-15 18:00:58 +00:00
scheglov@google.com 45203c06ce Issue 3643. Associate 'no such method' problem with method name, not with whole invocation
http://code.google.com/p/dart/issues/detail?id=3643

R=brianwilkerson@google.com
BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com//10545189

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@8726 260f80e4-7a28-3924-810f-c04153c831b5
2012-06-15 17:56:31 +00:00
scheglov@google.com bd7b9408d7 Attempt to fix build
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@8698 260f80e4-7a28-3924-810f-c04153c831b5
2012-06-14 23:00:29 +00:00
scheglov@google.com a01d245a87 Issue 3530. Import elements into separate import namespace
http://code.google.com/p/dart/issues/detail?id=3530

R=brianwilkerson@google.com
BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com//10536180

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@8696 260f80e4-7a28-3924-810f-c04153c831b5
2012-06-14 22:55:41 +00:00
keertip@google.com f7628dde99 fix for correct resolution of package: uris
Review URL: http://codereview.chromium.org//10540162

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@8694 260f80e4-7a28-3924-810f-c04153c831b5
2012-06-14 22:21:19 +00:00
zundel@google.com 1b7f8307d2 A redirect constructor cannot reference an instance method.
See issue http://code.google.com/p/dart/issues/detail?id=2105

Review URL: https://chromiumcodereview.appspot.com//10541184

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@8685 260f80e4-7a28-3924-810f-c04153c831b5
2012-06-14 20:32:33 +00:00
scheglov@google.com 6e8c1ff0b4 Issue 3516. Make displaying warning for inferred types configurable
http://code.google.com/p/dart/issues/detail?id=3516

I'm adding also people who expressed opinions about displaying such warnings or not.

R=brianwilkerson@google.com,messick@google.com
BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com//10546161

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@8684 260f80e4-7a28-3924-810f-c04153c831b5
2012-06-14 18:38:19 +00:00
brianwilkerson@google.com a21c18ed54 Additional fix for issue 2155
Review URL: https://chromiumcodereview.appspot.com//10539159

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@8683 260f80e4-7a28-3924-810f-c04153c831b5
2012-06-14 18:23:42 +00:00
scheglov@google.com 59ea2febb5 Attempt to fix build #2
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@8680 260f80e4-7a28-3924-810f-c04153c831b5
2012-06-14 18:18:28 +00:00
zundel@google.com 3f945014e7 Adds warning when a named argument is specified, but a positional argument is missing
http://code.google.com/p/dart/issues/detail?id=1941

Review URL: https://chromiumcodereview.appspot.com//10544156

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@8677 260f80e4-7a28-3924-810f-c04153c831b5
2012-06-14 17:52:31 +00:00
zundel@google.com e11f678bca Fix in analyzer for consecutively labeled case statments.
http://code.google.com/p/dart/issues/detail?id=1765

Review URL: https://chromiumcodereview.appspot.com//10539155

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@8676 260f80e4-7a28-3924-810f-c04153c831b5
2012-06-14 17:51:44 +00:00
scheglov@google.com d1fe4bc94f Issue 3540. Better error message for string concatenation
http://code.google.com/p/dart/issues/detail?id=3540

R=brianwilkerson@google.com
BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com//10546168

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@8671 260f80e4-7a28-3924-810f-c04153c831b5
2012-06-14 17:05:03 +00:00
scheglov@google.com c1e44ea184 Issue 3550. Initial understanding "const".
http://code.google.com/p/dart/issues/detail?id=3550

To complete "const" support http://code.google.com/p/dart/issues/detail?id=3553 should be done.

R=brianwilkerson@google.com
BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com//10536164

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@8670 260f80e4-7a28-3924-810f-c04153c831b5
2012-06-14 17:00:45 +00:00
brianwilkerson@google.com fa80c6f115 Fix a couple of NPE's discovered while running Editor
Review URL: https://chromiumcodereview.appspot.com//10542146

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@8663 260f80e4-7a28-3924-810f-c04153c831b5
2012-06-14 15:18:02 +00:00
brianwilkerson@google.com fefd3f81c3 Fix for issue 2155
Review URL: https://chromiumcodereview.appspot.com//10534145

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@8661 260f80e4-7a28-3924-810f-c04153c831b5
2012-06-14 15:07:45 +00:00
scheglov@google.com 2b9779fa27 Generate inferred types using all implemented interfaces.
R=brianwilkerson@google.com,pquitslund@google.com
BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com//10541159

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@8640 260f80e4-7a28-3924-810f-c04153c831b5
2012-06-14 02:47:23 +00:00
zundel@google.com b6dbbbc0ec Disallow underscores in named formal parameters.
See issue http://code.google.com/p/dart/issues/detail?id=2493

Review URL: https://chromiumcodereview.appspot.com//10541095

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@8631 260f80e4-7a28-3924-810f-c04153c831b5
2012-06-13 22:30:16 +00:00
zundel@google.com ce34ba9949 Detect continue inside of case statement with no label
Review URL: https://chromiumcodereview.appspot.com//10536143

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@8627 260f80e4-7a28-3924-810f-c04153c831b5
2012-06-13 20:13:17 +00:00
brianwilkerson@google.com e66af0c36e Fix for 3607. This enables the use of the new getter/setter syntax but continues to accept the old syntax. Once the library code has been modified we can disable the old syntax.
Review URL: https://chromiumcodereview.appspot.com//10545159

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@8618 260f80e4-7a28-3924-810f-c04153c831b5
2012-06-13 16:51:24 +00:00
brianwilkerson@google.com 848682cbe8 Fix for issue 1781
Review URL: https://chromiumcodereview.appspot.com//10535148

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@8616 260f80e4-7a28-3924-810f-c04153c831b5
2012-06-13 16:08:43 +00:00
brianwilkerson@google.com 93717a5f2b Fix for issue 3526
Review URL: https://chromiumcodereview.appspot.com//10533127

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@8615 260f80e4-7a28-3924-810f-c04153c831b5
2012-06-13 16:00:34 +00:00
scheglov@google.com 930a2f9c46 Report error if typedef references itself in type parameter bounds
R=brianwilkerson@google.com
BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com//10546136

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@8605 260f80e4-7a28-3924-810f-c04153c831b5
2012-06-13 13:38:07 +00:00
zundel@google.com f52f8f68cf Fix for issue 1351 - Analyzer accepts non-multiline strings with newlines
Review URL: https://chromiumcodereview.appspot.com//10540133

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@8601 260f80e4-7a28-3924-810f-c04153c831b5
2012-06-13 10:50:21 +00:00
zundel@google.com 8eb0dd4fcf Fix for issue 2351 - checking assignability on top level getters and setters
Committed: https://code.google.com/p/dart/source/detail?r=8568

Review URL: https://chromiumcodereview.appspot.com//10548002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@8588 260f80e4-7a28-3924-810f-c04153c831b5
2012-06-12 23:07:00 +00:00
brianwilkerson@google.com 2c0466752b Fix for issue 1601
Review URL: https://chromiumcodereview.appspot.com//10533115

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@8576 260f80e4-7a28-3924-810f-c04153c831b5
2012-06-12 21:33:36 +00:00
zundel@google.com 33fda6f748 Revert "Fix for issue 2351 - checking assignability on top level getters and setters"
This reverts commit 16ef0be9ccae7d9991c37b8cd01295e6c62c6f6a.

Review URL: https://chromiumcodereview.appspot.com//10543122

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@8574 260f80e4-7a28-3924-810f-c04153c831b5
2012-06-12 20:58:31 +00:00
scheglov@google.com c88461077a Issue 3528. Additional checks for 'case expressions'
http://code.google.com/p/dart/issues/detail?id=3528

R=brianwilkerson@google.com
BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com//10540114

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@8573 260f80e4-7a28-3924-810f-c04153c831b5
2012-06-12 20:21:34 +00:00
zundel@google.com 5255a46d70 Fix for issue 2351 - checking assignability on top level getters and setters
Review URL: https://chromiumcodereview.appspot.com//10548002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@8568 260f80e4-7a28-3924-810f-c04153c831b5
2012-06-12 19:42:32 +00:00