dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
87,731 Commits 2 Branches 0 Tags
cf50ee8eb4374e2ff514b21a04fcf6f0de3edf32
Commit Graph

40650 Commits

Author SHA1 Message Date
Paul Berry cf50ee8eb4 Prototype integration of shared type analysis logic with CFE. 
This change replaces the InferenceVisitorImpl.visitSwitchStatement
with a call to the new shared type analyzer, and implements the
necessary callbacks to allow analysis to work end-to-end.

Change-Id: I73a9514428b4ce092762d3ea450545986d0e1ea9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/257491
Reviewed-by: Chloe Stefantsova <cstefantsova@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2022-10-18 14:33:18 +00:00
Ben Konyi 39168c9ef0 [ CLI ] Fix dart run --enable-experiment 
Fixes issue where --enable-experiment options passed after `dart
run` weren't being handled by the VM.

Fixes https://github.com/dart-lang/sdk/issues/50205

TEST=pkg/dartdev/test/commands/run_test.dart

Change-Id: Ia9c585a16756fd4450cfd159a1b9864ebfb6d200
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/264200
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2022-10-18 13:42:32 +00:00
Danny Tuppeny bc7094dbc1 [dds/dap] Ensure "terminated" event is sent when detaching from processes 
Change-Id: I466f97c2d98649b77412396e462bf3ae9c9e7f6e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/264481
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2022-10-18 13:26:35 +00:00
Ömer Sinan Ağacan 54dbb42244 [dart2wasm] Fix truncating int div code gen 
Wasm `i64.div_s` result[1] is undefined when the division result is
2^63, and v8 traps with "divide result unrepresentable".

This change follows the checks in native runtime (in
`Integer::ArithmeticOp`) to handle overflowing in
`-9223372036854775808 ~/ -1`:

   case Token::kTRUNCDIV:
     if ((left_value == Mint::kMinValue) && (right_value == -1)) {
       return Integer::New(Mint::kMinValue, space);
     }
     return Integer::New(left_value / right_value, space);

These tests now pass:

- corelib/integer_parsed_div_rem_vm_test/01
- language/operator/left_shift_test

language/operator/arithmetic_test used to fail with the same trap, but
it now fails because of #50228.

[1]: https://webassembly.github.io/spec/core/exec/numerics.html#op-idiv-s

Change-Id: Ib43ac7a53d5cf96c01b016f73240da533ef84516
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/264460
Commit-Queue: Ömer Ağacan <omersa@google.com>
Reviewed-by: Joshua Litt <joshualitt@google.com>
 2022-10-18 07:06:46 +00:00
Joshua Litt 78f95a427b [dart2wasm] Switch to using declared nullability in subtype check. 
Change-Id: Id993392aad23dd5a6c03e84a21323ff529992c6f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/263146
Commit-Queue: Joshua Litt <joshualitt@google.com>
Reviewed-by: Aske Simon Christensen <askesc@google.com>
 2022-10-17 23:07:27 +00:00
Danny Tuppeny ae352fe940 [dds/dap] Improve handling of lists in variables requests 
Fixes https://github.com/Dart-Code/Dart-Code/issues/4204.
Fixes https://github.com/Dart-Code/Dart-Code/issues/4213.

Change-Id: Ibd95a149e6f620efb690c24623bb6b9d04a794b3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/263620
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2022-10-17 21:51:36 +00:00
Kallen Tu fee8a22c31 Clean up VM core libraries by removing dynamic invocations. 
Tested: No new behaviour. Covered by prior tests.
Change-Id: I739649a53c3982b673b1144e3c5aa98cc75f98a1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/263042
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Kallen Tu <kallentu@google.com>
 2022-10-17 21:22:50 +00:00
Joshua Litt 204c03a98e [dart2wasm] Wire up cfe experimental flags. 
Change-Id: Iab9b3a5997e63e61a42bc4fb27825b345ae63ab1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/264060
Reviewed-by: Aske Simon Christensen <askesc@google.com>
Commit-Queue: Joshua Litt <joshualitt@google.com>
Reviewed-by: Jake Macdonald <jakemac@google.com>
 2022-10-17 21:01:33 +00:00
Sam Rawlins c3fb570105 Add "Add 'late' hint" feature 
Tested with:

* top-level variables
* local variables
* instance and static fields declared in classes and mixins (enhanced enums are not supported pre-null safety)

Fixes https://github.com/dart-lang/sdk/issues/41389

Change-Id: I8a89668fffe64fff508d0aeb36aaebef5c84f223
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/263460
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2022-10-17 15:24:57 +00:00
Ömer Sinan Ağacan 045cb1a711 [dart2wasm] Handle void getters in selector return counts 
These tests now pass:

co19/Language/Classes/Getters/void_return_type_t01
language/void/generalized_void_syntax_test
language/void/void_type_usage_test/instance3_argument_void
language/void/void_type_usage_test/instance3_as
language/void/void_type_usage_test/instance3_conditional
language/void/void_type_usage_test/instance3_for
language/void/void_type_usage_test/instance3_literal_map_key_init
language/void/void_type_usage_test/instance3_literal_map_value_init
language/void/void_type_usage_test/instance3_literal_void_list_init
language/void/void_type_usage_test/instance3_null_equals1
language/void/void_type_usage_test/instance3_return_to_void
language/void/void_type_usage_test/instance3_stmt
language/void/void_type_usage_test/instance3_void_init

Change-Id: Iadcff0269360515267e0848bc7256e5bc51104fe
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/263720
Reviewed-by: Aske Simon Christensen <askesc@google.com>
Commit-Queue: Ömer Ağacan <omersa@google.com>
 2022-10-17 09:30:08 +00:00
Ahmed Ashour c8bda70c66 Remove nbsp 
Fixes #50202

Change-Id: I67e2f02f49deaf1bd9dc1f32a35310704f4d921b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/264120
Reviewed-by: Lasse Nielsen <lrn@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
 2022-10-17 08:18:49 +00:00
Paul Berry ef24f4c915 Migration: make DecoratedType.node non-nullable. 
Change-Id: I1bbaf596c26cd059da693f75483f16b4f621b4e4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/264380
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2022-10-16 23:42:52 +00:00
Paul Berry 5e29849393 Parser: consolidate handleCaseMatch and endCaseExpression. 
There was no need for both of these listener callbacks, because they
were always called together.  Since `beginCaseExpression` is actually
used, it makes sense to keep `endCaseExpression` and get rid of
`handleCaseMatch`.

Change-Id: I544096b2c2b2814e8cc0c8606455855cb77c9e60
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/264102
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2022-10-15 13:51:59 +00:00
Paul Berry 9aab3c7746 Patterns parsing: add support for guards. 
Bug: https://github.com/dart-lang/sdk/issues/50035
Change-Id: I21db09c9d8c1d359e1b125eea2bae2749cdb72fd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/264101
Reviewed-by: Jens Johansen <jensj@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2022-10-14 20:14:20 +00:00
Paul Berry 4cf63fb382 Parser and listener API changes for supporting pattern guards. 
These are in their own CL so that it's easy to verify that no
functionalty has changed, even though a lot of parser expectations
files are affected.

In a follow-up CL, I'll add code that actually parses pattern guards.

Bug: https://github.com/dart-lang/sdk/issues/50035
Change-Id: I79f5a02df45e29b69aa4d8348cfdf27042ada9d3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/264020
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2022-10-14 15:42:12 +00:00
Paul Berry 5923b883db Parser: add support for wildcard patterns. 
The bare identifier `_` is treated as a variable pattern wherever it
appears, even though other bare identifiers are sometimes treated as
constant patterns.

Bug: https://github.com/dart-lang/sdk/issues/50035
Change-Id: I475ef627b6d0bf519a1972aa5ec683e2d032f02b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/263280
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2022-10-14 14:04:59 +00:00
Jens Johansen 27e0e84cc3 [parser] Allow parsing top-level getter called get that's async/async*/sync* 
Change-Id: I07e9759cdf61e1b633bbc0e7cd961d80ecfedf8e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/263129
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-10-14 11:21:48 +00:00
Jens Johansen 7aeda010bf [parser] Follow-up on feedback posted after land of record commit 
Follow-up to https://dart-review.googlesource.com/c/sdk/+/262605

Change-Id: I5178f7118af30eaa280dde746ddbf579fff5df40
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/263127
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2022-10-14 10:57:39 +00:00
Jens Johansen c4ea2d95cd [parser] Add comments to calls 
Change-Id: Ide38846a6ff93c0bb7714ad89cc2f14accb0ed20
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/263126
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-10-14 09:48:38 +00:00
Jens Johansen b3dbaadc83 [parser] More corner cases for record types 
* required is a modifier when followed by [record type] `?`.
* Parse record type as record type if followed by `super` or `?` `super`
  or `?` `this`.
* Typedef with record type follow by `?`.
* Parse record type as record type in get/set with async/sync/sync*.
* Parse record type as record type when followed by `>>=` or `>>>=`
  (for weird formatted use in typedefs).

Change-Id: I19e208497e28780fb1505139c488e943751cce25
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/263123
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2022-10-14 09:33:58 +00:00
Sigmund Cherem 5501c7f978 [dart2js] Migrate resolution_world_builder.dart 
Change-Id: I089cf76ec054cbcc562f51bde43a3931c1dba9be
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/262743
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Nate Biggs <natebiggs@google.com>
 2022-10-14 03:13:52 +00:00
Sigmund Cherem 83dfe0b3fe [dart2js] migrate kernel_world.dart 
Change-Id: I44a5395b185035f95167875a57a392ae85f7eb40
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/262742
Reviewed-by: Nate Biggs <natebiggs@google.com>
 2022-10-14 03:13:52 +00:00
Sigmund Cherem b5bb9f84a1 [dart2js] add facade for kernel_strategy 
Change-Id: I71681bd8d3e6d06aeedd3a8dfc94bbc47fa8fbd1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/262741
Reviewed-by: Nate Biggs <natebiggs@google.com>
 2022-10-14 03:13:52 +00:00
Sigmund Cherem 6843d6e5be [dart2js] Migrate no_such_method_registry.dart 
Change-Id: Ib66a9c127dc3a88f835d5f74997260b0c856fe31
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/262740
Reviewed-by: Nate Biggs <natebiggs@google.com>
 2022-10-14 03:13:52 +00:00
Ahmed Ashour 8436076fe4 [analysis_server] AddExplicitCast to handle type arguments 
Bug #49896

Change-Id: Ib024d40c1291ecb219f235fabf3dcc2305a82368
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/263741
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-10-13 21:34:03 +00:00
Aske Simon Christensen 20bdf8d8c5 [dart2wasm] Runtime generic function instantiation 
Adds a slot to the vtable of all generic closures with a function
taking a generic closure and type arguments and returning a closure
representing the instantiation of the generic closure with those type
arguments. Instantiation operations then call this instantiation
function, fetched from the vtable of the closure to be instantiated.

The context of an instantiation closure contains the original closure
and the type arguments. The vtable of an instantiation closure
contains trampoline functions that call the corresponding entry point
in the original closure with the instantiated type arguments.

The instantiation functions are shared between all closures with the
same representation. The trampolines are shared across representations
for the same vtable entries.

For now, the instantiation closure just inherits the runtime type from
the original closure, which means that its runtime type will be
incorrect. When we support generic function types with runtime type
substitution, we can perform such substitution when instantiating
a closure.

Change-Id: I5d3a4d623c0673f9c2188f8a7ddd5b28b9404ac4
Cq-Include-Trybots: luci.dart.try:dart2wasm-linux-x64-d8-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/262201
Reviewed-by: Joshua Litt <joshualitt@google.com>
Commit-Queue: Aske Simon Christensen <askesc@google.com>
 2022-10-13 21:04:17 +00:00
Danny Tuppeny 6f8d1e4859 [analysis_server] Add LSP Type Hierarchy 
Fixes https://github.com/Dart-Code/Dart-Code/issues/3313.
Fixes https://github.com/Dart-Code/Dart-Code/issues/2527.

Change-Id: I9f471fd3d7d55999795fee7ab4761e906566bd10
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/264002
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-10-13 19:39:18 +00:00
Danny Tuppeny b5846d8aba [analysis_server] Fix renaming of enum constants 
Fixes https://github.com/Dart-Code/Dart-Code/issues/4215.

Change-Id: Ia55d7ffe5230c483218729e2c51c360dbb24bb57
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/264003
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-10-13 19:32:56 +00:00
Sam Rawlins 8d998a89a2 Update migration tool README 
Change-Id: I16349a7399d735a6edf8615570f4c783a98e8276
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/263461
Reviewed-by: Paul Berry <paulberry@google.com>
Auto-Submit: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2022-10-13 19:00:25 +00:00
Danny Tuppeny 54d7847787 [analysis_server] Fix relationships for subtypes that provide type arguments 
Change-Id: I655f7bff036a17ee79a1d0f9f163125112766f2b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/264001
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-10-13 18:07:19 +00:00
Danny Tuppeny a93b073d27 [analysis_server] Add interfaces+superclassConstraints to type hierarchy computer 
+ return relationship between each item and the target.

Change-Id: I426c84acf16caee0d0c5b5f69224c7ad894ee955
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/263901
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-10-13 17:00:50 +00:00
Nicholas Shahan 20ad5db3ab [ddc] Fix non-hermetic batch mode crashes 
Storing core types in a static caused data to leak between compiles
of separate tests. Compiler crashes on one test could trigger failures
on another.

Fixes: https://github.com/dart-lang/sdk/issues/50044
Change-Id: Ia688a8544576fc0b7ee1bc41ac68a3611c376b8b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/263144
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Nicholas Shahan <nshahan@google.com>
 2022-10-13 14:14:59 +00:00
Danny Tuppeny eab05710b4 [analysis_server] Add a lazy computer for type hierarchies 
Change-Id: Ieb71cea26214e3b790b80e905b3d581f297512d4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/263760
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-10-12 19:22:17 +00:00
Danny Tuppeny 20af356c79 [analysis_server] Trigger reanalysis when LSP TODO settings change 
Previously the setting only applied to future analysis, but this triggers reanalysis immediately.

Change-Id: Ia5687e2bbf5f5a48d9659645c5b15976e712f44f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/263800
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-10-12 17:43:01 +00:00
Ahmed Ashour 10e7e478a2 Fix typos 
Fixes #50184

Change-Id: If17f838d932171e30ef92d1bda8d4918e7e08a8f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/263622
Reviewed-by: Lasse Nielsen <lrn@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-10-12 14:12:42 +00:00
Brian Wilkerson aa7fb9e9e8 Add support for finding the covering node 
The intent is for this to replace NodeLocator and several other
mechanisms for computing a covering node so that we have a single
source of truth. It will also form the basis for some additional
utilities needed for code modifying features.

Change-Id: I33f48907145efbfe9dcba7b43cebb3284d061d1c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/263442
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-10-12 13:52:44 +00:00
Ömer Sinan Ağacan bc46593d5d [dart2wasm] Fix block type of unimplemented 
The test co19/Language/Libraries_and_Scripts/Imports/static_type_t01 now
fails with "unreachable" in runtime as expected (instead of compile
time crash).

Change-Id: Ia311485b3eefcde2d07d67b473238129dad69cce
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/263580
Reviewed-by: Aske Simon Christensen <askesc@google.com>
Commit-Queue: Ömer Ağacan <omersa@google.com>
 2022-10-12 07:10:46 +00:00
Brian Wilkerson 48f33cc37a Allow more information when creating pubspec lints 
Change-Id: Icf031b4f57eeb7861ddb9f5aa011087fa002c1ec
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/263681
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-10-12 03:15:37 +00:00
Ahmed Ashour 0b5d908221 [analyzer] NOT_ENOUGH_POSITIONAL_ARGUMENTS 
To report at the token of the expected positional argument

Fixes #50127

Change-Id: I5eb31c6d354fb15d482c2046f7faaa4505658f4e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/262603
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-10-11 17:56:11 +00:00
Kallen Tu 446ee14abf Cast sockets that set _owner and read closedReadEventSent of _NativeSocket 
Change-Id: I0d3b24f503dcb167dd039e47228a665ca3d38453
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/262272
Reviewed-by: Lasse Nielsen <lrn@google.com>
Commit-Queue: Kallen Tu <kallentu@google.com>
 2022-10-11 13:12:33 +00:00
Ahmed Ashour 7432006bd7 [analyzer] handle dead code with do statement 
Bug: #43511
Change-Id: Iddae879e5343ccdafc33258495771bd6a60afef2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/260110
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-10-10 23:03:34 +00:00
Ahmed Ashour 20218dfe15 [analysis_server] DataDriven to handle MISSING_REQUIRED_ARGUMENT 
Fixes #45475

Change-Id: Ibe5e3b393183affb15ed5fd3449f7c497acec14d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/260600
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-10-10 21:26:19 +00:00
Ahmed Ashour 0a23e439e9 [analysis_server] AddExplicitCast for as 
Bug: #49896
Change-Id: Iddbe616db0edadf57ad76637863ad7a29533a77b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/260111
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-10-10 21:26:15 +00:00
Ahmed Ashour ecb992586a [analyzer] change range of dead code of the RHS of binary operator 
Bug: #43511
Change-Id: I1b1562c0262101900dabea3544bfc28293d5c7f6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/260109
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-10-10 21:07:42 +00:00
Danny Tuppeny 946eec8330 [dds/dap] Optimise computing line/col for stack frames 
See https://github.com/Dart-Code/Dart-Code/issues/4209 / https://github.com/Dart-Code/Dart-Code/issues/4208.

Change-Id: I62f029d50e7b0b1964868c9221ca7b0a387dc23a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/263300
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2022-10-10 18:22:23 +00:00
Brian Wilkerson 38581783e6 Generate the list of error codes 
Change-Id: I315619a30ac8690e90be2b3a3ad7d849c28f2c05
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/263441
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-10-10 17:26:00 +00:00
Danny Tuppeny 172bcc33dd [analysis_server] Fix hover on constructor name declarations 
Change-Id: I6254a8a8d82a1f2b12e8fa3589fbe114d9945af6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/263401
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-10-10 16:43:57 +00:00
Ilya Yanok 174f3d3be2 Revert "[kernel] Create Source.sourceCode as view of the binary bytes" 
This reverts commit a07a0333c3.

Reason for revert: Seems to increase AOT build times significantly (see b/251787563).

Original change's description:
> [kernel] Create Source.sourceCode as view of the binary bytes
>
> This saves about 400MB heap when loading a 900MB .dill file.
>
> Change-Id: I5a09b06764cb493aab8dade2afb4665e12688133
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/255802
> Reviewed-by: Jens Johansen <jensj@google.com>
> Commit-Queue: Stephen Adams <sra@google.com>

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: Ia7edd7d5e711a33bd037f6edbe52ba2fb561709c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/263101
Reviewed-by: Ivan Inozemtsev <iinozemtsev@google.com>
Reviewed-by: Morgan :) <davidmorgan@google.com>
Commit-Queue: Ilya Yanok <yanok@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
Reviewed-by: Ilya Yanok <yanok@google.com>
 2022-10-10 11:20:19 +00:00
Stephen Adams 20fff85f10 [dart2js] Cache targetsIncludeComplexNoSuchMethod 
This seems to speed up inferrer by 5-10%

Change-Id: I733159e9ec79212821444b4e502b28aa2bf81bdd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/263220
Reviewed-by: Nate Biggs <natebiggs@google.com>
Commit-Queue: Stephen Adams <sra@google.com>
 2022-10-09 06:42:44 +00:00
Konstantin Shcheglov cf61632921 Use named parameters in few AST nodes. 
Change-Id: Ib9d59d762dc4dc58c66808864cf553c213857e0b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/263145
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-10-08 16:21:20 +00:00