2862fdfe1b
Elements. Migrate test/services/correction/status_test.dart
...
Change-Id: Ie0afd64be7b90d68c81b05f2973557a5c562a431
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/400165
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2024-12-12 07:23:48 -08:00
3bbcf1be96
Migrate move to file refactoring
...
Change-Id: I006ac6d11ef712f51ce97c3b310634949bbc1918
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/400160
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Phil Quitslund <pquitslund@google.com >
2024-12-11 11:47:49 -08:00
ec7cb0c0b6
Elements. Migrate lib/src/lsp/completion_utils.dart
...
Change-Id: I76f97ace7ffdbe77c556a9e4f0030dbb4ff5faf8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/400161
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2024-12-11 11:20:58 -08:00
7cac23ae8a
Migrate ElementReferencesComputer
...
Change-Id: I23ee2bef1c2dc1925cf7a730d0b46583f499067c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/400142
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2024-12-11 08:58:18 -08:00
ae0ffeecf9
Migrate 3 rename refactor tests
...
Change-Id: I3c7943d4219ae5a228e0cb022d319ef3ec38803c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/400001
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2024-12-10 22:51:20 +00:00
90efa353c0
[element model] migrate computer_documentation
...
Change-Id: I7ff0a47ea8b9fc325932d1a9c9f65dd8c65e2714
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/400000
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Phil Quitslund <pquitslund@google.com >
2024-12-10 21:59:39 +00:00
2d7bb5d052
Migrate 5 more rename pieces and a utility class
...
Change-Id: I54a9ac1590c262ca82d6ba62b8cac248cbfd9ee0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/399703
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2024-12-10 21:06:51 +00:00
8f77b2ebd9
[element model] migrate search_get_type_hierarchy
...
Change-Id: I5b494f6f387172e777c184e2f9c8fb99417234f5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/399632
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Phil Quitslund <pquitslund@google.com >
Auto-Submit: Phil Quitslund <pquitslund@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2024-12-10 17:54:33 +00:00
b08eb9d21a
DAS plugins: Launch a shared plugin, configured from analysis options
...
This change is the final piece in enabling plugins in the new style to
be launched from a specification in analysis options.
Work towards https://github.com/dart-lang/sdk/issues/53402
* We support both one legacy analyzer plugin (the current max), and
a set of new analyzer plugins, which are combined and launched in one
shared plugin isolate.
* Make PluginLocator.pluginMap private.
* Add a parameter to PluginManager.addPluginToContextRoot:
isLegacyPlugin. This method is used for both legacy and new plugins,
but has slightly different behavior, finding where the plugin files
are.
Change-Id: I6644aecd4283eea22586ffd051a01b0ec8987fc5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/395360
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2024-12-10 16:14:49 +00:00
bd76c51e2e
[analysis_server] Migrate Code Actions + Refactor base to new Element model
...
Change-Id: I6393f60abef6adae34c9f1b9a028662746da0612
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/399960
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Commit-Queue: Phil Quitslund <pquitslund@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2024-12-10 16:09:49 +00:00
5412f2c1b5
[DAS] Fixes wrong return type - add async
...
R=brianwilkerson@google.com
Fixes https://github.com/dart-lang/sdk/issues/50460
Change-Id: I0761364ec0292696ddcdba81213ab4d65a2a5e14
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/394361
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Auto-Submit: Felipe Morschel <git@fmorschel.dev >
2024-12-09 23:43:19 +00:00
bb483f34a3
[vm/ffi] Allow configuring the variable dimension of variable-length arrays
...
TEST=tests/ffi/*
CoreLibraryReviewExempt: VM only
Closes: https://github.com/dart-lang/sdk/issues/52366
Change-Id: I545a323f48d955b591cedf2dae7106d9004242e2
Cq-Include-Trybots: dart/try:vm-aot-android-release-arm64c-try,vm-aot-android-release-arm_x64-try,vm-aot-asan-linux-release-x64-try,vm-aot-linux-debug-x64-try,vm-aot-linux-debug-x64c-try,vm-aot-mac-release-arm64-try,vm-aot-mac-release-x64-try,vm-aot-msan-linux-release-x64-try,vm-aot-obfuscate-linux-release-x64-try,vm-aot-optimization-level-linux-release-x64-try,vm-aot-tsan-linux-release-x64-try,vm-aot-ubsan-linux-release-x64-try,vm-aot-win-debug-arm64-try,vm-aot-win-debug-x64-try,vm-aot-win-debug-x64c-try,vm-appjit-linux-debug-x64-try,vm-asan-linux-release-arm64-try,vm-asan-linux-release-x64-try,vm-checked-mac-release-arm64-try,vm-ffi-android-debug-arm-try,vm-ffi-android-debug-arm64c-try,vm-ffi-qemu-linux-release-arm-try,vm-ffi-qemu-linux-release-riscv64-try,vm-fuchsia-release-arm64-try,vm-fuchsia-release-x64-try,vm-linux-debug-ia32-try,vm-linux-debug-x64-try,vm-linux-debug-x64c-try,vm-mac-debug-arm64-try,vm-mac-debug-x64-try,vm-msan-linux-release-arm64-try,vm-msan-linux-release-x64-try,vm-reload-linux-debug-x64-try,vm-reload-rollback-linux-debug-x64-try,vm-tsan-linux-release-arm64-try,vm-tsan-linux-release-x64-try,vm-ubsan-linux-release-arm64-try,vm-ubsan-linux-release-x64-try,vm-win-debug-arm64-try,vm-win-debug-x64-try,vm-win-debug-x64c-try,vm-win-release-ia32-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/398621
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Commit-Queue: Daco Harkes <dacoharkes@google.com >
Reviewed-by: Daco Harkes <dacoharkes@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2024-12-09 22:02:56 +00:00
09c1b3a5ac
Elements. Migrate lib/src/handler/legacy/legacy_handler.dart
...
Change-Id: Ie28f56623633c3774ee2b9a8fb9273e532b0216e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/399033
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
2024-12-09 16:02:56 +00:00
d5088aac58
Elements. Migrate lib/src/lsp/handlers/handler_implementation.dart
...
Change-Id: Iaa32be3faad25e838dee04fe15833ebb51acb7db
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/399580
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
2024-12-09 15:56:04 +00:00
e87c93bd71
Elements. Migrate lib/src/domains/analysis/implemented_dart.dart
...
Change-Id: Iac8d3c225fa5f7c19add953defb01261c4ac6c9f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/399540
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Phil Quitslund <pquitslund@google.com >
2024-12-07 00:52:42 +00:00
1cca342b1e
Elements. Migrate lib/src/search/type_hierarchy.dart
...
Change-Id: Ic5ef83f214167da062f7dc1326361527235262bb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/399030
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2024-12-07 00:28:11 +00:00
af2527723b
Elements. Migrate lib/src/cider/fixes.dart
...
Change-Id: I01867f48ac6d39c65a9a21961079232399e05c1b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/399029
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Phil Quitslund <pquitslund@google.com >
2024-12-06 23:59:55 +00:00
f988136917
Elements. Migrate lib/src/computer/import_elements_computer.dart
...
Change-Id: I116786925a2a462f15cd757cb51e8da3ecdb247f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/399204
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2024-12-06 23:50:00 +00:00
17c6db0eac
Elements. Migrate lib/src/cider/completion.dart
...
Change-Id: I3d75e18e658349a3dd9e95ed8efb3cf1aac3fa76
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/399026
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2024-12-06 23:09:39 +00:00
139a560f80
Elements. Migrate lib/src/services/search/hierarchy.dart
...
Change-Id: I4917d439dd5db00799958109505a6f2d88df26d6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/399203
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2024-12-06 23:02:00 +00:00
372e84189f
[analysis_server] update package deps
...
Change-Id: Ia824cf11c6212e8d81dd2d6e0f900b95bd367672
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/399462
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Devon Carew <devoncarew@google.com >
2024-12-06 19:28:52 +00:00
2cd14ce1e3
Elements. Migrate lib/src/services/correction/util.dart
...
This touches some rename related files.
If you have any changes in progress, I could wait until they land.
Change-Id: Id349b83493153de947660c312e7657da3754ea5c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/399024
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2024-12-06 19:27:41 +00:00
0843a42158
Migrate three rename pieces
...
Change-Id: I5b7a61ce110930c46871fab57fdbc9ee7ce17fb0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/398954
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2024-12-06 18:45:29 +00:00
c57f879bd1
Elements. Migrate getExportedElement()
...
Change-Id: I987a14f465541d727aa32716bc77dd0702f1746c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/399023
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2024-12-06 17:25:39 +00:00
82c47897e9
Elements. Migrate DeclarationHelper.
...
Change-Id: I4558c53ba01d19ca3db8ae9903b3759bf3393b9e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/399022
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2024-12-06 05:10:58 +00:00
a348c85e1b
Elements. Migrate DartCompletionManager and VisibilityTracker.
...
Change-Id: I0582c52608d29373af778ff2f1ba869fb2ef3703
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/398953
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2024-12-05 19:21:50 +00:00
dc9be358e5
Elements. Use switch with patterns in UseDifferentDivisionOperator.
...
Change-Id: I9b66f6f657e34b91633a0cc946cd614655f8daa4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/398951
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Phil Quitslund <pquitslund@google.com >
2024-12-05 05:09:22 +00:00
7e1721dfab
Elements. Migrate ImportLibrary.
...
Change-Id: I127e0f0b31e6b0d05727ae518b54971287e37008
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/398950
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Phil Quitslund <pquitslund@google.com >
2024-12-05 05:04:08 +00:00
8e8a0e3f9a
Elements. Migrate UseDifferentDivisionOperator.
...
Change-Id: I916174422f918dce4c01764b5af3036e884031cb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/398930
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2024-12-05 00:58:58 +00:00
6f992aea0d
Elements. Migrate lib/src/utilities/extensions/element.dart
...
Change-Id: Ibcf9d2449411413210e1d363ced4acdcfeede8d7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/398948
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2024-12-04 23:19:17 +00:00
f773702a6f
[Elements.migrate] Migrate InScopeCompletionPass.
...
Change-Id: I5801f9882487e4f3255d75f5e44b7a5e9fdb3b79
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/398941
Commit-Queue: Keerti Parthasarathy <keertip@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2024-12-04 23:15:27 +00:00
074e9c343c
Elements. Migrate lib/src/utilities/extensions/ast.dart
...
Change-Id: I14c051881037ce161df63b4e37428396940ec2e8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/398946
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Phil Quitslund <pquitslund@google.com >
2024-12-04 21:55:29 +00:00
83c9f852e1
Migrate rename_class_member
...
Change-Id: I5a574c3858a9d59d01952052941e08dde4f1e6b9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/398924
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2024-12-04 21:49:54 +00:00
63382832fd
Elements. Migrate DartCompletionRequestExtensions.
...
Change-Id: I998b7e445772ea2ca0f4adf80ed07dc06867eefd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/398923
Reviewed-by: Keerti Parthasarathy <keertip@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2024-12-04 21:05:36 +00:00
015f872e24
[analysis_server] Add an LSP handler for editing argument values
...
This adds basic editing for the argument types supported by `textDocument/editableArguments`. It doesn't currently attempt to format code currently (or use multiline/raw strings where they might be more appropriate), and does not allow arbitrary values that don't match the type for the parameter.
Change-Id: Ied95d95c0de39310aef0a1153864e902d56e1910
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/395280
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Elliott Brooks <elliottbrooks@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2024-12-04 20:09:30 +00:00
c1e04fce7d
[Elements.migrate] Migrate create_extension_member.dart
...
Change-Id: I2b6bc9c0c6b1e8b1e2b8345d06b207b039fd70c2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/398583
Commit-Queue: Keerti Parthasarathy <keertip@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2024-12-04 19:39:49 +00:00
3f159b2b93
Elements. Updates as needed for google3.
...
Change-Id: Ib76bf37a41d2fc0923ccddb1da37599589da3a5f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/396571
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2024-12-03 17:38:28 +00:00
17483c53b7
[Elements.migrate] Migrate add_extension_override.dart
...
Change-Id: Id70be814e55899f62fffeb5d435ded3ba85d1278
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/398540
Commit-Queue: Keerti Parthasarathy <keertip@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2024-12-03 05:23:59 +00:00
83863711d3
Migrate NotImportedCompletionPass.
...
Change-Id: I15c18b941833688745416f69b271f8598505c673
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/397981
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Keerti Parthasarathy <keertip@google.com >
2024-12-02 21:38:39 +00:00
2a2905228f
Add extension on Completer to simplify code.
...
Change-Id: Ida74cf78f5cedf2c4b3c806c7aaef92fa86f6d61
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/397960
Commit-Queue: Keerti Parthasarathy <keertip@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2024-12-02 21:01:18 +00:00
05696d50cc
Migrate postfix_completion.dart, statement_completion.dart.
...
Change-Id: Ib3723395354822f010f207393ddebcc0b93cf289
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/397982
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Keerti Parthasarathy <keertip@google.com >
2024-12-02 20:36:31 +00:00
ed49d04e2e
[analysis_server] Extract some shared code from editableArguments to be used by editArgument
...
This doesn't change any functionality, it just extracts some code from the editableArguments handler into a mixin because the editArgument handler will want to reuse some of this logic to locate the argument/parameter and ensure it is allowed to be edited.
Change-Id: Ibe9f1350c977b470847cebe2ecf7a7bec5256000
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/398440
Reviewed-by: Elliott Brooks <elliottbrooks@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2024-12-02 20:06:13 +00:00
a635ccf2f5
[analysis_server] Only mark positional arguments as editable if they wouldn't require inserting additional values
...
We can _edit_ all existing arguments because we just replace their values.
We can also _add_ a new argument for a positional parameter as long as there are no missing positional arguments that would need to come before it (because we can't insert them).
Change-Id: Ia66e49f940c463511f472405e90ee46d3b5f6177
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/396841
Reviewed-by: Elliott Brooks <elliottbrooks@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2024-12-02 19:41:37 +00:00
bfb507a3af
Migrate utilities.dart
...
Change-Id: I0823b6bacdd0098123b912a7f3a1c1cf72f68e45
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/397560
Commit-Queue: Keerti Parthasarathy <keertip@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2024-12-02 19:11:27 +00:00
06caa3fa11
[DAS] Adds new import with show option
...
R= srawlins@google.com
Fixes https://github.com/dart-lang/sdk/issues/32234
Fixes https://github.com/dart-lang/sdk/issues/55842
Change-Id: I3acb03cc6d9a5f8bc1ebaf590a45ac5ee10388f8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/396564
Auto-Submit: Felipe Morschel <fmorschel.dev@gmail.com >
Commit-Queue: Phil Quitslund <pquitslund@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Phil Quitslund <pquitslund@google.com >
2024-12-02 18:54:59 +00:00
91c05b2bbb
[analysis_server] Use generic function syntax for function parameters in "Extract Method"
...
This fixes an issue where parameters that used the new function syntax and had no parameter names would produce code like `void f(String )` where the type would be interpreted as a parameter name and typed `dynamic`.
Fixes https://github.com/Dart-Code/Dart-Code/issues/5350
Change-Id: Ifcbe64dadb88cc0fd9b4fa3637045bcdc343f3f7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/397900
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2024-12-02 18:26:34 +00:00
dcb9ec10a1
[analysis_server] Add isEditable to editableArguments results and make false for non-editable strings
...
Change-Id: Iac020bfe0d495f3b634b95c8c32409433e9181bc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/396282
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Elliott Brooks <elliottbrooks@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2024-12-02 17:52:33 +00:00
343ffd1ea8
[analysis_server] Fix URI/path comparisons for Windows in the Scheduler
...
We can't use `uri.path` to get a file path from a `file:///` URI because on Windows it will be incorrect. Instead, we should use `toFilePath()`... however, it's possible in future we'll have non-file URIs here (macros etc.), so it's better to compare URIs directly.
Fixes https://github.com/dart-lang/sdk/issues/59615
Change-Id: I9b4badb96edc9f7dae57b1fa399d0e4fef8bb86a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/397620
Reviewed-by: Keerti Parthasarathy <keertip@google.com >
Reviewed-by: Jaime Wren <jwren@google.com >
Commit-Queue: Keerti Parthasarathy <keertip@google.com >
2024-11-26 21:52:58 +00:00
19da943583
[DAS] Fixes wrong prefixes
...
R=srawlins@google.com
Fixes https://github.com/dart-lang/sdk/issues/57090
Change-Id: I4a6597b174216dcdb8ce1801437b539e7f47136c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/396563
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Auto-Submit: Felipe Morschel <fmorschel.dev@gmail.com >
Reviewed-by: Phil Quitslund <pquitslund@google.com >
2024-11-22 23:30:24 +00:00
44a8f14932
[Elements.migrate] Migrate FeatureComputer
...
Change-Id: Iff5c9cffd676464454460ca2a51cdd7cd0e1d507
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/397040
Commit-Queue: Keerti Parthasarathy <keertip@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2024-11-22 22:21:29 +00:00
Konstantin Shcheglov