badfd146d2
Fix type error in js_dart2js.dart caught by DDC.
...
BUG=
R=vsm@google.com
Review-Url: https://codereview.chromium.org/2611423002 .
2017-01-09 07:42:49 -08:00
7ab0daeedf
Make EventStreamSubscription DDC safe.
...
EventStreamSubscription.listen does a cast which is only working in
DDC because we're ignoring the failure. This wraps the listener to
check the argument rather than casting the function. Also picks up a
few misc changes to the main SDK that hadn't been merged into DDC.
BUG=
R=jacobr@google.com
Review-Url: https://codereview.chromium.org/2609633002 .
2017-01-09 04:13:36 -08:00
83fc4b6b46
Put a TypeProvider on the TypeSystem implementations.
...
Adding a TypeProvider instance to TypeSystem to avoid needing to
thread it through the various APIs, and to avoid having to change
the API every time a method which previously did not need to
access the TypeSystem suddenly does.
BUG=
R=jmesserly@google.com
Review-Url: https://codereview.chromium.org/2590883004 .
2017-01-09 02:40:10 -08:00
95d5bf471c
fix analyzer failing resolve loop variable nodes
...
for example: `var item; for (item in list) { ... }`
this happens anytime ResolutionCopier is used on these, because it drops the staticElement reference for `item` in the above example.
R=vsm@google.com
Review-Url: https://codereview.chromium.org/2612983002 .
2017-01-05 10:47:43 -08:00
55ef6e193c
support --options flag and other analysis options flags in DDC
...
This updates DDC options processing to support:
* --options /path/to/analysis/options/file.yaml
* --enable-strict-call-checks
* --supermixin
* --no-implicit-casts
* --no-implicit-dynamic
As well as general refactoring and cleanup of DDC options processing
R=vsm@google.com
Review-Url: https://codereview.chromium.org/2598593003 .
2017-01-04 18:15:21 -05:00
93fb5d8119
Fix cross-window JS interop on FireFox.
...
BUG=
R=vsm@google.com
Review-Url: https://codereview.chromium.org/2610813003 .
2017-01-04 14:15:20 -08:00
3659aaf181
Fix bug in Blob creation from workers.
...
Fixes https://github.com/dart-lang/sdk/issues/28155
BUG=
Review-Url: https://codereview.chromium.org/2592813003 .
2016-12-21 08:45:48 -08:00
7f26211c26
Correct handling of cross-frame functions in ddc.
...
Misc fixes of dart:js support on ddc.
Work around issue with Blob constructor on ddc.
Fix incorrect dart:js test on dart2js (fixes https://github.com/dart-lang/sdk/issues/26197 )
BUG=
R=alanknight@google.com , leafp@google.com , rnystrom@google.com
Review-Url: https://codereview.chromium.org/2587203002 .
2016-12-19 15:00:55 -08:00
13bd1ad0bf
DDC/AnalyzerCLI common cmdline option processing
...
Refactor DDC and Analyzer CLI command line option processing
to use common createContextBuilderOptions method
and ContextBuilderOptions to hold common options.
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/2584293003 .
2016-12-19 16:24:20 -05:00
77f53f609f
fixes #27385 , implement virtual fields in DDC
...
If a field is marked @virtual in Analyzer, DDC will allow it to be overridden as well
also fixes #28114 , abstract getters/setters broke generation of forwarding getters/setters
R=vsm@google.com
Review-Url: https://codereview.chromium.org/2571363002 .
2016-12-15 11:39:25 -08:00
a105d89e2b
refactor DDC and Analyzer CLI parser option declaration
...
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/2580933002 .
2016-12-15 14:10:09 -05:00
5b84611856
refactor DDC to support --ignore-unrecognized-flags
...
* add --ignore-unrecognized-flags to DDC
* refactor Analyzer CLI to use same filterUnknownArguments functionality
* remove now unused CommandLineParser and associated tests
R=brianwilkerson@google.com , vsm@google.com
Review-Url: https://codereview.chromium.org/2578113002 .
2016-12-15 10:46:09 -05:00
1d4334739c
update DDC to use analyzer extractDefinedVariables
...
R=vsm@google.com
Review-Url: https://codereview.chromium.org/2578463004 .
2016-12-14 20:43:53 -05:00
392c242df9
Add dart:io stubs to ddc sdk, define dart.library.html
...
Fixes #27302
R=brianwilkerson@google.com , jmesserly@google.com , rnystrom@google.com
Review-Url: https://codereview.chromium.org/2578573003 .
2016-12-14 12:34:33 -08:00
b900a39620
Implement messages in assert() in dev_compiler.
...
Fix #27342 .
R=jmesserly@google.com
Review-Url: https://codereview.chromium.org/2568313002 .
2016-12-13 13:31:56 -08:00
f8cbc1423b
add verbose option to show hidden args
...
R=vsm@google.com
Review-Url: https://codereview.chromium.org/2569783003 .
2016-12-13 09:46:15 -05:00
756cfc963d
Fix warnings
...
Review-Url: https://codereview.chromium.org/2564323002 .
2016-12-11 16:53:13 -08:00
e0e7efc351
Support callable classes where call is inherited
...
R=jmesserly@google.com
Review URL: https://codereview.chromium.org/2560983002 .
2016-12-08 12:04:10 -08:00
ae9a362cc1
remove DDC --build-root option
...
R=vsm@google.com
Review URL: https://codereview.chromium.org/2553973004 .
2016-12-07 19:18:38 -08:00
ef4baafae5
fixes #28032 , await in cascade
...
R=vsm@google.com
Review URL: https://codereview.chromium.org/2559883002 .
2016-12-07 14:00:18 -08:00
ae6fd961a1
Prepare for decoupling analyzer ASTs from element model.
...
This CL creates top level accessor functions which may be used to map from AST data structures to their corresponding elements and types, and begins using those accessor functions throughout the SDK. It also adds empty interfaces ResolutionTarget and ResolutionType, which are implemented by Element and DartType respectively.
In a future CL, I will change the types stored in the AST to ResolutionTarget and ResolutionType, rather than specific element types; this will decouple the ASTs from the element model. The presence of the accessor functions will allow clients to continue accessing elements and types in a type-safe way.
R=asgerf@google.com , brianwilkerson@google.com , scheglov@google.com , vsm@google.com
Review URL: https://codereview.chromium.org/2551023005 .
2016-12-07 11:08:14 -08:00
dd16c377fb
Enable more async code on node
...
This is primarily for easier testing/repro on node which has "global",
but not "self".
R=jmesserly@google.com
Review URL: https://codereview.chromium.org/2558133002 .
2016-12-07 10:52:04 -08:00
69f0218802
Mark test pass on Chrome 55
...
TBR=alanknight@google.com
Review URL: https://codereview.chromium.org/2554523002 .
2016-12-05 05:55:44 -08:00
201c5b9297
Fix runtime strong mode error in ListMixin
...
R=jacobr@google.com
Review URL: https://codereview.chromium.org/2544163002 .
2016-12-01 15:41:46 -08:00
ec81359fc0
Fixes #27960
...
For "m.call(..)", the function is "m".
R=jmesserly@google.com
Review URL: https://codereview.chromium.org/2539033004 .
2016-12-01 15:38:46 -08:00
1ff09b431f
Keep only a single active stack trace, enables traces for thrown non-exceptions
...
BUG=
R=jmesserly@google.com
Review URL: https://codereview.chromium.org/2545923002 .
2016-12-01 13:41:08 -08:00
2d289c2df6
Modify dev_compiler to use analyzer's new AstFactory class.
...
The old mechanism for creating analyzer ASTs (factory constructors on
the interface classes) will be going away in analyzer 0.30.
R=jmesserly@google.com
Review URL: https://codereview.chromium.org/2545843002 .
2016-12-01 10:37:22 -08:00
106c623a9f
Some fixes for lazy JS types
...
R=jacobr@google.com
Review URL: https://codereview.chromium.org/2542833002 .
2016-12-01 07:44:38 -08:00
aa749dbd8d
Sprinkle some types on the SDK like the static typing fairy.
...
When I'm looking at the dynamic call profiles of an internal app test,
I see a bunch coming from the SDK itself. In fact, the top five most
common dynamic call sites are in the SDK.
This fixes four of them. (The fifth is in runUnary() in Zone, and I
don't think can be made typed yet.)
R=vsm@google.com
Review URL: https://codereview.chromium.org/2542723003 .
2016-11-30 17:04:54 -08:00
667fc8dbe9
Make the dart:developer library available in DDC so debugger statement works
...
BUG=
R=vsm@google.com
Review URL: https://codereview.chromium.org/2534263002 .
2016-11-29 16:13:45 -08:00
88c5dd5745
Better mirrors support for mixins and private fields
...
This is generally motivated by pageloader usage.
R=rnystrom@google.com
Review URL: https://codereview.chromium.org/2535273002 .
2016-11-29 14:00:01 -08:00
1370b6bb46
Fix handling of static names for JS interop and improve test coverage.
...
BUG=
R=jmesserly@google.com
Review URL: https://codereview.chromium.org/2536823003 .
2016-11-29 13:33:19 -08:00
1b339deab2
Support lazy JS types.
...
BUG=
R=jmesserly@google.com
Review URL: https://codereview.chromium.org/2515353003 .
2016-11-22 10:55:35 -08:00
f109556fb7
remove unused DDC --package-paths options and MultiPackageResolver
...
R=vsm@google.com
Review URL: https://codereview.chromium.org/2527433002 .
2016-11-22 11:20:23 -05:00
de9e3a3005
Set auto breakpoint at various errors
...
Any reason not to do this? I generally find when framework code wraps these errors, it just complicates finding the original bug. Better to just trap.
Perhaps should just inline the call to debugger though. I put in dart.debugger with the thought of making it configurable.
R=jacobr@google.com , jmesserly@google.com
Review URL: https://codereview.chromium.org/2519873004 .
2016-11-21 14:40:46 -08:00
37029a22de
fix #27336 , ddc with recursive generic class type args
...
R=vsm@google.com
Review URL: https://codereview.chromium.org/2516483002 .
2016-11-17 15:38:33 -08:00
365d9a000a
fix #27784 and fix #27785 , fromEnvironment constants in DDC
...
R=vsm@google.com
Review URL: https://codereview.chromium.org/2503803004 .
2016-11-16 12:20:43 -08:00
fb467ef68a
Fix _wrapDartFunction to call the JS set method directly. At one point this code was previously surprisingly generating a direct call to set instead of a call to dsetindex.
...
BUG=
R=vsm@google.com
Review URL: https://codereview.chromium.org/2504733002 .
2016-11-15 12:52:28 -08:00
27287baa57
Only re-export the main methods. The ddc codegen doesn't depend on any other methods being exported and export code for top level fields and all JS interop types was broken. This change reduces code size of a large Angular2 app by 6%.
...
BUG=
R=vsm@google.com
Review URL: https://codereview.chromium.org/2500283002 .
2016-11-15 09:35:44 -08:00
bc980498a1
Fix ddc whitelist op
...
R=jacobr@google.com
Review URL: https://codereview.chromium.org/2492523004 .
2016-11-09 15:23:04 -08:00
3356f82eb3
Fix crashing bug for closures of the form () { return; }
...
BUG=
R=jmesserly@google.com , vsm@google.com
Review URL: https://codereview.chromium.org/2484913004 .
2016-11-08 15:14:10 -08:00
8f04f902df
fix #27771 , create directory if needed
...
R=vsm@google.com
Review URL: https://codereview.chromium.org/2483753004 .
2016-11-08 10:21:31 -08:00
3995146b55
fix #27775 , enum declaration where "name" is a property
...
R=vsm@google.com
Review URL: https://codereview.chromium.org/2488543002 .
2016-11-08 10:18:55 -08:00
f05e2b0760
recompile for 4179bd7601
...
Review URL: https://codereview.chromium.org/2484853002 .
2016-11-07 11:02:36 -08:00
8daf4cfb73
Get the basics of deferred libraries working.
...
References to loadLibrary on a library prefix are compiled to a
helper function that returns a Future that always completes
successfully.
The deferred libraries aren't actually deferred, but code that uses
loadLibrary() now doesn't barf.
BUG=#27343
R=vsm@google.com
Review URL: https://codereview.chromium.org/2477673006 .
2016-11-07 10:41:23 -08:00
d062fd7994
Fixes #27752
...
R=jmesserly@google.com
Review URL: https://codereview.chromium.org/2473143003 .
2016-11-03 18:01:05 -07:00
1aff39dd13
replace / with . in sourceUrl to prevent breaking relative source uris in source maps ( #27730 )
2016-11-03 12:22:55 -07:00
4874480d55
Move FF and Canary to green on travis
...
Try run is here:
https://travis-ci.org/dart-lang/sdk/builds/172400947
R=rnystrom@google.com
Review URL: https://codereview.chromium.org/2467063002 .
2016-11-03 07:44:27 -07:00
69279d6b62
Fix summary path for tests
...
Should get travis back to green
TBR=jmesserly@google.com
Review URL: https://codereview.chromium.org/2470053002 .
2016-11-01 21:12:01 -07:00
2e8d011ca3
fix #27607 , add dev_compiler summary to the SDK and move JS files
...
R=vsm@google.com
Review URL: https://codereview.chromium.org/2474523003 .
2016-11-01 18:17:43 -07:00
Jacob Richman