b820aef91c
fix constructor suggestion element names
...
BUG=dartbug.com/22158
R=scheglov@google.com
Review URL: https://codereview.chromium.org//962243003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44183 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-03 17:03:24 +00:00
75fc8fd45c
Some clean-ups for Index / SearchEngine.
...
1. Remove the TODO, it is better to keep searchTopLevelDeclarations() returning Future,
for consistency and possible future changes.
2. Rename IndexStore.recordTopDeclaration() to recordTopLevelDeclaration().
Sorry, I missed it initially.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//975753002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44182 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-03 16:54:56 +00:00
7c9de023c2
include library prefix suggestions when suggesting constructors
...
BUG=dartbug.com/22158
R=scheglov@google.com
Review URL: https://codereview.chromium.org//972193002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44179 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-03 16:51:18 +00:00
1183b3b35a
When a closure is extracted as a method, it does not have any return type.
...
But it should not be returned as 'void'.
It should be an empty string, as any other method with unknown return type.
I guess we could improve this in the future, e.g. promote type of a returned expression into the signature.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//970063002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44177 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-03 16:17:33 +00:00
d69f9043cd
Don't allow to extract a closure as a getter.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//971203002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44176 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-03 16:15:47 +00:00
7e9557cb39
add arguments to constructor completions
...
BUG=dartbug.com/22158
R=scheglov@google.com
Review URL: https://codereview.chromium.org//972933002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44174 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-03 15:58:50 +00:00
fc38d660ee
Static SPPM-n1 model for Dart Core API usage
...
R=danrubel@google.com
Review URL: https://codereview.chromium.org//968283003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44158 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-03 01:15:52 +00:00
cd58e290c4
Reformat
...
R=paulberry@google.com
Review URL: https://codereview.chromium.org//969113002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44151 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-02 22:43:12 +00:00
253658afa8
Optimize top-level element declarations search.
...
No limits on the number of returned matches yet.
With this CL it takes about 20 ms for one-character regexp, vs. 200+ ms before.
The Editor UI is still not quite fast, we need to set some limits there too.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//971833003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44145 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-02 19:56:13 +00:00
268cd8bab2
API clean-up
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//970913002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44134 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-02 17:28:37 +00:00
2a88570c8f
update comments for http diagnostic port
...
BUG=
R=lukechurch@google.com
Review URL: https://codereview.chromium.org//957263003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44131 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-02 15:17:56 +00:00
fde14c072a
Issue 22593. Quick fix 'import library' for typedefs.
...
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22593
Review URL: https://codereview.chromium.org//965013002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44112 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-28 01:40:34 +00:00
1a7ac64ae2
Don't remove indexing operations on potential source changes.
...
This covers the following scenario:
1. User performs an undo operation in a save editor.
2. Editor updates the file buffer, so sends 'add overlay'.
Server performs an incremental analysis and schedules an 'analyze' operation.
3. The 'analyze' operation runs and schedules 'index' operation.
4. Editor saves the file buffer.
Editor sends 'remove overlay command'.
Server removes all the scheduled notification and index operations for the file.
Server notices that there is no real change for the file, so the is nothing to do.
But it still reschedules notifications, because the client might have lost some information.
5. Notifications are resent, but indexing is not performed.
So, the solution is to reschedule indexing operation.
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org//958373003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44111 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-28 01:34:56 +00:00
f54675b398
throw exception to stop visiting
...
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//967643002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44105 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-27 21:41:30 +00:00
a2baa0f2ba
remove unused imports
...
BUG=
R=paulberry@google.com
Review URL: https://codereview.chromium.org//962323002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44104 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-27 21:09:29 +00:00
d91099d6cb
fix invocation completion with trailing stmt
...
BUG=dartbug.com/22365
R=scheglov@google.com
Review URL: https://codereview.chromium.org//965753003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44100 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-27 18:42:41 +00:00
d3ceb5ce50
Use String.replaceRange() instead of concatenation.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//960653003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44079 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-26 22:25:07 +00:00
944fd2ccdd
Issue 22575. Fix for type hierarchy from FieldElement.
...
R=brianwilkerson@google.com , paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22575
Review URL: https://codereview.chromium.org//962743003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44077 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-26 22:22:31 +00:00
5a4919c270
Add instrumentation (issue 22572)
...
R=paulberry@google.com
Review URL: https://codereview.chromium.org//956103002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44071 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-26 19:54:36 +00:00
6a90488fc8
cache pub list results
...
BUG=
R=paulberry@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//941883002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44062 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-26 17:24:08 +00:00
98c9558a23
Issue 20827. Import required type in 'Extract Method' refactoring.
...
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=20827
Review URL: https://codereview.chromium.org//956393002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44059 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-26 17:08:13 +00:00
ec8ab11a9d
Issue 20827. Extract library importing helper and use it fox Quick Fixes.
...
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=20827
Review URL: https://codereview.chromium.org//961583002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44052 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-26 15:57:10 +00:00
08cff379ca
Don't propose 'Assign to local variable' when in arguments list.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//943053005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44036 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-26 01:34:25 +00:00
7c257183de
Issue 21804. Type hierarchy should show overrides in mixins.
...
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21804
Review URL: https://codereview.chromium.org//956023003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44033 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-25 22:53:19 +00:00
d7672348a1
Issue 21978. Put function 'main' first when sorting members.
...
R=brianwilkerson@google.com , paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21978
Review URL: https://codereview.chromium.org//961443004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44032 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-25 22:40:26 +00:00
49a2b92b29
Measure time spent running pub
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//959543005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44031 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-25 21:37:15 +00:00
6c16e7a255
Small improvements for indexing NameElements.
...
It improves analysis by about 2%.
For analyzer + analysis_server indexing takes about 12% now.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//951463005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44027 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-25 18:51:30 +00:00
209fcdf1d7
Merge notifications computing into the 'notices' tag.
...
Also cover incremental analysis with its own tag.
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org//956623006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44013 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-25 01:42:26 +00:00
ba818ae5e1
Add more user tags to help trackdown analysis server perf bottlenecks.
...
R=danrubel@google.com
Review URL: https://codereview.chromium.org//928073003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44008 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-24 22:59:34 +00:00
9581e77f58
Replace try/finally with PerformanceTag.makeCurrentWhile().
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//954013002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44004 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-24 22:33:55 +00:00
12ccb77c10
Add more performance tags.
...
This reduces amount of "unknown" time to less than 1%.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//951423002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44000 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-24 21:47:09 +00:00
a2fa6b10ec
Improve displaying overlays.
...
1. Use path as argument instead of id.
2. Show every file in the global ContentCache just once.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//949283002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43994 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-24 19:55:01 +00:00
d2c177955f
Optimize IntArrayToIntMap and ElementCodec.encodeHash().
...
This make analysis about 6% faster.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//953913003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43993 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-24 18:25:17 +00:00
e267b86440
Improve performance tags display - percent and sorting.
...
R=paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org//953933002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43992 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-24 17:53:08 +00:00
e0f3cceb17
Add the 'executionDomain' performance tag.
...
R=paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org//955743002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43991 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-24 17:39:51 +00:00
fcb524088e
Add support for writing instrumentation to a log file
...
R=danrubel@google.com
Review URL: https://codereview.chromium.org//950983002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43976 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-23 20:41:45 +00:00
2cc371c123
Drop return type in _IndexContributor.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//949993002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43975 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-23 19:49:51 +00:00
b36efe9640
Field references in field format parameter declarations and initializers mean writing.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//949623005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43971 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-23 18:45:30 +00:00
2e466105b2
Create package: URIs everywhere
...
R=paulberry@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//946803002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43965 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-23 17:34:12 +00:00
acec842aee
Add 'Convert Method to Getter' proposal only if it is an available refactoring.
...
So, that we don't show it for method with parameter or returning null.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//945113002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43936 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-20 23:18:21 +00:00
946d56198e
Fix for searching constructor references.
...
Currently we record constructor declarations and SearchEngine returns them as "references".
But it is not quite a reference, and it is used only as a way to get name range.
With this change to ConstructorElement we don't need to have these artificial references.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//946023003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43932 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-20 22:10:30 +00:00
0348d0decd
Issue 22288. Rename named parameters in hierarchy.
...
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22288
Review URL: https://codereview.chromium.org//945693004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43931 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-20 22:08:18 +00:00
bbc11c6640
Add ignore-unrecognized-flags as an option to the command line options of analysis server
...
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//940093003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43920 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-20 17:19:53 +00:00
45acfc4524
fix code completion invocation on getter
...
BUG=dartbug.com/22376
R=scheglov@google.com
Review URL: https://codereview.chromium.org//929323002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43896 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-19 22:14:52 +00:00
3750ba067f
Return version with connected notification
...
R=jwren@google.com , paulberry@google.com
Review URL: https://codereview.chromium.org//943723002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43892 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-19 20:45:01 +00:00
7256562fcd
Return RequestErrorCode.NO_INDEX_GENERATED if no index.
...
R=brianwilkerson@google.com , danrubel@google.com
BUG=
Review URL: https://codereview.chromium.org//939823002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43866 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-19 05:07:06 +00:00
1e120443b5
Issue 21879. Don't include 'this' and 'super' keywords if not in a method/constructor body.
...
R=danrubel@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21879
Review URL: https://codereview.chromium.org//935123002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43857 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-18 23:17:10 +00:00
6a78250c64
Issue 22476. Outline for enums.
...
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22476
Review URL: https://codereview.chromium.org//934353002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43853 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-18 21:37:27 +00:00
4e34c0d247
Generate artificial hashCode for often used classes.
...
By avoiding calling Object.hashCode we analyze about 1% faster.
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org//934113002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43832 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-18 01:12:43 +00:00
0e73ada9c2
Use package: URIs for files in lib
...
R=paulberry@google.com
Review URL: https://codereview.chromium.org//914373004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43827 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-17 22:47:34 +00:00
danrubel@google.com