be5b189c19
Exclude synthetic import prefixes from runtime completion.
...
R=brianwilkerson@google.com
Change-Id: I6ebcef8eab433782cc120810f50b872faa097314
Reviewed-on: https://dart-review.googlesource.com/55913
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-05-18 18:57:59 +00:00
817965f49d
Runtime completion support for constructors, for loops, and function expressions.
...
R=brianwilkerson@google.com
Change-Id: I3d33841b9386b6c9fb0e0f74946ca6fe9449581a
Reviewed-on: https://dart-review.googlesource.com/55911
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-05-18 18:14:32 +00:00
7a90ed9b88
Tests for completion with nested blocks, functions, and methods.
...
R=brianwilkerson@google.com
Change-Id: I050aaa2f80a3374fd92587a0b8461bc170078bd8
Reviewed-on: https://dart-review.googlesource.com/55903
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-05-18 17:43:38 +00:00
76a30dd594
Initial implementation of 'execution.getSuggestions'.
...
Only local variables, no tests for multiple blocks, or parameters.
No support for classes yet.
No support for expressions or runtime variable types.
R=brianwilkerson@google.com
Change-Id: I9ec5c40e407cda48be408e4e4882d97349413b9c
Reviewed-on: https://dart-review.googlesource.com/55762
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-05-17 20:25:04 +00:00
39fa25cbe2
Implement FILE_HEADER folding
...
Bug: https://github.com/dart-lang/sdk/issues/33033
Change-Id: I66833cc73b4adecf1743c623cfc2c7fbd9af45bc
Reviewed-on: https://dart-review.googlesource.com/55284
Commit-Queue: Danny Tuppeny <dantup@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-05-16 15:37:20 +00:00
9b8776763c
Add some (marked) failing tests for FILE_HEADER
...
Bug: https://github.com/dart-lang/sdk/issues/33033
Change-Id: I89d358dd1dc41d8bece7f16ed49fb98b9b8c0aa5
Reviewed-on: https://dart-review.googlesource.com/55104
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Danny Tuppeny <dantup@google.com >
2018-05-16 07:35:48 +00:00
8907348ae9
Issue 2246. Fix for 'Wrap with new widget' assist when activated on a constructor name.
...
R=brianwilkerson@google.com
Bug: https://github.com/flutter/flutter-intellij/issues/2246
Change-Id: I66ca8b121b2600fa86c787fc26fe6dc01c79c24d
Reviewed-on: https://dart-review.googlesource.com/55272
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-05-15 21:22:26 +00:00
ee414b4d9d
Issue 2249. Fix swap with parent/child when code is not formatted.
...
We cannot just rely on line ends.
AST is our best guide.
R=brianwilkerson@google.com
Bug: https://github.com/flutter/flutter-intellij/issues/2249
Change-Id: Id901878f621abc745fb6a380e5cf9afe21884642
Reviewed-on: https://dart-review.googlesource.com/55268
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-05-15 20:35:06 +00:00
5a3aff60b6
Update annotations to be a single region for all
...
Bug: https://github.com/dart-lang/sdk/issues/33033
Change-Id: I41586b53814d335046cc18c24936a3d32277deda
Reviewed-on: https://dart-review.googlesource.com/55100
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Danny Tuppeny <dantup@google.com >
2018-05-15 13:39:54 +00:00
568e977a35
Update FoldingKinds enum, update specs and increase version number
...
Bug: https://github.com/dart-lang/sdk/issues/33033
Change-Id: Ieccfd90ead67a9803744c54db4eec8eea0b0403c
Reviewed-on: https://dart-review.googlesource.com/54920
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Danny Tuppeny <dantup@google.com >
2018-05-14 16:48:48 +00:00
bdecb92032
Fix MinimalPlugin to allow its loading in Dart2 VM.
...
R=brianwilkerson@google.com
Change-Id: I9e52979cee844f32e4d423a7c928c0359f9dd5b2
Reviewed-on: https://dart-review.googlesource.com/54708
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-05-11 19:47:09 +00:00
68229b862f
NPE fix for annotations with no arguments
...
Change-Id: I93254aeef708157566a3adf942ebc84902e3c02c
Reviewed-on: https://dart-review.googlesource.com/54680
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Danny Tuppeny <dantup@google.com >
2018-05-11 13:38:27 +00:00
d5f76cc963
Add annotations to folding regions
...
Bug: https://github.com/dart-lang/sdk/issues/33033
Change-Id: Ie1917e3bd29b5cc2b6ecbed1238818e4e49f822a
Reviewed-on: https://dart-review.googlesource.com/54580
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Danny Tuppeny <dantup@google.com >
2018-05-10 14:22:41 +00:00
46043004d6
Move folding regions to actual blocks
...
This puts the region inside the braces; eg. the bit the user would expect to disappear when the region is collapsed.
Bug: https://github.com/dart-lang/sdk/issues/33033
Change-Id: I58b347d2e1582bb4a6a35cf45c17085ea1739816
Reviewed-on: https://dart-review.googlesource.com/54402
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Danny Tuppeny <dantup@google.com >
2018-05-10 07:44:10 +00:00
b73541cffe
Add a skeleton for Dart Folding
...
Only currently adds a single region around Directives.
Bug: https://github.com/dart-lang/sdk/issues/33033
Change-Id: Ibde0400c5815c00b1f94bf592d8cc9eb7cb592cf
Reviewed-on: https://dart-review.googlesource.com/54232
Commit-Queue: Danny Tuppeny <dantup@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2018-05-08 16:59:03 +00:00
f62302b8ee
Make extracted widgets follow Flutter style - const constructor and @required named parameters.
...
R=brianwilkerson@google.com , pquitslund@google.com
Bug: https://github.com/flutter/flutter-intellij/issues/2166
Change-Id: I28f548c8e814ac5b9585dd46fbb9a8f84f70f418
Reviewed-on: https://dart-review.googlesource.com/54066
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-05-07 20:59:04 +00:00
67d3e4e3a1
Use actual names of the @isTest of isTestGroup executable in outlines.
...
R=brianwilkerson@google.com , devoncarew@google.com
Change-Id: Ifcd9d2398ca4e80cdace115e36f0d27df1afaad4
Reviewed-on: https://dart-review.googlesource.com/53825
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Devon Carew <devoncarew@google.com >
2018-05-04 20:11:16 +00:00
b7a63c8d52
Use @isTest and @isTestGroup to understand executable element as a test/group.
...
R=brianwilkerson@google.com , devoncarew@google.com
Bug: https://github.com/flutter/flutter-intellij/issues/2055
Change-Id: I7c8e7639d111eca63df0780ebdec182573493047
Reviewed-on: https://dart-review.googlesource.com/53690
Reviewed-by: Devon Carew <devoncarew@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-05-04 17:09:06 +00:00
7054d92a02
Remove some classes from the analyzer public API
...
Change-Id: Ic53a8426818b06f44c2876abd16c789589bf78b5
Reviewed-on: https://dart-review.googlesource.com/52421
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2018-04-24 15:28:15 +00:00
5460ddbab5
Move three more libraries out of the public API
...
Change-Id: I8e6aeaea35c739fb26e22ffcfc30a343ebbb5424
Reviewed-on: https://dart-review.googlesource.com/51363
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2018-04-16 22:15:28 +00:00
9976cddcd7
Shared cache of FileState contents.
...
This makes Flutter repo analysis about 12% faster.
R=brianwilkerson@google.com , devoncarew@google.com
Base: 76.2 74.9 75.9
After: 65.6 66.0 66.6 67.1
Change-Id: I5afffdae15eacf2c09c4ede40d7312c8827bae0c
Reviewed-on: https://dart-review.googlesource.com/51061
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Devon Carew <devoncarew@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-04-13 16:43:36 +00:00
a6bd6fe047
Fix for generating forDesignTime(), must be factory.
...
R=brianwilkerson@google.com
Change-Id: Ie4a81511f52ee883da458ae9c029cc619013a433
Reviewed-on: https://dart-review.googlesource.com/49825
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-04-06 02:12:00 +00:00
618077cfee
Implement FlutterCorrections.addForDesignTimeConstructor().
...
R=brianwilkerson@google.com , devoncarew@google.com
Change-Id: I1318020e9feab79ac1403e5d76c7e15483fc9a8e
Reviewed-on: https://dart-review.googlesource.com/49545
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-04-04 22:27:25 +00:00
633b2ccb38
Add 'isWidgetClass' and 'stateClassName' to FlutterOutline.
...
R=brianwilkerson@google.com , devoncarew@google.com
Change-Id: Idf7a986a67321b3ed33bb5d3bd4c139fac995474
Reviewed-on: https://dart-review.googlesource.com/48260
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-03-25 20:22:26 +00:00
d06dbb2ba8
Make most of the server Dart 2 safe
...
Change-Id: Ic9e8ea2557d01c05caedc126486778865af0396d
Reviewed-on: https://dart-review.googlesource.com/48262
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2018-03-24 15:33:53 +00:00
39395f911b
Send type parameters for functions in outlines
...
Change-Id: Ie11d739a41408903390ac2c1434d05fd7dccca0e
Reviewed-on: https://dart-review.googlesource.com/48267
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2018-03-24 14:54:13 +00:00
91d3c02d19
Rewrite relative URIs in instrumented Flutter outline code.
...
R=brianwilkerson@google.com , devoncarew@google.com
Change-Id: I33e73400643d77eb7c2b105eae918f4997e7d55d
Reviewed-on: https://dart-review.googlesource.com/46920
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-03-16 16:52:40 +00:00
64e092d4a3
Add fields codeOffset/codeLength to FlutterOutline.
...
R=brianwilkerson@google.com
Change-Id: I917a780704882fcd7537a9334febc21098aabd4f
Reviewed-on: https://dart-review.googlesource.com/46579
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-03-15 21:01:14 +00:00
e1909cb52a
Update Outline protocol - change offset/length, add codeOffset/codeLength.
...
R=brianwilkerson@google.com
Change-Id: I4b5c03a21254f7c497adc4c043641b18599c5c39
Reviewed-on: https://dart-review.googlesource.com/45764
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-03-09 01:52:57 +00:00
6b44182344
Only widgets in libraries can be rendered.
...
Technically we could eventually implement rendering widgets in parts,
but this is probably rare situation, and IntelliJ plugin does not
handle this case yet.
R=brianwilkerson@google.com , devoncarew@google.com
Change-Id: I734eb5f5b26c386780a776f652366bd4d21125f9
Reviewed-on: https://dart-review.googlesource.com/45361
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-03-06 18:02:39 +00:00
be87175fee
Implement Flutter Outline rendering API.
...
R=brianwilkerson@google.com , devoncarew@google.com
Change-Id: I7cbb4c0be7656ba1e684e8864348e6f1af54efae
Reviewed-on: https://dart-review.googlesource.com/45140
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-03-06 16:33:34 +00:00
e9527bed5e
Fix plugin tests on Windows
...
Bug: https://github.com/dart-lang/sdk/issues/32226
Change-Id: Iffbd616eec6afcc7613d829c47d8c278a268ab1b
Reviewed-on: https://dart-review.googlesource.com/43662
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2018-02-26 15:35:42 +00:00
40e3f9addc
Convert paths for mock SDK libraries to fix tests on Windows
...
The other lines on this method are calling `provider.convertPath` around their paths but these ones do not, which is causing almost all analysis server tests to fail on Windows (for me - I can't explain them not
failing builds). This causes the hard-coded paths like `/lib/core/core.dart` to be fixed up to `C:\lib\core\core.dart` which is what the server is looking for (because at the other end the paths *have* been fixed up).
See #32226 .
Closes #32230
https://github.com/dart-lang/sdk/pull/32230
GitOrigin-RevId: 1adeee23f8ac8efc8acf61caf5f769e4ec44c030
Change-Id: Id9bf195967db0912c6f4b67bd79d504e627b8aab
Reviewed-on: https://dart-review.googlesource.com/42300
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-02-20 18:55:38 +00:00
223eeb2ebe
Always shorten function expressions, list/map literals, multiline values.
...
R=brianwilkerson@google.com , devoncarew@google.com
Bug: https://github.com/flutter/flutter-intellij/issues/1762
Change-Id: I742ac6cb0ebbdde78f1326c5e07775d94e335d42
Reviewed-on: https://dart-review.googlesource.com/40560
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-02-12 19:15:05 +00:00
49686f7ffa
Don't insert a trailing comma after a missing required argument, when there is on already.
...
R=brianwilkerson@google.com
Change-Id: I47819c9d2698880f793de2e3c056e1112b1b8f57
Reviewed-on: https://dart-review.googlesource.com/40402
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-02-09 19:01:49 +00:00
59716fede1
New Quick Asists for Flutter: 'Replace with child' and 'Replace with children'.
...
R=brianwilkerson@google.com , devoncarew@google.com
Bug: https://github.com/flutter/flutter-intellij/issues/1283
Change-Id: Ic50de9739cdab5cd82649dcbd8370c5e728d2ee3
https://github.com/flutter/flutter-intellij/issues/1756
Reviewed-on: https://dart-review.googlesource.com/40240
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Devon Carew <devoncarew@google.com >
2018-02-09 17:09:18 +00:00
330ad8d287
Fix for NPE when an argument does not correspond to a constructor parameter.
...
R=brianwilkerson@google.com
Change-Id: I97ba245398e4375e0e132cc3280db0357859e494
Reviewed-on: https://dart-review.googlesource.com/40104
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-02-08 21:38:57 +00:00
f3242f8533
Fix for some cases of indentation in 'Move widget up/down'.
...
R=brianwilkerson@google.com , devoncarew@google.com
Bug: https://github.com/Dart-Code/Dart-Code/issues/495
Change-Id: I62c8374a1b7a578886bad1fec5a7c8eaf83cf231
Reviewed-on: https://dart-review.googlesource.com/39841
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-02-07 20:08:19 +00:00
cfa159ceb3
Wrap any Flutter widget expressions, not just instance creations.
...
Relanding https://dart-review.googlesource.com/c/sdk/+/38922 with all
changes.
Change-Id: I40b533521f420eccf2f4f86cf9e722ab498636e2
Reviewed-on: https://dart-review.googlesource.com/39201
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-02-06 18:20:13 +00:00
1d95d50192
Revert "Wrap any Flutter widget expressions, not just instance creations."
...
This reverts commit 9356382e6bbrianwilkerson@google.com , devoncarew@google.com
>
> Change-Id: Idc233251a3f5a62e47a0899c27f524537a3497d3
> Reviewed-on: https://dart-review.googlesource.com/38922
> Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
TBR=devoncarew@google.com ,scheglov@google.com ,brianwilkerson@google.com
Change-Id: I0b7c75802e328bc3ae7fdc4c2be6fab663bac570
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/39200
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-02-06 17:36:13 +00:00
9356382e6b
Wrap any Flutter widget expressions, not just instance creations.
...
So, we can wrap references to widgets, e.g. variables.
R=brianwilkerson@google.com , devoncarew@google.com
Change-Id: Idc233251a3f5a62e47a0899c27f524537a3497d3
Reviewed-on: https://dart-review.googlesource.com/38922
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-02-06 17:35:34 +00:00
fb9b24a8cc
Shorted MethodInvocation as outline labels.
...
R=brianwilkerson@google.com , devoncarew@google.com
Change-Id: I9056b9116ad50b2d9cddc38895e17d53c010d934
Reviewed-on: https://dart-review.googlesource.com/38921
Reviewed-by: Devon Carew <devoncarew@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-02-06 01:27:56 +00:00
8871ffbae1
Include generic label into Flutter outlines.
...
R=brianwilkerson@google.com , devoncarew@google.com
Change-Id: I98f96b38839bf339080144f2dc1f4f8dc9f3126f
Reviewed-on: https://dart-review.googlesource.com/38840
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-02-05 20:46:27 +00:00
65e6697cf8
Add 'Add padding' quick assist.
...
R=brianwilkerson@google.com , devoncarew@google.com
Change-Id: I03ed7ec1c25dd8e9ee7b115d95f24baeee016251
Reviewed-on: https://dart-review.googlesource.com/38341
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-02-02 21:26:39 +00:00
0ff7348c7b
Switch tests to use Flutter package mock that more closely resembles the actual package structure.
...
So, we can test that "Wrap with Center" works when we ask for Center
in package:flutter/widgets.dart
R=brianwilkerson@google.com , devoncarew@google.com
Change-Id: I3446f5cf97c1d6f2e68686de6561d894b5e95620
Reviewed-on: https://dart-review.googlesource.com/38162
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-02-01 22:12:06 +00:00
b44989cd57
Fix exception (issue 31922)
...
Change-Id: Id2d64ec1f92611e44b3c6e22c94efd1711b1a30e
Reviewed-on: https://dart-review.googlesource.com/37083
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2018-01-27 15:58:20 +00:00
f771476eec
Record variable name in FlutterOutline, fix for named attributes.
...
R=brianwilkerson@google.com , devoncarew@google.com
Change-Id: Ie91b21f464eaa43d811d51e50f7a6b479406f9da
Reviewed-on: https://dart-review.googlesource.com/36980
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-01-26 17:54:45 +00:00
32cfb6a9e3
Implement wrapping Widget into some single-child container.
...
R=brianwilkerson@google.com , devoncarew@google.com
Change-Id: If6f393c0eb80ba2fb670eda19ff7dfde845e2f73
Reviewed-on: https://dart-review.googlesource.com/36780
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-01-25 22:21:11 +00:00
6393a247fc
Add support for boolean/integer attributes.
...
R=brianwilkerson@google.com , devoncarew@google.com
Change-Id: I574931e558d45370c33a1d7626e17b5fb5e60480
Reviewed-on: https://dart-review.googlesource.com/36561
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Devon Carew <devoncarew@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-01-24 05:49:35 +00:00
402af4db46
Add a new experimental 'flutter' domain and move FLUTTER_OUTLINE there.
...
R=brianwilkerson@google.com , devoncarew@google.com
Change-Id: I8f829f10a630e38c5a3f1638d077e37832a08daa
Reviewed-on: https://dart-review.googlesource.com/36320
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-01-23 00:57:55 +00:00
Konstantin Shcheglov