Commit Graph

788 Commits

Author SHA1 Message Date
scheglov@google.com caaa026df9 Issue 6718. Resolve initializers in wrong methods, but report error.
http://code.google.com/p/dart/issues/detail?id=6718

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//11412040

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15035 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-16 21:02:47 +00:00
keertip@google.com a1adfb789a Review URL: https://codereview.chromium.org//11348078
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15016 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-16 16:52:48 +00:00
scheglov@google.com 7b701d4c9c Issue 6711. Fix for NPE in resolver.
http://code.google.com/p/dart/issues/detail?id=6711

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//11410076

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14902 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-14 17:02:11 +00:00
danrubel@google.com da4d1c5c7e cleanup unused code
Review URL: https://codereview.chromium.org//11369214

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14888 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-14 13:11:11 +00:00
scheglov@google.com dd172d631d Type quality of ArrayAccess is same as quality of target type.
Also tweak using "inferred exact" only for places where we sure about type.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//11364211

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14867 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-13 21:12:48 +00:00
scheglov@google.com 5a8befa2d8 Get real result for batch exacution.
Not just exit code 1 always.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//11366213

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14865 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-13 21:04:14 +00:00
ajohnsen@google.com 970cc5ba68 Move JSSyntaxRegExp to core as a private member. This removes the last refrences to dart:coreimpl.
After this cleanup, RegExp no longer have a const constructor. Use 'new
RegExp(...)' from now on.

BUG=

Review URL: https://codereview.chromium.org//11365196

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14838 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-13 10:41:37 +00:00
scheglov@google.com d27580a5ca Issue 6578. Report warning, not error for static/instance getter/setter mismatch
http://code.google.com/p/dart/issues/detail?id=6578

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//11358187

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14772 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-10 00:43:05 +00:00
scheglov@google.com f1a782c5f0 Issue 6598. Fix for hanging during parsing incomplete 'switch'.
http://code.google.com/p/dart/issues/detail?id=6598

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//11293165

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14687 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-08 15:54:36 +00:00
scheglov@google.com e094b33b6c Issue 6463. Remove support for obsolete metadata in comments.
http://code.google.com/p/dart/issues/detail?id=6463

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//11369129

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14686 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-08 15:52:54 +00:00
scheglov@google.com 322c76d6a9 Issue 6560. Report error when generative constructor calls factory constructor.
http://code.google.com/p/dart/issues/detail?id=6560

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//11368132

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14685 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-08 15:49:38 +00:00
scheglov@google.com a3ef4464eb Issue 6251. Resolve and rename type and constructor references in [new Type.name].
http://code.google.com/p/dart/issues/detail?id=6251

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//11377039

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14658 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-07 23:00:26 +00:00
scheglov@google.com 81ed8bda7d Issue 6427. Use '/' in URL.
http://code.google.com/p/dart/issues/detail?id=6427

R=messick@google.com
BUG=

Review URL: https://codereview.chromium.org//11377019

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14638 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-07 17:20:55 +00:00
scheglov@google.com b6f29d80e6 Attempt to fix build.
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14614 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-07 03:18:59 +00:00
scheglov@google.com e38fccf3e4 Issue 6251. Resolve and rename [id] references in documentation comments
http://code.google.com/p/dart/issues/detail?id=6251

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//11312081

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14538 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-05 16:38:52 +00:00
scheglov@google.com 1d310ff72c Report error for deprecated #library #import #source
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//11366078

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14535 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-05 16:21:20 +00:00
scheglov@google.com 3ef4e7ce32 Issue 6491. Fix for @annotation on getter/setter.
http://code.google.com/p/dart/issues/detail?id=6491

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//11275136

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14507 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-03 02:51:39 +00:00
scheglov@google.com bde8258b86 Issue 6489. Report error when static method attempts to access const instance field.
http://code.google.com/p/dart/issues/detail?id=6489

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//11369050

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14495 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-02 19:30:10 +00:00
scheglov@google.com 9e554d05e0 Use union type parts when check if type is subtype.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//11366062

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14492 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-02 17:52:13 +00:00
scheglov@google.com 7fed5e1373 Forgot TypeQuality
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14483 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-02 16:01:29 +00:00
scheglov@google.com 33f6347583 Issue 5157. Introduce TypeQuality. Try to find member in subclasses.
http://code.google.com/p/dart/issues/detail?id=5157

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//11293058

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14480 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-02 15:45:06 +00:00
scheglov@google.com a2c7ebced0 Issue 6107. Infer cascade type when it is assigned to the element with know type
http://code.google.com/p/dart/issues/detail?id=6107

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//11364032

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14433 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-01 20:52:00 +00:00
devoncarew@google.com b7e4a2457d Reverting a performance optimization - I'm not comfortable it's side-effect free.
Review URL: https://codereview.chromium.org//11363039

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14428 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-01 20:09:24 +00:00
scheglov@google.com be6aa334b0 Issue 5987. Report error if static const references instance const.
http://code.google.com/p/dart/issues/detail?id=5987

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//11275093

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14421 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-01 17:59:48 +00:00
scheglov@google.com 303a6202cd Issue 5722. Better 'missing part of' error message. Quick Fix for it.
http://code.google.com/p/dart/issues/detail?id=5722

R=messick@google.com
BUG=

Review URL: https://codereview.chromium.org//11364020

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14378 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-01 00:35:28 +00:00
scheglov@google.com 6d28c5c771 Cascade should have type set. Tests.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//11361018

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14374 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-31 22:06:44 +00:00
scheglov@google.com d97431f262 Better warning to function-like call of getter; Quick Fix for it
R=messick@google.com
BUG=

Review URL: https://codereview.chromium.org//11365011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14365 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-31 19:31:20 +00:00
scheglov@google.com f970c9eaf4 Update semantic highlighting only if there are no parse errors
R=messick@google.com
BUG=

Review URL: https://codereview.chromium.org//11293018

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14364 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-31 19:24:52 +00:00
devoncarew@google.com dace4b0f2e Making save a little faster:
-removed an extraneous reconcile (happening on the UI thread)
-removed an extraneous notification to the analysis server that the file had changed
Review URL: https://codereview.chromium.org//11348017

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14363 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-31 18:55:36 +00:00
scheglov@google.com ed9a7dcc3f Option to disable syntax highlighter and use mostly semantic highlighter. Tests.
R=messick@google.com
BUG=

Review URL: https://codereview.chromium.org//11362002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14355 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-31 17:51:00 +00:00
scheglov@google.com d6027294c2 Issue 6399. Don't fall back to 'dynamic' when variable has explicit type.
http://code.google.com/p/dart/issues/detail?id=6399

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//11271041

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14306 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-30 20:12:31 +00:00
scheglov@google.com 148372942d Issue 5847. Parse incomplete function expression without body
http://code.google.com/p/dart/issues/detail?id=5847

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//11340033

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14305 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-30 20:07:54 +00:00
pquitslund@google.com 971446cc6b Fix for "API" break in DartParser.
Not API per se, but some clients are depending on access to the DYNAMIC_KEYWORD constant.  This will unbreak them.
Review URL: https://codereview.chromium.org//11342021

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14222 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-29 20:58:31 +00:00
scheglov@google.com 2e574c8c14 Issue 5887. Parts must start with 'part of'.
Second attempt.
Now only DartC changes, and status updates.
So, should not break anyone else.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//11273064

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14217 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-29 19:17:28 +00:00
scheglov@google.com deeebd8d98 Issue 6201. Clean up to replace 'interface' with 'abstract class'
http://code.google.com/p/dart/issues/detail?id=6201

R=messick@google.com
BUG=

Review URL: https://codereview.chromium.org//11346004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14214 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-29 18:07:49 +00:00
scheglov@google.com dce51bf910 Using 'interface' and 'abstract' for methods should produce error
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//11314019

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14165 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-27 16:22:18 +00:00
scheglov@google.com dbec5629e8 Issue 4289. Separate optional positional and named parameters
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//11309011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14164 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-27 04:02:36 +00:00
scheglov@google.com 20feff4f95 Getter with parameters is error.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//11305007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14161 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-26 23:36:23 +00:00
scheglov@google.com 55bb3a8033 Issue 5530. Make DartParser thread safe. Remove compiler lock.
http://code.google.com/p/dart/issues/detail?id=5530

R=danrubel@google.com
BUG=

Review URL: https://codereview.chromium.org//11189149

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14103 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-25 21:31:14 +00:00
scheglov@google.com 86b5bdca2b Issue 6202. Remove support for 'Dynamic'. Add Clean Up to rename to 'dynamic'.
http://code.google.com/p/dart/issues/detail?id=6202

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//11260031

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14085 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-25 16:28:58 +00:00
devoncarew@google.com 6ee84d5e7f Removed a -d32 flag to dart_analyzer (fix for http://code.google.com/p/dart/issues/detail?id=5836)
Quoted input to tr in dart_analyzer.sh (http://code.google.com/p/dart/issues/detail?id=6051)
Changed dart_analyzer --version to report the new version format (not the old build revision format).
Review URL: https://codereview.chromium.org//11234069

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14028 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-24 16:53:46 +00:00
ahe@google.com 6254729761 Revert "Parts must start with 'part of'" and "Attempt to fix VM build"
This reverts r13961 and r13963.

Review URL: https://codereview.chromium.org//11233061

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13967 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-23 14:24:04 +00:00
scheglov@google.com 50b5b6e1a8 Parts must start with 'part of'
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13961 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-23 13:20:50 +00:00
scheglov@google.com 03f321e1b0 Issue 5621. Report error when { is missing in 'switch'
https://codereview.chromium.org/11060014/

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//11238024

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13903 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-22 19:42:05 +00:00
scheglov@google.com 9d6fed2637 Issue 6087. Use getRealTarget() for DartPropertyAccess in const analyzer
http://code.google.com/p/dart/issues/detail?id=6087

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//11189104

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13854 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-20 21:26:27 +00:00
scheglov@google.com 09b22d5b46 Issue 6073. Fixes for 'export'.
http://code.google.com/p/dart/issues/detail?id=6073

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//11226010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13853 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-20 20:47:58 +00:00
scheglov@google.com da10523b14 Issue 6077. warn when importing dart:mirrors
http://code.google.com/p/dart/issues/detail?id=6077

R=danrubel@google.com
BUG=

Review URL: https://codereview.chromium.org//11225007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13845 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-19 23:11:29 +00:00
scheglov@google.com 4536b28631 Infer function expression parameter types what it is assigned to element with known type
R=messick@google.com
BUG=

Review URL: https://codereview.chromium.org//11140011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13783 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-18 15:15:27 +00:00
brianwilkerson@google.com 17db9490a9 Add an error for obsolete raw strings (issue 4815)
Review URL: https://codereview.chromium.org//11196025

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13780 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-18 15:04:11 +00:00
brianwilkerson@google.com 1eef063b98 Fix to parsing of conditional expressions
Review URL: https://codereview.chromium.org//11183031

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13779 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-18 14:50:03 +00:00