dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
35,786 Commits 2 Branches 0 Tags
ca5bf28fa53cd7651b1dfd5bc779eedd06e8099b
Commit Graph

148 Commits

Author SHA1 Message Date
Konstantin Shcheglov e1c6faceb5 Issue 25316. Quick Fix for removing 'final' keyword. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/25316

Review URL: https://codereview.chromium.org/1545323002 .
 2015-12-27 13:19:41 -08:00
Brian Wilkerson 56fe38f0ab Clean up imports in analysis_server and analyzer_cli (and one missed in analyzer) 
R=paulberry@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/1527793003 .
 2015-12-14 19:31:46 -08:00
Konstantin Shcheglov f93d4fde97 Issue 25219. Fix for RangeError during converting empty lines in /// comments. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/25219

Review URL: https://codereview.chromium.org/1518723002 .
 2015-12-10 10:08:07 -08:00
Paul Berry 7d3c4743db Merge remote-tracking branch 'origin/master' into analyzer-breaking-0.27 2015-12-03 14:22:24 -08:00
Konstantin Shcheglov 5f49df1644 Issue 25095. Add 'Change X to Y type annotation' Quick Fix. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/25095

Review URL: https://codereview.chromium.org/1492053004 .
 2015-12-02 18:50:41 -08:00
Brian Wilkerson 600fc17de1 Clean-up the registration of plugins 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1487953002 .
 2015-12-02 13:25:28 -08:00
Konstantin Shcheglov bf54a3bef6 Don't attempt to create a file for non-Dart imports. 
This should help to fix the following exception:

Dart analysis server, SDK version 1.13.0-dev.7.12, server version 1.12.0, error: Exception from fix contributor: DefaultFixContributor
Bad state: No element

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1492843003 .
 2015-12-02 09:28:58 -08:00
Konstantin Shcheglov cfc8ee30b7 Fix for exception in FixProcessor._addFix_illegalAsyncReturnType. 
This fixes the following reported exception.

Dart analysis server, SDK version 1.13.0, server version 1.12.0, error: Exception from fix contributor: DefaultFixContributor
The null object does not have a getter 'offset'.

NoSuchMethodError: method not found: 'offset'
Receiver: null
Arguments: []

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1487683006 .
 2015-12-01 14:37:11 -08:00
Konstantin Shcheglov 6859412fac Issue 24865. Quick Fix 'Create Method' should create named parameters. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/24865

Review URL: https://codereview.chromium.org/1475743003 .
 2015-11-24 14:55:39 -08:00
Konstantin Shcheglov 67e4b7d081 Convert all 'wrong' test to 'BAD'. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1469333003 .
 2015-11-24 14:02:01 -08:00
Konstantin Shcheglov c0c11daa15 Disable merging of 'if' statements when there are other staments in the outer one. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1473513003 .
 2015-11-24 13:06:20 -08:00
Konstantin Shcheglov 1e05c35650 Issue 25021. Fix for adding new required parameters when optional exist. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/25021

Review URL: https://codereview.chromium.org/1468913004 .
 2015-11-23 09:21:11 -08:00
Konstantin Shcheglov 53e9cce24d Quick assist for converting block documentation comments into line ones. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1470753002 .
 2015-11-22 19:57:03 -08:00
Konstantin Shcheglov bb1914e175 Make FixContributor asynchronous. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1461313004 .
 2015-11-20 14:57:00 -08:00
Konstantin Shcheglov ae1bee3859 Make AssistContributor asynchronous. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1461343002 .
 2015-11-20 12:18:26 -08:00
Konstantin Shcheglov 2b59830f49 Convert into block documentation comment assist. 
I found out that I don't like the /// style.
So, I'm going to convert the Angular2 analysis plugins to the block style.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1466623002 .
 2015-11-20 08:11:28 -08:00
Konstantin Shcheglov 31b1288f06 Fix for test - don't depend on the order of errors. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1434063002 .
 2015-11-11 14:03:54 -08:00
Konstantin Shcheglov 765c7fd0f1 Mark HintCode.CAN_BE_NULL_AFTER_NULL_AWARE as fixable. 
R=pquitslund@google.com
BUG=

Review URL: https://codereview.chromium.org/1428903002 .
 2015-10-30 08:02:29 -07:00
Konstantin Shcheglov 851dc4ea97 Quick Fix for CAN_BE_NULL_AFTER_NULL_AWARE. 
Also fix for false positive :-(

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1423993005 .
 2015-10-29 13:47:17 -07:00
Konstantin Shcheglov cbea0dedf9 Issue 24714. Check other libraries that define unresolved class. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/24714

Review URL: https://codereview.chromium.org/1413973007 .
 2015-10-26 11:32:59 -07:00
Konstantin Shcheglov f18a0209fb Fix for 'Assign to Local Variable' in closures. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1415253002 .
 2015-10-21 13:20:22 -07:00
Brian Wilkerson 9ad256cf18 Move the wire protocol support into the public API 
R=paulberry@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/1398293002 .
 2015-10-11 07:34:28 -07:00
Brian Wilkerson 8f4c63c92b Restructure the public API for server 
R=danrubel@google.com, paulberry@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/1392253002 .
 2015-10-09 07:57:00 -07:00
Konstantin Shcheglov abfa9bf46a Move getCamelWords() to the strings.dart file. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1394933003 .
 2015-10-08 21:31:27 -07:00
Konstantin Shcheglov 63d8b70fce Add 'Add != null' quick fix. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/24518

Review URL: https://codereview.chromium.org/1393953002 .
 2015-10-07 10:18:23 -07:00
Konstantin Shcheglov 0b01edac17 More tests for 'Organize Directives'. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1380893003 .
 2015-10-02 13:11:34 -07:00
Konstantin Shcheglov db4e79b74d Issue 24459. Fix for 'Create Method' QF in different unit. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/24459

Review URL: https://codereview.chromium.org//1375043004 .
 2015-09-29 21:29:07 -07:00
Konstantin Shcheglov cf88943a10 Issue 24338. Don't propose creating a local class for prefixed identifiers. 
Importing with prefix would take more time than I'd like to spend now.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1336323003 .
 2015-09-14 08:17:18 -07:00
Konstantin Shcheglov f0cbf430e0 Issue 24298. Fix for 'async' function body conversion. 
R=paulberry@google.com
BUG= https://github.com/dart-lang/sdk/issues/24298

Review URL: https://codereview.chromium.org//1324323004 .
 2015-09-04 21:39:28 -07:00
Konstantin Shcheglov aea1e572a1 Sort top-level constants before other top-level variables. 
R=danrubel@google.com
BUG=

Review URL: https://codereview.chromium.org//1306083003 .
 2015-08-21 12:19:48 -07:00
Paul Berry f3f52d4b59 Fix regression in import fixups introduced by .packages support. 
With the introduction of support for ".packages" files, analysis
server now uses a slightly different code path for translating the
Source objects from imported package files into "package:" URI's.
Previously it used PackageUriResolver.resolveAbsolute(); now it uses
ResourceUriResolver.resolveAbsolute(), and then translates the
resulting file: URI to a package: URI uring the .packages file.

The old code path used Source.fullName (the file path) to locate the
file in the filesystem; the new code path uses Source.uri.  This
causes problems because when figuring out the correct import statement
to insert, the analysis server creates a bogus Source object whose uri
field is null.  As a result, import fixups were getting relative paths
like "../../../../.pub-cache/..." rather than package imports, which
is clearly wrong.

As a short term non-invasive fix, we set Source.uri in the bogus
Source object, so that the new codepath is able to find the path of
the imported file.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1281313002 .
 2015-08-10 12:14:26 -07:00
Konstantin Shcheglov 65941839b7 Remove also duplicate imports. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1277983002 .
 2015-08-06 12:42:30 -07:00
Brian Wilkerson 908708d655 More fixes for failures on the Windows bot 
R=paulberry@google.com

Review URL: https://codereview.chromium.org//1266923004 .
 2015-08-05 08:13:28 -07:00
Konstantin Shcheglov d11b644cc5 Issue 23963. Improve to/from block/expression body with void expressions. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/23963

Review URL: https://codereview.chromium.org//1267333003 .
 2015-08-04 16:16:17 -07:00
Konstantin Shcheglov fbb7aedee5 WEB-17598. Name new libraries according to the Dart Style Guide. 
R=brianwilkerson@google.com
BUG= https://youtrack.jetbrains.com/issue/WEB-17598
     https://github.com/dart-lang/sdk/issues/23972

Review URL: https://codereview.chromium.org//1253103007 .
 2015-08-04 14:47:30 -07:00
Konstantin Shcheglov 60ab26dc30 Simplify directive's optimizer edit. 
There was also a bug in computing common range.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1272013002 .
 2015-08-04 13:14:27 -07:00
Konstantin Shcheglov 64ff591f56 Organize directives implementation. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1266393002 .
 2015-08-03 13:49:57 -07:00
Konstantin Shcheglov e5b4713f03 'Import library' and 'Create class' Quick Fixes for unresolved class-like name in list literals. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1269043003 .
 2015-08-03 13:03:28 -07:00
Konstantin Shcheglov b62e8fbca9 New Quick Assist - 'Convert to field formal parameter'. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1216463004 .
 2015-07-07 14:57:43 -07:00
Konstantin Shcheglov 0bb5179b84 Quick Assist for converting field formal parameters into normal parameters and initializers. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1217593006.
 2015-07-06 11:19:30 -07:00
Konstantin Shcheglov b35d54a8b7 Decide if unit without directives is a part or a library. 
1. When there is a library containing it while we are parsing a part.

2. When a part was parsed, but then we found a library containing it.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1167733004
 2015-06-02 16:01:01 -07:00
Konstantin Shcheglov b9cdbace93 Issue 23545. Replace unaccessible type parameters with 'dynamic'. 
R=brianwilkerson@google.com
BUG=https://code.google.com/p/dart/issues/detail?id=23545

Review URL: https://codereview.chromium.org//1147213005
 2015-06-01 14:50:39 -07:00
Konstantin Shcheglov a3a40c9ef6 Issue 11200. Quick Fix for adding required/positional parameters. 
R=brianwilkerson@google.com
BUG=https://code.google.com/p/dart/issues/detail?id=11200

Review URL: https://codereview.chromium.org//1159273004
 2015-06-01 14:48:50 -07:00
Konstantin Shcheglov be9cd1c165 Issue 23551. Fix for using type parameters of the enclosed classes in 'Create Missing Overrides' Quick Fix. 
R=brianwilkerson@google.com
BUG=https://code.google.com/p/dart/issues/detail?id=23551

Review URL: https://codereview.chromium.org//1151183003
 2015-06-01 14:19:33 -07:00
Konstantin Shcheglov c1c0354014 Issue 23239. Fix for 'Create Class' Quick Fix i case of prefixed names. 
R=brianwilkerson@google.com
BUG=https://code.google.com/p/dart/issues/detail?id=23239

Review URL: https://codereview.chromium.org//1161333002
 2015-06-01 12:26:39 -07:00
Konstantin Shcheglov d5774c5402 Issue 23481. Fix for creating a new class referenced from an inner local function. 
R=paulberry@google.com, brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=23481

Review URL: https://codereview.chromium.org//1144893002
 2015-05-19 12:10:50 -07:00
Konstantin Shcheglov 4013b08863 Quick Fix for missing 'part of' directive. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1146573003
 2015-05-18 16:32:23 -07:00
Konstantin Shcheglov 4936eb8d5d Fix for 'Create part' Quick Fix. 
1. NonExistingSource.modificationStamp should return -1.
2. NonExistingSource.fullName should be always an absolute path, not a URI.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1135073004
 2015-05-18 11:55:23 -07:00
scheglov@google.com 2c27356c32 Sort imports by package names, then by file paths. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1131523005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45822 260f80e4-7a28-3924-810f-c04153c831b5
 2015-05-15 20:00:44 +00:00
scheglov@google.com 7344dcc35c [WEB-16445] When create a missing imported library/part, add the edit once. 
R=brianwilkerson@google.com
BUG= https://youtrack.jetbrains.com/issue/WEB-16445

Review URL: https://codereview.chromium.org//1147543002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45813 260f80e4-7a28-3924-810f-c04153c831b5
 2015-05-15 16:22:01 +00:00