67525aef37
Convert a batch of negative tests to multitests.
...
Change-Id: I380c12ef633ec8c40de982782623d3e3659a4834
Reviewed-on: https://dart-review.googlesource.com/57162
Reviewed-by: Leaf Petersen <leafp@google.com >
2018-06-08 19:43:34 +00:00
be8748997d
Remove configurations that aren't useful to test anymore
...
Change-Id: I555ce0b54fec59d8c21b7574055ef7f444a3d423
Reviewed-on: https://dart-review.googlesource.com/38600
Reviewed-by: Bob Nystrom <rnystrom@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2018-02-06 08:28:37 +00:00
c236d4ff3b
Add dartdevk configurations to run_tests.dart
...
Change-Id: Iebf97f192ad84118f75656ba665030ff851eb9f7
Reviewed-on: https://dart-review.googlesource.com/25081
Commit-Queue: Paul Berry <paulberry@google.com >
Reviewed-by: Bob Nystrom <rnystrom@google.com >
2017-12-01 21:31:03 +00:00
54143ef90c
Add --dart2js-with-kernel configurations to run_tests.dart
...
Change-Id: Ie837af2934b2596a0dbe3e7f9a38d906bb6336d7
Reviewed-on: https://dart-review.googlesource.com/22341
Reviewed-by: Bob Nystrom <rnystrom@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2017-11-21 17:01:20 +00:00
9b8f917b90
Add more configurations to run_tests.dart
...
Change-Id: I3b0080c4d637d121b6c6e173b323632c7d808817
Reviewed-on: https://dart-review.googlesource.com/20040
Reviewed-by: Bob Nystrom <rnystrom@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2017-11-10 18:08:29 +00:00
cac79d8db9
Fix some tests to be better Dart 2.0 tests.
...
async_await_test was correct, but was using a misleading name. It really
cares about assertions being enabled, not "checked mode".
The setter tests originally validated the runtime type checks but were
changed to compile time checks. Used a little judicious dynamic to get
back to testing the runtime type checking.
Change-Id: I0e121bd1443376e885777d609f5d6507537c0b8c
Reviewed-on: https://dart-review.googlesource.com/14161
Commit-Queue: Bob Nystrom <rnystrom@google.com >
Reviewed-by: Janice Collins <jcollins@google.com >
2017-10-17 23:11:25 +00:00
bd2a8e1d60
Reland migrate most of the tests in standalone to be strong mode clean and move them to standalone_2 directory.
...
Bug:
Change-Id: I4ca50f315361422db1d4356055862463bfe1d6f3
Reviewed-on: https://dart-review.googlesource.com/12240
Reviewed-by: Siva Annamalai <asiva@google.com >
Reviewed-by: Ben Konyi <bkonyi@google.com >
Commit-Queue: Siva Annamalai <asiva@google.com >
2017-10-07 01:29:36 +00:00
9a61fd572a
Remove unittest checking from migration script.
...
It's OK for a test to keep using unittest.
Change-Id: I5789cda2baea44731e1ce01ccff04d81f42b9b0c
Reviewed-on: https://dart-review.googlesource.com/12080
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Commit-Queue: Bob Nystrom <rnystrom@google.com >
2017-10-06 21:31:43 +00:00
ff32187145
Revert "Migrate most of the tests in standalone to be strong mode clean and move"
...
This reverts commit c85563f582https://dart-review.googlesource.com/6080
> Reviewed-by: Ben Konyi <bkonyi@google.com >
TBR=bkonyi@google.com ,asiva@google.com
Change-Id: I3c7b6081f17fca45e7828603538f50d06417e2be
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/12020
Reviewed-by: Siva Annamalai <asiva@google.com >
Commit-Queue: Siva Annamalai <asiva@google.com >
2017-10-06 17:24:20 +00:00
c85563f582
Migrate most of the tests in standalone to be strong mode clean and move
...
them to standalone_2 directory.
Change-Id: I9887b8d6d4d86001e4660b400224b881205e6273
Reviewed-on: https://dart-review.googlesource.com/6080
Reviewed-by: Ben Konyi <bkonyi@google.com >
2017-10-06 17:07:34 +00:00
1f3d67ddbc
Don't migrate status entries from "_parser.status" files.
...
Change-Id: Ic5e3cbe8d6f95e1f3e9b2e0f4313d54e240d6f7d
Reviewed-on: https://dart-review.googlesource.com/7850
Reviewed-by: Ben Konyi <bkonyi@google.com >
2017-09-22 22:39:14 +00:00
65a2303696
Updated to support migrating *.html files too
...
R=rnystrom@google.com
Change-Id: Icca5b36c87cb7c3af566b66cec537c53552deeab
Reviewed-on: https://dart-review.googlesource.com/7635
Reviewed-by: Bob Nystrom <rnystrom@google.com >
Commit-Queue: Terry Lucas <terry@google.com >
2017-09-22 17:50:57 +00:00
0b7d8e9688
Fixed status file migration issues for html and isolate directories.
...
Bug:
Change-Id: Ie4853d109b95731018f63487fd658b76841c8742
Reviewed-on: https://dart-review.googlesource.com/4603
Reviewed-by: Janice Collins <jcollins@google.com >
Reviewed-by: Bob Nystrom <rnystrom@google.com >
2017-09-12 17:57:20 +00:00
090efb342c
Don't delete 1.0 tests and status entries when migrating.
...
We do still remove the "_strong" ones since there's no reason to keep
those -- "_2" strictly supersedes them.
Change-Id: If6b9a8a5d22d8995a5fd0ac5538449c646b053ef
Reviewed-on: https://dart-review.googlesource.com/3403
Reviewed-by: Ben Konyi <bkonyi@google.com >
2017-09-06 17:40:19 +00:00
51cc9689b3
Remove corelib and corelib_strong and migrate last two remaining tests.
...
This includes a migration of linked_hash_map_from_iterable_test and
stacktrace_current_test, which were migrated without changes.
BUG=
R=rnystrom@google.com , whesse@google.com
Review-Url: https://codereview.chromium.org/3004073002 .
2017-09-01 08:11:15 -07:00
574022c0e2
Add "-1" and "-2" to run subsets of the configurations.
...
R=jmesserly@google.com
Review-Url: https://codereview.chromium.org/3011593003 .
2017-08-30 14:53:29 -07:00
0cbd1ea1ea
Don't migrate status entries under a "[ $strong ]" header.
...
R=jcollins@google.com
Review-Url: https://codereview.chromium.org/3009653002 .
2017-08-25 16:50:27 -07:00
f9da770441
Fix message about status entries that need manual splitting.
...
It described the entry as being in the destination file when it's
actually still in the source file.
R=mkroghj@google.com
Review-Url: https://codereview.chromium.org/2997093002 .
2017-08-17 13:05:39 -07:00
d2f2b0f44d
Add cases to all configs and allow for running a single test.
...
This adds analyzer-strong-checked as distinct from analyzer-strong,
which seems to be how the bots run it. Also adds the d8 runtime to dart2js as that was the cause of some bot breakage.
Finally, you can now run one test by just passing a single parameter.
BUG=
R=bkonyi@google.com , jmesserly@google.com
Review-Url: https://codereview.chromium.org/2997673002 .
2017-08-14 07:48:11 -07:00
850b80a84e
Fix analyzer status for cast_test.
...
Also add another configuration in the migration test runner to catch
this in the future.
Review-Url: https://codereview.chromium.org/2993123003 .
2017-08-04 18:37:18 -07:00
f2b8669a0b
Output test results in diff mode.
...
R=jmesserly@google.com
Review-Url: https://codereview.chromium.org/2996563002 .
2017-08-04 17:16:45 -07:00
6b7819ec5a
Handle migration status entries into split up status files.
...
R=jcollins@google.com
Review-Url: https://codereview.chromium.org/2994573002 .
2017-08-04 13:49:30 -07:00
481ce5813c
Add more targets to run_tests based on experience in blocks 7 and 8
...
BUG=
R=rnystrom@google.com
Review-Url: https://codereview.chromium.org/2988423002 .
2017-08-03 11:39:47 -07:00
dbd48de07d
Fix a couple of things causing bot redness:
...
- Migrate over built_in_identifier_test since it imports a helper
library that was migrated.
- Fix some status file entries.
Also:
- Removed some old commented out status entries.
- Fix a bug in migration script.
R=jcollins@google.com
Review-Url: https://codereview.chromium.org/2992903002 .
2017-08-02 14:54:07 -07:00
95693b30a3
Add a script to run the tests in a migration block.
...
R=bkonyi@google.com
Review-Url: https://codereview.chromium.org/2987223002 .
2017-08-01 13:52:20 -07:00
385b88f289
Migrate status file entries when migrating files. Yay!
...
This looks at all the files in the batch being migrated. It goes through
the status files in the 1.0 and strong directories. If it sees an entry
that matches that file, it adds it to the resulting "_2" status file.
It handles adding entries to an existing section if already present in
the new status file. Otherwise, it adds a new section at the end with
the entries.
R=bkonyi@google.com
Review-Url: https://codereview.chromium.org/2989033002 .
2017-07-28 11:10:30 -07:00
1419935fa6
Better support for re-running in the middle of a migration.
...
- Track files that only exist in the "_2" directories. That way we can
show what work still remains to be done even if the unmigrated files
are gone.
- Friendlier matching of command line arguments. Pass in any substring
of the test path and if only one test matches, it will be used.
- Make --dry-run not crash.
R=bkonyi@google.com
Review-Url: https://codereview.chromium.org/2988973002 .
2017-07-27 12:07:21 -07:00
cc8ae6b723
Add some more validation of things in expect that should not be used.
...
Also add some helper functions in expect.
R=bkonyi@google.com
Review-Url: https://codereview.chromium.org/2989743002 .
2017-07-26 16:52:18 -07:00
158e95a940
Report more heuristics for tests that require manual work.
...
If the contents of a test mention "checked", "TypeError", or
"AbstractClassInstantiationError", they will need some work. Tell the
user about those.
R=bkonyi@google.com
Review-Url: https://codereview.chromium.org/2991803003 .
2017-07-26 12:57:30 -07:00
caf87da9ed
Added functionality to dump relevant status file entries to a single file to make it easier to see which tests have which status file entries. Future work: remove entries from original status files.
...
BUG=
R=jcollins@google.com , rnystrom@google.com
Review-Url: https://codereview.chromium.org/2987633002 .
2017-07-25 17:48:09 -07:00
456ebea38f
Check in the .packages file for the migration tool.
...
This way, users don't have to run "pub get" on it before they can use
it. Since the .packages file only contains relative paths, it's safe to
check into the repo.
R=bkonyi@google.com
Review-Url: https://codereview.chromium.org/2983993002 .
2017-07-20 14:01:01 -07:00
152bc2d538
Add simple test migration helper.
...
R=bkonyi@google.com
Review-Url: https://codereview.chromium.org/2987533002 .
2017-07-20 12:54:46 -07:00
Bob Nystrom