2dcd56ef43
Format all tests.
...
There are far too many files here to review everyone carefully.
Spot checking most of the diffs look good as test code is generally written
with less care than application code so lots of ugly formatting get through.
If people notice files where the automated formatting bothers them feel free
to comment indicating file names and I'll move spaces within comments to make
the formatting cleaner and use comments to force block formatting as I have
done for other case where formatting looked bad.
BUG=
R=efortuna@google.com
Review-Url: https://codereview.chromium.org/2771453003 .
2017-04-17 14:53:02 -07:00
4283c3e41e
using unittest via package import
...
R=sigmund@google.com
Review URL: https://codereview.chromium.org//231413003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34890 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-09 19:42:11 +00:00
9c2f329e56
Remove defaultSelected property.
...
BUG=https://code.google.com/p/dart/issues/detail?id=4958
R=blois@google.com
Review URL: https://codereview.chromium.org//27516011
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28832 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-17 22:38:47 +00:00
d5212a6ac0
Make OptionElement construtor arguments named optional parameters.
...
BUG=
R=blois@google.com
Review URL: https://codereview.chromium.org//25585002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28115 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-01 20:33:49 +00:00
3b030702bc
Fixing selectelement_test on IE9
...
It was failing because of innerHTML parsing semantics from the unittest.
TBR
BUG=
Review URL: https://codereview.chromium.org//15705012
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23654 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-05 20:25:03 +00:00
797769e39f
Fixing SelectElement.options, adding support for optgroup.
...
BUG=8115
R=efortuna@google.com
Review URL: https://codereview.chromium.org//16409002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23652 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-05 19:45:36 +00:00
d1da6affdd
Deprecating Element.elements for Element.children.
...
BUG=3584
Review URL: https://codereview.chromium.org//11413071
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15118 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-19 23:01:13 +00:00
981c4b11df
Restructure pkg/unittest and pkg/webdriver to follow the pub conventions.
...
This means all imports of unittest in our test code had to change to include 'lib' in the path.
While doing that change I changed the library/imports to the new syntax in the affected files.
Review URL: https://codereview.chromium.org//11301046
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14443 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-01 23:09:47 +00:00
f7d27f2c64
Modified unittest to use new argument syntax.
...
Fix affected unit tests.
Clean up unit tests that are using Expect instead of expect.
Get rid of warnings about duplicated library names.
Review URL: https://codereview.chromium.org//11275054
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14158 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-26 22:52:03 +00:00
3300f91153
Make first and last getters.
...
Review URL: https://codereview.chromium.org//11273041
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14082 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-25 15:19:31 +00:00
caa43082d6
Fixes to get SelectElement working properly on IE.
...
BUG=
Review URL: https://codereview.chromium.org//11031076
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13307 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-05 18:13:13 +00:00
bc5a9328bb
Fixing SelectElement.selectedOptions to work on all platforms.
...
This is a fixup of the original CL which broke dartium because I mistakenly applied the polyfill to both dart2js and dartium.
Fix was to move impl_SelectElement.darttemplate to dart2js.
BUG=4503
Review URL: https://codereview.chromium.org//11035032
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13304 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-05 17:03:28 +00:00
4198b9d3a8
Revert "Fixing SelectElement.selectedOptions to work across all platforms."
...
This reverts commit #13239 because it breaks the dartium build.
TBR=vsm
BUG=
Review URL: https://codereview.chromium.org//11032033
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13242 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-04 16:16:51 +00:00
25f67482f2
Fixing SelectElement.selectedOptions to work across all platforms.
...
BUG=4503
Review URL: https://codereview.chromium.org//11049012
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13239 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-04 16:10:12 +00:00
Jacob Richman