dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
58,640 Commits 2 Branches 0 Tags
c9bcfe877b43391af4e470fec00ef036557a7fee
Commit Graph

45 Commits

Author SHA1 Message Date
Terry Lucas bc75856e54 Update getClientRects, removed xtab, removed bogus entry in dom.json, 
expose ServiceWorker, removed query and queryAll from in dart:html,
added constructor to MessageChannel and removed getCssCanvasContext.

Fixed all tests using query and queryAll.

Fixes https://github.com/dart-lang/sdk/issues/25664
Fixes https://github.com/dart-lang/sdk/issues/26349
Fixes https://github.com/dart-lang/sdk/issues/32323
Fixes https://github.com/dart-lang/sdk/issues/32659
Fixes https://github.com/dart-lang/sdk/issues/32675

R=kevmoo@google.com

Change-Id: I687471e80b8fe9c7040673113f424dbaab7c64d4
Reviewed-on: https://dart-review.googlesource.com/48381
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Kevin Moore <kevmoo@google.com>
 2018-03-27 20:45:33 +00:00
Jacob Richman 2dcd56ef43 Format all tests. 
There are far too many files here to review everyone carefully.
Spot checking most of the diffs look good as test code is generally written
with less care than application code so lots of ugly formatting get through.
If people notice files where the automated formatting bothers them feel free
to comment indicating file names and I'll move spaces within comments to make
the formatting cleaner and use comments to force block formatting as I have
done for other case where formatting looked bad.

BUG=
R=efortuna@google.com

Review-Url: https://codereview.chromium.org/2771453003 .
 2017-04-17 14:53:02 -07:00
sra@google.com 904c18efcc Enforce token syntax for CssClassSet arguments 
Committed: https://code.google.com/p/dart/source/detail?r=45265

Reverted: https://code.google.com/p/dart/source/detail?r=45266

R=terry@google.com

Committed: https://code.google.com/p/dart/source/detail?r=45301

Committed: https://code.google.com/p/dart/source/detail?r=45303

Reverted: https://codereview.chromium.org/1096433006/

Review URL: https://codereview.chromium.org//1077203004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45307 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-21 01:32:49 +00:00
sra@google.com 736007062a Revert "Enforce token syntax for CssClassSet arguments" 
TBR=terry@google.com
BUG=

Review URL: https://codereview.chromium.org//1096433006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45306 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-21 01:14:32 +00:00
sra@google.com a1850bb69a Enforce token syntax for CssClassSet arguments 
Committed: https://code.google.com/p/dart/source/detail?r=45265

Reverted: https://code.google.com/p/dart/source/detail?r=45266

R=terry@google.com

Committed: https://code.google.com/p/dart/source/detail?r=45301

Review URL: https://codereview.chromium.org//1077203004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45303 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-21 00:37:10 +00:00
sra@google.com ec484da9f6 Revert "Enforce token syntax for CssClassSet arguments" 
Review URL: https://codereview.chromium.org//1098073003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45302 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-21 00:25:54 +00:00
sra@google.com 01d3e99f18 Enforce token syntax for CssClassSet arguments 
Committed: https://code.google.com/p/dart/source/detail?r=45265

Reverted: https://code.google.com/p/dart/source/detail?r=45266

R=terry@google.com

Review URL: https://codereview.chromium.org//1077203004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45301 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-20 23:44:11 +00:00
sra@google.com efc7d09945 Enforce token syntax for CssClassSet arguments 
Committed: https://code.google.com/p/dart/source/detail?r=45265

Review URL: https://codereview.chromium.org//1077203004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45266 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-18 01:58:20 +00:00
sra@google.com 08676965c4 Enforce token syntax for CssClassSet arguments 
Review URL: https://codereview.chromium.org//1077203004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45265 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-18 01:53:21 +00:00
sra@google.com 12ad718f3e element_classes_test - move helper functions to top level 
The slightly better type inference helps with developing better
CssClassSet implementations.

BUG=

Review URL: https://codereview.chromium.org//1055363002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44877 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-03 02:09:46 +00:00
sra@google.com 6e65076450 Add new methods to html/element_classes_test 
- Add tests for retainAll, removeWhere, retainWhere.
 - Simply expect checking

R=vsm@google.com

Review URL: https://codereview.chromium.org//1054093002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44866 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-02 19:46:50 +00:00
jacobr@google.com 60bae5bb5d Cleanup method signatures that were incorrect due to a lack of understanding about how Dart generics work. 
BUG=
R=alanknight@google.com, terry@google.com

Review URL: https://codereview.chromium.org//896293003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43562 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-06 19:15:49 +00:00
kevmoo@google.com 4283c3e41e using unittest via package import 
R=sigmund@google.com

Review URL: https://codereview.chromium.org//231413003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34890 260f80e4-7a28-3924-810f-c04153c831b5
 2014-04-09 19:42:11 +00:00
kevmoo@j832.com cf134382a1 Set.add returns true if item has been added, otherwise false 
BUG= https://code.google.com/p/dart/issues/detail?id=3546
R=floitsch@google.com

Review URL: https://codereview.chromium.org//26280002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28863 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-18 17:24:24 +00:00
efortuna@google.com 7c20ac6514 Added boolean to toggle. 
BUG=
R=blois@google.com

Review URL: https://codereview.chromium.org//18583004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24938 260f80e4-7a28-3924-810f-c04153c831b5
 2013-07-12 02:00:38 +00:00
efortuna@google.com 6f7ef4126d Reapply "Aggregate CSS manipulation functions in html lib." (r22400) 
BUG=

Review URL: https://codereview.chromium.org//14931008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22424 260f80e4-7a28-3924-810f-c04153c831b5
 2013-05-06 16:27:16 +00:00
efortuna@google.com 33b4567f83 "Reverting 22400" 
BUG=

Review URL: https://codereview.chromium.org//14965003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22401 260f80e4-7a28-3924-810f-c04153c831b5
 2013-05-06 00:12:34 +00:00
efortuna@google.com 5e07799aba Aggregate CSS manipulation functions in html lib. 
BUG=
R=blois@google.com

Review URL: https://codereview.chromium.org//14941002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22400 260f80e4-7a28-3924-810f-c04153c831b5
 2013-05-06 00:04:15 +00:00
ajohnsen@google.com 24c200b76c Fix 'collection' tests and co19 dartc/dart2js status files. 
BUG=

Review URL: https://codereview.chromium.org//14135005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21343 260f80e4-7a28-3924-810f-c04153c831b5
 2013-04-12 10:28:29 +00:00
kasperl@google.com 64b13959b7 Fix broken test. 
R=erikcorry@google.com
BUG=

Review URL: https://codereview.chromium.org//13601006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20959 260f80e4-7a28-3924-810f-c04153c831b5
 2013-04-05 11:04:35 +00:00
efortuna@google.com f364ed048a Add toggleAll to CSSClassSet. 
BUG=

Review URL: https://codereview.chromium.org//12851014

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20263 260f80e4-7a28-3924-810f-c04153c831b5
 2013-03-20 00:39:40 +00:00
floitsch@google.com 7cefd7ab2b Fix test after Set-change. 
Review URL: https://codereview.chromium.org//12463033

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19934 260f80e4-7a28-3924-810f-c04153c831b5
 2013-03-13 14:55:14 +00:00
blois@google.com 8595b8bed2 Using an ordered set for Element.classes. 
BUG=6946

Review URL: https://codereview.chromium.org//12282045

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18727 260f80e4-7a28-3924-810f-c04153c831b5
 2013-02-19 21:37:32 +00:00
lrn@google.com 03f5a66836 Recommit changing List.skip/take/revert returns Iterable and remove mappedBy. 
This reverts r18591.

Review URL: https://codereview.chromium.org//12295009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18615 260f80e4-7a28-3924-810f-c04153c831b5
 2013-02-18 10:35:51 +00:00
rnystrom@google.com 0e0473d33a Unbreak pub: 
Revert "Make List.skip, List.take and List.reversed return Iterables, not Lists."

This reverts commit 44c3745a76acfad3d1d5bfc7a8b8c8e2def30e09.

Revert "Remove deprecated mappedBy."

This reverts commit 779ab69eab73e5e349245e99560b18955908e0cc.

BUG=dartbug.com/8560

Review URL: https://codereview.chromium.org//12286004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18591 260f80e4-7a28-3924-810f-c04153c831b5
 2013-02-15 18:38:42 +00:00
floitsch@google.com 0672317bec Remove deprecated mappedBy. 
Committed: https://code.google.com/p/dart/source/detail?r=18575
Reverted: http://code.google.com/p/dart/source/detail?r=18576

Review URL: https://codereview.chromium.org//12212213

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18579 260f80e4-7a28-3924-810f-c04153c831b5
 2013-02-15 13:57:18 +00:00
floitsch@google.com ad839e6957 Revert "Remove deprecated mappedBy." 
This reverts commit 18575.

Review URL: https://codereview.chromium.org//12207205

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18576 260f80e4-7a28-3924-810f-c04153c831b5
 2013-02-15 13:23:22 +00:00
floitsch@google.com b37100770b Remove deprecated mappedBy. 
Review URL: https://codereview.chromium.org//12212213

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18575 260f80e4-7a28-3924-810f-c04153c831b5
 2013-02-15 13:18:17 +00:00
lrn@google.com 9b23dff467 Reapply "Rename mappedBy to map." 
This reverts commit r17907.

TBR.

Review URL: https://codereview.chromium.org//12090093

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17918 260f80e4-7a28-3924-810f-c04153c831b5
 2013-01-31 15:12:56 +00:00
floitsch@google.com b1a118d5ce Revert "Rename mappedBy to map." 
This reverts commit 17899.

Review URL: https://codereview.chromium.org//12087103

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17907 260f80e4-7a28-3924-810f-c04153c831b5
 2013-01-31 14:02:27 +00:00
lrn@google.com 0dc2f4b1ba Rename mappedBy to map. 
Retain a deprecated mappedBy for now.
Change return type of mappedBy, skip and take on List to Iterable.

BUG= http://dartbug.com/8063
BUG= http://dartbug.com/8064
BUG= http://dartbug.com/6739
BUG= http://dartbug.com/7982

Review URL: https://codereview.chromium.org//12086062

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17899 260f80e4-7a28-3924-810f-c04153c831b5
 2013-01-31 12:37:13 +00:00
floitsch@google.com 4a7dfd2da3 Big merge from experimental to bleeding edge. 
Review URL: https://codereview.chromium.org//11783009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16687 260f80e4-7a28-3924-810f-c04153c831b5
 2013-01-07 11:23:16 +00:00
blois@google.com 2688c60a05 Dartifying members. 
Updating dart:html to generate members which follow the Dart naming guidelines.

BUG=4830

Review URL: https://codereview.chromium.org//11418075

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15405 260f80e4-7a28-3924-810f-c04153c831b5
 2012-11-27 17:38:23 +00:00
gram@google.com 981c4b11df Restructure pkg/unittest and pkg/webdriver to follow the pub conventions. 
This means all imports of unittest in our test code had to change to include 'lib' in the path.
While doing that change I changed the library/imports to the new syntax in the affected files.
Review URL: https://codereview.chromium.org//11301046

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14443 260f80e4-7a28-3924-810f-c04153c831b5
 2012-11-01 23:09:47 +00:00
gram@google.com f7d27f2c64 Modified unittest to use new argument syntax. 
Fix affected unit tests.
Clean up unit tests that are using Expect instead of expect.
Get rid of warnings about duplicated library names.
Review URL: https://codereview.chromium.org//11275054

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14158 260f80e4-7a28-3924-810f-c04153c831b5
 2012-10-26 22:52:03 +00:00
floitsch@google.com 09f6d09d88 Make isEmpty a getter. 
Review URL: https://codereview.chromium.org//11238035

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14022 260f80e4-7a28-3924-810f-c04153c831b5
 2012-10-24 15:04:32 +00:00
efortuna@google.com 9163dfe93c revert 1204. Will investigate when I get a chance. 
TBR=rnystrom
Review URL: https://codereview.chromium.org//10928216

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12413 260f80e4-7a28-3924-810f-c04153c831b5
 2012-09-15 01:21:41 +00:00
rnystrom@google.com 383488ec4f Update unittest to new package layout. 
Review URL: https://codereview.chromium.org//10917275

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12404 260f80e4-7a28-3924-810f-c04153c831b5
 2012-09-14 21:12:17 +00:00
rnystrom@google.com 659a57df3e Revert "Make unittest follow the new package layout." 
This reverts commit 38f7d16f373832a7bf889192af7845cb602aec01.

Review URL: https://codereview.chromium.org//10911318

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12400 260f80e4-7a28-3924-810f-c04153c831b5
 2012-09-14 19:43:10 +00:00
rnystrom@google.com 2ba81033a6 Make unittest follow the new package layout. 
Review URL: https://codereview.chromium.org//10918240

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12396 260f80e4-7a28-3924-810f-c04153c831b5
 2012-09-14 18:22:24 +00:00
blois@google.com b128fea156 Adding .toggle method to Element.classes to match the JS element.classList.toggle method. 
BUG=1063

Review URL: https://chromiumcodereview.appspot.com//10868026

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@11420 260f80e4-7a28-3924-810f-c04153c831b5
 2012-08-27 21:22:11 +00:00
dgrove@google.com c265902bea Move unittest from lib to pkg. 
Review URL: https://chromiumcodereview.appspot.com//10836241

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@10685 260f80e4-7a28-3924-810f-c04153c831b5
 2012-08-14 22:36:59 +00:00
sra@google.com 1784012e4c Revert "Revert "Split classes test from html/element_test"" 
Try again with adjusted expectations.

Review URL: https://chromiumcodereview.appspot.com//10606002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@8960 260f80e4-7a28-3924-810f-c04153c831b5
 2012-06-21 01:01:54 +00:00
sra@google.com 74a7e8ac25 Revert "Split classes test from html/element_test" 
Review URL: https://chromiumcodereview.appspot.com//10600010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@8957 260f80e4-7a28-3924-810f-c04153c831b5
 2012-06-21 00:30:06 +00:00
sra@google.com 4dcaa90a41 Split classes test from html/element_test 
Work-around Issue 3484 in html/element_classes_test.
This rehabilitates 900 lines of dart:html test that slowly got marked as failing because of a dart2js bug.

Review URL: https://chromiumcodereview.appspot.com//10599004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@8954 260f80e4-7a28-3924-810f-c04153c831b5
 2012-06-20 23:51:09 +00:00