2dcd56ef43
Format all tests.
...
There are far too many files here to review everyone carefully.
Spot checking most of the diffs look good as test code is generally written
with less care than application code so lots of ugly formatting get through.
If people notice files where the automated formatting bothers them feel free
to comment indicating file names and I'll move spaces within comments to make
the formatting cleaner and use comments to force block formatting as I have
done for other case where formatting looked bad.
BUG=
R=efortuna@google.com
Review-Url: https://codereview.chromium.org/2771453003 .
2017-04-17 14:53:02 -07:00
4b119a94d8
Better way of fixing attribute_changed_callback_test, doesn't require a timer
...
BUG=
Review URL: https://codereview.chromium.org//1061403002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44946 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-07 20:52:54 +00:00
4adf68734b
Fix attribute_changed_callback_test to expect event delivery either synchronously or asynchronously
...
BUG=
R=terry@google.com
Review URL: https://codereview.chromium.org//1060103002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44942 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-07 18:23:59 +00:00
2956fd8739
- Fork implementation for Dartium and dart2js. Dartium is working fine.
...
- dart2js version uses Element.classList (DomTokenList) for 4x speedup.
- Fix bug where document.querySelectorAll(...).classes.add('x') fails for SVG elements.
- Add test for above.
For later:
- Identify a polyfill for IE SVGElements (they don't have classList)
- Simplify CssClassSet further to exploit uniform availability of classList. This should give another performance boost by enabling inlining.
R=alanknight@google.com
Committed: https://code.google.com/p/dart/source/detail?r=44888
Committed: https://code.google.com/p/dart/source/detail?r=44897
Review URL: https://codereview.chromium.org//1054863002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44898 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-03 23:00:28 +00:00
1102849f15
[dart:html] rename register to registerElement per spec
...
BUG= https://code.google.com/p/dart/issues/detail?id=18621
R=jacobr@google.com
Review URL: https://codereview.chromium.org//268313002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35829 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-06 20:41:07 +00:00
7d71bc988d
introduce web_components pkg to replace shadow_dom, html_import, custom_element. This new package is 100% compatible with the polyfills used by http://www.polymer-project.org/
...
Deletes:
pkg/shadow_dom
pkg/custom_element (except web_ui stuff)
pkg/html_import
Adds:
pkg/web_components, with README.md and build instructions
Changes:
pkg/html5lib -- deprecate queryAll/query in favor of *Selector
pkg/polymer -- test fixes & a few small changes to work with new polyfills, mostly in build
tests/html/custom -- can't load the CE polyfill at runtime, must now be injected statically via an HTML page, similar to the style @blois used for some custom element tests.
R=blois@google.com , sigmund@google.com
Review URL: https://codereview.chromium.org//158083002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32533 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-11 01:15:05 +00:00
c2f5471669
Removing Element.createdCallback
...
This was a placeholder for before dart2js converted to the constructor, can now be removed.
BUG=
R=sra@google.com
Review URL: https://codereview.chromium.org//26592009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28465 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-10 16:59:19 +00:00
c6b1d91f34
Implementing custom element's attributeChanged callback in Dartium
...
BUG=
R=vsm@google.com
Review URL: https://codereview.chromium.org//25793002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28232 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-03 17:37:51 +00:00
05bb03642d
Implementing CustomElement's attributeChanged callback in dart2js.
...
BUG=
R=jmesserly@google.com
Review URL: https://codereview.chromium.org//25325004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28168 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-02 15:57:56 +00:00
c71f315c8d
Fixing analyzer issues in tests.
...
BUG=
Review URL: https://codereview.chromium.org//25614002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28124 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-01 22:01:25 +00:00
1aa8a7be0e
Adding Element.created constructor and .created constructors to all subclasses. Also ensuring generative constructor for all superclasses.
...
This is for post-construction custom element creation.
Element.created is public, then the base classes of that get private ._created constructors.
BUG=
R=vsm@google.com
Review URL: https://codereview.chromium.org//24653006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28120 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-01 21:26:06 +00:00
a85f2a8d4c
Changing onCreated callback to created.
...
Brings it in-line with the browser's createdCallback and Polymer's created. Avoid conflict with event names.
Dartium changes are https://codereview.chromium.org/23494005
BUG=
R=jacobr@google.com
Review URL: https://codereview.chromium.org//23451006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26754 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-27 23:51:42 +00:00
dcce9cd117
Port custom element layout tests to Dart
...
These are adapted from Dominic's tests here:
http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/custom/
R=blois@google.com
Review URL: https://codereview.chromium.org//23232005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26319 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-19 17:50:42 +00:00
Jacob Richman