bc75856e54
Update getClientRects, removed xtab, removed bogus entry in dom.json,
...
expose ServiceWorker, removed query and queryAll from in dart:html,
added constructor to MessageChannel and removed getCssCanvasContext.
Fixed all tests using query and queryAll.
Fixes https://github.com/dart-lang/sdk/issues/25664
Fixes https://github.com/dart-lang/sdk/issues/26349
Fixes https://github.com/dart-lang/sdk/issues/32323
Fixes https://github.com/dart-lang/sdk/issues/32659
Fixes https://github.com/dart-lang/sdk/issues/32675
R=kevmoo@google.com
Change-Id: I687471e80b8fe9c7040673113f424dbaab7c64d4
Reviewed-on: https://dart-review.googlesource.com/48381
Commit-Queue: Terry Lucas <terry@google.com >
Reviewed-by: Kevin Moore <kevmoo@google.com >
2018-03-27 20:45:33 +00:00
2dcd56ef43
Format all tests.
...
There are far too many files here to review everyone carefully.
Spot checking most of the diffs look good as test code is generally written
with less care than application code so lots of ugly formatting get through.
If people notice files where the automated formatting bothers them feel free
to comment indicating file names and I'll move spaces within comments to make
the formatting cleaner and use comments to force block formatting as I have
done for other case where formatting looked bad.
BUG=
R=efortuna@google.com
Review-Url: https://codereview.chromium.org/2771453003 .
2017-04-17 14:53:02 -07:00
b8ab793a1b
Reapply 38999. Third time's the charm! The issue was supportsTransitions was a
...
static method,and with my change I was calling an instance method. I've tested
all of the other html tests (before I was just testing on Dartium).
BUG=
R=leafp@google.com
Review URL: https://codereview.chromium.org//445733003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39003 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-07 18:36:23 +00:00
c8d48f89a9
t cl dcommi# Enter a description of the change.
...
"Reverting 38998"
TBR
BUG=
Review URL: https://codereview.chromium.org//449033004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38999 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-07 17:50:26 +00:00
c7dd285314
Reapplication of revision 38996 (dart side edits to make CSS Properties
...
accessible with and without prefixes), with the addition of CSSPropertyNames.in
which will be deleted once https://codereview.chromium.org/444453006/
is committed.
BUG=
Review URL: https://codereview.chromium.org//452493004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38998 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-07 17:21:06 +00:00
ceea5ab278
"Reverting 38996"
...
TBR because we need CSSPropertyNames.in from DEPS
BUG=
Review URL: https://codereview.chromium.org//451563005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38997 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-07 17:12:12 +00:00
19c379afd9
This is the dart side edits to make this happen.
...
Fix for https://code.google.com/p/dart/issues/detail?id=19932
BUG=
R=leafp@google.com
Review URL: https://codereview.chromium.org//442523003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38996 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-07 17:09:40 +00:00
ebe987dd84
Have the same behavior for setting a CSS style to null versus empty string in all browsers.
...
BUG=
R=blois@google.com
Review URL: https://codereview.chromium.org//304293005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36888 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-02 18:22:39 +00:00
4283c3e41e
using unittest via package import
...
R=sigmund@google.com
Review URL: https://codereview.chromium.org//231413003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34890 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-09 19:42:11 +00:00
5952d7a067
Upgrading tests with unittest deprecations
...
R=ricow@google.com , sigmund@google.com
Review URL: https://codereview.chromium.org//218273002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34569 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-31 18:33:18 +00:00
de32b0e4af
Fixing CSSStyleDeclaration test
...
Was broken from blink roll, just a toString change on CSS.
BUG=
R=efortuna@google.com
Review URL: https://codereview.chromium.org//23658015
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27087 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-04 01:08:51 +00:00
93c361dd36
This is an updated version of https://codereview.chromium.org/16374007/
...
Original submission is the first patch, fixes are the second.
There were two issues with the original-
- Issue with URI sanitization where relative URIs on IE were being dropped.
- Analyzer issue on missing members for CustomElement.
BUG=
R=jmesserly@google.com
Review URL: https://codereview.chromium.org//23525003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26757 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-28 01:03:01 +00:00
24e9f22c90
Revert "First rev of Safe DOM"
...
This reverts commit 26681.
Some IE issues with URL validation that I need to investigate further.
BUG=
Review URL: https://codereview.chromium.org//23523002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26682 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-27 02:18:48 +00:00
63ecf1a3fd
First rev of Safe DOM
...
BUG=
R=jacobr@google.com , jmesserly@google.com
Review URL: https://codereview.chromium.org//16374007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26681 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-27 01:48:13 +00:00
0d9d5204c9
Fix border-left measurement for IE.
...
BUG=
Review URL: https://codereview.chromium.org//21252004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25626 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-30 17:34:38 +00:00
65145338e7
Allow "bulk editing" of the CssStyleDeclaration objects in an ElementList as
...
well.
BUG=
R=blois@google.com
Review URL: https://codereview.chromium.org//21182002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25623 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-30 16:55:23 +00:00
d9b1c12f4c
Fixing CssStyleDeclaration to not throw exceptions for unsupported values.
...
Only occurs on IE9, but unsupported values should fail silently.
BUG=8588
Review URL: https://codereview.chromium.org//12295039
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19024 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-26 00:48:23 +00:00
d7057b2d8c
Reapply setTimeout change.
...
This CL is identical to 18555. The reason it will work now is the corresponding
dartium change has been checked in.
TBR-blois
BUG=
Review URL: https://codereview.chromium.org//12254046
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18562 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-15 07:40:51 +00:00
6e15e3eff7
Revert "Reapply remove setTimeout, take 3."
...
Review URL: https://codereview.chromium.org//12207198
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18559 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-15 04:25:18 +00:00
adf0fadd0d
Reapply remove setTimeout, take 3.
...
BUG=
Review URL: https://codereview.chromium.org//12259037
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18555 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-15 02:42:13 +00:00
2b86a542a3
"Reverting 18531"
...
BUG=
Review URL: https://codereview.chromium.org//12212200
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18542 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-14 21:33:33 +00:00
8da959b722
Reapply remove setInterval.
...
BUG=
Review URL: https://codereview.chromium.org//12253011
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18531 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-14 19:08:45 +00:00
3b0c52f47f
Reverting setTimeout removal.
...
BUG=
Review URL: https://codereview.chromium.org//12258020
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18478 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-13 21:06:31 +00:00
71a32af213
Combine window.setTimeout/setInterval with Timer and Timer.repeating. Also
...
Stream-and-future-ified some of the Window methods that used to take callbacks.
BUG=
Review URL: https://codereview.chromium.org//12218131
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18475 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-13 20:32:30 +00:00
165c6ec133
A couple of changes to change Window.requestLayoutFrame into a microtask API.
...
- Renamed window.requestLayoutFrame to window.setImmediate.
- Added support for IE's window.setImmediate
- Converted Element.getComputedStyle to be synchronous
- Removed Element.computedStyle, should use Element.getComputedStyle.
BUG=
Review URL: https://codereview.chromium.org//12087004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17681 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-26 01:02:48 +00:00
5bc653278a
Dartifying dart:html type names.
...
BUG=
Review URL: https://codereview.chromium.org//11419300
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15739 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-05 17:48:38 +00:00
2688c60a05
Dartifying members.
...
Updating dart:html to generate members which follow the Dart naming guidelines.
BUG=4830
Review URL: https://codereview.chromium.org//11418075
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15405 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-27 17:38:23 +00:00
d1da6affdd
Deprecating Element.elements for Element.children.
...
BUG=3584
Review URL: https://codereview.chromium.org//11413071
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15118 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-19 23:01:13 +00:00
2208fcd208
Change NotImplementedException to UnimplementedError.
...
Retain a NotImplementedException type for backwards compatibility.
This class will be removed soon.
The constructor of UnimplementedError is currently const in order to
support the NotImplementedException. That will be fixed too.
Review URL: https://codereview.chromium.org//11358060
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14467 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-02 13:18:37 +00:00
981c4b11df
Restructure pkg/unittest and pkg/webdriver to follow the pub conventions.
...
This means all imports of unittest in our test code had to change to include 'lib' in the path.
While doing that change I changed the library/imports to the new syntax in the affected files.
Review URL: https://codereview.chromium.org//11301046
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14443 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-01 23:09:47 +00:00
f7d27f2c64
Modified unittest to use new argument syntax.
...
Fix affected unit tests.
Clean up unit tests that are using Expect instead of expect.
Get rid of warnings about duplicated library names.
Review URL: https://codereview.chromium.org//11275054
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14158 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-26 22:52:03 +00:00
bffc05a1b1
CSSStyleDeclaration.getPropertyValue returns empty string instead of null.
...
Review URL: https://codereview.chromium.org//11047008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13189 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-03 18:05:41 +00:00
03166989b9
Fixing up setting styles to invalidate on IE9.
...
This CL fixes a bug with the original CL where setProperty was defined twice for dartium.
BUG=2772
Review URL: https://codereview.chromium.org//10908269
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12454 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-17 19:51:21 +00:00
9163dfe93c
revert 1204. Will investigate when I get a chance.
...
TBR=rnystrom
Review URL: https://codereview.chromium.org//10928216
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12413 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-15 01:21:41 +00:00
383488ec4f
Update unittest to new package layout.
...
Review URL: https://codereview.chromium.org//10917275
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12404 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-14 21:12:17 +00:00
659a57df3e
Revert "Make unittest follow the new package layout."
...
This reverts commit 38f7d16f373832a7bf889192af7845cb602aec01.
Review URL: https://codereview.chromium.org//10911318
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12400 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-14 19:43:10 +00:00
2ba81033a6
Make unittest follow the new package layout.
...
Review URL: https://codereview.chromium.org//10918240
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12396 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-14 18:22:24 +00:00
1643d0b306
Revert "Fixing up setting styles to invalidate on IE9."
...
This reverts commit 3bf7c99df82d8343efbcd757e5fb1acd6d2aa611.
BUG=
Review URL: https://chromiumcodereview.appspot.com//10905219
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12219 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-11 20:29:40 +00:00
06499a594c
Fixing up setting styles to invalidate on IE9.
...
BUG=2772
Review URL: https://chromiumcodereview.appspot.com//10917148
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12217 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-11 20:19:05 +00:00
e3ad3308a4
Adding IE support to browser prefixes.
...
BUG=3824
Review URL: https://chromiumcodereview.appspot.com//10905130
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@11971 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-06 18:02:02 +00:00
36ac6bc5e1
Remove now unnecessary trailing whitespaces.
...
TBR=podivilov@chromium.org
Review URL: https://chromiumcodereview.appspot.com//10894006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@11442 260f80e4-7a28-3924-810f-c04153c831b5
2012-08-28 13:27:01 +00:00
c265902bea
Move unittest from lib to pkg.
...
Review URL: https://chromiumcodereview.appspot.com//10836241
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@10685 260f80e4-7a28-3924-810f-c04153c831b5
2012-08-14 22:36:59 +00:00
9b79e27e17
Some unit test fixes:
...
Fixed a couple of issues in the ensureInitialized() function.
Added expectAsyncUntil methods to support callbackDone style tests.
Split the matcher tests up so that we can exclude those that use isInstance
from the environments where they don't work.
Eliminated the need for two functions calls in throws/throwsA.
Fixed some tests.
Changed some uses of Expect to expect.
Fixed a bug when using expectAsync with a count of zero.
Fixed a bug where we weren't updating the call count in invoke0/1/2.
Made expect behave sensibly in cases where the user doesn't supply a
matcher (e.g. expect(foo, 0)). USing the predicate form with a
reason now requires a named parameter.
Review URL: https://chromiumcodereview.appspot.com//10544167
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@8753 260f80e4-7a28-3924-810f-c04153c831b5
2012-06-15 23:17:57 +00:00
daef678742
test renaming overhaul: step 4 client tests
...
Review URL: https://chromiumcodereview.appspot.com//10191033
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@7041 260f80e4-7a28-3924-810f-c04153c831b5
2012-04-26 20:09:35 +00:00
Terry Lucas