Commit Graph

1987 Commits

Author SHA1 Message Date
William Hesse 0999a7b75e Remove special handling of _htmltest.html tests.
This removes the special category of html tests which was added in 2014, in cl
https://codereview.chromium.org//695893002

Change-Id: I42d2992e79e7b508465a7fffb4864b545f3af452
Reviewed-on: https://dart-review.googlesource.com/72000
Reviewed-by: Jonas Termansen <sortie@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
2018-08-30 14:37:57 +00:00
Aske Simon Christensen ac77419209 Status file cleanup for dart2js.
Removed all sections labeled $compiler == dart2js and !$fasta.

Removed $fasta from all sections with $compiler == dart2js and merged
with existing sections as appropriate.

Some additional cleanup and normalization.

Change-Id: I8b93283a2cce22ce60e29d364c8d0e70dccbb6e3
Reviewed-on: https://dart-review.googlesource.com/71840
Commit-Queue: Aske Simon Christensen <askesc@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
2018-08-30 10:28:41 +00:00
William Hesse 46743f3868 Remove $runtime == drt sections and uses of drt from status files.
Change-Id: Iffd934a67668901176a84c9b01512711a011652d
Reviewed-on: https://dart-review.googlesource.com/67803
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: William Hesse <whesse@google.com>
2018-08-03 12:40:46 +00:00
Devon Carew d1bf825c0f Remove some broad dart2analyzer status file exclusions.
Change-Id: Ibbcfa13b572bd02a821da1150d673b438c7ab504
Reviewed-on: https://dart-review.googlesource.com/64760
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
2018-07-13 04:20:21 +00:00
Terry Lucas f479435bca - Removed custom handling of fill - it was wrong the method is now overloaded.
- Associate the JS class SpeechSyntesisVoice with the correct Dart class (DDC).
- Top-level querySelectorAll wasn't generic.
- Handle "static" for attributes in the IDLs.

Fixes #33147
Fixes #33178
Fixes #31886
Fixes #20585

R=vsm@google.com

Change-Id: Ic75a2bfc66670b72342269be259408b610547dab
Reviewed-on: https://dart-review.googlesource.com/59240
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
2018-06-15 02:25:13 +00:00
Terry Lucas aca417a256 Fix test and expected failure.
TBR=sra@google.com

Change-Id: I1ee39073ccf977725d89152ddfba5c56211815d1
Reviewed-on: https://dart-review.googlesource.com/60181
Reviewed-by: Terry Lucas <terry@google.com>
2018-06-13 21:19:27 +00:00
Terry Lucas eea2dff20d Added support for members of type Promise.
Fixes #31046

R=sra@google.com

Change-Id: Id1e8d415b91a842bd8e2f50c6064c24aaaed9d98
Reviewed-on: https://dart-review.googlesource.com/59460
Reviewed-by: Stephen Adams <sra@google.com>
Commit-Queue: Terry Lucas <terry@google.com>
2018-06-13 18:20:53 +00:00
Emily Fortuna c911a1bef6 Clean up additional dart2js strong mode runtime error and don't add method type variable in dart 1 version.
Change-Id: I8f8a62fe2b4fcc00c05fbab22ed9e7a55eb95ccf
Reviewed-on: https://dart-review.googlesource.com/57523
Commit-Queue: Emily Fortuna <efortuna@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
2018-05-31 18:52:06 +00:00
Sigmund Cherem c25a9fd46b Remove support for dart:isolate in dart2js.
Change-Id: I1216a0ac91d8a1d13b441809596e1a8b5e51bb34
Reviewed-on: https://dart-review.googlesource.com/54526
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
2018-05-10 01:20:17 +00:00
Sigmund Cherem 3ec1b929e3 Remove dependencies on isolates.
This starts removing support for isolates. I've kept around the
isolate library for now, but I stopped injecting the isolate logic
unless you directly access an isolate API.

Concrete changes:

* Timer no longer uses the event queue: this was only used in worker
isolates, soon to be removed.

* Checking for whether the code is run within a worker is not dependent
   on initializing the isolates global state. This was important to allow
   deferred-loading to work without the isolate logic.

* Workers no longer track pending async calls correctly. This may make it possible
   to terminate worker isolates early, again this wont be relevant shortly.

Bug: https://github.com/dart-lang/sdk/issues/32684
Change-Id: I05025418e05c3641ba1a3bc34ea75ca558a28fbd
Reviewed-on: https://dart-review.googlesource.com/54160
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
2018-05-09 16:36:26 +00:00
Terry Lucas 678691334f More tests passing.
TBR=sra@google.com

Change-Id: Ic8f533c9b8ed679b842074883d2a9db9f93d755c
Reviewed-on: https://dart-review.googlesource.com/50660
Reviewed-by: Terry Lucas <terry@google.com>
2018-04-11 02:10:25 +00:00
Terry Lucas 79bfbf5a34 These tests now pass.
TBR=sra@google.com

Change-Id: Ibd761b6ba6118f7f56732816379a71cea56457df
Reviewed-on: https://dart-review.googlesource.com/50621
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Terry Lucas <terry@google.com>
2018-04-11 00:19:51 +00:00
Alexander Thomas 3851591642 [infra] Keep comments intact when updating status files.
* Preserve empty lines in the file header.
* Add empty entry to the tool's newly created sections.
* Remove extra empty line at the end of the file.

Change-Id: I271583774d5f5497025a9d85bcadf8b0b9e39e81
Reviewed-on: https://dart-review.googlesource.com/37600
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: William Hesse <whesse@google.com>
2018-04-10 19:03:21 +00:00
Terry Lucas 49558b9c4c Fixed MessageChannel receiveing messages on ports.
Removed pkg browser from tests.

Fixes https://github.com/dart-lang/sdk/issues/26351
Fixes https://github.com/dart-lang/sdk/issues/32631

R=kevmoo@google.com

Change-Id: Ib0ef5f933d38b2f748cca1f82de8bcf01702df4d
Reviewed-on: https://dart-review.googlesource.com/48742
Reviewed-by: Kevin Moore <kevmoo@google.com>
Commit-Queue: Terry Lucas <terry@google.com>
2018-03-30 17:16:15 +00:00
Terry Lucas bc75856e54 Update getClientRects, removed xtab, removed bogus entry in dom.json,
expose ServiceWorker, removed query and queryAll from in dart:html,
added constructor to MessageChannel and removed getCssCanvasContext.

Fixed all tests using query and queryAll.

Fixes https://github.com/dart-lang/sdk/issues/25664
Fixes https://github.com/dart-lang/sdk/issues/26349
Fixes https://github.com/dart-lang/sdk/issues/32323
Fixes https://github.com/dart-lang/sdk/issues/32659
Fixes https://github.com/dart-lang/sdk/issues/32675

R=kevmoo@google.com

Change-Id: I687471e80b8fe9c7040673113f424dbaab7c64d4
Reviewed-on: https://dart-review.googlesource.com/48381
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Kevin Moore <kevmoo@google.com>
2018-03-27 20:45:33 +00:00
Terry Lucas 17a778c9cb Changed AudioScheduledSourceNode.start to start2.
Fixes https://github.com/dart-lang/sdk/issues/32624

TBR=kevmoo@google.com

Change-Id: Ied9494a4b9695ae08ff2ef63c43759ea7951e9fa
Reviewed-on: https://dart-review.googlesource.com/47760
Reviewed-by: Terry Lucas <terry@google.com>
Commit-Queue: Terry Lucas <terry@google.com>
2018-03-22 13:18:37 +00:00
William Hesse 2546f2235e Fix status lines for html group tests - group was duplicated in logs.
Bug: dartbug.com/32632
Change-Id: I26acd8e01b776719f4592683eaf56ca3d3fcf72c
Reviewed-on: https://dart-review.googlesource.com/47600
Reviewed-by: Alexander Thomas <athom@google.com>
2018-03-21 19:42:32 +00:00
William Hesse dddb578fbb Update Safari status for two tests
Bug: dartbug.com/32576
Bug: dartbug.com/32572
Change-Id: I83d4d2d685f3239f3ba6a2e5f8a96c4b63338522
TBR: terry@google.com
Reviewed-on: https://dart-review.googlesource.com/47480
Reviewed-by: William Hesse <whesse@google.com>
2018-03-21 16:16:25 +00:00
Terry Lucas afa27982e4 Marked the failing tests in the right status file.
TBR=whesse@google.com

Change-Id: I7eda272cc69e2be8784c85b0045c0d04197924f8
Reviewed-on: https://dart-review.googlesource.com/47063
Reviewed-by: Terry Lucas <terry@google.com>
2018-03-19 15:53:00 +00:00
Terry Lucas c51db0d213 Revert "Fix status file for few broken tests."
This reverts commit 52d2813dfd.

TBR=sigmund@google.com

Change-Id: If84e54b755c0d690fa4fbde163b374e0ab1e8cd6
Reviewed-on: https://dart-review.googlesource.com/47061
Reviewed-by: Terry Lucas <terry@google.com>
2018-03-19 12:29:48 +00:00
Terry Lucas 52d2813dfd Fix status file for few broken tests.
TBR=sigmund@google.com

Change-Id: I2f9104be404771cfb6685ff2dbfd18591e947b73
Reviewed-on: https://dart-review.googlesource.com/46960
Reviewed-by: Terry Lucas <terry@google.com>
2018-03-19 04:07:33 +00:00
Terry Lucas 666172ded2 Revert "Corrected for safari only"
This reverts commit 3612130281.

TBR=sigmund@google.com

Change-Id: Idd49c929a1245e9e6bf3fd4798c478e8f08c9bdf
Reviewed-on: https://dart-review.googlesource.com/46956
Reviewed-by: Terry Lucas <terry@google.com>
2018-03-19 03:55:06 +00:00
Terry Lucas 3612130281 Corrected for safari only
TBR=sigmund@google.com

Change-Id: I01d64bb823f566e5d55e14110508ab5f36b08f53
Reviewed-on: https://dart-review.googlesource.com/46955
Reviewed-by: Terry Lucas <terry@google.com>
2018-03-19 02:41:02 +00:00
Terry Lucas ef292c678e Updated for Chrome 63 Roll
TBR=sigmund@google.com

Change-Id: Iba8e73a1db3f898babdca7aaa08d34790000cf51
Reviewed-on: https://dart-review.googlesource.com/46954
Reviewed-by: Terry Lucas <terry@google.com>
Commit-Queue: Terry Lucas <terry@google.com>
2018-03-19 01:57:50 +00:00
Terry Lucas 60469482f1 Move ClientRect members to DOMRect.
TBR=sigmund@google.com,sra@google.com

Change-Id: I424b087830954329f4399f6b169f572196a4f658
Reviewed-on: https://dart-review.googlesource.com/46948
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Terry Lucas <terry@google.com>
2018-03-18 13:27:46 +00:00
Terry Lucas 148a642aa1 Fixed typo.
TBR=sigmund@google.com

Change-Id: I7b898c6c77615d9790a72dcb0b5622af0cc4a9e5
Reviewed-on: https://dart-review.googlesource.com/46947
Reviewed-by: Terry Lucas <terry@google.com>
2018-03-18 11:29:05 +00:00
Terry Lucas b4e0c342c5 Updated html tests to match new/changed Chrome 63 APIs.
TBR=sigmund@google.com

Change-Id: I831a37c29ed1b82ac5336a017c54486ea75bb889
Reviewed-on: https://dart-review.googlesource.com/46946
Reviewed-by: Terry Lucas <terry@google.com>
2018-03-18 10:55:05 +00:00
Terry Lucas ef6273cba0 Dart Web Libraries re-generated based on Chrome 63 WebIDLs.
This is a migration of 13 Chrome release about 1.5 years of Chrome releases.
Update PYTHON scripts for cleaner and easier rolling.

Here's a doc on the changes that might affect Dart users:
https://docs.google.com/document/d/1Kj0nk3SueO3JKub8im7z3znu9j5oiI7vf49ejZrMxuE/edit#

Change-Id: I768fbd09b04fe6884af36ac102d5813f67bae426
Reviewed-on: https://dart-review.googlesource.com/24501
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Terry Lucas <terry@google.com>
2018-03-18 09:41:04 +00:00
Sigmund Cherem d6294bc6b5 Round 6 of status updates: remaining issues in d8, safari, ie11, ff (hopefully)
TBR=efortuna@google.com

Change-Id: Id84ed1a13646a27015d3aa20ad0d3c0c7d08522c
Reviewed-on: https://dart-review.googlesource.com/46564
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Emily Fortuna <efortuna@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
2018-03-14 19:25:29 +00:00
Sigmund Cherem af1f26fd48 Status fixes round 5: chrome mac & windows
TBR=efortuna@google.com

Change-Id: I69db60955cd22aca48981bb84a2637a28c385cc4
Reviewed-on: https://dart-review.googlesource.com/46422
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
2018-03-14 16:16:34 +00:00
Sigmund Cherem 1bad507517 Status fixes round 4: minified+checked d8, and chrome csp
TBR=efortuna@google.com

Change-Id: I98fd69ca11b962a9eb665c0de9d5ecb49626a891
Reviewed-on: https://dart-review.googlesource.com/46421
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
2018-03-14 07:11:29 +00:00
Sigmund Cherem 9c9497bda0 Status updates round 3: chrome-faststarup, ff, ff-faststartup
TBR=efortuna@google.com

Change-Id: I06b535f7273c3ac85173bf4f0286e02d09897c8e
Reviewed-on: https://dart-review.googlesource.com/46420
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
2018-03-14 06:16:19 +00:00
Sigmund Cherem 1b13c73062 Round 1 of .status fixes: to cover d8 bots
TBR=efortuna@google.com

Change-Id: I93e86104760e6e41ea32fbae311535a46a72e4c8
Reviewed-on: https://dart-review.googlesource.com/46386
Reviewed-by: Emily Fortuna <efortuna@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
2018-03-14 01:53:58 +00:00
Sigmund Cherem 16e8194147 Prepare additional lib, html, samples statuses: this embeds of d8-hostcheck results
TBR=sra@google.com

Change-Id: I4a86f3d51629bbd7dd36825f8c2d993b386ea8e0
Reviewed-on: https://dart-review.googlesource.com/45745
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
2018-03-08 21:10:37 +00:00
Sigmund Cherem 4c58384b50 Prepare html, isolate, lib, and lib_2 status files to turn on CFE on dart2js by default
TBR=sra@google.com

Change-Id: I4ed72f27eb21477bf281df5039a53d0eb703b8ac
Reviewed-on: https://dart-review.googlesource.com/45581
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
2018-03-08 01:04:05 +00:00
Peter von der Ahé 94aa20dd07 Update status for $compiler == fasta
Change-Id: I5d073d1c678dc313e79193074c6491085c093596
Reviewed-on: https://dart-review.googlesource.com/45381
Commit-Queue: Peter von der Ahé <ahe@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
2018-03-07 10:32:33 +00:00
Sigmund Cherem 9ed595b4b3 Use $fasta instead of $dart2js_with_kernel in our status files.
Note: $fasta is true when passing --dart2js-with-kernel. This change will make it
easier to flip the default: the plan is that $fasta will be true by default
later on, and passing --dart2js-old-frontend will make it false.

TBR=sra@google.com

Change-Id: Ib917d55b2d14db954c56513af057dd9a37b9c825
Reviewed-on: https://dart-review.googlesource.com/44601
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
2018-03-01 21:02:18 +00:00
Stephen Adams 24b7429b02 Install JS-interop properties on JavaScriptObject
Fixes #26838

Change-Id: Id4a16431e94a50fd0e962301ef23eb4a31a8d5cf
Reviewed-on: https://dart-review.googlesource.com/42585
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Stephen Adams <sra@google.com>
2018-02-23 00:31:52 +00:00
Sigmund Cherem 4436877ab2 More changes to make bots happy
R=efortuna@google.com

Change-Id: If0407436d204d9668a0ed13bf5fe2d36a0e041a9
Reviewed-on: https://dart-review.googlesource.com/41563
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Emily Fortuna <efortuna@google.com>
2018-02-14 23:09:34 +00:00
Sigmund Cherem 50db95f69b Fixes for CSP: status lines and some test fixes.
These failures started showing up when we switched to use chrome instead of DRT
for CSP tests.

Change-Id: I53b70ce18eaef73e720e10fdac05245953131f7c
Reviewed-on: https://dart-review.googlesource.com/41480
Reviewed-by: Emily Fortuna <efortuna@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
2018-02-14 21:54:53 +00:00
Peter von der Ahé 8815bbe90e Update status files for $compiler == fasta
Change-Id: I09761d12b98864d9a9abcc7abe6f046e45951715
Reviewed-on: https://dart-review.googlesource.com/36642
Commit-Queue: Peter von der Ahé <ahe@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
2018-02-07 15:38:09 +00:00
Paul Berry cca7b4419d Replace $builder_tag == strong with $strong in status files
The `$builder_tag == strong` annotations were added before test.py
supported `$strong`.  Now that `$strong` is supported, it's better to
use it directly to avoid confusion.

Change-Id: I715edecaee1e36ab8a26dbc96a6aa056e1be018f
Reviewed-on: https://dart-review.googlesource.com/39600
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
2018-02-07 11:50:10 +00:00
Erik Corry 3c2f9ea88d More SkipByDesign for tests that were moved
R=vegorov@google.com

Change-Id: I9d89ce90428d70ceb48e7eb2b16eb63f0aff8734
Reviewed-on: https://dart-review.googlesource.com/35721
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Commit-Queue: Erik Corry <erikcorry@google.com>
2018-01-19 09:11:45 +00:00
Erik Corry 5ed2f25f40 There is no longer a safarimobilesim test runtime.
And so there is no need to maintain status files for this platform.

R=whesse@google.com

Change-Id: Ie70e4b7308cfd9b1b179b2d1eeeb8f36dd1a62dc
Reviewed-on: https://dart-review.googlesource.com/34824
Commit-Queue: Erik Corry <erikcorry@google.com>
Reviewed-by: William Hesse <whesse@google.com>
2018-01-17 13:13:17 +00:00
Terry Lucas 476b1e02a9 Updated PYTHON code to correctly generate web_sql and re-wrote/re-enabled async web_sql test.
Also, updated status files to correctly fix failures in FF, IE and removed other spurious status entries.

R=alanknight@google.com,vsm@google.com

Change-Id: Ic965103d892ff4d5d119712e3187e829f57cd022
Reviewed-on: https://dart-review.googlesource.com/31800
Reviewed-by: Terry Lucas <terry@google.com>
2017-12-29 23:51:02 +00:00
Terry Lucas 0af98266ab Revert "Updated PYTHON code to correctly generate web_sql and re-wrote/re-enabled async web_sql test."
This reverts commit 0c8294e4a0.

Bug:
Change-Id: Idb35c64fd5365f2669e8aff45765fed74e0f0766
Reviewed-on: https://dart-review.googlesource.com/31440
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Terry Lucas <terry@google.com>
2017-12-23 01:59:38 +00:00
Terry Lucas 0c8294e4a0 Updated PYTHON code to correctly generate web_sql and re-wrote/re-enabled async web_sql test.
R=alanknight@google.com,vsm@google.com

Change-Id: I80e82f5aaa3c9748740031d8da139f79e2c0ab70
Reviewed-on: https://dart-review.googlesource.com/31080
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Alan Knight <alanknight@google.com>
2017-12-22 22:57:34 +00:00
Terry Lucas 642b768e87 Fixed default parameter messagePorts for MessageEvent factory.
R=vsm@google.com

Change-Id: Ic94ccbe4c29302e44c58791658ce75dff86d9ac2
Reviewed-on: https://dart-review.googlesource.com/29544
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
2017-12-14 18:21:25 +00:00
Morten Krogh-Jespersen 3db4b1070b Normalize all status files and enable presubmit hook.
This CL normalizes all status files by the status file normalizer found at
pkg/status_file/bin/normalize.dart.

To make sure all status files are kept in pristine condition, a linter is placed
on the presubmit hook. The linter can be found at pkg/status_file/bin/lint.dart.

Bug:
Change-Id: I20bdb74824be65f079b8c9ab08b7ae38394d637f
Reviewed-on: https://dart-review.googlesource.com/24112
Commit-Queue: Morten Krogh-jespersen <mkroghj@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
2017-12-07 08:38:30 +00:00
Emily Fortuna 31cb880614 Add parameter type checks in constructor body methods.
Bug:
Change-Id: Ic62886aa9db8dbe1f16f85ea528faffdeb299dac
Reviewed-on: https://dart-review.googlesource.com/26044
Reviewed-by: Stephen Adams <sra@google.com>
Commit-Queue: Emily Fortuna <efortuna@google.com>
2017-12-05 00:28:04 +00:00