Commit Graph

1402 Commits

Author SHA1 Message Date
Alexander Markov 3ba5aa8ba7 [vm/bytecode] Support SymbolConstant nodes in bytecode pipeline
After https://github.com/dart-lang/sdk/commit/609d2770bea3d4c9dc76b515a52ee325dfb5c50d
constant evaluator produces SymbolConstant nodes.

This CL adds handling of SymbolConstant nodes to bytecode generator by
emitting a new constant pool entry. Constant pool reader is adjusted to
read new constant pool entry.

Change-Id: Idc1e91e765014b3290d80e5a3743448b8a0f472c
Reviewed-on: https://dart-review.googlesource.com/74322
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Reviewed-by: Régis Crelier <regis@google.com>
2018-09-11 17:54:16 +00:00
Kevin Moore 0f1fa9eeae Remove pkg/dart_messages
Not used

Fixes https://github.com/dart-lang/sdk/issues/27832

Change-Id: Ia1e00fc8be2c904f21a95e89640099fa900a15a5
Reviewed-on: https://dart-review.googlesource.com/74461
Reviewed-by: Peter von der Ahé <ahe@google.com>
2018-09-11 16:20:06 +00:00
Martin Kustermann 609d2770be Reland "[VM] Add new SymbolConstant to package:kernel/ast.dart"
The canonicalization of symbols needs to take library privacy into
account. Since the Symbol class itself only has a [_name] field but does
not reference in which library the symbol came from, the [_name] must be
mangled.

Mangling is done by backends and so we make a new [SymbolConstant] which
the backends can desugar by doing appropriate mangling and construction
of a [Symbol] instance.

Fixes https://github.com/dart-lang/sdk/issues/34396

Change-Id: I2e13288483c35f875d39eefdb73677b2cc03527a
Reviewed-on: https://dart-review.googlesource.com/74360
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
2018-09-11 09:29:01 +00:00
Brian Wilkerson 2aca0b8b67 Fix a test broken on Windows
Change-Id: I2612573bee93ec04e769cd627a4f4f0031937883
Reviewed-on: https://dart-review.googlesource.com/73980
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2018-09-07 18:22:22 +00:00
Danny Tuppeny f53964c944 Unskip Windows analysis server integration tests
Bug: https://github.com/dart-lang/sdk/issues/32356
Change-Id: Iec178a071a030864d71fc0413f8a35f7c360b3f1
Reviewed-on: https://dart-review.googlesource.com/72641
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Danny Tuppeny <dantup@google.com>
2018-09-04 17:16:57 +00:00
Konstantin Shcheglov 1f52372bfa Remove CFE integration from analyzer, analysis_server, and analyzer_cli.
AnalysisDriverResolutionTest is partially updated, about 30 failing
tests added. I will get back to it in a following CL, it is not
directly CFE integration, but updated understanding how we want to
resolve. For example we don't need types for non-expression identifiers.

Change-Id: I3daddbb6c66ffad7a726f3313a1199fd7387aa04
Reviewed-on: https://dart-review.googlesource.com/71883
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2018-08-29 13:46:45 +00:00
Janice Collins f40ff153a9 Enable --use-fasta-parser with the analyzer by default.
Based on Devon's change at:

https://dart-review.googlesource.com/c/sdk/+/67090

Change-Id: I80b7943826e248bf37d9bbbb769330d24b0dd6ae
Reviewed-on: https://dart-review.googlesource.com/70160
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Devon Carew <devoncarew@google.com>
Commit-Queue: Janice Collins <jcollins@google.com>
2018-08-28 19:29:17 +00:00
Alexander Aprelev 8908d68d0d [gardening] Mark pkg/plugin_manager_test as flaky.
Bug: https://github.com/dart-lang/sdk/issues/34231

Change-Id: Iee983cebb48b0dfab97282a6f11f07cb2a18617a
Reviewed-on: https://dart-review.googlesource.com/71224
Reviewed-by: Alexander Aprelev <aam@google.com>
Commit-Queue: Alexander Aprelev <aam@google.com>
2018-08-22 21:41:49 +00:00
Alexander Thomas ba10df6611 [infra] Switch pkg bots to Dart 2
* Update named configs for unit tests to Dart 2.
* Bump json_rpc_2 in front_end package.
* Use named configurations in unit tests.
* Fix typing issues.

Change-Id: Id3b393a0d2abe92c8eaec10fa8057fb35d18a4c6
Reviewed-on: https://dart-review.googlesource.com/67341
Reviewed-by: Jens Johansen <jensj@google.com>
2018-08-13 07:04:06 +00:00
Brian Wilkerson 96a1e9985f Fix the pkg bot
Change-Id: If1f56890c4a9f0e2d5081a124b07e498edfe9145
Reviewed-on: https://dart-review.googlesource.com/69182
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2018-08-09 17:38:07 +00:00
Brian Wilkerson 95d1ebd9f0 Fix one cause of timeouts in tests
Change-Id: I8514c7a1e89c69bbbf11882fa734903cd7c7569c
Reviewed-on: https://dart-review.googlesource.com/68430
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
2018-08-06 16:08:05 +00:00
William Hesse 46743f3868 Remove $runtime == drt sections and uses of drt from status files.
Change-Id: Iffd934a67668901176a84c9b01512711a011652d
Reviewed-on: https://dart-review.googlesource.com/67803
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: William Hesse <whesse@google.com>
2018-08-03 12:40:46 +00:00
William Hesse f10b4005cd Code to load a named configuration and check it against the existing options.
First stab at loading named configuration, plus temporary test code

Change-Id: I5835fe34a024a6052021c8189629a1578bed2355
Reviewed-on: https://dart-review.googlesource.com/63880
Reviewed-by: Bob Nystrom <rnystrom@google.com>
2018-08-01 12:55:13 +00:00
Danny Tuppeny 3dc201e168 Update ChangeBuilder to not include empty edits (Take 2)
Combination of Brian's change:
https://dart-review.googlesource.com/c/sdk/+/63901

and Devon's change:
https://dart-review.googlesource.com/c/sdk/+/66405

Change-Id: I57e5d1f7d3a653f225aba2d690190fe1ff18a5b1
Reviewed-on: https://dart-review.googlesource.com/67344
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Danny Tuppeny <dantup@google.com>
2018-07-31 13:44:06 +00:00
Konstantin Shcheglov 8c8a211c6e Understand 'isNegative' for Analyzer as 'hasError'.
Change-Id: Ia9489806c472cdbe44f3a234b3403c5ad5086b3b
Reviewed-on: https://dart-review.googlesource.com/67021
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
2018-07-26 21:44:18 +00:00
Danny Tuppeny a470790e5e Revert "Mark get_signature_test.dart as slow."
This reverts commit 5b2e9a4c4e.

Change-Id: If9d1c3abf1babee8ec7c8ce17bc8ce86240542fe
Reviewed-on: https://dart-review.googlesource.com/66571
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Danny Tuppeny <dantup@google.com>
2018-07-26 13:50:40 +00:00
Devon Carew 5b2e9a4c4e Mark get_signature_test.dart as slow.
Change-Id: I483bc17f084f82702e1f5883bdcb1fa5b8cfdc6e
Reviewed-on: https://dart-review.googlesource.com/66840
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2018-07-26 04:21:10 +00:00
Konstantin Shcheglov d78b217b62 Update some kernel test expections.
Strangely bots are green, but these 3 tests pass on my machine locally,
and 1 fails.

R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I79eec4b07ff37915e2da5a9fdd666809f32a0c4b
Reviewed-on: https://dart-review.googlesource.com/66407
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2018-07-24 21:40:40 +00:00
danrubel 1ddadd4207 Update LocalDeclarationVisitorTest for fasta parser
Change-Id: Ieb36aff41bbf132bc8a1d765c6b08e15c4363ac3
Reviewed-on: https://dart-review.googlesource.com/66261
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
2018-07-24 14:57:16 +00:00
danrubel dd23176eab Update CompletionTargetTest for fasta parser
Change-Id: Ic3673f05750d8973f5e1cd7c787d884cf66d2b09
Reviewed-on: https://dart-review.googlesource.com/66260
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2018-07-24 14:57:16 +00:00
Siva Annamalai 33697f7339 Revert "Reland "[VM/SDK]""
This reverts commit b59583edea.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Reland "[VM/SDK]"
> 
> This is a reland of b4146411d0
> 
> Original change's description:
> > [VM/SDK]
> > 
> > - Switch the kernel isolate to run in Dart2 mode
> > - Refactor build rules so bootstrapping of the front end happens
> >   with a prebuilt dart sdk
> > - Refactor application snapshot build rules so the kernel application
> >   snapshot rule does not get into a cyclic dependency during the
> >   bootstrap stage
> > 
> > Change-Id: Id16b2859e0b299b2d689971d03a247cb94d0aa26
> > Reviewed-on: https://dart-review.googlesource.com/61660
> > Commit-Queue: Siva Annamalai <asiva@google.com>
> > Reviewed-by: Zach Anderson <zra@google.com>
> 
> Change-Id: I2a3fa8ed4f331cf3de89ddff5cf8e478809dae39
> Reviewed-on: https://dart-review.googlesource.com/65841
> Reviewed-by: Siva Annamalai <asiva@google.com>

TBR=zra@google.com,asiva@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I6077236481bec9089ead881c902036b0817114fc
Reviewed-on: https://dart-review.googlesource.com/66240
Reviewed-by: Siva Annamalai <asiva@google.com>
Reviewed-by: Zach Anderson <zra@google.com>
Commit-Queue: Siva Annamalai <asiva@google.com>
2018-07-23 18:07:29 +00:00
Devon Carew 6a8b2822ad Mark a test as slow.
Change-Id: I6181819fec2a28b4ae2deca9fb1d6ea1e7fddabc
Reviewed-on: https://dart-review.googlesource.com/66184
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
2018-07-23 17:08:29 +00:00
Peter von der Ahé 1d46b4728c Handle non-regular files in _IoFileSystemEntity.exists.
Also call validateOptions.

Fixes https://github.com/dart-lang/sdk/issues/33842

Change-Id: I7038d93ccbb4a0a2fd1f95817c53bbf30f130477
Reviewed-on: https://dart-review.googlesource.com/65082
Commit-Queue: Peter von der Ahé <ahe@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
2018-07-20 14:10:48 +00:00
asiva b59583edea Reland "[VM/SDK]"
This is a reland of b4146411d0

Original change's description:
> [VM/SDK]
> 
> - Switch the kernel isolate to run in Dart2 mode
> - Refactor build rules so bootstrapping of the front end happens
>   with a prebuilt dart sdk
> - Refactor application snapshot build rules so the kernel application
>   snapshot rule does not get into a cyclic dependency during the
>   bootstrap stage
> 
> Change-Id: Id16b2859e0b299b2d689971d03a247cb94d0aa26
> Reviewed-on: https://dart-review.googlesource.com/61660
> Commit-Queue: Siva Annamalai <asiva@google.com>
> Reviewed-by: Zach Anderson <zra@google.com>

Change-Id: I2a3fa8ed4f331cf3de89ddff5cf8e478809dae39
Reviewed-on: https://dart-review.googlesource.com/65841
Reviewed-by: Siva Annamalai <asiva@google.com>
2018-07-19 22:04:56 +00:00
Siva Annamalai 7f5334480e Revert "[VM/SDK]"
This reverts commit b4146411d0.

Reason for revert: Seems to have build issues on certain bots

Original change's description:
> [VM/SDK]
> 
> - Switch the kernel isolate to run in Dart2 mode
> - Refactor build rules so bootstrapping of the front end happens
>   with a prebuilt dart sdk
> - Refactor application snapshot build rules so the kernel application
>   snapshot rule does not get into a cyclic dependency during the
>   bootstrap stage
> 
> Change-Id: Id16b2859e0b299b2d689971d03a247cb94d0aa26
> Reviewed-on: https://dart-review.googlesource.com/61660
> Commit-Queue: Siva Annamalai <asiva@google.com>
> Reviewed-by: Zach Anderson <zra@google.com>

TBR=zra@google.com,asiva@google.com

Change-Id: I4fc5b81e0a102bde4e8b4f737af3825e9728be3b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/65840
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Siva Annamalai <asiva@google.com>
2018-07-19 21:20:39 +00:00
asiva b4146411d0 [VM/SDK]
- Switch the kernel isolate to run in Dart2 mode
- Refactor build rules so bootstrapping of the front end happens
  with a prebuilt dart sdk
- Refactor application snapshot build rules so the kernel application
  snapshot rule does not get into a cyclic dependency during the
  bootstrap stage

Change-Id: Id16b2859e0b299b2d689971d03a247cb94d0aa26
Reviewed-on: https://dart-review.googlesource.com/61660
Commit-Queue: Siva Annamalai <asiva@google.com>
Reviewed-by: Zach Anderson <zra@google.com>
2018-07-19 20:48:18 +00:00
Devon Carew 87e21a130d Update pkg.status file entry to unbreak the pkg bots.
Change-Id: Ia7553c662749ed1a7eee46e2d78be6305b53b17d
Reviewed-on: https://dart-review.googlesource.com/65640
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Devon Carew <devoncarew@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
2018-07-19 00:27:29 +00:00
danrubel a133e78ead Mark last 2 statement completion tests as failing for now
... so that the many other tests will be correctly asserted as passing by the bots.

Change-Id: I382f49b6578574ea2e1ea1adf52aa67241b9ae09
Reviewed-on: https://dart-review.googlesource.com/65460
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
2018-07-18 14:10:10 +00:00
Peter von der Ahé 11001793a2 Check void usage and invalid returns
Closes https://github.com/dart-lang/sdk/issues/30470

Change-Id: I2ed5b54c74e0bba2771036774bbe2197ce29109d
Reviewed-on: https://dart-review.googlesource.com/65141
Commit-Queue: Peter von der Ahé <ahe@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
2018-07-18 10:18:52 +00:00
danrubel 1714abb7b0 Update status file
Change-Id: I23e2ad2231699272f95dc6098b706bdb6e50d92e
Reviewed-on: https://dart-review.googlesource.com/65360
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2018-07-17 15:04:52 +00:00
Jenny Messerly 2420134b23 Remove obsolete tools and tests from package:dev_compiler
Change-Id: I28fcd5832d89a0531961daac8f94a97a8b5ec68c
Reviewed-on: https://dart-review.googlesource.com/64824
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Jenny Messerly <jmesserly@google.com>
2018-07-16 19:28:01 +00:00
Devon Carew fbd9c4e7a6 Fix a build mode test breakage from a recent DEPS update.
Bug: https://github.com/dart-lang/sdk/issues/33814
Change-Id: Ibff9db2c71eb8aeb32c6da0f6b63f4ce44f5f12e
Reviewed-on: https://dart-review.googlesource.com/64600
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
2018-07-11 18:12:44 +00:00
danrubel 89d6f50465 Fix override completion suggestion when fasta parser enabled
Change-Id: I72a066c8a1a71fe4fa037ff86d19e19ed56371d5
Reviewed-on: https://dart-review.googlesource.com/64480
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
2018-07-11 15:43:12 +00:00
danrubel 647c72e0e5 Fix keyword completion with fasta parser enabled
Change-Id: I9c7417168d27b13eae46bce90d6a61b447f0556c
Reviewed-on: https://dart-review.googlesource.com/64421
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
2018-07-11 14:25:54 +00:00
Lasse R.H. Nielsen 2efe3447ee Update DEPS to remove dependencies on upper-case constants
Change-Id: I5839a92d9790abcf35011b7ab3cdd3e05dbfa45c
Reviewed-on: https://dart-review.googlesource.com/63950
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
2018-07-11 09:45:33 +00:00
Devon Carew 94ca9b35af Mark four tests as slow.
Change-Id: Ic7edca2b34fffb282770c8af7d10fe5b4826054e
Reviewed-on: https://dart-review.googlesource.com/64280
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
2018-07-10 05:20:08 +00:00
Devon Carew 6dfc4ef663 Remove old dart2analyzer not strong status file entries.
Change-Id: I8e7775ce9a3d6fd14ee9d1b9d79be2f6df23cd01
Reviewed-on: https://dart-review.googlesource.com/63801
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
2018-07-07 04:14:20 +00:00
Devon Carew 31cd00b12c Mark the analysis server integration tests as slow.
Change-Id: Ic501bc36724c10a00d1ee7e8fc28308f7c5e497f
Reviewed-on: https://dart-review.googlesource.com/63900
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
2018-07-06 00:16:41 +00:00
Devon Carew 5d2405f112 Update the status file for slow tests.
Change-Id: Ib10fb573b0bfa0a5dd2685671e913e9fe762a1f9
Reviewed-on: https://dart-review.googlesource.com/63760
Reviewed-by: Devon Carew <devoncarew@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
2018-07-04 13:21:30 +00:00
Devon Carew eeb54497cf More slow test status file updates
Change-Id: Ic6e20bc3a5310fd33608e8bccc03d50548214bc7
Reviewed-on: https://dart-review.googlesource.com/63702
Reviewed-by: Devon Carew <devoncarew@google.com>
2018-07-04 01:38:48 +00:00
Devon Carew 6218c0fbb3 Mark analyzer tests as slow.
Change-Id: I93668451b495af026557b3f08ed5b4aed20b919b
Reviewed-on: https://dart-review.googlesource.com/63689
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
2018-07-03 21:41:15 +00:00
Devon Carew 46bfa7297e Have the regular analyzer bots test in dart 2 mode.
Change-Id: I91bf09600d0e5f099737be0363228cad6d0b5329
Reviewed-on: https://dart-review.googlesource.com/63642
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: William Hesse <whesse@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
2018-07-03 19:12:36 +00:00
Sigmund Cherem b7b24e9bbe Update dart2js-strong status across several suites
Change-Id: I7550e3221bcfdb4f9281b2be96af8579848c5a69
Reviewed-on: https://dart-review.googlesource.com/63504
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
2018-07-03 00:27:31 +00:00
Devon Carew ed6c09636f Remove old entries from pkg/pkg.status.
Change-Id: I6625eda145979bcd627774ae33bd401eb99e6885
Reviewed-on: https://dart-review.googlesource.com/63502
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
2018-07-03 00:19:26 +00:00
Sigmund Cherem 87550f4632 Add dart2js-strong entry in pkg.status
TBR=sra@google.com

Change-Id: Id5bf90f1a614ecd3f4816bed5d9d0f12b7ee4953
Reviewed-on: https://dart-review.googlesource.com/63263
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
2018-06-29 18:41:49 +00:00
Devon Carew d40e5543a3 Allow test/services/correction/fix_test to timeout.
Change-Id: I0608cbabfe7a6af98c2430e2350a9aab3d018db6
Reviewed-on: https://dart-review.googlesource.com/63021
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
2018-06-29 15:26:19 +00:00
Dan Rubel 08d3ca0ad3 Update status file
This addresses a comment in https://dart-review.googlesource.com/c/sdk/+/62681

Change-Id: I41c908e60ebab47cdd5654c0be3d3f83188b3e9e
Reviewed-on: https://dart-review.googlesource.com/62940
Reviewed-by: Dan Rubel <danrubel@google.com>
2018-06-28 19:58:41 +00:00
danrubel 7a5714ad0f Update compile_time_error_code_kernel_test
Change-Id: Idae979cfb48a3fce8db09802e90d48ce1daa1dad
Reviewed-on: https://dart-review.googlesource.com/62681
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2018-06-28 19:52:31 +00:00
Devon Carew e7da604c11 More updates for -DuseFastaParser.
Change-Id: If0850d4e6c2f937f95e8b00c4718ab0370e5decf
Reviewed-on: https://dart-review.googlesource.com/62447
Reviewed-by: Dan Rubel <danrubel@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
2018-06-27 17:30:17 +00:00
Bob Nystrom a4c7cf388f First stab at a parsing library for named configurations.
Change-Id: I1a2660914715d529b0233645b109b13c2fa9171a
Reviewed-on: https://dart-review.googlesource.com/61121
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Reviewed-by: William Hesse <whesse@google.com>
2018-06-26 22:17:08 +00:00