Konstantin Shcheglov
0fae13e6bf
Support for mixins in search.getElementDeclarations.
...
R=brianwilkerson@google.com
Change-Id: I88e90159ae28a2585fdbaacca2c4caab15891b83
Reviewed-on: https://dart-review.googlesource.com/72523
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-08-31 20:19:18 +00:00
Devon Carew
6fc1dd4480
analyzer_plugin no implicit-casts.
...
Change-Id: I12e5d4da5b61938b3eb7cc7c0e2ade6a64510b9e
Reviewed-on: https://dart-review.googlesource.com/69201
Commit-Queue: Devon Carew <devoncarew@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-08-09 22:41:41 +00:00
Devon Carew
92a70946b0
Fix three missing return warnings.
...
Change-Id: I69c5684a40bf46ac6a2b1ed304ea593b9d073922
Reviewed-on: https://dart-review.googlesource.com/68381
Commit-Queue: Devon Carew <devoncarew@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-08-03 19:25:37 +00:00
Danny Tuppeny
d792809d6f
Add signature param defaultValue and remove (unused) selectedParameterIndex
...
Bug: https://github.com/dart-lang/sdk/issues/27034
Change-Id: I3409ab544b79a7f64d6d41e5d091ca20418f248a
Reviewed-on: https://dart-review.googlesource.com/66562
Commit-Queue: Danny Tuppeny <dantup@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-07-25 15:42:44 +00:00
Danny Tuppeny
ebb033cb72
Add signature information to spec and add basic implementation for functions
...
Bug: https://github.com/dart-lang/sdk/issues/27034
Change-Id: I8d3f1a9c9a824b4b80f9cfa0370a439fa897b226
Reviewed-on: https://dart-review.googlesource.com/64689
Commit-Queue: Danny Tuppeny <dantup@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-07-25 07:16:52 +00:00
Devon Carew
710530c640
Update deprecated uses of package:test's isInstanceOf.
...
Change-Id: I0789ad89f2a247a17c472d74ca16885c5b8b6d5c
Reviewed-on: https://dart-review.googlesource.com/63320
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Devon Carew <devoncarew@google.com >
2018-06-30 00:08:44 +00:00
Devon Carew
17b53a2835
Test out no_implicit_casts on the analyzer source base.
...
Change-Id: I4eb2414d7d9bbe21883c9e5e8eca10f2eaafb465
Reviewed-on: https://dart-review.googlesource.com/62725
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Devon Carew <devoncarew@google.com >
2018-06-28 02:20:43 +00:00
Devon Carew
f8caffd9e6
Remove some uses of Platform.packageRoot.
...
Change-Id: Ic01e7f7a9f5c677bcf3779ae2a9386345620793a
Reviewed-on: https://dart-review.googlesource.com/60443
Reviewed-by: Mike Fairhurst <mfairhurst@google.com >
Commit-Queue: Devon Carew <devoncarew@google.com >
2018-06-19 05:12:13 +00:00
Danny Tuppeny
3af09b5b26
Add support for invocation + list/map literal folding
...
Bug: https://github.com/Dart-Code/Dart-Code/issues/966
Change-Id: Id85471f095b26349e60e0b10f89b4465d4c9b138
Reviewed-on: https://dart-review.googlesource.com/58740
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Danny Tuppeny <dantup@google.com >
2018-06-07 09:05:33 +00:00
Danny Tuppeny
568e977a35
Update FoldingKinds enum, update specs and increase version number
...
Bug: https://github.com/dart-lang/sdk/issues/33033
Change-Id: Ieccfd90ead67a9803744c54db4eec8eea0b0403c
Reviewed-on: https://dart-review.googlesource.com/54920
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Danny Tuppeny <dantup@google.com >
2018-05-14 16:48:48 +00:00
Brian Wilkerson
d3295ded48
Remove the SORT_MEMBERS refactoring from the spec
...
Change-Id: Ic8b8135f22d8c3c07d4ded661ac43d2d5105dc3f
Reviewed-on: https://dart-review.googlesource.com/48464
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2018-03-27 16:37:44 +00:00
Konstantin Shcheglov
6bd38cc912
Analysis Server API for 'Extract Widget' refactoring.
...
R=brianwilkerson@google.com
Change-Id: Ie6b7c349d304785ab6829770ebd3504c0affe8df
Reviewed-on: https://dart-review.googlesource.com/47943
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-03-22 20:25:29 +00:00
Konstantin Shcheglov
e1909cb52a
Update Outline protocol - change offset/length, add codeOffset/codeLength.
...
R=brianwilkerson@google.com
Change-Id: I4b5c03a21254f7c497adc4c043641b18599c5c39
Reviewed-on: https://dart-review.googlesource.com/45764
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-03-09 01:52:57 +00:00
Brian Wilkerson
602a8c2a7b
Clean up usage of deprecated constants
...
Change-Id: I9005ba6e94529e15d8f7b21322591f4a9dabec47
Reviewed-on: https://dart-review.googlesource.com/45763
Commit-Queue: William Hesse <whesse@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2018-03-09 01:02:49 +00:00
pq
a4ecc44c30
Completion protocol API for overrides.
...
Proposed API to allow IDEs to ask a suggestion for a displayText which may differ from the value to insert (the completion).
Also, adds a new OVERRIDE suggestion kind.
See: https://youtrack.jetbrains.com/issue/WEB-31130
Change-Id: Ic0644308d746ac7771bc27bc2ff2789444733af3
Reviewed-on: https://dart-review.googlesource.com/40101
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-02-09 17:57:17 +00:00
Konstantin Shcheglov
ffd67154f7
Add a new optional field - 'id' to SourceChange.
...
R=brianwilkerson@google.com
Change-Id: Ibe85415be35982327593ffd1187ec74b1d037463
Reviewed-on: https://dart-review.googlesource.com/40102
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-02-08 20:13:11 +00:00
Lasse R.H. Nielsen
6f78471687
New methods on Iterable, List, Set, Queue, Map.
...
Changes signature of Iterable.singleWhere.
Makes LinkedHashMap no longer be a HashMap.
Change-Id: I7a12fea533d42b0fc8357086649df38ad01f3cdd
Reviewed-on: https://dart-review.googlesource.com/39140
Commit-Queue: Leaf Petersen <leafp@google.com >
Reviewed-by: William Hesse <whesse@google.com >
Reviewed-by: Leaf Petersen <leafp@google.com >
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com >
2018-02-07 06:12:53 +00:00
William Hesse
9c35cff5cd
Revert "New methods on Iterable, List, Set, Queue, Map."
...
This reverts commit 0b59f24f97 .
Reason for revert: Creates crashes in dart2js with kernel, see
https://luci-milo.appspot.com/buildbot/client.dart/dart2js-linux-d8-minified-1-5-be/9751
Original change's description:
> New methods on Iterable, List, Set, Queue, Map.
> Changes signature of Iterable.singleWhere.
> Makes LinkedHashMap no longer be a HashMap.
>
> Change-Id: Ibd7e56e1ac03cb9fb10d19d1328d452fcd06d89f
> Reviewed-on: https://dart-review.googlesource.com/32541
> Commit-Queue: Lasse R.H. Nielsen <lrn@google.com >
> Reviewed-by: Leaf Petersen <leafp@google.com >
TBR=lrn@google.com ,leafp@google.com
Change-Id: Iab904f5885a5213ae2e16ef496eed0b6843185f3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/39060
Reviewed-by: William Hesse <whesse@google.com >
2018-02-06 13:32:19 +00:00
Lasse R.H. Nielsen
0b59f24f97
New methods on Iterable, List, Set, Queue, Map.
...
Changes signature of Iterable.singleWhere.
Makes LinkedHashMap no longer be a HashMap.
Change-Id: Ibd7e56e1ac03cb9fb10d19d1328d452fcd06d89f
Reviewed-on: https://dart-review.googlesource.com/32541
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com >
Reviewed-by: Leaf Petersen <leafp@google.com >
2018-02-06 11:17:46 +00:00
Devon Carew
47a861ca85
Add two new element types to the protocol.
...
Bug:
Change-Id: I5a60081d7c8500590bbabb9ee6dce74fa611b0a3
Reviewed-on: https://dart-review.googlesource.com/14883
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2017-10-18 19:02:47 +00:00
Konstantin Shcheglov
455984bbf9
Fix fuzzy arrow warnings in analyzer and analysis_server.
...
There is one warning which I'd like to fix in a separate CL.
The rest is because of package:test predicate().
I think Leaf fixed it in https://github.com/dart-lang/matcher/commit/3625f13698346576da0f5baf44e95abc9c56fb49
R=brianwilkerson@google.com
Bug:
Change-Id: I060f7ced55dbcc460185916251c47ebbd5c838d3
Reviewed-on: https://dart-review.googlesource.com/3404
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2017-09-06 00:26:18 +00:00
Brian Wilkerson
37042bb59b
Add an integration test for kythe support with bug fixes
...
R=jwren@google.com
Review-Url: https://codereview.chromium.org/3006693002 .
2017-08-28 10:07:04 -07:00
Brian Wilkerson
579a032564
Add kythe support to plugins and format the spec files
...
R=jwren@google.com
Review-Url: https://codereview.chromium.org/2994103002 .
2017-08-10 11:24:40 -07:00
Brian Wilkerson
8bbf373a5e
Remove the analysus.reanalyze request from the plugin API
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2988743002 .
2017-07-25 12:10:52 -07:00
Brian Wilkerson
4749014b06
Remove an unused request and the associated type
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2964113003 .
2017-06-30 09:44:59 -07:00
Brian Wilkerson
24996fbfe7
Add support to pass the location of the analysis options file to plugins
...
R=mfairhurst@google.com
Review-Url: https://codereview.chromium.org/2947743002 .
2017-06-20 07:41:03 -07:00
Devon Carew
8df017b670
Re-gen analysis server specs.
...
BUG=
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/2911783002 .
2017-05-27 12:42:17 -07:00
Brian Wilkerson
7f5e1f260f
Add a getNavigation request for plugins
...
R=mfairhurst@google.com , scheglov@google.com
Review-Url: https://codereview.chromium.org/2908523002 .
2017-05-25 10:51:24 -07:00
Brian Wilkerson
daffcecc11
Pass the sdk path to plugins
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2885993004 .
2017-05-17 08:19:49 -07:00
Brian Wilkerson
3085734ef6
Generate common types into a separate library
...
R=danrubel@google.com
Review-Url: https://codereview.chromium.org/2880443006 .
2017-05-13 08:12:14 -07:00
Brian Wilkerson
2cbcd96327
Allow the common spec types to be in a separate document
...
R=danrubel@google.com
Review-Url: https://codereview.chromium.org/2876023003 .
2017-05-12 12:24:05 -07:00
Brian Wilkerson
d3c926b089
Fix errors in analyzer
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2772473004 .
2017-03-23 11:26:49 -07:00
Devon Carew
f486a21d8f
Run dartfmt on additional generated files.
...
BUG=
Review-Url: https://codereview.chromium.org/2762413002 .
2017-03-21 16:23:43 -07:00
Jacob Richman
3688edaa17
Roll back two files that shouldn't have had dartfmt run.
...
BUG=
Review-Url: https://codereview.chromium.org/2757753003 .
2017-03-16 16:56:20 -07:00
Jacob Richman
a993294503
Format all analyzer packages
...
BUG=
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/2753923003 .
2017-03-16 16:11:43 -07:00
Brian Wilkerson
67b7952cf0
Update plugin spec to match server spec changes
...
R=pquitslund@google.com
Review-Url: https://codereview.chromium.org/2739473007 .
2017-03-08 13:41:20 -08:00
Devon Carew
42cd232ba5
Fix pkg/analyzer_plugin/tool/spec/check_all_test.
...
BUG=
Review-Url: https://codereview.chromium.org/2715853003 .
2017-02-23 21:07:32 -08:00
Devon Carew
9793406f08
Switch to using expectAsync0() to address some deprecation warnings.
...
BUG=
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/2701473009 .
2017-02-17 09:39:23 -08:00
Devon Carew
4667e59e85
Add integration tests for the execution domain.
...
BUG=
R=brianwilkerson@google.com , scheglov@google.com
Review-Url: https://codereview.chromium.org/2691763002 .
2017-02-12 11:23:33 -08:00
Brian Wilkerson
6ca3a29f2f
Rename generated file
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2686933002 .
2017-02-08 13:26:02 -08:00
Brian Wilkerson
4a40efa4c7
Add a priority to source changes for assists and fixes
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2678263005 .
2017-02-07 09:11:55 -08:00
Brian Wilkerson
17a447c89e
Update plugin spec
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2677663003 .
2017-02-07 08:03:15 -08:00
Brian Wilkerson
95c777fe7e
Add the generator and the generated files
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2664213003 .
2017-01-31 12:36:17 -08:00