19a87506bc
Fix for the server test.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1196213005 .
2015-06-22 10:03:06 -07:00
e9c3b2d7b1
Move cache consistency validation into Analysis Server.
...
This speeds up the add/analyze/remove/analyze cycle from 1600 ms to
1300 ms, i.e. on about 20%.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1195183002 .
2015-06-22 08:19:44 -07:00
d907a4265e
(TBR) improve integration test failure message
...
BUG=
Review URL: https://codereview.chromium.org//1194393002 .
2015-06-22 07:04:28 -04:00
f3a1297576
fix tests
...
BUG=
Review URL: https://codereview.chromium.org//1191363003 .
2015-06-20 18:20:46 -04:00
eb95064511
recompute package map when input file changes
...
BUG=
R=paulberry@google.com
Review URL: https://codereview.chromium.org//1180843011 .
2015-06-20 17:18:54 -04:00
8b9578ef26
add for() keyword suggestion
...
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1179283007 .
2015-06-20 15:01:20 -04:00
61460a0a10
pull in new watcher package
...
BUG=
R=paulberry@google.com
Review URL: https://codereview.chromium.org//1194653002 .
2015-06-20 14:12:12 -04:00
108f6c114b
analysis server performance measurement - work in progress
...
still need to debug some failing requests,
verify responses match expected responses,
track notifications to determine what was analyzed,
add docs, and ...
BUG=
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//1182933005 .
2015-06-17 11:35:47 -04:00
e7321ee4a0
(TBR) fix server tests
...
BUG=
Review URL: https://codereview.chromium.org//1192603002
2015-06-17 11:04:56 -04:00
db11964b83
refactor Reqest.fromJson for use by performance measurement tests
...
BUG=
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//1181363004 .
2015-06-15 12:27:41 -04:00
ce311218e9
suggest keywords in if expression
...
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1147213008 .
2015-06-12 09:50:10 +02:00
9c9108d51a
no keyword suggestions in library identifier or property accessor
...
BUG=
R=paulberry@google.com
Review URL: https://codereview.chromium.org//1151493004 .
2015-06-12 09:39:40 +02:00
f3c28ef449
Don't create navigation regions for not existing sources.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1180883003 .
2015-06-11 13:21:12 -07:00
b8067b5fb9
Compute RESOLVED_UNIT for all units in all of the libraries of the closure before verifying.
...
This fixes many co19 tests, so I guess it might solve the problems with constants you mentioned.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1183533002 .
2015-06-11 10:47:26 -07:00
add5a6910d
Remove many explicit references to AnalysisContextImpl and enable testing of the new task model
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1150863007
2015-06-06 08:30:38 -07:00
811877df42
Invalidate resolution of analysisOptions/sourceFactory changes.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1167483004
2015-06-05 14:09:12 -07:00
1c1497ff98
Another tweak for displaying performance.
...
1. It is still interesting to see performance tags, even with the next task model.
2. Factor out "WorkOrder.moveNext" as a separate performance tag, something like "intertask" for new tasks.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1161183004
2015-06-05 09:19:28 -07:00
4224b9c049
fix ENUM_CONSTANT suggestions
...
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1157283004
2015-06-04 18:01:06 -04:00
d6580fd9fb
generated analysis server java client code package rename
...
This changes the generated package name to better reflect our new home
from com.google.dart.server.generated.types
to org.dartlang.analysis.server.protocol
BUG=
R=paulberry@google.com
Review URL: https://codereview.chromium.org//1164683003
2015-06-04 17:29:35 -04:00
3cbd3e2e96
Tweak ADD_PART_OF quick fix to support both new/old task models.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1165943003
2015-06-04 14:28:35 -07:00
c1e2448928
Tweak for the new task statistics formatting.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1147043006
2015-06-04 11:49:37 -07:00
4b082cb871
cleanup local reference contributor
...
BUG=
R=paulberry@google.com
Review URL: https://codereview.chromium.org//1163973004
2015-06-04 14:18:03 -04:00
aec339a767
Expose timing data for the new task model in the status pages
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1169573003
2015-06-04 10:47:04 -07:00
ab5371e9b7
analysis server performance measurement driver first cut
...
* reads instrumentation file (log file support later)
* tracks initial analysis elapse time
* skeleton structure for adding more operations and tracking
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1163713005
2015-06-04 10:11:59 -04:00
b35d54a8b7
Decide if unit without directives is a part or a library.
...
1. When there is a library containing it while we are parsing a part.
2. When a part was parsed, but then we found a library containing it.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1167733004
2015-06-02 16:01:01 -07:00
a567814119
Replace 'Element.node' with 'Element.computeNode()'.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1164823003
2015-06-02 13:25:04 -07:00
8e439849b3
Issue 23573. Catch exception during indexing.
...
R=paulberry@google.com
BUG=https://code.google.com/p/dart/issues/detail?id=23573
Review URL: https://codereview.chromium.org//1168473003
2015-06-02 09:40:20 -07:00
06a3fd1984
Fix more tests for the new task model
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1159623013
2015-06-02 09:06:53 -07:00
40e925078f
Bug fixes for the new task model
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1144393006
2015-06-01 16:42:36 -07:00
aad76fdcbf
Issue 23568. Fix for NPE in index when unresolved field formal parameter.
...
R=brianwilkerson@google.com
BUG=https://code.google.com/p/dart/issues/detail?id=23568
Review URL: https://codereview.chromium.org//1162853004
2015-06-01 15:08:33 -07:00
b9cdbace93
Issue 23545. Replace unaccessible type parameters with 'dynamic'.
...
R=brianwilkerson@google.com
BUG=https://code.google.com/p/dart/issues/detail?id=23545
Review URL: https://codereview.chromium.org//1147213005
2015-06-01 14:50:39 -07:00
a3a40c9ef6
Issue 11200. Quick Fix for adding required/positional parameters.
...
R=brianwilkerson@google.com
BUG=https://code.google.com/p/dart/issues/detail?id=11200
Review URL: https://codereview.chromium.org//1159273004
2015-06-01 14:48:50 -07:00
be9cd1c165
Issue 23551. Fix for using type parameters of the enclosed classes in 'Create Missing Overrides' Quick Fix.
...
R=brianwilkerson@google.com
BUG=https://code.google.com/p/dart/issues/detail?id=23551
Review URL: https://codereview.chromium.org//1151183003
2015-06-01 14:19:33 -07:00
717da6731b
Eliminate Modifier.TYPEDEF and deprecate ClassElement.isTypedef.
...
Modifier.TYPEDEF was redundant with Modifier.MIXIN_APPLICATION and
ClassElement.isTypedef was redundant with
ClassElement.isMixinApplication.
Since Modifier.TYPEDEF was private to analyzer, it has been
eliminated. Since ClassElement.isTypedef is part of the public API to
analyzer, it is retained, but with a "@deprecated" annotation.
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1158193008
2015-06-01 14:17:40 -07:00
f1d4ef9164
Issue 23409. Don't set 'propagatedType' in (vs. after) 'name is Type'.
...
This fixes the corresponding 'Extract Method' issue.
R=brianwilkerson@google.com
BUG=https://code.google.com/p/dart/issues/detail?id=23409
Review URL: https://codereview.chromium.org//1161343002
2015-06-01 12:40:30 -07:00
c1c0354014
Issue 23239. Fix for 'Create Class' Quick Fix i case of prefixed names.
...
R=brianwilkerson@google.com
BUG=https://code.google.com/p/dart/issues/detail?id=23239
Review URL: https://codereview.chromium.org//1161333002
2015-06-01 12:26:39 -07:00
f118546d06
Issue 23332. Don't compute overrides for static members.
...
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=23332
Review URL: https://codereview.chromium.org//1151573011
2015-06-01 10:42:22 -07:00
5b44136f2a
Issue 23389. Report error in the renamed element be invisible after rename.
...
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=23389
Review URL: https://codereview.chromium.org//1153253004
2015-06-01 10:40:59 -07:00
213f0322f9
Fix missed version number
...
R=jwren@google.com
Review URL: https://codereview.chromium.org//1165763002
2015-06-01 09:50:57 -07:00
07dd6b7649
Add lineLength parameter to edit.format request (issue 23519)
...
R=jwren@google.com
Review URL: https://codereview.chromium.org//1154303005
2015-06-01 09:39:02 -07:00
0e39092fd0
add enum suggestions
...
and update LocalDeclarationVisitor to visit enum declarations
BUG=
R=paulberry@google.com
Review URL: https://codereview.chromium.org//1157113004
2015-06-01 12:10:46 -04:00
089038b085
Move index closer to the plugin API
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1156493004
2015-06-01 08:25:40 -07:00
ecf44e960d
remove keyword suggestions in constructor names and prefixed expressions
...
BUG=
R=paulberry@google.com
Review URL: https://codereview.chromium.org//1158413003
2015-05-29 13:28:34 -04:00
535394c265
Remove debugging print statements.
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1149063005
2015-05-27 20:24:06 -07:00
2362001bdb
Bump analysis server's reference to analyzer to 0.25.1-alpha.0.
...
This should fix errors being experienced by DartPad.
R=brianwilkerson@google.com , pquitslund@google.com
Review URL: https://codereview.chromium.org//1149203004
2015-05-27 06:37:50 -07:00
45862f401e
Send 'execution.launchData' only after full resolution.
...
We don't need to send them after each and every notice.
This information becomes ready somewhere in between parsing and full resolution.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1157823002
2015-05-24 10:39:21 -07:00
ad2b8a43c8
Fix context creation in tests
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1149723004
2015-05-22 14:25:29 -07:00
ad52c9eab9
Add support for specifying files needing analysis
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1152013002
2015-05-21 14:34:04 -07:00
0ce6fb29a6
Propogate and handle lint analysis option.
...
BUG=
R=brianwilkerson@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//1131373004
2015-05-19 15:13:26 -07:00
d5774c5402
Issue 23481. Fix for creating a new class referenced from an inner local function.
...
R=paulberry@google.com , brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=23481
Review URL: https://codereview.chromium.org//1144893002
2015-05-19 12:10:50 -07:00
Konstantin Shcheglov