dart-lang/sdk - sdk - Tonycloud git server

dart-lang/sdk

Fork 0

Commit Graph

Author	SHA1	Message	Date
Sigmund Cherem	73de586423	[web] improve fileapi tests. These tests had several issues. The fixes are aimed to reduce flakiness and remove invalid configurations where tests are not providing any value. Some of the issues include: * some tests interferered with each other causing a 18% flakiness rate in chrome: they used a common file system that ended up being shared in a single browser instance. This is why some tests failed when they find a file exists before it was created [1]. * some tests were not properly using async_helper/async_minitest, so they may complete before they finish executing * DDC no longer supports these APIs due to https://github.com/dart-lang/sdk/issues/53864. We don't intend to fix those issues, so there is no purpose in running these tests in DDC at this time. [1]: https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket/8766313714239949697/+/u/test_results/ignored_flaky_test_failure_logs Change-Id: I1dbb28eba2d962000a4d425563dbc1eb6b55dbed Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/332266 Commit-Queue: Sigmund Cherem <sigmund@google.com> Reviewed-by: Srujan Gaddam <srujzs@google.com>	2023-10-27 02:25:20 +00:00
Srujan Gaddam	364db086ef	[dart:html] Migrate fileapi tests to NNBD Change-Id: I4c653fcac0f0a2c5ff7dc5b00f794fba4c3fc028 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140647 Reviewed-by: Bob Nystrom <rnystrom@google.com>	2020-04-03 17:43:57 +00:00
Srujan Gaddam	1d44ef07c1	[dart:html] Copy and rename lib_2/html to NNBD. Added annotations such that these tests won't fail when submitted. Added copyright notices if there isn't a copyright notice. Change-Id: I51ae347d44875cdfa1c6d0dad1bc41e00ea443bd Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139963 Commit-Queue: Srujan Gaddam <srujzs@google.com> Reviewed-by: Sigmund Cherem <sigmund@google.com>	2020-04-03 00:36:56 +00:00

Author

SHA1

Message

Date

Sigmund Cherem

73de586423

[web] improve fileapi tests.

These tests had several issues. The fixes are aimed to reduce flakiness
and remove invalid configurations where tests are not providing any
value. Some of the issues include:

* some tests interferered with each other causing a 18% flakiness rate
  in chrome: they used a common file system that ended up being shared
  in a single browser instance. This is why some tests failed when they
  find a file exists before it was created [1].

* some tests were not properly using async_helper/async_minitest, so
  they may complete before they finish executing

* DDC no longer supports these APIs due to
  https://github.com/dart-lang/sdk/issues/53864. We don't intend to fix
  those issues, so there is no purpose in running these tests in DDC at this
  time.

[1]: https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket/8766313714239949697/+/u/test_results/ignored_flaky_test_failure_logs

Change-Id: I1dbb28eba2d962000a4d425563dbc1eb6b55dbed
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/332266
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Srujan Gaddam <srujzs@google.com>

2023-10-27 02:25:20 +00:00

Srujan Gaddam

364db086ef

[dart:html] Migrate fileapi tests to NNBD

Change-Id: I4c653fcac0f0a2c5ff7dc5b00f794fba4c3fc028
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140647
Reviewed-by: Bob Nystrom <rnystrom@google.com>

2020-04-03 17:43:57 +00:00

Srujan Gaddam

1d44ef07c1

[dart:html] Copy and rename lib_2/html to NNBD.

Added annotations such that these tests won't fail when submitted.
Added copyright notices if there isn't a copyright notice.

Change-Id: I51ae347d44875cdfa1c6d0dad1bc41e00ea443bd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139963
Commit-Queue: Srujan Gaddam <srujzs@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>

2020-04-03 00:36:56 +00:00

3 Commits