dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
98,756 Commits 2 Branches 0 Tags
c84edaefe9e457e9cc975c050019479b2d94dea2
Commit Graph

87 Commits

Author SHA1 Message Date
pq b17d4cb14b Fix a few typos 
Change-Id: I461ea0c88c257c630577d21bd94c08a3fadb3ade
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/341384
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2023-12-12 19:16:13 +00:00
Moritz a3568286ff Adding the resource-identifier functionality from the compiler to the 
vm.

This identifies all calls to static methods annotated with
`@ResourceIdentifier`, collects the constant arguments passed to the
method, and writes the results into a file.

The purpose of this feature is to be able to pass the recorded
information to packages in a post-compilation step, allowing them to
remove or modify assets based on the actual usage in the code prior to
bundling in the final application.

Tested: pkg/vm/test/transformations/resource_identifier_test.dart
Change-Id: I58cb313b66ee23c1d154dcc242547723a1ced359
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/329961
Commit-Queue: Moritz Sümmermann <mosum@google.com>
Reviewed-by: Nate Bosch <nbosch@google.com>
 2023-11-21 15:05:35 +00:00
pq f962700302 + flutter_style_todos 
Enabled `flutter_style_todos` in analyzer packages:

* `analyzer_cli`
* `analyzer_plugin`
* `analyzer_utilities`
* `meta`


Change-Id: I5fcd76bfa5a3bdeb14d6a81b8193129c6d83d0e8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/335405
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2023-11-13 00:14:09 +00:00
pq 8a5ddecfb3 + extension type target kind (and @optionalTypeArgs support) 
Adds a new TargetKind for extension types and adds it to `@optionalTypeArgs`.

Change-Id: I7254c1299c296451b9adc5d1f8eceb50af66f039
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/324769
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2023-09-08 18:09:01 +00:00
pq 813339e28a refactor TargetKind enum to class 
A trimmed down version of https://dart-review.git.corp.google.com/c/sdk/+/258200 which was reverted (https://dart-review.git.corp.google.com/c/sdk/+/268380) for (undiagnosed) performance reasons.

See: https://github.com/dart-lang/sdk/issues/53368


Change-Id: Iecd00a4483a4b6904b8b281eec49228620e1e943
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/322981
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2023-08-28 23:09:27 +00:00
pq 98070ec188 Add @redeclare 
See: https://github.com/dart-lang/sdk/issues/53121

Change-Id: I812bc49b58cdf15e9c0c8bcc62a846b51f5dff70
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/319100
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2023-08-09 16:59:00 +00:00
pq eb2af1a41a +implicit_reopen link 
Change-Id: I7e4468ab77b86437bd0483698cf2be873b9f57c5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/319002
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2023-08-09 15:43:19 +00:00
pq dfe1093849 meta 1.9.1 
Fixes: https://github.com/dart-lang/sdk/issues/51059

Change-Id: I7f28741ad0d1507cc1140da6c7c0bccb31d6946b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/290604
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2023-03-22 20:58:58 +00:00
pq 4c7e87888d update @reopendocs 
Fixes: https://dart-review.googlesource.com/c/sdk/+/286860

Feedback welcome. I expect we'll want to iterate more on this but I see Erik's new content as a distinct improvement.


Change-Id: Iba385be6c411f2e5e3f1bd490b437dbea86e07aa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/286860
Reviewed-by: Erik Ernst <eernst@google.com>
Reviewed-by: Marya Belanger <mbelanger@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2023-03-07 21:21:01 +00:00
Josh Soref 77978889eb Spelling 
Closes https://github.com/dart-lang/sdk/pull/51143

GitOrigin-RevId: 9e21c99a222d588e4fc95980725a2f8c9784965c
Change-Id: If0870e8936c7649935dce7e23cd783d62aa5610c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/279916
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
 2023-01-30 18:29:59 +00:00
Sam Rawlins b1525bcf19 Deprecate alwaysThrows 
Fixes https://github.com/dart-lang/sdk/issues/49583

Change-Id: Icc10dbba642703098708202537c733ff1d48b9db
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/279651
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
 2023-01-26 16:42:08 +00:00
pq c8df5570bc + @reopen 
See: https://github.com/dart-lang/sdk/issues/50977

Change-Id: I8bc6547a3f5e2cf4bb8913b1d6dfb8a618fc2022
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278888
Reviewed-by: Kallen Tu <kallentu@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2023-01-23 21:33:53 +00:00
Samuel Rawlins 813ca7faf6 Revert "[analyzer][meta] Refactor TargetKind to be a class, add a value in TargetKind to represent type parameter" 
This reverts commit 82143e6c95.

Reason for revert: This commit appears to have negatively affected the analyze benchmark:

* https://golem.corp.goog/Revision?repository=flutter-analyze&team=dartanalyzer&revision=114193

We need to revert and analyze it.

Original change's description:
> [analyzer][meta] Refactor TargetKind to be a class, add a value in TargetKind to represent type parameter
>
> Bug: https://github.com/dart-lang/sdk/issues/49796
> Change-Id: Ide144ceb57bae94a71b9d1a7ec841d03363fc121
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/258200
> Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: https://github.com/dart-lang/sdk/issues/49796
Change-Id: I6ec04ffe8d85c417d138626ffa4f1a7ac7dafe2b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/268380
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-11-07 20:17:09 +00:00
Mateus Felipe C. C. Pinto 82143e6c95 [analyzer][meta] Refactor TargetKind to be a class, add a value in TargetKind to represent type parameter 
Bug: https://github.com/dart-lang/sdk/issues/49796
Change-Id: Ide144ceb57bae94a71b9d1a7ec841d03363fc121
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/258200
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-11-04 23:38:40 +00:00
Sam Rawlins d77ded508e Report invalid mustCallSuper annotation targets 
Fixes https://github.com/dart-lang/sdk/issues/49499

Change-Id: Ibea55a78b58ee83b9290c33bca5e69039c995d55
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/252865
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
 2022-07-28 17:48:15 +00:00
Sam Rawlins aee2e21de8 Correct mustCallSuper documentation as per analyzer impl 
See must_call_super_test.dart for tests covered by this documentation.

Bug: https://github.com/dart-lang/sdk/issues/49499
Change-Id: I50e6546dda155cb133b8ad314db27a266a94fa00
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/252762
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2022-07-27 00:58:37 +00:00
Sam Rawlins 7280525117 Implement mustBeOverridden annotation and enforcement 
Fixes https://github.com/dart-lang/sdk/issues/30175
Fixes https://github.com/dart-lang/sdk/issues/28250

Change-Id: Id9c62448da9ade81258c2ae2355d05117057a8f3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/252463
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2022-07-25 22:17:18 +00:00
Devon Carew 580597c2eb [pkg/meta] analyze using package:lints 
Change-Id: Ie490a992eac0f8b6e784346c67c8c297e9d1d034
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/250773
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-07-06 22:24:20 +00:00
Marc Plano-Lesay 9d68fe751d Fix a typo 
Closes https://github.com/dart-lang/sdk/pull/47817
https://github.com/dart-lang/sdk/pull/47817

GitOrigin-RevId: a7bbf4d895136b4c304cc11dd2e83aa4f208be51
Change-Id: Ib60bfc53d77532ff782ba732a282f4c2a61d293a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/221746
Reviewed-by: Michael Thomsen <mit@google.com>
Commit-Queue: Michael Thomsen <mit@google.com>
 2021-12-02 11:37:31 +00:00
Stephen Adams 55596f4c01 [dart2js] Implement package:meta/dart2js.dart in terms of @pragma 
Change-Id: I56777498f3c3b6f910eb8c7e066de4fc254c1708
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209040
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Stephen Adams <sra@google.com>
 2021-08-16 18:02:39 +00:00
pq 9491cafc2f add UseResult.unless({... , this.parameterDefined}); 
Sample use:

```
@UseResult.unless(parameterDefined: 'count')
Matcher hasCount([int? count]) => Matcher();
```

See: https://github.com/dart-lang/sdk/issues/46727


Change-Id: I507659c09072157d67433f347d1fa6b511a93a7c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/208721
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2021-08-04 14:30:10 +00:00
Konstantin Shcheglov 0f2e58367d Prepare to publish meta 2.0.0 
Adding any not private extension is a breaking change.
So, to add `TargetKindExtension` we need version `2.0.0`.

Bug: https://github.com/dart-lang/sdk/issues/46558
Change-Id: Ic23c95490f12805784460c40013711e9d99dbf23
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/205905
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-07-03 01:22:45 +00:00
Konstantin Shcheglov a6c37854f5 Prepare to publish meta 1.6.0 
Revert "Move TargetKind.displayString from analyzer to meta"

This reverts commit 6de639b71f.

Change-Id: Ie4bec18dbc22db81ddec50eb36f47282e8a0a7ae
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/205904
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-07-03 00:00:05 +00:00
Sam Rawlins 9f85dc07a7 Improve quality of @protected doc comment 
Fixes https://github.com/dart-lang/sdk/issues/29804

Start doc comment with a single-sentence summary.
https://dart.dev/guides/language/effective-dart/documentation#do-start-doc-comments-with-a-single-sentence-summary

Separate the first sentence of a doc comment into its own paragraph.
https://dart.dev/guides/language/effective-dart/documentation#do-separate-the-first-sentence-of-a-doc-comment-into-its-own-paragraph

Replace text which refers to "using" an "invocation" of a member with text which refers to "referencing" a member.

Explicitly call out mixins and superclass constraints.

Improve language around using "this" as a receiver.

Attempt to use more straightfoward sentences.

Change-Id: Ib465b640c217d3759455611116aef0545b5665fc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/201445
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2021-05-27 18:41:24 +00:00
Brian Wilkerson 6de639b71f Move TargetKind.displayString from analyzer to meta 
Change-Id: Ifa24fb96c97c6b7a2f27794e671672796c56331e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/201460
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-05-26 19:37:40 +00:00
Sam Rawlins e7d65d9822 Update docs on optionalTypeArgs to allow for functions, methods, typedefs 
Also minor edit to invalid_annotation_target_test.

Bug: https://github.com/dart-lang/sdk/issues/37714
Change-Id: Ie13a33625786d4a5fc7de2eee11d6adfad6cdcfd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/201161
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
 2021-05-24 20:31:05 +00:00
pq 1bfa8610d1 add @useResult 
See: https://github.com/dart-lang/linter/issues/1888

Change-Id: Idd529c86236a4c2692104dc36cb0a7f0d5dd35aa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/200301
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2021-05-19 18:04:32 +00:00
creativecreatorormaybenot 9108f927ab Document same-library access for protected members 
I noticed that in the Flutter framework, `@protected` members are called from outside of instance methods. @Hixie responded:

> protected allows access from the same file

I think this should be documented.

Closes https://github.com/dart-lang/sdk/pull/45937
https://github.com/dart-lang/sdk/pull/45937

GitOrigin-RevId: c1a86d4039aeaa5a2126b505cad28e10fe361b0a
Change-Id: If0be693897abe10197516bdf854ec45fcb1be7fc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/198480
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-05-06 22:53:54 +00:00
Sam Rawlins afbb8f9063 Meta: introduce @internal annotation 
Fixes https://github.com/dart-lang/sdk/issues/28066

Change-Id: I200173e48bfbffa8460d6273c274d210b3be8606
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/164244
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
 2020-09-24 00:25:29 +00:00
pq eb30e43940 specify targets for @doNotStore 
Change-Id: I22546585fb189e4536e16a38488ce2e8b3b7fe52
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/160740
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-08-29 01:11:03 +00:00
Brian Wilkerson 896f874b9f An initial definition of the Target annotation 
Change-Id: I6980da1e869c57b15a8bd068fef17f33d6a884ab
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/154380
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Nate Bosch <nbosch@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
 2020-07-17 19:01:17 +00:00
Brian Wilkerson 73e9554779 Update meta to correspond to the published 1.2.2 
Change-Id: I9dcbd9237d25948eb62e3ba68403436c64c70845
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/153822
Auto-Submit: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Jake Macdonald <jakemac@google.com>
Reviewed-by: Jake Macdonald <jakemac@google.com>
 2020-07-09 17:38:32 +00:00
Tess Strickland 06cb010247 Revert "Add unawaited to package:meta" 
This reverts commit 0d44449aaa.

Reason for revert: Breaks Flutter HHH and the Dart->Flutter roll.

Original change's description:
> Add unawaited to package:meta
> 
> Change-Id: I09df4989591327bd4d148e73a5887b900902576c
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152680
> Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
> Reviewed-by: Jake Macdonald <jakemac@google.com>

TBR=brianwilkerson@google.com,jakemac@google.com

Change-Id: I71f491bccc37508a24b7f6f9d051ed914bafeccd
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/153351
Reviewed-by: Tess Strickland <sstrickl@google.com>
Commit-Queue: Tess Strickland <sstrickl@google.com>
 2020-07-07 08:14:51 +00:00
Brian Wilkerson 0d44449aaa Add unawaited to package:meta 
Change-Id: I09df4989591327bd4d148e73a5887b900902576c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152680
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Jake Macdonald <jakemac@google.com>
 2020-07-06 21:57:52 +00:00
pq 37ba50cd0c Add @doNotStore. 
See: https://github.com/dart-lang/sdk/issues/41941

As per the conversation there, I opted not to handle the formal parameter case.

(My thinking being we could add it as a refinement.)

Change-Id: Ia91c525c8ea4ce26d9debe3f52af9a3018e50d6f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152540
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-06-25 17:27:52 +00:00
pq 2d7235c14d typos 
Change-Id: Idbbd0ad4d6097f7c1c5a70de5f3fa4c2d13ff2c7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/130061
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-01-02 23:09:17 +00:00
pq a688de0371 Add deprecated member messages 
Change-Id: I8efa2244b3f03a1af44eca93ed4441a255c6cb68
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129923
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-01-02 15:41:26 +00:00
pq 6a8ab6a858 Remove unnecessary const modifiers 
Change-Id: I2187b009abc150d8e361d00c673099ec7b4147f4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129924
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-01-02 00:48:55 +00:00
pq 5812bf4688 remove “implements” condition 
Change-Id: I21f571e0490bcfd43ed84f84fb08f8b6659c836d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/122840
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2019-10-24 18:19:22 +00:00
pq d43cd7e909 + @nonVirtual 
See: https://github.com/dart-lang/sdk/issues/34378

Change-Id: Ie61b8bddaef01cdbf47da9a8ca6915cbd86b21a7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/122701
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-10-23 22:43:47 +00:00
Sam Rawlins e9dcb9f45d fix typo in factory; add mixin text for protected 
Change-Id: Idab2890de1f128105a02d94a7512e4a22eba7023
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116050
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Auto-Submit: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-09-09 14:11:47 +00:00
Sam Rawlins 35c011c030 Update meta docs to consider mixins and static extensions 
* Update optionalTypeArgs to consider mixins and static extensions
* Update visibleForOverriding to consider mixins
* Update visibleForTesting to consider private declarations, and
  declarations on unnamed mixins

Bug: https://github.com/dart-lang/sdk/issues/38105
Change-Id: I50b87e0fafd7960abc945b240788b1a640f78621
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115067
Auto-Submit: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2019-09-04 04:01:47 +00:00
Vijay Menon 23dae9cca3 Make package:meta NNBD agnostic 
Minor changes to pass analysis with --experiment=non-nullable on.

Change-Id: I17cafbc4f3a127fb755412883b889e5454387819
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114400
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Vijay Menon <vsm@google.com>
 2019-08-23 19:23:41 +00:00
Sam Rawlins af97015781 Fix markdown and Dart links in meta package 
Right now they're dead. https://pub.dev/documentation/meta/latest/meta/meta-library.html

Change-Id: Iecc12075e56eb4caf115c34fdfb04d9b164ebe2f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111865
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2019-08-02 21:08:59 +00:00
Jonas Termansen 7d6a3e0058 Fix http links to pub which has https. 
Change-Id: I3b712014fb0744b890df426e941907760bd92780
Reviewed-on: https://dart-review.googlesource.com/c/88452
Reviewed-by: Jonas Jensen <jonasfj@google.com>
Commit-Queue: Jonas Termansen <sortie@google.com>
 2019-01-07 11:37:19 +00:00
Sam Rawlins 359217d30d Correct doc comment for sealed 
As per discussion at https://github.com/dart-lang/sdk/issues/34232

Bug: https://github.com/dart-lang/sdk/issues/34232
Change-Id: Ib0a7207a43167b5e69973fc3abffa197e0bdafe5
Reviewed-on: https://dart-review.googlesource.com/c/88289
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2019-01-03 21:21:20 +00:00
Sam Rawlins 31fa815dca Remove sealed ability on mixin 
Change-Id: I69f59dfaa18d77fcd53f82b71a79c567102a9b66
Reviewed-on: https://dart-review.googlesource.com/c/88200
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-01-03 01:51:35 +00:00
Brian Wilkerson e58e3fbb55 Deprecate the "virtual" annotation 
Change-Id: I3fa88a70f36c769be3649ea7d40d280e6cf6b633
Reviewed-on: https://dart-review.googlesource.com/c/84443
Reviewed-by: Nate Bosch <nbosch@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-11-14 20:12:37 +00:00
Stephen Adams ded73cdd08 Revert "[dart2js] Simplify noInline / tryInline annotations" 
This reverts commit 8bae3a1cfd.

There are versioning issues that need to be addressed.

TBR=kevmoo@google.com

Change-Id: Ia82e94f127523db650e4df03af1179ef94463bee
Reviewed-on: https://dart-review.googlesource.com/76564
Reviewed-by: Stephen Adams <sra@google.com>
Reviewed-by: Kevin Moore <kevmoo@google.com>
Commit-Queue: Stephen Adams <sra@google.com>
 2018-09-25 22:11:42 +00:00
Stephen Adams 8bae3a1cfd [dart2js] Simplify noInline / tryInline annotations 
Use @pragma for dart2js.noInline / dart2js.tryInline

Change-Id: Id7932ad7f85b91e4c1e427bb88e782ede81d5926
Reviewed-on: https://dart-review.googlesource.com/76341
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Stephen Adams <sra@google.com>
 2018-09-25 19:08:14 +00:00