d5d8486c25
[ddc] Remove legacy code from tests
...
Stop running expression evaluation and module symbols tests on legacy
code. These still run with unsound null safety, just on migrated code.
Change-Id: Ifb602c058ebcc3fbd8254e8c2f431f8b18146a64
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/337615
Commit-Queue: Nicholas Shahan <nshahan@google.com >
Reviewed-by: Anna Gringauze <annagrin@google.com >
2023-12-14 00:34:15 +00:00
a45fc14739
[ddc] Update debugger field signatures
...
Erases extension types to their representation type for field
signatures. This is the best representation we have at runtime for
the field. Note this isn't necessarily the runtime type of the
field value.
Issue: https://github.com/dart-lang/sdk/issues/49735
Change-Id: Ibe064f4fd3829a858fc9fd920e2e91175d9ae0c9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/336823
Commit-Queue: Nicholas Shahan <nshahan@google.com >
Reviewed-by: Mark Zhou <markzipan@google.com >
2023-11-21 01:55:46 +00:00
67d752aa12
[ddc] Clean up expression compiler tests
...
- Allow running the tests with asserts enabled
- Allow running the tests in canary mode
- Unify common test code and remove duplication
- merge expression_compiler/setup_compiler_options.dart
into share_compiler_options.dart
- Merge TestCompiler code from expression evaluation and
expression compilation tests and move into
expression_compiler/test_compiler.dart
- Rename various TestDrivers so they have more descriptive names
- Remove 'golden' JS comparison tests from expression_compiler_test.dart
- replace by evaluation tests where needed
Closes: https://github.com/dart-lang/sdk/issues/53145
Change-Id: Ic797fa4ee9bfa6b858b924be9f9a53fd10ae1448
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/318080
Commit-Queue: Anna Gringauze <annagrin@google.com >
Reviewed-by: Sigmund Cherem <sigmund@google.com >
2023-08-08 16:21:31 +00:00
d2f5b3bfab
[ddc] Add --canary flag to expression compiler worker
...
Closes: https://github.com/dart-lang/sdk/issues/52776
Change-Id: I639fe7fbadf3e938cc686aa8dbd2320a4cc7af7d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/311151
Reviewed-by: Mark Zhou <markzipan@google.com >
Commit-Queue: Anna Gringauze <annagrin@google.com >
Reviewed-by: Nicholas Shahan <nshahan@google.com >
2023-06-26 22:55:07 +00:00
aa0a7e7083
[ddc] Add dart.web.assertions_enabled environment variable.
...
Change-Id: If28f2f1404f02c5d757774188a5a006137c8734f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/273284
Reviewed-by: Nicholas Shahan <nshahan@google.com >
Commit-Queue: Mayank Patke <fishythefish@google.com >
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Reviewed-by: Anna Gringauze <annagrin@google.com >
2023-02-14 01:35:05 +00:00
a9d9b7395b
[kernel] Enable sound null safety in TargetFlags by default
...
TargetFlags.enableNullSafety is set to true by default and
also renamed to TargetFlags.soundNullSafety to better reflect its
meaning.
TEST=ci
Change-Id: I2c2f30c2af6502fd9a96141dc60e4afbf8c524fd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/280216
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Commit-Queue: Alexander Markov <alexmarkov@google.com >
Reviewed-by: Siva Annamalai <asiva@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Reviewed-by: Nicholas Shahan <nshahan@google.com >
Reviewed-by: Aske Simon Christensen <askesc@google.com >
Reviewed-by: Daco Harkes <dacoharkes@google.com >
2023-02-02 14:54:18 +00:00
d56b9b3988
[ddc] Remove unsound .dill files from SDK
...
Dart 3 requires all code to be null safe.
Compiling with --no-sound-null safety requires manually passing
an unsound SDK outline. This is no longer provided by default
and is not packaged with the SDK at all.
Fixes: https://github.com/dart-lang/sdk/issues/50700
Change-Id: Ic4bd7dc5e96b42c7c10a29f273371c6a680936f1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278999
Reviewed-by: William Hesse <whesse@google.com >
Commit-Queue: Nicholas Shahan <nshahan@google.com >
2023-01-26 22:34:38 +00:00
c140324e1e
[ddc] Rename .dill files
...
- Makes the names consistent with dart2js and dart2wasm.
- Prepares for the upcoming removal of the weak null safety .dill file.
Change-Id: Idcf694b27cd4731db8f7ed6f0fdab7766ced08a6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/277183
Reviewed-by: William Hesse <whesse@google.com >
Reviewed-by: Bob Nystrom <rnystrom@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Reviewed-by: Mayank Patke <fishythefish@google.com >
2023-01-18 01:34:57 +00:00
3f104a2ab4
[ddc] Migrate command to null safety
...
Revert small diffs introduced in earlier migrations to avoid an
import of command.dart before it was migrated.
Issue: https://github.com/dart-lang/sdk/issues/46617
Change-Id: Ia728fd727417fd4fdf8c454a0044e096e9de5756
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/248948
Reviewed-by: Anna Gringauze <annagrin@google.com >
Commit-Queue: Nicholas Shahan <nshahan@google.com >
2022-06-22 21:30:16 +00:00
6366fddf12
[ddc] Migrate expression_compiler to null safety
...
Migrate the test file that is unblocked.
Issue: https://github.com/dart-lang/sdk/issues/46617
Change-Id: I65598f5837115d7dce1c51389bb7c762c1ce451e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/248884
Reviewed-by: Anna Gringauze <annagrin@google.com >
2022-06-22 21:30:16 +00:00
7f026d6e46
[dev_compiler] remove the dep on package:cli_util
...
Change-Id: I34c17dc76a0c608ac3536bfdf2c0e39bb8daa6c1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232424
Auto-Submit: Devon Carew <devoncarew@google.com >
Reviewed-by: Nicholas Shahan <nshahan@google.com >
Commit-Queue: Nicholas Shahan <nshahan@google.com >
2022-02-11 00:50:31 +00:00
e681abace9
Remove unnecessary imports
...
TEST=N/A
Change-Id: I7440c1165a7403aad023f002a97c90572cb66c59
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/205820
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Nicholas Shahan <nshahan@google.com >
Reviewed-by: Ben Konyi <bkonyi@google.com >
2021-07-15 16:57:21 +00:00
e36fbfd978
[ddc] Add basic symbol information for classes
...
Module symbol information now includes basic details the classes
compiled in the module.
Add tests and refactor to share some of the options for running the
incremental frontend compiler and ddc.
Change-Id: I6d3eb16bd6fb70c4c0af46de93a0f7bf96151c4f
Issue: https://github.com/dart-lang/sdk/issues/40273
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/202865
Commit-Queue: Nicholas Shahan <nshahan@google.com >
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Reviewed-by: Anna Gringauze <annagrin@google.com >
2021-06-16 23:48:28 +00:00
Nicholas Shahan