dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
98,756 Commits 2 Branches 0 Tags
c84edaefe9e457e9cc975c050019479b2d94dea2
Commit Graph

147 Commits

Author SHA1 Message Date
Derek Xu 53be2cb558 [package:dds] Prepare to publish version 3.1.1 
Change-Id: I56132705e10657a3210f9b9938744fb2ce3e8bbd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/341502
Commit-Queue: Derek Xu <derekx@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2023-12-15 15:32:18 +00:00
Danny Tuppeny 5fde2e1534 [dds/devtools_server] Add support for finding VS Code extensions defined in packages 
See https://github.com/Dart-Code/Dart-Code/issues/4705

Change-Id: I724c039cd6940dd5939330a6f91f38567db9a179
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/337781
Reviewed-by: Kenzie Davisson <kenzieschmoll@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Kenzie Davisson <kenzieschmoll@google.com>
 2023-12-06 20:56:11 +00:00
Ben Konyi 9b17a1b703 [ package:dds ] Prepare for 3.1.0 release 
Change-Id: Ie1d19e45ae60ed5ced0a49a3b9b04848ffe661a1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/332183
Auto-Submit: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Derek Xu <derekx@google.com>
 2023-11-06 18:50:51 +00:00
Kenzie Schmoll 549c1eea11 Roll DevTools into SDK and bump to devtools_shared 5.0.0 
Change-Id: I9c38d6be70816de14bb6b9818e6aa550b11c1a34
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/331748
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Kenzie Davisson <kenzieschmoll@google.com>
 2023-10-24 17:09:20 +00:00
Ben Konyi 51dde069b2 [ package:dds ] Prepare for 3.0.0 release 
- Fixes typo in CHANGELOG.md
- Reverts vm_service version bump to ^12.0.0 as it's not needed for this
  breaking change

Change-Id: Ib9251dac0af4958d72fcb341490643bfe0f7a21a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/331800
Reviewed-by: Derek Xu <derekx@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2023-10-23 19:38:33 +00:00
Ben Konyi 08b4f49249 Split package:vm_service into package:vm_service and package:vm_service_interface 
To reduce the headache associated with adding parameters to VM service
APIs, VmServiceInterface has been removed from package:vm_service and
pulled into its own dedicated package:vm_service_interface. This will
help reduce the need for major version bumps of package:vm_service,
which requires manual version bumps through >8 packages in order to make
the latest version available to flutter_tools and DevTools.

This separation of the VmService client from the interface will reduce
the frequency of major version bumps to `package:vm_service` as adding
optional parameters to existing APIs would cause implementers of the
interface to break.

package:vm_service continues to expose a copy of the contents of package:vm_service_interface to avoid breaking google3 rolls until package:dwds can migrate to package:vm_service_interface. package:vm_service will not be published until this copy is removed.

This change also includes:
 - some code cleanup and modernization to both the code generator and
   generated code
 - >=3.0.0 SDK version requirement to allow for new language features

Change-Id: Ib1859c1b4e153fef7ee1f91e67e881bbf42652c2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/330500
Reviewed-by: Derek Xu <derekx@google.com>
Reviewed-by: Devon Carew <devoncarew@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2023-10-23 17:00:10 +00:00
Ben Konyi ebd669a0d4 Update package:dds and package:dds_service_extensions to vm_service 
^12.0.0

Change-Id: I4430112a027c281b87c4360de419110c5e10c453
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/329180
Reviewed-by: Derek Xu <derekx@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2023-10-02 17:51:35 +00:00
Kenzie Schmoll 0054a68cc3 Update DevTools rev to 2a1d1975d7ad8773a3e2590d10636432775f23a1 
Change-Id: I5072fe1be9255f2eacda45db93dcc639ddfd8e42
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/326804
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Kenzie Davisson <kenzieschmoll@google.com>
 2023-09-19 18:17:22 +00:00
Kenzie Schmoll 83b27b8bcf Add a retry to the DevTools handler for static files 
Change-Id: Iced8093f894afd5574e3ae898e07f237e02002bf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/325323
Reviewed-by: Derek Xu <derekx@google.com>
Commit-Queue: Kenzie Davisson <kenzieschmoll@google.com>
Reviewed-by: Alexander Aprelev <aam@google.com>
 2023-09-12 18:52:01 +00:00
Kenzie Schmoll 2ed87ffb02 Update DevTools rev to adfb08c95c626248b28cc60df3b085c12ad8758e 
Change-Id: Ieda1de59dec0ba68b01ec0893c43c6c4015fe58e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/324770
Reviewed-by: Derek Xu <derekx@google.com>
Commit-Queue: Kenzie Davisson <kenzieschmoll@google.com>
 2023-09-08 18:32:51 +00:00
Polina Cherkasova eaf4c2c6eb Bump DevTools DEP to 2.27.0 and devtools_shared to ^3.0.1 
Change-Id: I389800b160d6edfe89a7bda45963ff10a96c9e8f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/323302
Reviewed-by: Ben Konyi <bkonyi@google.com>
Reviewed-by: Kenzie Davisson <kenzieschmoll@google.com>
Commit-Queue: Polina Cherkasova <polinach@google.com>
 2023-08-30 16:35:40 +00:00
Kenzie Schmoll caedf8214d Bump DevTools to 2.26.2 and devtools_shared to 3.0.0 in DDS 
Change-Id: I8601b54fffa34d2c3dba678b3bc6d86f68223ec7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/321620
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Kenzie Davisson <kenzieschmoll@google.com>
 2023-08-21 19:43:52 +00:00
Danny Tuppeny eda6963e4d [dds/dap] Revert using Isolate numbers for DAP threadIds 
This reverts 95e6f1e110 (minus the changelog/version, which have been updated accordingly).

Fixes https://github.com/dart-lang/sdk/issues/53086 although a replacement for mapping threads/isolates needs to be implemented.

Change-Id: I5e4d71f3b4683a04cabec6bda9e6d23caa7901d9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/317700
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2023-08-21 14:17:26 +00:00
Ben Konyi 5ef423d55c [ DDS ] Prepare for 2.9.4 release 
Change-Id: I393ce964bce316592f78c0ea1de45ac1b34ddefd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/317620
Reviewed-by: Kenzie Davisson <kenzieschmoll@google.com>
 2023-08-01 22:59:17 +00:00
Kenzie Schmoll c96ea516f7 Serve devtools extension assets from devtools_server. 
This change cannot be landed until a new version of devtools_shared is published and rolled into the SDK so that it can be depended upon here.

Change-Id: Ia7196fb8c12e980220ee2c2749a979f6359452a9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/305043
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Kenzie Davisson <kenzieschmoll@google.com>
 2023-08-01 22:30:34 +00:00
Kenzie Schmoll d792438829 Roll DevTools 2.26.1 into the SDK 
Change-Id: I5206ced2deab27841f49c4f1272b0266ed14487b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/317445
Commit-Queue: Kenzie Davisson <kenzieschmoll@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2023-08-01 21:03:16 +00:00
Danny Tuppeny 95e6f1e110 [dds/dap] Use Isolate numbers as DAP thread IDs 
We used to generate our own thread ID starting at 1 and counting up. There was always a 1:1 mapping from a DAP thread to a VM Isolate. With this change, we always use the Isolate number as the thread ID which makes it easier for tools using both VM Service and DAP at the same time.

Change-Id: Id8d82f6fd5134987f2ecfeaa761765d55999405d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/312906
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2023-07-10 20:14:58 +00:00
Ben Konyi ea1a6a66b8 [ DDS ] Set minimum SDK bound to 3.0.0 
Allows for use of new language features.

Change-Id: Ic66cb6d2e8bfbf5ff505cc72c0a23deb32026bbc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/312601
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Derek Xu <derekx@google.com>
 2023-07-06 15:39:35 +00:00
Danny Tuppeny 4d1b418230 [dds/dap] Fix breakpoint resolution races when there are multiple isolates 
When there are multiple isolates, we may get breakpoint responses/events like this:

- Request/Response to add breakpoint to Isolate 1
- Request/Response to add breakpoint to Isolate 2
- BreakpointAdded for Isolate 1
- BreakpointResolved for Isolate 1
- BreakpointAdded for Isolate 2

Because Isolate 2 did not load the script, the last breakpoint was never resolved. However because the breakpoint ID matched, we would forward this event to the client and un-resolve the previously resolved breakpoint. This would result in odd behaviour in VS Code.

Additionally, the VM may return the same BM breakpoint ID for what the client thinks are two breakpoints (they are on different lines, but resolve to the same location) so when we get a resolved breakpoint, we need to handle both:

- Client breakpoints that have already been transmitted
- Future client breakpoints that may resolve to this same VM breakpoint

The previous code assumed that a BreakpointResolved event could be handled just once. Either for an existing breakpoint, or a future one.

This change swaps from storing queued events to storing the resolution information for each breakpoint, and it does this even if there was an existing breakpoint (in case the breakpoint is reused in future).

Fixes at least some of https://github.com/Dart-Code/Dart-Code/issues/4598

Change-Id: I53b92debfaa0c8f538dc8d67966854bb89634708
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/311480
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2023-06-27 14:54:10 +00:00
Helin Shiah 5b3f7990e8 Revert "Revert "Send DAP events through DDS"" - only check for event handler when DDS URI is also set. 
Original change reverted due to test failure: https://github.com/dart-lang/sdk/issues/43743#issuecomment-1601278402

This reverts commit 02b10e1321.

Change-Id: Idb2cbffe18342c76d0cc062e5855c10a6df0e8f1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/310780
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Helin Shiah <helinx@google.com>
 2023-06-22 21:43:22 +00:00
Danny Tuppeny 194767e452 [dds/dap] Add 'showGettersInDebugViews' which includes getters but lazily 
The existing 'evaluateGettersInDebugViews' evaluates getters eagerly which can have side-effects. This adds a setting that allows showing getters in a way that can be shown lazily instead.

I added a new setting (instead of just making evaluateGettersInDebugViews=false be lazy) to preserve the ability to have getters not shown at all (since some users are using that today and might prefer this over lots of lazy getters showing up).

Fixes https://github.com/Dart-Code/Dart-Code/issues/4234

Change-Id: I56c2a7c8f85aa8c4cc85cfb3120a8cfec6b54c70
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/310164
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2023-06-22 16:42:52 +00:00
Helin Shiah 02b10e1321 Revert "Send DAP events through DDS" 
This reverts commit 5292ee8839.

Reason for revert: Causes failure on `sse_smoke_test` because it needs to set up an event handler.

Original change's description:
> Send DAP events through DDS
>
> Change-Id: Ib40306b8e47d74b02b6cbf348c2b5833cfb31a9d
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/309080
> Commit-Queue: Helin Shiah <helinx@google.com>
> Reviewed-by: Ben Konyi <bkonyi@google.com>

Change-Id: I62b12de8e2478441d9a7a4177ed1090aa845467f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/310740
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Derek Xu <derekx@google.com>
Commit-Queue: Helin Shiah <helinx@google.com>
 2023-06-21 18:17:16 +00:00
Helin Shiah 5292ee8839 Send DAP events through DDS 
Change-Id: Ib40306b8e47d74b02b6cbf348c2b5833cfb31a9d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/309080
Commit-Queue: Helin Shiah <helinx@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2023-06-21 15:51:24 +00:00
Danny Tuppeny 565379aaec [dds/dap] Respond to DAP launch request before sending runInTerminalRequest 
Currently when the user configures a Dart CLI program to be run in the terminal, we ask VS Code to launch it in the terminal before we respond to the launch request. This (depending on settings) can cause VS Code to show the terminal and then switch to the Debug Console (which is both confusing and frustrating for users that opt-in to do this to access stdin of the terminal process).

This change reverses the order when using `runInTerminal` so that `launch` is responded to first.

See https://github.com/microsoft/vscode/issues/168295

Fixes https://github.com/Dart-Code/Dart-Code/issues/4287

Change-Id: If9a221361cc3329fb86fb17ba532043266b3438c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/307481
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2023-06-07 17:31:03 +00:00
Dan Chevalier 46d9f76f7e Add postEvent to dds client. 
This will allow for communication to custom streams through a connection to DDS. The primary use case for this is so Dart DevTools can communicate to the running app's custom streams, and by extension VSCode.

Bug: https://github.com/flutter/devtools/issues/5819
Change-Id: Ib22181a55a15baa4a85f49fb20d86d1ca8f0e5e7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/304981
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Dan Chevalier <danchevalier@google.com>
 2023-06-02 19:07:39 +00:00
Alexander Aprelev 17781dbc36 [frontend/dds] Enable frontend server and dds to pass through types, method and class information for expression evaluation. 
This information is needed for correct expression compilation.
Method name, for example, introduced in https://github.com/dart-lang/sdk/commit/48d8225b17f11c56dff129942ce044474a21db46 is needed for the compiler to confirm extension method context.

For flutter https://github.com/flutter/flutter/pull/128084 will be needed.

Fixes https://github.com/dart-lang/sdk/issues/52522

Change-Id: I32e53a953ebfb51afb462f4e2169fac0bcee0a7a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/306908
Reviewed-by: Jens Johansen <jensj@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Alexander Aprelev <aam@google.com>
 2023-06-02 16:27:28 +00:00
Helin Shiah 2cc17f4718 Export dap package from DDS for flutter tools 
Reland "Reland "Use dap package in dds, dds_service_extensions""

This is a reland of commit a48d2cf02c

This was failing in g3 because it seemed dependencies weren't added to the g3 files. There's now a fix in g3.

Original change's description:
> Reland "Use dap package in dds, dds_service_extensions"
>
> This is a reland of commit 59bb1fce82
>
> Original change's description:
> > Use dap package in dds, dds_service_extensions
> >
> > Change-Id: I678c810e02a5989ee1b4edebaf9d741e2fc7d026
> > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/302849
> > Reviewed-by: Ben Konyi <bkonyi@google.com>
> > Commit-Queue: Helin Shiah <helinx@google.com>
>
> Change-Id: Ib5b9cad1d0c19dac79c73e65c5de8721d1768285
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/304105
> Reviewed-by: Ben Konyi <bkonyi@google.com>
> Commit-Queue: Helin Shiah <helinx@google.com>

Change-Id: Ie6618c761ce57b33c36260b52076f6335da2a102
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/304326
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Helin Shiah <helinx@google.com>
 2023-05-23 19:23:35 +00:00
Derek Xu 3af9eb58af Revert "Reland "Use dap package in dds, dds_service_extensions"" 
This reverts commit a48d2cf02c.

Reason for revert: breaks g3 (https://ci.chromium.org/ui/p/dart/builders/ci.sandbox/google/39297/overview)

Original change's description:
> Reland "Use dap package in dds, dds_service_extensions"
>
> This is a reland of commit 59bb1fce82
>
> Original change's description:
> > Use dap package in dds, dds_service_extensions
> >
> > Change-Id: I678c810e02a5989ee1b4edebaf9d741e2fc7d026
> > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/302849
> > Reviewed-by: Ben Konyi <bkonyi@google.com>
> > Commit-Queue: Helin Shiah <helinx@google.com>
>
> Change-Id: Ib5b9cad1d0c19dac79c73e65c5de8721d1768285
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/304105
> Reviewed-by: Ben Konyi <bkonyi@google.com>
> Commit-Queue: Helin Shiah <helinx@google.com>

Change-Id: I5eee0e7ed9c721d576e1fa59c666c03e4ddb63af
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/304363
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Derek Xu <derekx@google.com>
 2023-05-18 20:25:17 +00:00
Helin Shiah a48d2cf02c Reland "Use dap package in dds, dds_service_extensions" 
This is a reland of commit 59bb1fce82

Original change's description:
> Use dap package in dds, dds_service_extensions
>
> Change-Id: I678c810e02a5989ee1b4edebaf9d741e2fc7d026
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/302849
> Reviewed-by: Ben Konyi <bkonyi@google.com>
> Commit-Queue: Helin Shiah <helinx@google.com>

Change-Id: Ib5b9cad1d0c19dac79c73e65c5de8721d1768285
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/304105
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Helin Shiah <helinx@google.com>
 2023-05-18 19:25:28 +00:00
Daco Harkes 987c7a7c35 Revert "Use dap package in dds, dds_service_extensions" 
This reverts commit 59bb1fce82.

Reason for revert: Breaks arm64 bot with
`Couldn't resolve the package 'dap' in 'package:dap/dap.dart'.`


Original change's description:
> Use dap package in dds, dds_service_extensions
>
> Change-Id: I678c810e02a5989ee1b4edebaf9d741e2fc7d026
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/302849
> Reviewed-by: Ben Konyi <bkonyi@google.com>
> Commit-Queue: Helin Shiah <helinx@google.com>

Change-Id: Ie5895dc958ee6bad798007d380bc7e75a67b8926
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/304000
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Daco Harkes <dacoharkes@google.com>
 2023-05-17 07:50:07 +00:00
Helin Shiah 59bb1fce82 Use dap package in dds, dds_service_extensions 
Change-Id: I678c810e02a5989ee1b4edebaf9d741e2fc7d026
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/302849
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Helin Shiah <helinx@google.com>
 2023-05-17 03:26:57 +00:00
Danny Tuppeny 84f528d26d [dds/dap] Handle "Service has disappeared" errors for in-flight requests when app may be shutting down 
Fixes https://github.com/flutter/flutter/issues/116235.

Change-Id: Ibfd24bce45519116e350a7f409609f19ca502ad3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/303580
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2023-05-16 14:44:23 +00:00
Derek Xu 8ccece520f [DDS] Prepare to publish package:dds 2.8.1 
Fixes: https://github.com/dart-lang/sdk/issues/52270
Change-Id: I08ef372653adfd04eab9d45da225a5bfda74531c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/302000
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Derek Xu <derekx@google.com>
 2023-05-08 15:14:44 +00:00
Derek Xu 33ab02b064 [DDS] Add getPerfettoVMTimelineWithCpuSamples RPC 
Change-Id: I3d8e5c48f5482e787ab9d561692d416c50f37a8a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/301541
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Derek Xu <derekx@google.com>
 2023-05-04 20:23:09 +00:00
Danny Tuppeny 14ab84ebb3 [dds/dap] Don't throw if isolates exit while trying to resume them 
There are two cases where we might be trying to resume an exited isolate:

1. Another debugger resumed the isolate and it exited before we got here
2. We were starting to resume an isolate but then the app was shut down so the isolate exited

Because of async code, we can never guarantee the isolate hasn't exited before we send this event, so the exception we throw should only ever be because the ID was invalid.

Fixes https://github.com/Dart-Code/Dart-Code/issues/4515.

Change-Id: If3500d5d1adf3ba9179e6a571130256783b23c2d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/299640
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2023-05-01 14:43:51 +00:00
Danny Tuppeny facfcf0f92 [dds/dap] Handle some additional error causes when resuming isolates 
Fixes https://github.com/flutter/flutter/issues/125064.

Change-Id: I521fe29d0f269694dc6c2b993d1e400c495b0605
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/296560
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2023-04-20 14:55:23 +00:00
Danny Tuppeny 57ba99c2d3 [dds/dap] Handle sentinel values in Scopes and Variables requests 
Fixes https://github.com/dart-lang/sdk/issues/51916.

Change-Id: I72f02c640084059af5e2b761554ee6ec706f5f6a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/292540
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2023-04-03 14:50:12 +00:00
Danny Tuppeny b984c308be [dds/dap] Don't sent breakpoint changed events until after the response to setBreakpoints. 
In the response to setBreakpoints we provide IDs for each breakpoint and it's important the client gets these before we sent any "breakpoint resolved" events.

Change-Id: I776304b67b12d8e090480ea2a25a849ad4c1ac5e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/291763
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2023-03-29 18:20:17 +00:00
Danny Tuppeny 6bce1b1e7c [dds/dap] Add global variables to scopes/variables requests 
Fixes https://github.com/Dart-Code/Dart-Code/issues/4408.

Change-Id: I8a6f7e15f1db247424db23518e53c821d519f1e3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/285904
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2023-02-28 17:16:49 +00:00
Dan Chevalier 7599222465 Update to vm_service:11.0.0 in dds 
Changing the vm_service version to allow 11.0.0.

Change-Id: I78c5cdc474228e2d280e62ff408a12ea05df1ae3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/282460
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Dan Chevalier <danchevalier@google.com>
 2023-02-13 15:12:55 +00:00
Danny Tuppeny 16ede0e1d3 [dds] Bump version and update changelog to reflect published 2.7.3 
Change-Id: I4a0f75fdf6ebf5cb3a2ba88996127096af0b9d56
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/280090
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2023-01-30 14:42:44 +00:00
Danny Tuppeny 4fdbe1b47d [dds] Pass existing DDS URI in existingDdsInstance exception 
Work towards a better fix for https://github.com/flutter/flutter/issues/118609.

Change-Id: I7db8bd74cc272a2bb1df3a04e6f1d7b82b877ddb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/279175
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2023-01-18 20:36:07 +00:00
Ben Konyi 0a0c90e37a [DDS] Prepare for 2.7.2 release 
Change-Id: Ifb4cac218b2723e52b76936a6b8275fed6a3a3d3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/279121
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Derek Xu <derekx@google.com>
 2023-01-16 16:31:28 +00:00
Derek Xu ac23909288 [pkg:dds] Update pkg:vm_service dependency to >=9.0.0 <11.0.0 
Change-Id: I6525b63c854dff454700425e142dc69a850169ad
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278946
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Derek Xu <derekx@google.com>
 2023-01-13 15:56:23 +00:00
Derek Xu 9a7d8857ec [pkg:dds, pkg:dds_service_extensions] Update pkg:vm_service dependency to ^10.0.0 
Change-Id: I93d0690edf2bc9b21ac39707ed5dceb2488901b1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278940
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Derek Xu <derekx@google.com>
 2023-01-11 18:01:43 +00:00
Ben Konyi 52f62eaea8 [ package:dds ] Add support for registering external DevTools servers with DDS 
External DevTools instances can be registered with DDS at runtime, allowing for DDS
to redirect DevTools requests to the external DevTools server.

TEST=pkg/dds/test/external_devtools_instance_test.dart

Change-Id: I0bed34029b6ea7d935f77a031ff99b73b986b068
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278663
Reviewed-by: Kenzie Davisson <kenzieschmoll@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2023-01-10 16:03:41 +00:00
Danny Tuppeny 5b50a61918 [dds/dap] Fix handling of errors when fetching full strings 
Fixes https://github.com/dart-lang/sdk/issues/50802.

Change-Id: Ia2bda968708f34aa48c6b92b2f19c24c603fb85c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278349
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2023-01-06 16:54:03 +00:00
Ben Konyi 112e1213dc [ package:dds ] Prep for 2.6.0 release 
Change-Id: I7ffcd1c9cdf23906324ef77521216bb293259c08
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/276620
Reviewed-by: Dan Chevalier <danchevalier@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2023-01-06 15:26:34 +00:00
Danny Tuppeny ec8918c20c [dds/dap] Handle errors parsing/casting launch/attach arguments and provide useful errors 
Fixes https://github.com/dart-lang/sdk/issues/50709.

Change-Id: I35a7593ced462ab81d52069db831e5f95a9a4ba7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/275623
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2022-12-14 17:19:05 +00:00
Danny Tuppeny 37be66028b [dds/dap] Allow debug adapters to register multiple mappings for org-dartland-sdk URIs 
Change-Id: Ibcb0f145d64c7cd7712c031737741b2dbc4aaab8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/265500
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2022-10-26 14:26:01 +00:00