5b3f387f4d
Make dartdev test_all.dart test all and work.
...
This corrects some tests that just weren't working for myself and
others while disabling a small number that don't work anymore or
are blocked on a bug.
Bug: https://github.com/dart-lang/sdk/issues/51707
Change-Id: Ib537d210e80baa3bb80578f0fcccc063a2029173
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/288623
Auto-Submit: Janice Collins <jcollins@google.com >
Reviewed-by: Ben Konyi <bkonyi@google.com >
Commit-Queue: Janice Collins <jcollins@google.com >
2023-03-14 16:19:08 +00:00
1c571a12fa
[ CLI ] Migrate package:dartdev to null safety
...
Fixes https://github.com/dart-lang/sdk/issues/47964
TEST=CQ
Change-Id: I4ee57bc5739835824b0052bd9470a0d52ccf161b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/229948
Reviewed-by: Devon Carew <devoncarew@google.com >
Commit-Queue: Ben Konyi <bkonyi@google.com >
2022-01-26 21:16:49 +00:00
e557fef27d
[ CLI ] Fix incorrect string in smoke_test.dart
...
Change-Id: Ic60b0010d97b138c6afaa2d3606f4e41598fc41b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/229120
Reviewed-by: Ben Konyi <bkonyi@google.com >
Commit-Queue: Ben Konyi <bkonyi@google.com >
2022-01-20 04:33:26 +00:00
0c2079561b
[ DDS ] Handle case where requested DDS port is already in use
...
Instead of hanging with no output to the console, a useful error message
is output to the console before shutting down the VM process.
Fixes https://github.com/dart-lang/sdk/issues/48160
Change-Id: Ib37c0cdf8b1bae6f164abff4a3b3100e944d8a3c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/228961
Reviewed-by: Ryan Macnak <rmacnak@google.com >
Commit-Queue: Ben Konyi <bkonyi@google.com >
2022-01-19 22:43:37 +00:00
dd35db6192
"master->main" migration
...
Change-Id: I773e0a60a782f9e6678cea22e2a7d8fae48cffa3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/212869
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Phil Quitslund <pquitslund@google.com >
2021-09-09 18:14:36 +00:00
70a3627d57
Update dartdev smoke tests for Dart version 2.12
...
I also took the time to
- add the smoke tests to the dartdev test_all.dart file
- change the order of the asserts to fail fast and with better messages if there are failures
Bug: https://github.com/dart-lang/sdk/issues/43842
Change-Id: Ic35e52145bf3f9d6871dcec07395966a02ca3d11
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/168761
Reviewed-by: Leaf Petersen <leafp@google.com >
Commit-Queue: Jaime Wren <jwren@google.com >
2020-10-21 20:06:54 +00:00
da2bff9c96
update the dartdev pubspec file; various lint fixes
...
Change-Id: Ib4bc6af7f77001895cbc534ef64c6d999008695f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/159160
Reviewed-by: Jaime Wren <jwren@google.com >
Commit-Queue: Devon Carew <devoncarew@google.com >
2020-08-18 17:12:45 +00:00
9bac327e32
[ VM / dartdev ] Fix issue where hard-coded false value for 'null_safety' flag in dartdev's Dart_IsolateFlags
...
was overwritten by isolate initialization code
Fixes situation where the following command would fail due to the
dartdev kernel not being compiled with null-safety:
dart --strong-null-safety --enable-experiment=non-nullable run foo.dart
Change-Id: I7e7c980eb3274a51e64c031e6bfef8650b897b8b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/158345
Reviewed-by: Alexander Markov <alexmarkov@google.com >
Commit-Queue: Ben Konyi <bkonyi@google.com >
2020-08-13 22:04:24 +00:00
cb6ed67a73
[ VM ] Fix issue where dartdev's script_uri was being freed prematurely
...
This was causing flaky failures when initializing DDS as it was invoking
the getVM RPC which in turn sometimes accessed the script_uri after it
had been freed.
Change-Id: I4454b6fa2da3ad6767938ed12b1013223a667af7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/155740
Commit-Queue: Ben Konyi <bkonyi@google.com >
Reviewed-by: Siva Annamalai <asiva@google.com >
2020-07-27 19:11:53 +00:00
Janice Collins