545ee13cd4
[dart2js] Clean up usages of 'new' keyword.
...
Change-Id: I193e19581d29a9c4b343ae0a681d1ff530cfce1d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/281309
Commit-Queue: Nate Biggs <natebiggs@google.com >
Reviewed-by: Mayank Patke <fishythefish@google.com >
2023-02-14 02:36:38 +00:00
959b8db302
[dart2js] Migrate test/optimization for null safety migration.
...
Change-Id: I0dba89a8b26dff3cba5116aefd77c6c5f7b772f8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/279582
Reviewed-by: Mayank Patke <fishythefish@google.com >
2023-01-24 05:10:28 +00:00
3ed70b013b
[dart2js] Remove JClosedWorld interface and use only implementer, JsClosedWorld, everywhere.
...
Change-Id: I9641033aa3a93a28ee428ddc63aa7fc337e5468a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/267802
Reviewed-by: Sigmund Cherem <sigmund@google.com >
2022-11-04 15:11:27 +00:00
8a883fa54d
Change : to = for default values in pkg.
...
Leaves some in parser test:
pkg/front_end/parser_testcases/error_recovery/keyword_named_formal_parameter_prime.dart
TEST=Refactoring, covered by existing tests.
Change-Id: I7a83ef95df3cbd283878b3685b5c747bd89a1b16
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/256125
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Commit-Queue: Lasse Nielsen <lrn@google.com >
2022-08-24 15:57:16 +00:00
6384eceedc
[dart2js] Late instance field optimizations
...
Late fields start out holding a sentinel value and after they are initialized or assigned, never hold a sentinel value again.
This CL implements some removal of checks and loads based on this monotonic behaviour.
On two large Dart Angular apps, this reduces the number of late-instance-field checks by ~25%.
One app is 0.44% smaller, the other is 0.98% smaller.
The optimization_test.dart no longer forces `--disable-inlining` because that prevents the inlining that exposes the optimization opportunities.
Most tests already use `@pragma('dart2js:noInline')` to prevent inlining where relevant.
Change-Id: I2327a96e69191313ed6c07eabe94aa2962fb2648
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/246881
Reviewed-by: Joshua Litt <joshualitt@google.com >
Commit-Queue: Stephen Adams <sra@google.com >
Reviewed-by: Sigmund Cherem <sigmund@google.com >
2022-06-07 05:57:59 +00:00
70533ae7fa
pkg:compiler - enable and fix prefer_final_fields lint
...
Change-Id: I042f6047c2c10490121398027489217c6291425d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/211622
Auto-Submit: Kevin Moore <kevmoo@google.com >
Commit-Queue: Kevin Moore <kevmoo@google.com >
Reviewed-by: Stephen Adams <sra@google.com >
2021-09-24 21:37:39 +00:00
c260f251a7
Remove redundant imports from compiler
...
In many files, there is a redundancy in importing
import 'package:compiler/src/common.dart'
and
import 'package:compiler/src/diagnostics/diagnostic_listener.dart'
I chose to remove the latter import.
Bug: https://github.com/dart-lang/sdk/issues/44569
Change-Id: Ia6c871080bf2d7c637694a4fe5cb1b84e540b789
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/213851
Reviewed-by: Mayank Patke <fishythefish@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2021-09-20 19:14:33 +00:00
3ec6a72b93
[dart2js] Cleanup triple-shift flags
...
Bug: 45335
Change-Id: I4fc2f970884439d9e4f0957dd4f756c13511306a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/196560
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Commit-Queue: Stephen Adams <sra@google.com >
2021-04-24 18:55:12 +00:00
39aa454e7b
[dart2js] Implement int.>>> optimizations
...
Change-Id: I7d54bc523bb81c5ae8d6fed4ec2e6df473206788
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/187340
Commit-Queue: Stephen Adams <sra@google.com >
Reviewed-by: Joshua Litt <joshualitt@google.com >
2021-03-09 02:20:06 +00:00
20faaa5d94
[dart2js] Move dart2js unit tests to pkg/compiler/test.
...
Change-Id: Ib18f554c1076f27a3f7c0df5a36410da41a1f467
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148784
Reviewed-by: Paul Berry <paulberry@google.com >
Reviewed-by: Sigmund Cherem <sigmund@google.com >
2020-05-28 18:51:11 +00:00
Nate Biggs