aad9e57674
Revert "Revert "[analyzer] new warning for nullable '==' parameter type""
...
This reverts commit 885457e1d3https://github.com/dart-lang/linter/issues/3441
Replaces https://github.com/dart-lang/linter/pull/3923
Change-Id: Ic0be2bfebaf59b0336e9a3a58e5b7f5359eb8646
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/291042
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Stephen Adams <sra@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2023-12-14 23:58:12 +00:00
069e617ef4
[analyzer/ffi] Fix Unwrap typed data error messages
...
Fixes issues reported by:
TEST=pkg/analyzer/test/verify_diagnostics_test.dart
* Fixes error messages on asFunction.
* Fixes validation by introducing Uint8List to mock sdk.
* Removes unused typed_data import in example snippet.
* Fixes error locations in example snippets
Bug: https://github.com/dart-lang/sdk/issues/44589
Change-Id: I82261eea5e55cbafa686865a92131a449a7642f5
Cq-Include-Trybots: luci.dart.try:pkg-linux-debug-try,pkg-linux-release-try,pkg-mac-release-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/340921
Commit-Queue: Daco Harkes <dacoharkes@google.com >
Reviewed-by: Martin Kustermann <kustermann@google.com >
2023-12-12 14:32:57 +00:00
6ea4aa3070
Docs for additional extension type diagnostics
...
I think these are the last of the diagnostics added for extension types.
Change-Id: I86744f8cab2683c5c6fb18a59e92a9c0ab7ff672
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/338582
Reviewed-by: Marya Belanger <mbelanger@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2023-12-07 01:23:12 +00:00
3b648e4635
analyzer: Support more complex flutter assets declarations
...
Fixes https://github.com/dart-lang/sdk/issues/54038
The main feature is a small expansion to what is allowed in the `flutter / assets` field. We used to enforce that the `assets` field is a list, and that each value is a string. Now we enforce that:
* the `assets` field is a list
* an asset is either a string, or
* an asset is a map, with at least a 'path' key, with a string value.
This requires deprecating the `ASSET_NOT_STRING` code, and introducing
three others:
* ASSET_MISSING_PATH
* ASSET_NOT_STRING_OR_MAP
* ASSET_PATH_NOT_STRING
In addition I cleaned up a UX issue: Several codes referenced an 'asset' key, but it should be 'assets'. (In addition, the `ASSET_FIELD_NOT_LIST` code should be `ASSETS_FIELD_NOT_LIST` but I did not fix that.)
I also refactored all of the code to be more modern:
* Use `var` instead of types in declarations
* Short circuit error-and-return with `if (foo is! YamlMap)`. We didn't use to have promotion here, but this led to a wild amount of nesting (if, if, for, if, if, else, if!).
Change-Id: Ia489ea631f7d1027fdb84a9a682c831752c5835c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/338593
Reviewed-by: Marya Belanger <mbelanger@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2023-12-04 21:10:31 +00:00
d91f3a113e
Add diagnostic docs for extension types
...
I'm fairly sure there will be other diagnostics added later, so this
isn't everything, but it covers the diagnostics that are currently
implemented in the analyzer.
Change-Id: I27100c9a76e6db4fb2b0bf8b9bc6b0b2c326707f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/322442
Reviewed-by: Marya Belanger <mbelanger@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2023-11-28 06:09:10 +00:00
2f30295254
[analyzer] Correct invalid_dependency diagnostic message
...
Fixes https://github.com/dart-lang/sdk/issues/53217
Bug: https://github.com/dart-lang/sdk/issues/53217
Change-Id: I2b802adda2ff6403d279dc2f6cffc36f6f8047d1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/337302
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Marya Belanger <mbelanger@google.com >
Auto-Submit: Parker Lougheed <parlough@gmail.com >
Reviewed-by: Marya Belanger <mbelanger@google.com >
2023-11-21 18:46:06 +00:00
df4ef72c01
[vm/ffi] Remove deprecated FfiNative
...
TEST=pkg/analyzer/test/
TEST=CI build with class removed from `dart:ffi`
Closes: https://github.com/dart-lang/sdk/issues/53923
CoreLibraryReviewExempt: VM & dart2wasm only.
Change-Id: I45a39b623754f9f1b65cac55ea9adae390199f5d
Cq-Include-Trybots: luci.dart.try:vm-ffi-android-debug-arm64c-try,analyzer-analysis-server-linux-try,analyzer-mac-release-try,dart-sdk-linux-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/336960
Reviewed-by: Martin Kustermann <kustermann@google.com >
Commit-Queue: Daco Harkes <dacoharkes@google.com >
2023-11-20 13:16:28 +00:00
326cf03995
[analyzer/ffi] Fix error message
...
Closes: https://github.com/dart-lang/sdk/issues/54036
Change-Id: I273822e044efdb5829f81cfb8a8ed17a34680280
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/336040
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Auto-Submit: Daco Harkes <dacoharkes@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2023-11-14 17:03:28 +00:00
6137e93241
Extension type. Issue 53930. Report BUILT_IN_IDENTIFIER_AS_EXTENSION_TYPE_NAME.
...
Bug: https://github.com/dart-lang/sdk/issues/53930
Change-Id: Ibf88b678cc45147f308de68614d6d127323b822a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/333600
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2023-11-03 23:17:30 +00:00
c31be01bbe
Improve message when generating error ARGUMENT_TYPE_NOT_ASSIGNABLE for records.
...
Fixes BUG: #53580
Change-Id: I4c5a7b5147875ced2319ba36a396067a5ce1a657
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/330668
Commit-Queue: Keerti Parthasarathy <keertip@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
2023-10-18 17:56:49 +00:00
5c9c383224
[analyzer] Mark 'MISSING_DEPENDENCY' diagnostic as having published docs
...
Also makes a few copy improvements.
Published docs: https://dart.dev/tools/diagnostic-messages#missing_dependency
Change-Id: Ifdf79b609b2e6ff1c3c8044dbfae2b2cee1a91f4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/329840
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Keerti Parthasarathy <keertip@google.com >
Reviewed-by: Keerti Parthasarathy <keertip@google.com >
2023-10-09 21:42:26 +00:00
3263977c48
Add a validator for missing dependencies in pubspec file.
...
Change-Id: Ief1986d4eb5a8095ea6a21d81239e6dd08b9a0b2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/326260
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Keerti Parthasarathy <keertip@google.com >
2023-09-29 15:01:05 +00:00
742ba5c20d
[analyzer] Change the const evaluation result of variables to be Constant.
...
We rely on the result of the `ConstantVisitor` to indicate whether we have an error or a valid constant value.
This CL changes `evaluationResult` to be a `Constant` and changes error reporting to occur at a POE for evaluating a constant.
Last few chunks of cleaning up the constant evaluator, woo!
Change-Id: Icd41a4fcbab0626df36c6a83cd60ecbb59c2dcf0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/324573
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Lasse Nielsen <lrn@google.com >
Commit-Queue: Kallen Tu <kallentu@google.com >
2023-09-22 16:13:10 +00:00
304cdc951f
[analyzer] Update INVALID_REFERENCE_TO_THIS docs to match spec
...
I tried my best to match terminology with other existing diagnostic docs.
Fixes https://github.com/dart-lang/site-www/issues/5172
Change-Id: I8c59bcdd6b0e9315dd35e120e3a9536d7a6c9930
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/325923
Reviewed-by: Marya Belanger <mbelanger@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2023-09-19 15:10:39 +00:00
e8d7425c4e
[vm/ffi] Closure callbacks for sync callbacks
...
Bug: https://github.com/dart-lang/sdk/issues/52689
Change-Id: I54be397cfbf8519fe5b5a51b793fe46d602124d9
Fixes: https://github.com/dart-lang/sdk/issues/52689
Bug: https://github.com/dart-lang/sdk/issues/53096
TEST=isolate_local_function_callbacks_test.dart, plus generated tests and additions to existing tests
CoreLibraryReviewExempt: The isolate and FFI packages are VM-only
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/317060
Commit-Queue: Liam Appelbe <liama@google.com >
Reviewed-by: Liam Appelbe <liama@google.com >
Reviewed-by: Martin Kustermann <kustermann@google.com >
Reviewed-by: Daco Harkes <dacoharkes@google.com >
2023-08-25 03:35:44 +00:00
d2bae29d84
[analyzer] Enable highlighting in docs for yaml diagnostics
...
Change-Id: Ifc0cf843603547c586c7d0d43828b56a3e8d5114
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/320720
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2023-08-14 22:35:05 +00:00
0140ecd9dd
[analyzer] Clarify obsolete colon separator diagnostic messaging
...
Clarify that the diagnostic applies to optional named parameters, that support is already removed, and showcase the symbols themselves for extra clarity.
Change-Id: I0920793452bb8b0aaba04cbc96e89bb8acd571c0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/320442
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2023-08-14 16:44:03 +00:00
083b3e5150
Update the generated diagnostic docs
...
This should fix one of the issues turning the bots red.
Change-Id: I5729e1f4cb8dd12b33391113166581d5d6618e67
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/320260
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2023-08-11 22:55:35 +00:00
6f127b2b47
[analyzer] Update list of unverified docs
...
No longer marks a few error codes as unverified if the issue no longer exists or an adjustment of the offset/length was needed.
Change-Id: I78aa557dcffeafb5c3af40b978fa23ba0bc93a0b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/319640
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Kallen Tu <kallentu@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2023-08-10 20:21:08 +00:00
061396f38d
[analyzer] Add back removed diagnostic messages
...
It adds them back and specifies `removedIn: "3.2"` to prevent generation of error codes.
Fixes https://github.com/dart-lang/sdk/issues/53120
Bug: https://github.com/dart-lang/sdk/issues/53120
Change-Id: Icc6e861f317b582d15d463867f08ba70ffee9f2b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/319382
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2023-08-09 16:53:36 +00:00
401fa6130f
[analyzer] Mark diagnostics as published and fix spelling mistakes
...
Change-Id: Ib9bc435b88611724cf0527d942990991ecf8d024
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/319340
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2023-08-09 15:16:03 +00:00
1b8870bbb1
[analyzer] Don't generate error codes for removed diagnostics
...
Also renames 'removed' to 'removedIn' to better indicate it is looking for a version, not a boolean.
Change-Id: If3a6708ba32460305e89ba59c4a58ce2ad284e6a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/319282
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2023-08-09 04:08:23 +00:00
5c9b4ed2cb
[analyzer] Remove support for pre-const-update-2018 code
...
Dart 3's minimum language version is 2.12. google3's is 2.9.
Change-Id: Icd892b0fcec7f2ce9fa813a108519c0bbbd29a52
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/317040
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2023-08-01 21:31:52 +00:00
1a4c889fbc
Fix verify_diagnostics_test, #53020
...
Change-Id: Ida68ed3995c4db9be34fa0ce90b6683fc826f8a6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/315822
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Auto-Submit: Jonas Jensen <jonasfj@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
2023-07-31 16:42:29 +00:00
415ff8ece8
[analyzer] Remove all checks for set-literal and extensions enablement
...
And using Future from dart:core, which was not enabled until Dart
2.1.0.
Dart 3's minimum language version is 2.12. google3's is 2.9.
Change-Id: Id31d92007e685447ff217bdccf8161c8fd6ce6e7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/316863
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2023-07-30 00:12:59 +00:00
ab8736cf7c
[analyzer] Remove all checks for ui-as-code enablement
...
Dart 3's minimum language version is 2.12. google3's is 2.9.
Change-Id: I8303b14de17b695e835cf9f8018f08731b51ec35
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/316526
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2023-07-27 02:43:38 +00:00
008cb0bbc1
Revert "Separate out UNUSED_ELEMENT_PARAMETER from UNUSED_ELEMENT"
...
This reverts commit a458bab09ahttps://github.com/flutter/flutter/issues/131096
Original change's description:
> Separate out UNUSED_ELEMENT_PARAMETER from UNUSED_ELEMENT
>
> Fixes https://github.com/dart-lang/sdk/issues/49025
>
> Change-Id: I401093e5b76bcf707060ce022c346e26c6807aa0
> Tested: try-bots
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/303261
> Commit-Queue: Samuel Rawlins <srawlins@google.com >
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
> Reviewed-by: Ben Konyi <bkonyi@google.com >
> Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Change-Id: Ib0c9afc4911efd620013896fb895ab7825c50aa4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/315940
Commit-Queue: Siva Annamalai <asiva@google.com >
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Siva Annamalai <asiva@google.com >
2023-07-24 16:25:07 +00:00
c77b7a6eda
Add diagnostics for platforms key in pubspec.yaml.
...
**Context:**
The `platforms` field is used to indicate what platforms are supported
by a given package. It's only relevant when publishing to pub.dev, or
similar package repository. If no `platforms` fields is supplied the
platforms will be detected based on `import` statements, also accounting
for conditional imports. See [pubspec reference][1] for details.
These diagnostics aim to help developers discover a misconfigured
`platforms` fields, which they would otherwise only discover when
publishing to [pub.dev][2].
[1]: https://dart.dev/tools/pub/pubspec#platforms
[2]: https://pub.dev
Change-Id: I7b9ea5e371bb1cce6410d32fe6f38c49bc2ff69e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/309661
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Marya Belanger <mbelanger@google.com >
Commit-Queue: Jonas Jensen <jonasfj@google.com >
Reviewed-by: Phil Quitslund <pquitslund@google.com >
2023-07-21 12:04:19 +00:00
a458bab09a
Separate out UNUSED_ELEMENT_PARAMETER from UNUSED_ELEMENT
...
Fixes https://github.com/dart-lang/sdk/issues/49025
Change-Id: I401093e5b76bcf707060ce022c346e26c6807aa0
Tested: try-bots
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/303261
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Ben Konyi <bkonyi@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2023-07-20 18:33:58 +00:00
eae32a7e92
Fix link and missing new line in generate.dart
...
Added a new line to _writeGlossary before the contents, because otherwise it was generating in the line directly below the contents of _writeHeader, and therefore not rendering properly. I also updated the link to [Customizing static analysis] as that changed recently and I've had to manually update it in the site-www doc version a couple times now.
Change-Id: I8c5d3d9adcc0004fc8d84d11935860617e7c2bfd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/314520
Commit-Queue: Marya Belanger <mbelanger@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2023-07-18 22:47:01 +00:00
6b1c969ac5
Update glossary links and remove content from generated page.
...
I added the entries to dart.dev/resources/glossary in site-www/#5066.
I was only able to test whether the links worked by putting them in the same place in the diagnostics markdown on site-www, which worked. So, I think the way I did it in generate.dart should work but if anyone knows otherwise please let me know!
There were also a couple small changes from my last CL on the diagnostic messages that I didn't get in before merging, so those are in here too (https://dart-review.googlesource.com/c/sdk/+/309780 ).
Change-Id: Ie5561fa72c7f99f5c86d2112294edccee41d4544
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/313960
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Marya Belanger <mbelanger@google.com >
2023-07-17 21:22:42 +00:00
7918525a6b
Writing review 3.0 diagnostics
...
Minor changes to last few 3.0 diagnostic message changes (late follow up). Mostly just a practice CL for me, after setting my sdk environment up for the first time.
Fixes https://github.com/dart-lang/site-www/issues/4740
Change-Id: I8f6871a270089627538928dd95bcbf38a29b74e7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/309780
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Marya Belanger <mbelanger@google.com >
2023-07-14 18:31:31 +00:00
c86af3c39b
[analyzer] Refactor visitMethodInvocation in the const evaluator.
...
Change-Id: I9ae6c17967c98770ed06dead200c8bd87ae7f2a9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/309829
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Kallen Tu <kallentu@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2023-06-30 18:32:27 +00:00
13ec07415b
[vm] Async FFI callbacks
...
More details about the design:
https://docs.google.com/document/d/1QDjyY_6wOTOgURwpeYMKU9qEz0gKxx2MUrdruC6Kp6c/edit?usp=sharing
Change-Id: Ie3985d86dca7f5010044ca46c33ca177588c0f69
Bug: #37022
CoreLibraryReviewExempt: Reviewed by vm and api groups. web and wasm groups not affected because FFI isn't on those platforms.
TEST=async_void_function_callbacks_test.dart, ffi_callback_metadata_test.cc, other front end tests
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/305900
Commit-Queue: Liam Appelbe <liama@google.com >
Reviewed-by: Alexander Markov <alexmarkov@google.com >
Reviewed-by: Lasse Nielsen <lrn@google.com >
Reviewed-by: Daco Harkes <dacoharkes@google.com >
Reviewed-by: Martin Kustermann <kustermann@google.com >
Reviewed-by: Ryan Macnak <rmacnak@google.com >
2023-06-28 01:00:18 +00:00
5200d086d1
[pkg/analyzer] Add class to diagnostic messages for special highlighting
...
Will be used on dart.dev for customizing the highlight syntax in code blocks to be red underlines rather than yellow highlighting.
Related: https://github.com/dart-lang/site-www/pull/5006
Change-Id: Ib33ee8f6f7307efb649b627dfd9a5d90187cca1a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/311500
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2023-06-26 19:58:56 +00:00
583da435e9
[analyzer] Support for RawVoidCallbacks
...
Pointer.fromFunction returns a native function pointer to a Dart
function, but has the restriction that the native code must invoke it
on the same thread as the isolate that created it. RawVoidCallbacks is
a new API that is similar to Pointer.fromFunction. It returns a native
function pointer that can be invoked on any thread, with the
restriction that the Dart function must return void. Under the hood we
forward the function args over a port to the target isolate.
We're not 100% settled on the name of the class, but the overall API
design won't change. I'll make sure to get the naming finalized before
submitting this CL. Doc with discussion of naming:
https://docs.google.com/document/d/1z9Rgahoid2AhC9JXwsDAEODvlJS6dvBHCbcGkOxv_ws/edit?resourcekey=0-TbdNiSL-fdwskla02QaPwg#heading=h.te70ikwelbw8
Bug: https://github.com/dart-lang/sdk/issues/37022
Change-Id: Iba98f6f803c52919b942fa054df1060991574c8c
TEST=ffi_async_callback_test.dart
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/308860
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Liam Appelbe <liama@google.com >
Reviewed-by: Marya Belanger <mbelanger@google.com >
Reviewed-by: Daco Harkes <dacoharkes@google.com >
2023-06-18 23:28:52 +00:00
b80d5479c1
[analyzer] Change error message for mixin subtypes of final and base types.
...
Add new diagnostics for mixin subtypes since they can only be 'base'.
Bug: https://github.com/dart-lang/sdk/issues/52686
Change-Id: I8e4d6830c5c735c5b42d7fbe78d197c9506bbf4c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/308806
Commit-Queue: Kallen Tu <kallentu@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2023-06-13 16:00:21 +00:00
4079a47cc4
[analyzer] Introduce a new annotation @visibleOutsideTemplate
...
The new annotation is intended to be used on members of class, enum or mixin to opt out the @visibleForTemplate visibility restriction cascaded from class- / enum- / mixin- level.
1. Throw warning if the annotation is added to a invalid target.
2. Update @visibleForTemplate diagnostics logic to opt out members annotated with @visibleOutsideTemplate.
Change-Id: Iec546fc7785cd45f39a1b2a2cc8849ef1cf9d04a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/304825
Reviewed-by: Marya Belanger <mbelanger@google.com >
Auto-Submit: Ludi Zhan <ludizhan@google.com >
Commit-Queue: Ludi Zhan <ludizhan@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
2023-06-08 18:47:15 +00:00
deddb64ff7
[pkg/analyzer] Fix meta annotation links in diagnostic messages
...
Bug: https://github.com/dart-lang/site-www/issues/4901
Change-Id: I238d9508984846c4bbe2bb1b23eb2b12fd262ed8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/304260
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2023-05-18 00:55:53 +00:00
a071769acc
Improve error message for async return type
...
fixes #33424
Bug: 33424
Change-Id: I8a0b7fb356ded813bf8736f6e52ccd365987e148
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/302846
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Keerti Parthasarathy <keertip@google.com >
2023-05-11 23:13:27 +00:00
40d99bc981
[cfe] Remove extra conditions on await-for in non-async body check
...
Additionally, report the error on the 'await' keyword instead of 'in'
Change-Id: I0ccd156f19997eb18b5df004a75f86e616b23864
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/301021
Commit-Queue: Chloe Stefantsova <cstefantsova@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
2023-05-09 06:56:44 +00:00
199feac353
[analyzer/cfe] Update abstract sealed error message.
...
State more explicitly that sealed classes are abstract and lead the
user to a better fix with the error message.
Bug: https://github.com/dart-lang/sdk/issues/52073
Change-Id: Id24c6cb187ee5497ca2819f930c48ff5aa8d07fc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/296025
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Kallen Tu <kallentu@google.com >
2023-04-20 19:54:30 +00:00
1eecd779c3
Add documentation for a last minute diagnostic
...
Change-Id: I798269bcfad348ec763abb23b553f3d4dae3af69
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/293383
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2023-04-05 03:21:09 +00:00
d47cd99310
Report NOT_NAMED_FIELD_IN_OBJECT_PATTERN
...
Change-Id: Iea58d3cef38c07f5fbac0dcbc8984ea727ffd93e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/293441
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2023-04-04 21:36:38 +00:00
5518abf1c7
[_fe_analyzer_shared] Update non-exhaustive message
...
This updates the message report for non-exhaustive switch statements
and expressions to include the witness in the problem message and
a reduced witness, which doesn't include properties that fully cover the
static type. The message is also split into two messages; one for
switch statements and one for switch expressions, allowing for a
better wording regarding the default/wildcard pattern case.
Change-Id: I17db657ef12ade5d47fa96bf69b8807e33ed5b8c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/293040
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Johnni Winther <johnniwinther@google.com >
2023-04-04 09:44:59 +00:00
db0dfec609
Issue 51893. Report PATTERN_NEVER_MATCHES_VALUE_TYPE in some cases.
...
Bug: https://github.com/dart-lang/sdk/issues/51893
Change-Id: Ia7582df3942a077e81f0343e83359c303d152b1b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/292420
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2023-04-03 20:31:45 +00:00
1ec1e7358a
Changes for map pattern: report an error for rest elements, empty map pattern.
...
Bug: https://github.com/dart-lang/language/issues/2861
Change-Id: I00ccb3ea03aa476f96c2ecf3e3a9e13bd4926193
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/291940
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Reviewed-by: Marya Belanger <mbelanger@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2023-03-30 17:54:06 +00:00
f7bc72fce6
[analyzer/cfe] Remove interface mixin, final mixin and sealed mixin.
...
Added error messages for when users try to use invalid mixins + a language test that tests that (and tests in each of the front ends).
Removed the tokens from the parser listeners.
Removed all behaviours and error reporting related to these invalid mixins.
Change-Id: I558595826dae7e2c176bd1929e97caa2335c167c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/290614
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Kallen Tu <kallentu@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
2023-03-30 11:56:08 +00:00
e0ab0d1be5
[analyzer] Report error when sealed or final used in on type outside of library.
...
Also, when using a final class in an on clause outside of its library, we don't produce a base/final subtype error.
Change-Id: I6600bc136ca37e98f9698c604214a6c565d6a9af
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/290263
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Kallen Tu <kallentu@google.com >
2023-03-27 22:33:29 +00:00
4e29f0b339
Add documentation for two more diagnostics
...
Also adds a dropped link target so that we don't break existing users.
Change-Id: I98e5e9fe2e51730150acfab889245a7b9f6b11d3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/290180
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2023-03-24 17:36:28 +00:00
Sam Rawlins