dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
98,756 Commits 2 Branches 0 Tags
c84edaefe9e457e9cc975c050019479b2d94dea2
Commit Graph

499 Commits

Author SHA1 Message Date
Parker Lougheed 2c8721550a [analyzer] Add dependency override for linter in analyzer 
This allows me to use IntelliJ's built in testing support when working on the analyzer.

Change-Id: Ie7c072b06d0eeaf2be10433604519714fe79a01e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/339020
Auto-Submit: Parker Lougheed <parlough@gmail.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
 2023-11-29 19:33:01 +00:00
Paul Berry ba42706e66 Begin developing code for "Wolf analysis". 
Wolf analysis is an experimental part of the analyzer that I intend to
use as the basis for new, more advanced, lint rules and other
analyses. Its first phase will consist of lowering the abstract syntax
of each function or method to a stream of instructions for a minimal
stack machine.

This code implements the first few instructions for the minimal stack
machine (`function`, `end`, `literal`, and `drop`). These are
sufficient to express a simple function like:

    int f() => 0;

Which maps to the following instruction stream:

    function(int Function(), 0)
    literal(0)
    end

This code includes a validator that verifies that an instruction
stream is well-formed. In follow-up CLs I will add logic to convert an
analyzer AST to an instruction stream.

The internal representation of an instruction stream is code
genreated, because:

- I intend to add additional instructions in follow-up CLs, and I
  don't want to have to remember all the boilerplate for adding an
  instruction each time.

- Once the implementation is far enough along to start consuming large
  amounts of real-world Dart code, I would like to be able to
  investigate the performance effects of changing the internal
  representation. Code generation will make this a lot easier.

Change-Id: I4bc299d31ed108f6eebf9cca913d1484dbc9a3cf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/334644
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
 2023-11-08 17:50:43 +00:00
Konstantin Shcheglov e4cae77332 Prepare to publish analyzer 6.3.0 and _fe_analyzer_shared 65.0.0 
Change-Id: I0346ec75f93f55c6c9d6ebdcd34878aa2b414173
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/330026
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2023-10-11 14:44:31 +00:00
Konstantin Shcheglov b7d3c47d13 Adds benchmark measuring memory consumption of live objects after analyzing flutter. 
Will warm up the memory cache and then measure how much live memory the analyzer consumes after visiting all elements with the warmed up cache.

All results
--------------------------------
flutter_elements
  reachableObjects
    count: 9071480
    size: 799672175 = 780929 KB = 762 MB
  _SimpleUri
    count: 3112
    size(shallow): 248960 = 243 KB
    duplicateCount: 0

Change-Id: I75209f88f6f615172127cd439afe9d0cd83b1c4f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/329682
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2023-10-10 17:54:08 +00:00
Konstantin Shcheglov b9c1578737 Prepare to publish analyzer 6.2.0 and _fe_analyzer_shared 64.0.0 
Change-Id: I02474a58dabd12ea9a4d5a0f2dca8d3de49f35f4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/320680
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2023-08-14 20:32:30 +00:00
Konstantin Shcheglov 319eb24e1e Prepare to publish analyzer 6.1.0 and _fe_analyzer_shared 63.0.0 
Bug: https://github.com/dart-lang/sdk/issues/53084
Change-Id: Id3143e4d2ffd7795a5c36c69d1e6c62d4ee7c65c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/318460
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
 2023-08-04 22:34:59 +00:00
Konstantin Shcheglov d264ceeb05 Add InstanceElement as a super-interface for InterfaceElement and InlineClassElement. 
Change-Id: Ie92168509cccb5b145bc5c9adea2945813725038
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/311721
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2023-06-28 00:56:05 +00:00
Konstantin Shcheglov 5940badbd3 Prepare to publish analyzer 6.0.0 and _fe_analyzer_shared 62.0.0 
Change-Id: Ic816540e8b052fdd1fd59f030c334c3bf56e79f9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/310961
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2023-06-22 19:00:56 +00:00
Konstantin Shcheglov 21cfe2ce61 Breaking changes for analyzer version 6.0.0 
Change-Id: I792c3d66fb10ab779e2a5011b2909efa5738aba7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/265183
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2023-06-16 16:31:27 +00:00
Konstantin Shcheglov 645587bc70 Issue 52486. Fix LinterContext.resolveNameInScope() in SwitchExpression cases. 
Bug: https://github.com/dart-lang/sdk/issues/52486
Change-Id: I7d00ed03f8da37e7adb2959a62acefbd1904770a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/305060
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2023-05-23 19:19:38 +00:00
Konstantin Shcheglov d85aa126e3 Require SDK 3.0.0 for analyzer/. 
Change-Id: I9e787930d2101b39808c44d2e7bd537337ac3855
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/304286
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2023-05-22 20:51:40 +00:00
Konstantin Shcheglov efe0ca193f Prepare to publish analyzer 5.13.0 and _fe_analyzer_shared 61.0.0 
Change-Id: Ic1402c8a003573a0861c9a907c0a14e9b95f4859
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/304561
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2023-05-19 21:11:29 +00:00
Konstantin Shcheglov 4f77ddf8ce Start 5.13.0-dev, update CHANGELOG.md 
There is a demand for a new analyzer version.
https://github.com/dart-lang/sdk/issues/52352#issuecomment-1546214969

I'm not ready to publish yet, lets wait for a couple of days after
landing `InvalidType`. But I'd like to record issues fixed.

Change-Id: I045ba904e3a229939fca5e37d63f16624cff8872
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/303012
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2023-05-12 23:09:28 +00:00
Konstantin Shcheglov 4a62426d1d Prepare to publish analyzer 5.12.0 and _fe_analyzer_shared 60.0.0 
Change-Id: Iea968efec63034ed3830dbc46ad0a29158dd9fcb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/302363
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2023-05-09 23:35:48 +00:00
Konstantin Shcheglov ec330b47de Deprecate 'DartType.isDynamic', use 'is DynamicType' instead. 
Change-Id: Ia3660a0d38f01a590dd3e034f40dbdb5a432638a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/300042
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2023-05-01 16:09:08 +00:00
Konstantin Shcheglov 34c18da5eb Prepare to publish analyzer 5.11.1 and _fe_analyzer_shared 59.0.0 
Bug: https://github.com/dart-lang/sdk/issues/52159
Change-Id: Ia603e77694d11af1045a94bdf00468d02eb5f6af
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/297980
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2023-04-25 01:15:05 +00:00
Konstantin Shcheglov 82cffbb38b Prepare to publish analyzer 5.11.0 and _fe_analyzer_shared 59.0.0 
Change-Id: I1d841f7c12698e56bd99ed109e58795172499ed1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/297842
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2023-04-24 22:08:12 +00:00
Konstantin Shcheglov cef5bcb602 Remove '@experimental' from declarations related to records and patterns. 
Change-Id: I4db54e3097c343ec72e041f78df2b38b1835853e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/296061
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2023-04-19 00:51:58 +00:00
Paul Berry eee509140d Add dependency overrides for pkg/analyzer 
These dependency overrides prevent pub from getting confused about the
fact that our SDK development is in a mono-repo; that in turn allows
unit tests to be run from inside vscode using the standard test
integration.

Change-Id: Ica94f0a49d8c79f6a1f6395707b02d36da20089d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/295661
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2023-04-17 19:27:27 +00:00
Konstantin Shcheglov 6ef15e48bb Prepare to publish analyzer 5.10.0 and _fe_analyzer_shared 58.0.0 
Change-Id: Ia298440a6d4a07fa777fe182c64cf0bb830d31ed
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/290910
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2023-03-24 02:39:22 +00:00
Konstantin Shcheglov 56a43c0867 Add 'DartType.isDartCoreType' 
Change-Id: Ifd72be0e0e70e0d48f0f0ff8d2afa2102ef2d6ca
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/290707
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2023-03-23 16:02:13 +00:00
Konstantin Shcheglov 62cfd07b52 Prepare to publish analyzer 5.9.0 and _fe_analyzer_shared 57.0.0 
Change-Id: Id583c0f5e0a9c2afb5af719a4d6964d8bdfd2346
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/290342
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2023-03-22 00:36:06 +00:00
Konstantin Shcheglov 38a2a91eaa Deprecate FunctionBody.isPotentiallyMutatedInClosure 
Change-Id: I992ad2fbb91509a02c88f6842b72bc9c60e9e891
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/290182
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2023-03-21 20:45:08 +00:00
Konstantin Shcheglov 771042f5ca Prepare to publish analyzer 5.8.0 and _fe_analyzer_shared 56.0.0 
Change-Id: I09c65e9897fb8fe77c668fac8044da9b73b0f41a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/289441
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2023-03-17 16:36:59 +00:00
Konstantin Shcheglov 5ecf6db857 Deprecate 'DartType.isVoid', use 'is VoidType' instead. 
Maybe? With an explicit type check we don't try to make an impression
that anything more happens here, e.g. for type parameters.

Similarly, for https://github.com/dart-lang/sdk/issues/36697 we would need to introduce `InvalidType`, which is not `DynamicType`. And so, `DartType.isDynamic` should not return `true` for `InvalidType`, it is not a property that various types may have, and should be replaced with explicit `is DynamicType`.

We also have `UnknownInferredType`, but it should never leak to clients.

Change-Id: I302b06355143d97bb52922c805dbad585a522e0a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/288340
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2023-03-14 18:50:33 +00:00
Konstantin Shcheglov bdd9535b4e Prepare to publish analyzer 5.7.1 and _fe_analyzer_shared 55.0.0 
Change-Id: Ie9c95abba680a8d564f8577a8bf91604ec8d5022
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/286341
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2023-03-02 18:22:31 +00:00
Devon Carew a8afc781b4 [pkg/analyzer] bump the min. sdk version 
Change-Id: I92b086de357e28239580fd17f4b1aaf29447941c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/286321
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2023-03-02 16:09:45 +00:00
Konstantin Shcheglov 479a98f5b5 Prepare to publish analyzer 5.6.0 and _fe_analyzer_shared 54.0.0 
Change-Id: I6b36a25adfa78cb8d0534afa006daa66a6a8ed78
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/284380
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2023-02-21 21:26:42 +00:00
Konstantin Shcheglov 4ddfa7bac5 Prepare to publish analyzer 5.5.0 and _fe_analyzer_shared 53.0.0 
Change-Id: If616813aeab905026f936015d86560388aa80044
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/283101
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2023-02-14 18:41:48 +00:00
Konstantin Shcheglov ebdb53fe85 Rename to PatternField and PatternFieldName. 
Change-Id: I534e13fb8843e0b4a961cdf981016f7504858ba6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/281782
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2023-02-08 23:44:54 +00:00
Konstantin Shcheglov 79e6beaf7d Prepare to publish analyzer 5.4.0 and _fe_analyzer_shared 52.0.0 
Change-Id: Iafb9a1f8d5ce9f8502795192c9cbc6b26cb337c0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278300
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2023-01-04 19:33:48 +00:00
Konstantin Shcheglov 09a5d048e8 Issue 50660. Fix 'get Source' for ParameterMember. 
Bug: https://github.com/dart-lang/sdk/issues/50660
Change-Id: Ie6af7c60178b2010f4cd5254e563185eb7e27042
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/274603
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-12-09 02:08:24 +00:00
Konstantin Shcheglov bd30de18ba Prepare to publish analyzer 5.3.0 and _fe_analyzer_shared 51.0.0 
Bug: https://github.com/dart-lang/sdk/issues/50637
Change-Id: I0ce445af106168fd4af6529e2c55deceb954e559
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/274086
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-12-07 22:18:37 +00:00
Konstantin Shcheglov f282fcfa35 Prepare to publish analyzer 5.2.0 and _fe_analyzer_shared 50.0.0 
Change-Id: Iebf909af9e62322d898d6db79ee5fa6f8bfe3899
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/265561
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-10-25 21:03:37 +00:00
Konstantin Shcheglov 745d0ff64a Deprecate 'Element.enclosingElement3', use 'enclosingElement'. 
Change-Id: I6f4fd7e8c0f071bde10cb5e57ed6195ae517e575
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/261221
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-09-26 23:58:14 +00:00
Konstantin Shcheglov 5a812f423d Prepare to publish analyzer 5.1.0 and _fe_analyzer_shared 49.0.0 
Change-Id: I64bbfb67d39a86cf4c3b00067f78c992d0fe2502
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/261161
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2022-09-26 18:14:58 +00:00
Konstantin Shcheglov e03170035a Deprecate 'get name2', use 'get name' instead. 
Change-Id: Iee8ef5fb6700d96c857a22a99dc61dac3da88572
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/260443
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-09-22 02:22:47 +00:00
Konstantin Shcheglov daada3e35d Prepare to publish analyzer 5.0.0 and _fe_analyzer_shared 48.0.0 
Change-Id: Ib9f0cab59a6791ed077ed78395cc24d1bf3d482c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/258860
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2022-09-12 19:37:09 +00:00
Konstantin Shcheglov 6f0fe880c4 Breaking changes for analyzer version 5.0.0 
Reland of https://dart-review.googlesource.com/c/sdk/+/243164

Change-Id: I5167844ea1001f026cf8d9b82465a79f560d188d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/257267
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-09-07 16:27:18 +00:00
Konstantin Shcheglov f442c98a3f Prepare to publish analyzer 4.7.0 and _fe_analyzer_shared 47.0.0 
Change-Id: I1a2b727e5b49fe4386e12e4957e39c55421b1ff2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/257280
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
 2022-09-01 17:31:04 +00:00
Konstantin Shcheglov ff8024fc78 Revert "Breaking changes for analyzer version 5.0.0" 
This reverts commit d8df88cbe4.

Reason for revert: breaks Flutter HHH, requires updates to linter

Original change's description:
> Breaking changes for analyzer version 5.0.0
>
> Change-Id: Id9f27b6c41829249f6b2e7b93ad396643193fc78
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/243164
> Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>

TBR=scheglov@google.com,brianwilkerson@google.com

Change-Id: I6ca213427189c169ddacbd89f60d463efa2c38f2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/257122
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2022-08-31 21:05:19 +00:00
Konstantin Shcheglov d8df88cbe4 Breaking changes for analyzer version 5.0.0 
Change-Id: Id9f27b6c41829249f6b2e7b93ad396643193fc78
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/243164
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-08-31 05:08:50 +00:00
Konstantin Shcheglov f1aea65363 Add ImplicitCallReference to NodeLintRegistry 
Towards https://github.com/dart-lang/language/issues/2399

Change-Id: I4e31bec7703504711a5827e282b2b52d14ae6b05
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/254465
Auto-Submit: Nate Bosch <nbosch@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-08-12 19:09:16 +00:00
Konstantin Shcheglov 5b3a78b675 Prepare to publish analyzer 4.6.0 and _fe_analyzer_shared 46.0.0 
Change-Id: I3562b5e3ce0c7f744d4bf80a71adf8e97b9b57b7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/254740
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-08-11 23:31:18 +00:00
Konstantin Shcheglov 82e33cc598 Add DartType.element2 
Unfortunately my idea about checking for specific `DartType` subtype,
and only then asking for the element is too punitive. It almost
works in google3, but the amount and the kind of changes I had to
do make me realize that we should keep `get elementX` in `DartType`.

I guess this is the same as we had in AST when `get constructors`
does not make sense for mixins (?), but works for classes and enums,
and it is easier to pull it into the superclass.

Change-Id: Ibc4fac0b95d63748fa65de96d29300f477fdfc76
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/254482
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-08-11 16:01:48 +00:00
Konstantin Shcheglov a1b90438e8 Prepare to publish analyzer 4.5.0 and _fe_analyzer_shared 45.0.0 
Change-Id: I0ab45251f8a7e87b70ce6dfd1f964da7d2cc6e9c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/254282
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-08-09 22:42:26 +00:00
Konstantin Shcheglov 75b8b916d6 Deprecate ClassOrMixinDeclaration, use ClassDeclaration or MixinDeclaration. 
Change-Id: I23e292e9f7c4413edf9b068f057dd02794db21a8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/254064
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-08-08 21:40:40 +00:00
Konstantin Shcheglov 8c275efddf Update deprecation message for 'FormalParameter.identifier'. 
Change-Id: I2670fbfd01ba5864fd339bd2e6dd059660fdf9c1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/253904
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-08-08 04:28:59 +00:00
Konstantin Shcheglov a34e93f9d3 Prepare to publish analyzer 4.4.0 and _fe_analyzer_shared 44.0.0 
Change-Id: I81a6366092ede393546212cfef1746fa06d1aed6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/253709
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2022-08-05 21:27:37 +00:00
Konstantin Shcheglov a31337548e Deprecate ClassDeclaration/ClassTypeAlias.isAbstract 
Change-Id: I70fa1714fb31bb611d86054fc4538c01afda6763
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/252563
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Jake Macdonald <jakemac@google.com>
 2022-07-26 01:51:27 +00:00