dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
98,756 Commits 2 Branches 0 Tags
c84edaefe9e457e9cc975c050019479b2d94dea2
Commit Graph

3 Commits

Author SHA1 Message Date
Sam Rawlins 9de396953f analyzer: Track fixes in YAML files 
This may seem to be a silly change, adding these lists only for the
error fix status file, but I claim this is a very pragmatic solution:

* It is important and beneficial to correctly track error fix
  statuses; I was recently confused about these fix statuses because
  the text in the fix status file was a lie.
* When fixes are added for more errors, you cannot forget to update
  the codesWithFixes list because the fix won't apply (and no test
  asserting the fix works would pass).
* Overhauling these FixGenerators to use maps like the others is maybe
  a good change in the long run, but at this point might be
  over-engineering; we only have fixes for 2-3 codes for each file
  type.

Change-Id: Iaa902acf2401f97ff722e222910f5d6fcd00a5ce
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/338800
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Auto-Submit: Samuel Rawlins <srawlins@google.com>
 2023-11-29 23:19:54 +00:00
Danny Tuppeny 6489835d8c Enable "Import Library" fix for comment_references lint 
Fixes https://github.com/Dart-Code/Dart-Code/issues/4792

Change-Id: I8f03c9bed032b52c2bcbf86b43abf74343f2b7df
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/330640
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2023-10-17 03:39:47 +00:00
Sam Rawlins 312b46b444 Introduce first presubmit check for analyzer team. 
See the issue below, and the code comments, for the further plans.
I plan on adding whichever ones we find useful, as long as I can
keep them performant. This one is performant, and we can discuss
possible problematic checks on the issue.

Work towards https://github.com/dart-lang/sdk/issues/53578

Change-Id: Ie3980e6194e46574a01ad3e0bd8e36f7ac248917
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/329620
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Kallen Tu <kallentu@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Jonas Termansen <sortie@google.com>
 2023-10-16 16:42:24 +00:00