dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity
98,756 Commits 2 Branches 0 Tags
c84edaefe9e457e9cc975c050019479b2d94dea2
Commit Graph

241 Commits

Author SHA1 Message Date
Danny Tuppeny 23e1437f6a [analysis_server] Update generated code to match latest spec 
This should have been a small change to keep us in-sync with small changes so when there are bigger changes (LSP 3.18.0) the change is less noisy.

However, it turns out the meta model is built from the latest version always, so it includes 3.18.0 proposed features.

So this change not only regenerates the code with the latest spec, it also adds some handling to exclude any types (and methods) marked as proposed.

It also includes a few minor fixes to things like re-wrapping of comments where there are references.

So, it should still essentially be a non-functional change, but the CL isn't as small as planned because of the cleanup.

- The lsp_meta_model.json file is downloaded and not changes I've made
- The protocol_generated.dart file is the output of the code-gen
- All other files are changes I made manually

Change-Id: I6380f86848d2799cf94d58a419ace0bf0d5a35ef
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/340040
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2023-12-05 19:58:47 +00:00
Danny Tuppeny a18a24c16c [analysis_server] Update + test for LSP readme being up-to-date with implemented methods 
Change-Id: I4c25da38da937d76c4a1b1c9ba1e6318f16c1046
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/333400
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2023-11-02 20:59:20 +00:00
Sam Rawlins f34ddb39f4 analyzer: Sort elements in generated LSP protocol files 
Change-Id: Icddd53f8a5f858d49a2a00b853cd1f824e3783ef
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/329583
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2023-10-10 17:39:49 +00:00
Alexander Thomas 49f4c5f94a [analysis_server] Move language server protocol to third_party 
Bug: b/286184681
Change-Id: Iabb9070e354f85d29bb94dee4bdd52a0cf664c94
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/326643
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Devon Carew <devoncarew@google.com>
 2023-10-10 07:48:30 +00:00
Sam Rawlins d48592f22a analysis_server: Indent pattern examples to be code blocks 
As `{@link` is not a doc directive, it should not be written like it
is a doc directive.

Change-Id: Iebdc34175372ce1933b02c482499acf52ddd2324
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/327285
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2023-09-24 18:01:22 +00:00
Sam Rawlins 283dad4ddc analysis_server: Enforce single quotes preference 
Change-Id: I553befc2c45e66bfc569004d810b4e0a958d4baa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/325544
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2023-09-13 17:48:22 +00:00
Konstantin Shcheglov 38546e90ab Pre-fix unreachable_from_main for instance members. 
https://github.com/dart-lang/linter/pull/4441

Change-Id: I55afa6b7d78bc1114ce97c1b5bebcf7a8bca5b98
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/307975
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2023-06-09 22:39:27 +00:00
Danny Tuppeny d75a4e162e [analysis_server] Update LSP generated classes to latest published version of the spec 
No functional changes here but there have been some refactors inside the meta model that required some minor tweaks (URI moved from a type alias to string to a spec-defined base type).

I also improved the handling of some type references in the comments we bring in so they're clickable in more places.

Change-Id: I7c725d01b6d7bc0925979b8118dbfd8952f78724
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/297482
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2023-04-24 15:09:20 +00:00
Danny Tuppeny 8696096afd [analysis_server] Prompt when there are issues that might be fixable by "dart fix" 
Change-Id: Ibcc7a9b0b4258b0576e6f6e58bbb4b08987de0ae
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/289601
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2023-03-21 17:05:39 +00:00
Josh Soref 9e4dc755cb Spelling pkg 
Closes https://github.com/dart-lang/sdk/pull/50921

GitOrigin-RevId: 6b1ca502b6722b0a987f33ace66f65cbd2c24e23
Change-Id: I74e4ff3c8e759c576036d6b791bd7734ebd215d8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278536
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
 2023-01-19 10:06:29 +00:00
Danny Tuppeny 41b5ba1629 [analysis_server/lsp] Allow user to configure whether Workspace Symbols includes all files or just their workspace 
Fixes https://github.com/Dart-Code/Dart-Code/issues/1903.

Change-Id: I1b9221a1ebfa83e3089b4036e6d0d5446ac24461
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/275760
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-12-19 19:07:26 +00:00
Danny Tuppeny 699b42c8e3 [analysis_server] Support adding multiple imports for @overrides completions 
Related to https://github.com/Dart-Code/Dart-Code/issues/4116.

Change-Id: I81b9e7bfbe4bbd093770925f9dcb640b72487142
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/270181
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-11-21 18:06:35 +00:00
Danny Tuppeny fc9581d758 [analysis_server] Use ElementLocation to properly resolve documentation in LSP completions 
Fixes https://github.com/Dart-Code/Dart-Code/issues/3787.

Change-Id: Iffd83fbd96f2ff8dc136c2a3f5ec7824e7451ca2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/269960
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-11-15 19:14:18 +00:00
Danny Tuppeny 09c1722044 [analysis_server] Add a user setting to control verbosity of dartdocs in LSP hovers and related responses 
Fixes https://github.com/Dart-Code/Dart-Code/issues/4119.

Change-Id: I26aa074f35b87ced1e09073f534451248c633402
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/266741
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-10-31 19:22:11 +00:00
Danny Tuppeny 27ba8fce6c [analysis_server] Include type arguments in Type Hierarchy 
Fixes https://github.com/Dart-Code/Dart-Code/issues/4217.

Change-Id: I8b8dec4ad25a9eb4a4f80dd036e8a9b61bb012d2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/264981
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-10-25 16:00:41 +00:00
Danny Tuppeny 9c0b575fa5 [analysis_server] Include filters in saveUri parameters, rename type -> kind 
Change-Id: I815a86a57fbb15d4d851d368a3b4eeffefa39ed8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/261605
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-09-28 17:25:56 +00:00
Danny Tuppeny 63b6239f79 [analysis_server] Tweaks to new server refactorings 
Change-Id: If2dc19b724a4fd617288466003a8d35e599d5950
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/261403
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-09-27 18:22:05 +00:00
Danny Tuppeny b3b2a1cebf [analysis_server] Change LSP types to use Uri types instead of Strings 
This requires some tweaks to to/from JSON code, and some handling for Maps that previously could be serialised directly but now may contain `Uri`s in keys and need to be converted to strings explicitly (since Uri has no toJson method).

Change-Id: I61358d8198ac1da322fae98d6c40747ad08754b7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/258927
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-09-14 18:58:44 +00:00
Danny Tuppeny 8e2dbc1cdc [analysis_server] Add support for showing inferred types via inlayHints 
Change-Id: I075871df3e6bec89f03f55e1387d479a48123713
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/258807
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-09-12 18:26:07 +00:00
Danny Tuppeny 139d150b23 [analysis_server] Remove use of SuggestionSets from LSP 
Always use NotImportedContributor.

Change-Id: I3ed518f2d84d10600a5ea27bc88282762573ef2e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/253784
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-08-05 17:08:27 +00:00
Brian Wilkerson 023c6df3b4 Initial draft of a custom LSP protocol for refactoring 
Change-Id: Ib7a6b6bd0b2e0dccd8e7b6c117dc284b0e5a95cd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/253361
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Danny Tuppeny <danny@tuppeny.com>
 2022-08-02 15:48:04 +00:00
Danny Tuppeny f34d4d5f93 [analysis_server] Add support for LSP Call Hierarchy 
Fixes https://github.com/Dart-Code/Dart-Code/issues/612.

Change-Id: Ic51d4be2340317443b5a1cdae83e6eeaac4fa06b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/251460
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-07-13 18:45:03 +00:00
Danny Tuppeny e3c055de80 [analysis_server] Add support for using NotImportedConstributor in LSP behind preview flag 
Change-Id: I4b7223f5057ede1f97c3209c12a2a50a9ab911bd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/250845
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-07-07 20:23:28 +00:00
Danny Tuppeny a8a0ea2ea5 [analysis_server] Simplify resolution of LSP completion items 
Change-Id: Iadfe416e3da69cd74c633f8513ee3f1edb3f0499
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/250841
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-07-07 16:28:01 +00:00
Danny Tuppeny 77bf07a87f [analysis_server] Rename LSP Pattern alias to not conflict with Dart Pattern type 
Change-Id: Ib3178eb2fd3f3e2d41844d5fb492775da7e3171a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/249487
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-06-22 14:05:24 +00:00
Danny Tuppeny 341b60796a [analysis_server] Generate typedefs for LSP params/result unions 
Many params/result types are defined as unions without names in the spec. This gives them names so the handlers will be able to use names instead of the full EitherX<Y> type.

Change-Id: I3f96b48e5e70c86814724edc3fec4fc7f76534de
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/248801
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-06-16 16:11:21 +00:00
Danny Tuppeny b46a2d3039 [analysis_server] Preserve type aliases from the LSP spec as typedefs in generated code 
+ improve the use of LSPAny/LSPObject where

LSPAny = anything, including null or undefined
LSPObject = any object (equiv of non-null Map<String, Object?>)

Change-Id: I335b299aad8e58b1cb4ee33cf27dc0dd887ec916
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/248781
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-06-16 14:15:41 +00:00
Danny Tuppeny 8038192b9d [analysis_server] Fix names of canParse functions for nested generics 
Change-Id: I4f641d8cb4cc2aadfd38c5fc0b06fd11445c4165
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/248587
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-06-15 19:29:48 +00:00
Danny Tuppeny e787255915 [analysis_server] Remove unused type args in LSP interfaces 
The new JSON model doesn't have/support type args (the original Markdown/TS spec had one instance where the type arg added no value) so this cleans up the code slightly.

Change-Id: I773d2acb38f95d78d2d5f73e1c9bd39468fbcad8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/248585
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-06-15 16:00:01 +00:00
Ahmed Ashour 07f7e455fa [analysis_server] use single function per type for canParse 
Fixes #49229

Change-Id: I87d2dea79f8786b826162d132a63c69a2ebaba67
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/248009
Reviewed-by: Danny Tuppeny <danny@tuppeny.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-06-15 14:31:38 +00:00
Ahmed Ashour 85700570f6 Fix typos 
Fixes #49241

TEST=ci

Change-Id: I6117bf816fc8c4613cce66927f952fef75632725
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/248120
Reviewed-by: Alexander Thomas <athom@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
Reviewed-by: Nicholas Shahan <nshahan@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-06-15 11:08:28 +00:00
Danny Tuppeny 7df87288d8 [analysis_server] Update + simplify LSP methods table 
Change-Id: Ia89e4bf2b65effe7ea98bd0081873f6a749eade6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/248145
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-06-14 17:28:32 +00:00
Ahmed Ashour 503e7232ab [analysis_server] have a single function for union 
Bug: #49229
Change-Id: I6141c48e48fbe88812c10d7fcc3541af28ec36c6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/247966
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Danny Tuppeny <danny@tuppeny.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-06-12 17:31:57 +00:00
Ahmed Ashour 8bb3a10e40 Fix typos 
Fixes #49228

TEST=ci

Change-Id: Idcc625554bcf07807bae9791ea37b73ae9394b87
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/247960
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
Reviewed-by: Lasse Nielsen <lrn@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-06-10 15:48:54 +00:00
Ahmed Ashour e11d6b4a62 [analysis_server] simplify generated equals 
Fixes #49222

Change-Id: I430ff02a4721d7d937b701bf0137096f314a6860
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/247557
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-06-09 18:30:33 +00:00
Danny Tuppeny 88c2f888ea [analysis_server] Support dart.updateImportsOnRename setting for updating directives on renames 
This setting is already supported in VS Code but accidentally stopped working in the switch to LSP. This change prevents/removes the registration for willRenameFiles so that a client won't call the server when files are renamed if this setting is `false`.

Change-Id: Ia7b22b9fc2f119d0e7f98f4e2c5f0bac994a28af
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/247544
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-06-08 16:06:52 +00:00
Danny Tuppeny 225291c803 [analysis_server] Improve naming of LSP codegen types 
Change-Id: I51f97c5a7bfdbc1fb420c7d59855efd2f9f4b2f7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/247381
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-06-06 19:53:48 +00:00
Danny Tuppeny 06ee6405e6 [analysis_server] Drop Token/TokenTypes from LSP codegen 
Change-Id: I8290f3aa94fe3d44ba5b0ce6aee813b15db7ec86
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/247380
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-06-06 17:56:18 +00:00
Danny Tuppeny ab9a9fe9c0 [analysis_server] Simplify documentation comments in LSP codegen 
Change-Id: Ifb808331ea3bcec5b292ed245811102d6374e71d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/247342
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-06-06 15:49:18 +00:00
Danny Tuppeny b05b832a2e [analysis_server] Remove/rename code from legacy LSP spec/parsing 
Change-Id: I72e9e146b4961c7757c2885bc109fd1e43258137
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/247341
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-06-06 15:00:28 +00:00
Danny Tuppeny 086727ee6f [analysis_server] Migrate from using Markdown/TypeScript spec for LSP types to JSON model 
Change-Id: I58dbbbee48febc45304b27a95fedfef289479265
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/247340
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-06-06 14:27:48 +00:00
Danny Tuppeny 2deae5a599 [analysis_Server] Sync with latest published LSP (TS) spec 
Change-Id: If5003354491047bf18538c6c097ea21a34e44843
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/247222
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-06-06 14:11:13 +00:00
Ahmed Ashour c202252876 [analysis_server] remove two lint ignores for generated LSP spec files 
Fixes #49059

`prefer_is_not_operator`
`unnecessary_parenthesis`

Change-Id: I79d3e1b6ed89d138a2bb6eab79fa8dcdc9a23080
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/245541
Reviewed-by: Danny Tuppeny <danny@tuppeny.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-05-26 06:00:59 +00:00
Ahmed Ashour 366042a0dd [analysis_server] satisfy annotate_overrides in generated LSP spec files 
Part of #49059

Change-Id: Ifb97985907757f53548764fc64a46094650efd4c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/245544
Reviewed-by: Danny Tuppeny <danny@tuppeny.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-05-26 04:37:59 +00:00
Danny Tuppeny e66540d8a3 [analysis_server] Update to latest published 3.17 (TS) spec 
Some minor tweaks + fix for `NotebookDocumentSyncOptions` since the original publish.

Change-Id: I3962222a984e2617ebcb023453a16580cd787b7b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/245700
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-05-24 16:49:15 +00:00
Danny Tuppeny c954d80f18 [analysis_server] Fix LSP class name generation for nested inline types + minor renames 
Change-Id: Ia8321eedeb783ffe5e91a508e258a87aa9efcf31
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/245372
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-05-24 16:36:55 +00:00
Ahmed Ashour 77da5016fe [analysis_server] remove ignore of no_leading_underscores_for_local_identifiers in generated file 
Part of #49059

Change-Id: I9d8771e71ca505d61442bc04b9f71fd02f1c7d5e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/245380
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Danny Tuppeny <danny@tuppeny.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-05-20 15:54:53 +00:00
Ahmed Ashour 3fa01b2b9b [analysis_server] Remove ignoring avoid_renaming_method_parameters 
Bug: #48785
Change-Id: I089dd5a76bf5c5c5d4e57ecc8ddaabda04866621
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/245361
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Danny Tuppeny <danny@tuppeny.com>
 2022-05-20 14:55:12 +00:00
Danny Tuppeny aae961063f [analysis_server] Move LSP JSON-RPC types to custom generation 
Change-Id: Ie84f7aa099bdeeb1be2a565faf1ffa0bb3ef4b21
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/245365
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-05-19 18:18:01 +00:00
Danny Tuppeny b9c077b435 [analysis_server] Fix type aliases with multiple literal types in LSP TypeScript spec 
Change-Id: I82a8344b5e4858355757b8d4d167a305f74f3ec4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/245172
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-05-18 18:46:23 +00:00