dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity
98,756 Commits 2 Branches 0 Tags
c84edaefe9e457e9cc975c050019479b2d94dea2
Commit Graph

406 Commits

Author SHA1 Message Date
Danny Tuppeny 07d40a0210 [analysis_server] Fix Rename+References for forElements outside of blocks 
Fixes https://github.com/Dart-Code/Dart-Code/issues/4849

Change-Id: Iceeeab549235622d4fe8c5c129c754cea53012b5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/337741
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2023-11-28 21:23:39 +00:00
Sam Rawlins 73ab31b98a analyzer: Move the Source class to be public API. 
Deprecate accessing LineInfo, Source, or SourceRange via the
old library (pkg/analyzer/lib/src/generated/source.dart).
Migrate all SDK code to the new library.

Fixes https://github.com/dart-lang/sdk/issues/46420

Change-Id: Ic7c98a5820415c92a457f9fa2756351b05520cd1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/335382
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2023-11-14 17:10:37 +00:00
Konstantin Shcheglov e0b7d929a9 De-duplicate Posix path access implementation. 
Change-Id: Ie97dd395c3f760881b38a9045be167b9d21eff0d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/335905
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
 2023-11-13 20:17:11 +00:00
Konstantin Shcheglov 49ef0be2bc Add ElementKind.MIXIN, use it for MixinElement. 
Change-Id: Ie95c6c331ff437c4d6b99bfc7f9a3109f47c985b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/332460
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2023-10-26 18:27:39 +00:00
Danny Tuppeny 209483da72 [analysis_server] Don't disallow extracting local variables matching argument names 
Fixes https://github.com/Dart-Code/Dart-Code/issues/4787

Change-Id: Idbd54e55599cf3cb34f504e4aad40018b70dfe78
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/330109
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2023-10-11 17:37:43 +00:00
Danny Tuppeny 09f3eb0c8b [analysis_server] Support renaming multiple files in a single operation 
We already supported moving a single folder, which we expanded to each file inside it. This adds support for moving multiple distinct items at the same time (eg. dragging multiple files).

To support this, we need to track a full mapping of source/destination paths (because files might be moved from different levels into the same level - we can't compute destination paths from a single `newFile` variable), and also build a unique set of references that need updating (rather than building edits as we go - where we might try to edit the same reference from both ends).

Fixes https://github.com/Dart-Code/Dart-Code/issues/4533

This is currently only supported for LSP.

Change-Id: I3a8ab8b2dcb13451111d38d2ec0e2f69d6084e28
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/329320
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2023-10-11 03:56:29 +00:00
Danny Tuppeny cc7dd80d51 [analysis_server] Don't include unnecessary parens when inlining locals 
Fixes https://github.com/Dart-Code/Dart-Code/issues/4732

Change-Id: I5d0da808bea37b533a42b7aaf5443433826393f5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/326821
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2023-09-19 17:04:40 +00:00
Sam Rawlins 283dad4ddc analysis_server: Enforce single quotes preference 
Change-Id: I553befc2c45e66bfc569004d810b4e0a958d4baa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/325544
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2023-09-13 17:48:22 +00:00
Konstantin Shcheglov 12bd986c71 Extension type. Request based test for rename, a fix for representation field. 
Change-Id: Ic10550089272797724a0047a31fa040f4a293001
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/323706
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2023-09-01 17:53:57 +00:00
Konstantin Shcheglov 84f65be285 Fix 'Extract Method' refactoring inside extensions. 
Change-Id: If055456980361c5ec768bf5cb104af11cfa1b12e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/323704
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2023-09-01 17:06:39 +00:00
Konstantin Shcheglov 80a76ff357 Extension type. Extract method refactoring. 
Change-Id: I34e08182b568bfc0296b45851ccedb803595efa8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/323701
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2023-08-31 21:35:39 +00:00
Konstantin Shcheglov 55634cbb5b Extension type. Rename refactorings. 
Change-Id: Ia65a8e18ff0a92b799ac376872b621e69ad61701
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/323683
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2023-08-31 20:40:00 +00:00
Danny Tuppeny 5926a7301b [analysis_server] Fix duplicate fields when extracting widgets 
Fixes https://github.com/dart-lang/sdk/issues/53383

Change-Id: Ia985f1c71c99416906bac4669ff61961d32f29fd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/323400
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2023-08-30 21:10:49 +00:00
Konstantin Shcheglov 508a293029 Revert a few not published API changes. 
Change-Id: I093c3d3f6e221cfe874e82b598f52087670ce24e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/318020
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2023-08-04 19:21:58 +00:00
Danny Tuppeny 02c99b40ab [analysis_server] Handle "Extract Method" in static field declarations 
Fixes https://github.com/Dart-Code/Dart-Code/issues/4564

Change-Id: I9119941232cf17af7115fe5476ac1c4faa95cddb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/317780
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2023-08-02 18:17:38 +00:00
Konstantin Shcheglov 4bb8312b4a Revert "Move API declarations of elements into src/, re-export." 
This reverts commit 43db92d9ed.


Revert "Tweaks for comments of classes around augmentations."

This reverts commit 6d0fb5094f.

Change-Id: I9508169158d536302579346defebf696edfe4bec
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/315660
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2023-07-23 16:43:30 +00:00
Konstantin Shcheglov 43db92d9ed Move API declarations of elements into src/, re-export. 
In following CLs I plan to add `final` and `sealed` modifiers.

Change-Id: Ia6b9091034ed9f8f6f8576dbe6029d7e72a9d6b3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/315249
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2023-07-21 16:05:21 +00:00
Konstantin Shcheglov fae9e418ea Deprecate Element.enclosingElement, use enclosingElement2 instead. 
Change-Id: I78edb6d433949eb8bd86f397fb873a078edf9fc4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/311827
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2023-06-29 19:45:19 +00:00
Konstantin Shcheglov 98d7e25027 [CMSR] Test that it works with FunctionTypedFormalParameter(s). 
Change-Id: I86d483d379e7fe0be2dccf1659d2c6377dcc8eb1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/311140
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2023-06-23 19:30:12 +00:00
Konstantin Shcheglov ecc18c9600 [CMSR] Tests for TrailingComma, support for required positional formal parameters. 
Change-Id: I1e477782895a053ff2060dada8fe834bd2c2c8db
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/310977
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2023-06-23 17:53:30 +00:00
Konstantin Shcheglov 9b3e36bbdc Refactorings run with multiple AnalysisContext(s) and sessions. 
If we use just the session that produced the resolved unit, we will
not update other packages for example.

I tried to apply a refactoring to `LanguageVersionImpl` from `_fe_analyzer_shared`, and it did not update `analyzer`. With this change it does update :-)

Change-Id: I47fc28b4adba59c8e025e1bfe17490e4038d28ba
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/310973
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2023-06-23 00:22:38 +00:00
Konstantin Shcheglov c2ffa07d7e [CMSR] Tests for removing first / last named / positional formal parameter. 
Change-Id: I4028f17b9244835beb60d955f12763ff9184afc4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/310967
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2023-06-22 20:27:24 +00:00
Konstantin Shcheglov fe35362602 [CMSR] Support for removing formal parameters. 
Change-Id: Id04f6c7854dec3d5059009a0a579110690d3eb62
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/310963
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2023-06-22 18:09:23 +00:00
Konstantin Shcheglov a8a3f3f77e [CMSR] Improve 'get invocation' implementation. 
Change-Id: I871eddc1727ea6a51e169f4031d55ba3bc93527d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/310860
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2023-06-22 14:38:38 +00:00
Konstantin Shcheglov dc01c56e94 [CMSR] Test when the agnostic refactoring updates multiple files. 
Change-Id: Ia80d9e31db9d7ad17472aff0e5f5595bf43bc9ec
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/310778
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2023-06-22 05:11:55 +00:00
Konstantin Shcheglov 6a4f127831 [CMSR] Not available if external executable element. 
Change-Id: Icf209c8cd844918a62195f8a024f0c0b8922f0d7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/310705
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2023-06-21 19:51:58 +00:00
Konstantin Shcheglov c3f3a00465 [CMSR] More checks for not allowed order of formal parameters. 
Change-Id: Ida0380afb141873e75c27460b0804a8457c876e2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/310703
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2023-06-21 18:12:48 +00:00
Konstantin Shcheglov 62f66ecef4 [CMSR] Initial support for constructors. 
Change-Id: I2349eaf5dd59596bab1137e297fdf08873d79c1e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/310201
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2023-06-20 00:33:28 +00:00
Konstantin Shcheglov c24c41eeac Extract availability analysis from selection analysis. 
Danny gave a good idea that checking for availability of a refactoring
should be cheap. Change method signature refactoring mostly satisfied
this, with one exception - we cannot compute formal parameters for
an ExecutableElement, because we need resolved AST to do this, and
the invoked method can be declared in a different file. We cannot
afford resolving other files while checking.

So, this CL separates availability checking, and preparing formal
parameters, postponing expensive opertions until the time when the
action is invoked.

Change-Id: Ic703d70717e41de304c9dbcef66cadb22c139ad8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/310041
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2023-06-18 20:51:16 +00:00
Konstantin Shcheglov fda8556438 [CMSR] Write existing extra named formal parameters and arguments. 
Change-Id: Ibbd69140c7e46bca95dd72f99739eccd1984b2d0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/309828
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2023-06-17 05:20:27 +00:00
Konstantin Shcheglov 324cef773c [CMSR] Support for formal parameters selection. 
Change-Id: I38beddf9eeb36615e11ae1375aac335c1a7a6d56
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/308966
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2023-06-13 20:58:39 +00:00
Konstantin Shcheglov d9e2f515ea Check the id of the formal parameter in update, and formal parameters vs. target. 
Change-Id: I5f6d1f65386d385d470a7b1d0de3727c0f7788e1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/308843
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2023-06-13 15:52:28 +00:00
Konstantin Shcheglov 015912a3f4 [CMSR] Fix a TODO for converting optional formal parameter into required. 
Change-Id: I40c8c9dc6369fec382e0e650ebe01bed384d86b8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/308844
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2023-06-13 06:58:14 +00:00
Konstantin Shcheglov 1b1c133b61 Support for ArgumentsTrailingComma in 'Change Method Signature' refactoring. 
Change-Id: Iadb60c3cd233044ab78ef8a36eba32616b1ca9c5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/308804
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2023-06-13 00:57:20 +00:00
Konstantin Shcheglov cd0a7e43fd Fix failing tests in ChangeMethodSignatureTest. 
We allow missing named formal parameters and arguments, because
reordering them will not change the semantics. But we fail when a
positional formal parameter or argument is missing.

Change-Id: If3b3315407d2cf717aeaf1db219e6f1f84469224
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/308807
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2023-06-12 23:49:34 +00:00
Konstantin Shcheglov f75e26564e Issue 45675. 'Change Method Signature' refactoring. 
Bug: https://github.com/dart-lang/sdk/issues/45675
Change-Id: I396228ec9306353b4bd269abedd3879d0c10a02f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/306160
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2023-06-12 18:39:04 +00:00
Konstantin Shcheglov fdd628b831 Use getResolvedUnit(File) in AbstractContextTest. 
Change-Id: Ic6237185b8a8c8b62de470490873703672a203e0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/308581
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2023-06-11 23:59:39 +00:00
Konstantin Shcheglov 1a98453d63 Issue 48474. Fix for renaming private methods, don't update other libraries. 
Bug: https://github.com/dart-lang/sdk/issues/48474
Change-Id: I361c5d53826a2e8b97c5c5df9e14a0298b6fe424
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/308165
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2023-06-08 20:27:08 +00:00
Konstantin Shcheglov 6055524426 Use File instead of String path in AbstractContextTest. 
Change-Id: I30ea3f08f8954e4d642aaf070e0da313013ad153
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/308162
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2023-06-08 19:21:31 +00:00
Konstantin Shcheglov 25dc2147bb Separate testFile and testFilePath in server tests. 
Change-Id: Icc11f0c7f1642471cc01a0046e2a04801efba084
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/307967
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2023-06-07 23:56:09 +00:00
Konstantin Shcheglov faa16fc565 Issue 52130. Fix 'Inline Local' refactoring inside SwitchPatternCase. 
Bug: https://github.com/dart-lang/sdk/issues/52130
Change-Id: Ic84e4781e12dece3775fc0462b727a6a9b9c9906
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/306125
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2023-05-26 19:38:48 +00:00
Konstantin Shcheglov 464235a29e Issue 52426. Handle InvalidType in CorrectionUtils.getTypeSource() 
Bug: https://github.com/dart-lang/sdk/issues/52426
Change-Id: I34fde1bf0836990ecb41a75c1684795d75d286fb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/304103
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2023-05-17 18:32:26 +00:00
Konstantin Shcheglov 25b2a4c989 Issue 52340. When inline method, check for string interpolation of parameters. 
Bug: https://github.com/dart-lang/sdk/issues/52340
Change-Id: Ic8d74778e62b3bee2152bf921fbb48d2febd3701
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/302641
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2023-05-10 20:57:37 +00:00
Konstantin Shcheglov 310f854c24 Issue 52177. Add rename refactoring for type parameters. 
Bug: https://github.com/dart-lang/sdk/issues/52177
Change-Id: I4ae5bb7d72c8956af6dcd91ad28fb1d7397bf424
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/299280
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2023-04-27 21:43:48 +00:00
Konstantin Shcheglov 39cb6acb88 Issue 52149. Fix to support rename refactoring for declared identifier with LSP. 
Bug: https://github.com/dart-lang/sdk/issues/52149
Change-Id: Ia4c5c564cc44583741722c658389ea674a5643c3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/297900
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2023-04-24 22:04:39 +00:00
Brian Wilkerson 71d4e1478e Clean up some tests to make conversion of contributor tests easier 
Change-Id: I801970b4b88b883b2219badcefb7e1c84517d592
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/297780
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2023-04-24 17:35:27 +00:00
Konstantin Shcheglov 529adda42e Issue 52131. Find implicit constructor invocations from other constructors. 
Bug: https://github.com/dart-lang/sdk/issues/52131
Change-Id: I7f28e4664f18196f978cb9dd38f878b1240d46a1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/297080
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2023-04-21 22:04:16 +00:00
Konstantin Shcheglov 63fd5aa364 Issue 52014. Make an implicit name of a named PatternField explicit when the pattern variable is renamed. 
Bug: https://github.com/dart-lang/sdk/issues/52014
Change-Id: Ifcc8ba255cb536cba11360ef4326525c1e037b44
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/295101
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2023-04-13 21:02:37 +00:00
Konstantin Shcheglov f70238a83b Issue 52015. Extract local variable into SwitchCase / SwitchPatternCase. 
Bug: https://github.com/dart-lang/sdk/issues/52015
Change-Id: I069ecfbd2be5375bdba9977872bc9e0c88431f62
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/295100
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2023-04-13 19:18:38 +00:00
Konstantin Shcheglov db0dfec609 Issue 51893. Report PATTERN_NEVER_MATCHES_VALUE_TYPE in some cases. 
Bug: https://github.com/dart-lang/sdk/issues/51893
Change-Id: Ia7582df3942a077e81f0343e83359c303d152b1b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/292420
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2023-04-03 20:31:45 +00:00