dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
98,756 Commits 2 Branches 0 Tags
c84edaefe9e457e9cc975c050019479b2d94dea2
Commit Graph

36 Commits

Author SHA1 Message Date
pq 8a5ddecfb3 + extension type target kind (and @optionalTypeArgs support) 
Adds a new TargetKind for extension types and adds it to `@optionalTypeArgs`.

Change-Id: I7254c1299c296451b9adc5d1f8eceb50af66f039
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/324769
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2023-09-08 18:09:01 +00:00
pq 813339e28a refactor TargetKind enum to class 
A trimmed down version of https://dart-review.git.corp.google.com/c/sdk/+/258200 which was reverted (https://dart-review.git.corp.google.com/c/sdk/+/268380) for (undiagnosed) performance reasons.

See: https://github.com/dart-lang/sdk/issues/53368


Change-Id: Iecd00a4483a4b6904b8b281eec49228620e1e943
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/322981
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2023-08-28 23:09:27 +00:00
Parker Lougheed 6f645c8f1c [analysis_server] Fix TODO in diagnostic_describe_all_properties test 
Change-Id: Id81194e0bf07aaa90777055597a9dba914060d3a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/319620
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2023-08-09 22:04:58 +00:00
pq 8db531a948 update mocked package:meta to 1.10 
Change-Id: I6d3afd37a31302855d426085547eda67a145efd8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/319385
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2023-08-09 20:23:48 +00:00
Ahmed Ashour adb321a4b8 [analysis_server] add a fix for use_decorated_box 
Fixes #50817

Change-Id: I78309df7cda2dc74b62eab3bdb48e52a3df02f94
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/280165
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2023-02-09 22:12:11 +00:00
Ahmed Ashour 1631284945 [analysis_server] update header of Flutter mock files. 
Bug #51184

Change-Id: Ic8eda3e07858b3533f65bef4e2133d0da74e5209
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/280117
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2023-01-31 18:20:56 +00:00
Ahmed Ashour a174b981e4 [analysis_server] associate RemoveAnnotation with some diagnostics 
Fixes #50788

Change-Id: Iea8753c00b61366e23301937a48fadaadb065082
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/276641
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2023-01-05 22:51:32 +00:00
Samuel Rawlins 813ca7faf6 Revert "[analyzer][meta] Refactor TargetKind to be a class, add a value in TargetKind to represent type parameter" 
This reverts commit 82143e6c95.

Reason for revert: This commit appears to have negatively affected the analyze benchmark:

* https://golem.corp.goog/Revision?repository=flutter-analyze&team=dartanalyzer&revision=114193

We need to revert and analyze it.

Original change's description:
> [analyzer][meta] Refactor TargetKind to be a class, add a value in TargetKind to represent type parameter
>
> Bug: https://github.com/dart-lang/sdk/issues/49796
> Change-Id: Ide144ceb57bae94a71b9d1a7ec841d03363fc121
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/258200
> Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: https://github.com/dart-lang/sdk/issues/49796
Change-Id: I6ec04ffe8d85c417d138626ffa4f1a7ac7dafe2b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/268380
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-11-07 20:17:09 +00:00
Danny Tuppeny 54370738ac [analysis_server] Change Flutter snippets to use Placeholder 
Using empty Container() can trigger lints and "const Placeholder()" is preferred.

See discussion in https://github.com/Dart-Code/Dart-Code/issues/3975#issuecomment-1234507375.

Fixes https://github.com/Dart-Code/Dart-Code/issues/4136.

Change-Id: I453f34f157f5667427403f2c0b9058f236895d6b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/268320
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-11-07 16:15:30 +00:00
Mateus Felipe C. C. Pinto 82143e6c95 [analyzer][meta] Refactor TargetKind to be a class, add a value in TargetKind to represent type parameter 
Bug: https://github.com/dart-lang/sdk/issues/49796
Change-Id: Ide144ceb57bae94a71b9d1a7ec841d03363fc121
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/258200
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-11-04 23:38:40 +00:00
Ahmed Ashour 98afb38b6a [analysis_server] add fixes for MISSING_OVERRIDE_OF_MUST_BE_OVERRIDDEN_* 
Fixes #50312

Change-Id: I0c599dede1c2c0710d35997144db5457360b096b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/266140
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-10-28 14:42:57 +00:00
Ahmed Ashour de68893488 [analysis_server] FlutterRemoveWidget to handle Builder 
Fixes #49949

Change-Id: I6b6b0454661523f622256199f1ebd4051e37ec0e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/259590
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-09-20 17:04:35 +00:00
Ahmed Ashour df1e5cce34 [analysis_server] Add FlutterConvertToStatelessWidget assist 
Fixes #46011

Change-Id: I14a4498831ed7d91a2ac1350824f5b7d8d0023c1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/250087
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-07-07 16:19:31 +00:00
Ahmed Ashour 85700570f6 Fix typos 
Fixes #49241

TEST=ci

Change-Id: I6117bf816fc8c4613cce66927f952fef75632725
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/248120
Reviewed-by: Alexander Thomas <athom@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
Reviewed-by: Nicholas Shahan <nshahan@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-06-15 11:08:28 +00:00
Ahmed Ashour 3c10e484c9 Flutter Widget Key to be nullable 
Fixes #46913

Change-Id: Id2d72ce497eaa1512c2bb95f023c9ff0160c5005
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/210128
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-05-11 19:20:24 +00:00
Danny Tuppeny 62c138bbc4 [analysis_server] Add Flutter snippet for Widget with AnimationController 
Change-Id: Icea1af510e65bdfbc395089184452ddb91d7446e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/234042
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-02-23 17:23:42 +00:00
Danny Tuppeny 2001b00c07 [analysis_server] Add ColorComputer for locating color references in user code 
Change-Id: I166f87135a9b15821e5f65cfea33b8a15fa7aa03
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/219101
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-11-11 21:50:41 +00:00
Danny Tuppeny 445ac5d803 [analysis_server] Improve handling of library-target annotations when organizing imports 
+ handle comments between the last annotation and the directive code.

Fixes https://github.com/Dart-Code/Dart-Code/issues/3598.

Change-Id: I868c832c8fcb2bf67aab83400ef2e57a5f14ce45
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/219783
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-11-09 17:16:52 +00:00
Ahmed Ashour d041cf0478 Remove extra the, be and of 
Fixes #https://github.com/dart-lang/sdk/issues/47504

TEST=No tests needed, only comments affected.

Change-Id: Ie096307b5ce314d328fea6780f396aaa226ad3b0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/216182
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
 2021-10-20 09:29:01 +00:00
Konstantin Shcheglov 78fd1fb758 Format analysis_server/ and analyzer_plugin/. 
R=brianwilkerson@google.com

Change-Id: Ib3140b9a7e1dbefd7106cc471574d210b359e7bd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/212221
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-09-01 21:08:56 +00:00
b-stime c1339411bb Adds assist for basic Flutter Builder 
Fixes issues such as

* https://github.com/flutter/flutter-intellij/issues/814
* https://github.com/dart-lang/sdk/issues/33957 .

Essentially, in Flutter, it's often useful to create a new context in the UI/widget tree as a place to begin a search towards the trunk of the tree for various state structures attached to lower levels of the tree. The basic `Builder` widget is the official means for creating such a context/entry-point.

The patches in this PR are essentially a copy-paste-tweak from two types of existing, similar assists. The main origin was taken from `FlutterWrapStreamBuilder` which wraps client code with a constructor for the StreamBuilder sub-class. The new assist, provided here, is a little more basic/general than the StreamBuilder so it was able to also adopt assertion and test code from some of the other assists for basic widgets.

Closes https://github.com/dart-lang/sdk/pull/45656
https://github.com/dart-lang/sdk/pull/45656

GitOrigin-RevId: 00a5043e5dbd410f24f30f6503711413341dbe7a
Change-Id: I5f93837af571b4974e35da131112f82cd9359697
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/194941
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-04-12 17:33:06 +00:00
Konstantin Shcheglov 9f986d2501 Migrate package:analyzer to null safety. 
Change-Id: Iffe4370431587e46a141ddc72a86ceec29c163b2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/176486
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2021-02-01 18:56:04 +00:00
Danny Tuppeny b613265c85 [Analyzer] Reanalyze analysis_options when .packages changes 
Fixes https://github.com/dart-lang/stagehand/issues/619.

Change-Id: I30022215b23de2b690b5cde95c9dd256a9ef83d8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/160068
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-08-25 15:03:29 +00:00
Devon Carew 31335728d1 [analyzer] add a new wrap with widget for SizedBox 
Change-Id: Ib94b254ebdff82309d8761c8bb769e15e19d23ed
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157423
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-08-06 04:34:26 +00:00
pq aea99b2f5c scope debug property assist to Diagnosticables 
Fixes: https://github.com/dart-lang/sdk/issues/42783

Change-Id: Ied9b0fa04e0f99b4d5b4604c72696b5cfaec737d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/155501
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-07-22 22:18:24 +00:00
Brian Wilkerson 486467c02d Bulk sort of a subset of the files in analysis_server 
Change-Id: Id811d37ad565c6f3c0ed508ae2b42e22469cbd3d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139830
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-17 19:13:14 +00:00
pq 7eaafa01cc linter 0.1.111+1 
Change-Id: I9e311527a41f65b888c4208615158715e3ff6dbf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137321
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-02-26 20:34:31 +00:00
Brian Wilkerson e2a528d976 Remove the lint marker from more fix tests 
Some of the tests were fairly seriously broken, so this fixes them.

Some of the tests were testing that we don't provide a fix when there is
no lint, but I don't think that it's useful to test that.

One test required no changes other than removing the marker.

Change-Id: I6d85fd98506fa20d8bf4996d30603feb8b1ff252
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134500
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-02-05 18:10:49 +00:00
Kevin Moore 8342ec2c71 Fix pub.dev URLs throughout SDK repo 
Change-Id: I5bcb7c40be12ee1dc887620281b4807469d67bbb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125729
Auto-Submit: Kevin Moore <kevmoo@google.com>
Reviewed-by: Michael Thomsen <mit@google.com>
Commit-Queue: Michael Thomsen <mit@google.com>
 2019-11-20 11:30:48 +00:00
pq 0a63bd4b0a diagnostic fix support for colors, iterables, lists, matrices 
See: https://github.com/dart-lang/sdk/issues/38633

Change-Id: I8d7baa32bcea22f2c162bd9d77c7dd0b95b308de
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119901
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2019-10-03 20:05:33 +00:00
Konstantin Shcheglov a62de52d04 Insert new named arguments before 'child' or 'children'. 
R=brianwilkerson@google.com

Change-Id: Idbe5bb7efbeaa81a8f2319fab929944e7b3492d5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112027
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Jacob Richman <jacobr@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-08-06 01:31:27 +00:00
Konstantin Shcheglov 1390201177 Support for 'padding' property, and EdgeInsets type. 
R=brianwilkerson@google.com

Change-Id: I536ee3952d6e280a56b048773a3a5696bc508b07
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109761
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-07-22 17:15:28 +00:00
Konstantin Shcheglov 1014272f3b Extent 'alignment' property, copy from Align, virtual Container. 
R=brianwilkerson@google.com

Change-Id: I9bec5b32e91f3cb77c4996f0ba0e7c2dd424316b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109724
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-07-19 21:41:03 +00:00
Konstantin Shcheglov 9d204ca5d8 Start adding 'Container' properties. 
R=brianwilkerson@google.com

Change-Id: I88c8194545dc3944318b897616e5a500c97ae4d5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109422
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-07-17 20:03:54 +00:00
Konstantin Shcheglov 65f8cd4365 Start implementing widget properties. 
Only self properties for now.

No compound properties.

No virtual Container properties.

R=brianwilkerson@google.com

Change-Id: Icd61f45ecc95c45037c3998a927eb267fd13c4cd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109121
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-07-15 21:06:56 +00:00
Konstantin Shcheglov 8b012ac780 Replace package mock in strings with files in tests/mock_packages. 
R=brianwilkerson@google.com

Change-Id: I5240fbd90c8220d14ff41d6a98069f943e56aa6d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108920
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-07-12 17:17:33 +00:00