dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
98,756 Commits 2 Branches 0 Tags
c84edaefe9e457e9cc975c050019479b2d94dea2
Commit Graph

32 Commits

Author SHA1 Message Date
pq 440ea59ee0 enable flutter_style_todos in server 
Change-Id: I4921d538e1498e66c8cab2d84dfcad21d1a7b555
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/335952
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2023-11-14 21:08:12 +00:00
pq 9e6c856c27 migrate to getAnalysisOptionsForFile(file) 
This migrates the bulk of the calls to `.analysisOptions`. I'll tackle the remainder in a few follow-ups.

Change-Id: I0f4c78d88938feecaba7202e0dc299dc17e2bb35
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/334647
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2023-11-08 21:48:38 +00:00
Sam Rawlins 7ee87f8601 [analyzer] Remove all support for strong-mode 
This looks pretty beefy; it is more-or-less 3 parts:

* Removing the `implicit-casts: false`, `implicit-dynamic: false`
  modes:
  * Remove `AnalysisOptionsFileConfig.implicitCasts|implicitDynamic`
  * Remove `AnalysisOptionsImpl.implicitCasts|implicitDynamic`
  * Remove `TypeSystemImpl.implicitCasts`
  * Remove all behavioral tests of the modes
  * Remove Analysis Options-parsing code that handled `strong-mode`
* Remove ability to fix deprecated modes (introduced before Dart 3).
* Move some non-generated AnalysisOptionsHintCodes and
  AnalysisOptionsWarningCodes to be generated. As
  `AnalysisOptionsHintCode.STRONG_MODE_SETTING_DEPRECATED` was the
  last `AnalysisOptionsHintCode` code, there were problems with the
  code-generator, unless I moved these non-generated codes.
  * `DEPRECATED_LINT_HINT`, `DEPRECATED_LINT_HINT_WITH_REPLACEMENT`,
    `DUPLICATE_RULE_HINT`, `INCOMPATIBLE_LINT`, `UNDEFINED_LINT`.
  * Those codes are then added to error_fix_status.yaml.

Change-Id: Ic165b60ca85f08f92886433eac5f5da5b7dd5021
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/316483
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2023-08-17 17:07:37 +00:00
eliasyishak 34f0e26d45 Swapping NoopAnalytics for noop from package:unified_analytics 
Change-Id: I3419a128830ae434fa37bd10a1fc8a3da146fd89
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/313880
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Elias Yishak <eliasyishak@google.com>
 2023-07-14 19:15:20 +00:00
Konstantin Shcheglov 69c62b1a31 Remove shipped features, and deprecated experiments from tests. 
Change-Id: I428906a1d75a0dacedc8a5d5fd805f84ca8e3ce0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/311156
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2023-06-24 16:23:28 +00:00
Danny Tuppeny 76761576a2 [analysis_server] Move "dart fix" prompt into base server for use by both protocols 
Change-Id: I5abc6172b1cdb83c855064eb5a7b81a5d4930c07
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/291823
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2023-03-29 20:50:37 +00:00
Brian Wilkerson f4bbc427c3 Implement the legacy protocol for showing messages and URIs to users 
There is a desire to unify the two subclasses of the analysis server,
but I didn't attempt to do that in this CL.

Change-Id: I17bbf4f6247fc547df1c82f02e74c50eabe7aadc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/291000
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Jaime Wren <jwren@google.com>
 2023-03-24 18:10:17 +00:00
Konstantin Shcheglov 6c7f3ab27d Revert "Use Feature to specify experiments." 
This reverts commit fce81082c0.

Reason for revert: I changed my mind, specifically about using something else than `String` in `AnalysisOptionsFileConfig`.

Original change's description:
> Use Feature to specify experiments.
>
> Change-Id: Ide1a58c93cfc4920dff3ab2f52113434de93fff0
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/288162
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
> Commit-Queue: Konstantin Shcheglov <scheglov@google.com>

Change-Id: Ib6eb1c04c099e318e935e9761f12bf35f561389f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/288260
Auto-Submit: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2023-03-10 17:06:17 +00:00
Konstantin Shcheglov fce81082c0 Use Feature to specify experiments. 
Change-Id: Ide1a58c93cfc4920dff3ab2f52113434de93fff0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/288162
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2023-03-10 16:14:38 +00:00
Konstantin Shcheglov b63c0c545a Add missing features to PubPackageAnalysisServerTest.experiments, remove duplicates. 
Change-Id: Icc48a13123177406e5fbc7793c9d03228edad5c2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/281948
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2023-02-09 21:07:53 +00:00
Konstantin Shcheglov 0376883986 Rename Local refactoring for pattern variables. 
Change-Id: I283532d19d165b9c1442c026a76ef40b47a0c00f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/279205
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2023-02-09 20:05:17 +00:00
Konstantin Shcheglov 97f5626a6f Issue 50960. Revert delaying removing file overlays. 
This reverts 6de7ea7432

This hurts our external users, and I got an impression that the
scenario for which we designed it initially is not the way our
internal developers works now.

Bug: https://github.com/dart-lang/sdk/issues/50960
Change-Id: I9b1ecf4860146d67963c5c99ecefc581e1526a89
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278883
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2023-01-11 18:59:12 +00:00
Sam Rawlins 166c54b4d9 analyzer: Mark implicit-casts and implicit-dynamic as deprecated 
Also add a fix which replaces 'implicit-casts' with 'strict-casts' and
a fix which replaces 'implicit-dynamic' with 'strict-raw-types'.

Fixes #47902

This reverts 5050f31b29

Change-Id: Icd156b0dda78a50ed28272ddef7460018f511cc2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/276766
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2023-01-03 17:30:28 +00:00
Sam Rawlins 94f20d7731 Revert "Remove all support for all strong-mode analysis options" 
This reverts ea120b5d44

Change-Id: I97a1bf6ced06bf8bcab50a2fdb41732f13182a84
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/276026
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-12-16 00:47:49 +00:00
Sam Rawlins ea120b5d44 Remove all support for all 'strong-mode' analysis options 
Fixes https://github.com/dart-lang/sdk/issues/50679

Change-Id: I3572faf51276f5c7551d35b7725c799567189413
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/274921
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2022-12-13 21:32:24 +00:00
Konstantin Shcheglov f3d919308f Use different marker file to identifier Blaze workspace. 
Bug: https://github.com/dart-lang/sdk/issues/49629
Change-Id: I8f1496735373494745a79d502488a217e3c71223
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/254480
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2022-08-10 19:58:43 +00:00
Konstantin Shcheglov 43065920cc Rename Bazel to Blaze - files, classes, methods. 
No changes to implementation yet, we still look for both Blaze and Bazel.

Bug: https://github.com/dart-lang/sdk/issues/49629
Change-Id: Iaf1b1cc2c9a8cf28d8bbfb5541819a1f5c8a3de6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/254343
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-08-10 16:00:18 +00:00
Brian Wilkerson 60773b9135 Rename two classes 
Change-Id: I3fe6f0e4a4f3e8d04994a21c97e608fe8065e5ac
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/253902
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2022-08-08 04:11:19 +00:00
Lasse R.H. Nielsen 3fc0bf7e59 Retire the 2.17 language feature experiment flags. 
Remove them from tests.
(They should have been removed from tests before launcing 2.17.)

Change-Id: I546f6cb90fdf9e6ed1bb560f3715f9db163b7c68
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/250384
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Devon Carew <devoncarew@google.com>
Commit-Queue: Lasse Nielsen <lrn@google.com>
 2022-07-11 13:02:22 +00:00
Brian Wilkerson 9f97ab9602 Restructure analytics support 
I wanted to be able to plug in different kinds of analytics reporters,
and that's still a goal, but with the desire to make it possible for
users to see what data we are collecting I needed to change the level
at which reporters are plugged in.

This CL doesn't change the behavior of the code, but it does split the
classes out into separate files and collapse the AnalyticsManager class
and its subclasses into a single class, requiring that different
reporters be implemented by implementing the Analytics class instead.

Change-Id: Ia98ff225f97ae747d89c61fe98f520ce0b5e9961
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/249943
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-06-27 21:19:32 +00:00
Konstantin Shcheglov 1b9554d481 Add 'textToMatchOverride' for 'setState' completion. 
Bug: https://github.com/dart-lang/sdk/issues/49233
Change-Id: I74fd86fc7f49c932e6698e474842078ff823f3cf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/247933
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-06-13 00:54:16 +00:00
Brian Wilkerson 3e1bad6e7a Record startup information for analytics 
In order to avoid passing several pieces of data through several layers
of the API, this change passes the analytics manager down. This means
that we're creating the manager earlier, but I think it keeps the code
cleaner.

Change-Id: I096e416c1aa445f5f7382ae666b3d02d0abf0a0f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/246320
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-05-27 19:29:20 +00:00
Konstantin Shcheglov cf36021633 Migrate AnalysisHoverBazelTest to BazelWorkspaceAnalysisServerTest. 
Change-Id: Ibafbeb27d6b494c2139a298dd3e3cab74c7c1e4e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/241994
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-04-22 21:07:29 +00:00
Konstantin Shcheglov 994b2e2f47 Deprecate newAnalysisOptionsYamlFile2(), use newAnalysisOptionsYamlFile(). 
Change-Id: Ia86808f649459e6c4c9c7d4e488273c1e593a85b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/241515
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-04-19 15:49:57 +00:00
Brian Wilkerson 52e7099c66 Move state out of the completion domain so that handlers can share it 
Change-Id: I71381f11725af109f5c6f67fa8ec28f04ab475a8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/241513
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-04-19 15:37:37 +00:00
Konstantin Shcheglov 20b560226e Rename newFile2() to newFile(). 
Change-Id: I1c2a4f15dee607a0a6241dfaf2d764a7d284389b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/241510
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-04-19 02:59:57 +00:00
Konstantin Shcheglov d234ad2e87 Migrate more tests to PubPackageAnalysisServerTest. 
Change-Id: I1375531f2a1c917765f0b4d8fcbb2e3d49d4e7c5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/240782
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-04-12 22:01:52 +00:00
Konstantin Shcheglov df0ebab22b Fix BulkFixesTest on Windows. 
Change-Id: I8ff97c7a7cc94f7d7bd762b113db65cbf5321625
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/240648
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-04-08 20:30:09 +00:00
Konstantin Shcheglov 9ab676b6d0 Migrate analysis domain tests to PubPackageAnalysisServerTest. 
Change-Id: I684d027906b118d2c0fddd8f64930ae291ed8827
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239365
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-03-30 17:01:00 +00:00
Konstantin Shcheglov 0640f6e1e3 Move navigation tests to PubPackageAnalysisServerTest. 
Change-Id: I7c98b5621bca9b204a253faec5e45488e1ef1bc9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239260
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-03-29 18:09:51 +00:00
Konstantin Shcheglov 38a0305768 Inline 'testFilePathPlatform' as 'testFile.path'. 
Change-Id: I6b27af152f91a639e1dfc09a2b1a4da286692a38
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239124
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-03-29 05:55:45 +00:00
Konstantin Shcheglov 4247bcbbdc Extract PubPackageAnalysisServerTest. 
Change-Id: Ib952f26c226f147221471af0366bf9c95c7bc5b2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239201
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-03-28 21:48:20 +00:00