eff8c0d946
[macros] Finish and fix ExtensionTypeDeclaration.
...
Add corresponding `DeclarationKind`, rename `onType` to
`representationType`.
R=jakemac@google.com , scheglov@google.com
Change-Id: I0ce697de6c0b03d4a69a0f55379a0c9d9850233b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/340400
Reviewed-by: Jake Macdonald <jakemac@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Auto-Submit: Morgan :) <davidmorgan@google.com >
2023-12-07 15:37:39 +00:00
296a7f642e
[macros] Remove Introspectable* types.
...
Per https://github.com/dart-lang/language/issues/3442 inrospection will
be allowed to succeed if possible, failing if there are cycles.
Change-Id: I341cc4ae87d1399df82cebb1d5c9df7e5070e777
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/339620
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Jake Macdonald <jakemac@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Commit-Queue: Morgan :) <davidmorgan@google.com >
2023-12-07 09:44:59 +00:00
5650e743d5
Macro. Fix executor_test after the previous CL.
...
https://dart-review.googlesource.com/c/sdk/+/339722
Change-Id: I0d26aa33cbe5ee3454e49700fc3fc51fecd5ebd1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/340061
Reviewed-by: Jake Macdonald <jakemac@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2023-12-05 21:19:09 +00:00
613fa1f5aa
fix executor_test.dart for hasAbstract changes
...
Bug: https://github.com/dart-lang/sdk/issues/54130
Change-Id: If3554796de99ed0e8b8ea37ae159e89bcc5cbcf6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/337860
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Auto-Submit: Jake Macdonald <jakemac@google.com >
2023-11-22 18:52:20 +00:00
e6ebb9340f
remove unmeaningful constructor parameters from ConstructorDeclarationImpl
...
Change-Id: I1bb5712349198d3a1658c405a164aa38d447c752
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/337660
Commit-Queue: Jake Macdonald <jakemac@google.com >
Auto-Submit: Jake Macdonald <jakemac@google.com >
Reviewed-by: Morgan :) <davidmorgan@google.com >
2023-11-22 17:37:22 +00:00
a1b8fa4613
move hasAbstract from FunctionDeclaration to FieldDeclaration
...
Bug: https://github.com/dart-lang/language/issues/3454
Change-Id: Ic157dcd1e2c82c8cc08cd225065fd2810a8b02f2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/335240
Reviewed-by: Morgan :) <davidmorgan@google.com >
Commit-Queue: Jake Macdonald <jakemac@google.com >
2023-11-21 23:18:10 +00:00
8d62c1962c
Add extension type macro and declaration interfaces and implementation.
...
Add test coverage: `SimpleMacro`, `executor_test`, `serialization_test`.
R=jakemac@google.com
Bug: https://github.com/dart-lang/language/issues/3224
Change-Id: I17a814b18231db60a33b41099c93c0978cebae1b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/337543
Reviewed-by: Jake Macdonald <jakemac@google.com >
Commit-Queue: Jake Macdonald <jakemac@google.com >
Auto-Submit: Morgan :) <davidmorgan@google.com >
2023-11-21 16:55:34 +00:00
307a46f991
Add arguments to ConstructorMetadataAnnotation.
...
Support serializing them. Add helper methods to serialize lists of `Code` and `Map<String, Code`.
R=jakemac@google.com
Bug: https://github.com/dart-lang/language/issues/3443
Change-Id: If03b4ad5bf761b089f800834fc103b26143a0ddc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/335446
Commit-Queue: Jake Macdonald <jakemac@google.com >
Reviewed-by: Jake Macdonald <jakemac@google.com >
Auto-Submit: Morgan :) <davidmorgan@google.com >
2023-11-13 17:12:00 +00:00
0ffd54738a
add declarationKind for extensions and libraries, support augmenting extensions and add test
...
Change-Id: I510976cac641800e664e92e7db786962d539ec9c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/325021
Reviewed-by: Bob Nystrom <rnystrom@google.com >
Commit-Queue: Jake Macdonald <jakemac@google.com >
Auto-Submit: Jake Macdonald <jakemac@google.com >
2023-09-11 15:56:23 +00:00
abc7a21679
add Builder.report method and Diagnostic class to support macros sending diagnostics
...
Will follow up with tests once we agree on the API. At the same time I will handle translating any normal runtime errors into error diagnostics.
Bug: https://github.com/dart-lang/language/issues/3234
Change-Id: I2fc22af088f0e50b1877022aa793337850257804
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/317221
Commit-Queue: Jake Macdonald <jakemac@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2023-08-30 17:43:42 +00:00
597444b54e
add hasBody getter to FunctionDeclaration
...
Bug: https://github.com/dart-lang/language/issues/3078
Change-Id: I3b14d050062d0c2e90e6e0f5614dcc25e87a23fb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/316060
Reviewed-by: Bob Nystrom <rnystrom@google.com >
Commit-Queue: Jake Macdonald <jakemac@google.com >
2023-08-01 16:00:29 +00:00
91f389ed6a
Drop use of package:_dart_internal in _fe_analyzer_shared
...
This is largely a copy of https://github.com/leafpetersen/cast , with some extra magic.
Change-Id: Iff92ac9a57b1cfbaa67fe15647aabb8858442b60
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/316880
Reviewed-by: Leaf Petersen <leafp@google.com >
Commit-Queue: Jake Macdonald <jakemac@google.com >
2023-07-28 22:36:44 +00:00
e12698594c
Move more macro apis to has* instead of is* nomenclature.
...
These are intended to be syntactic and not semantic in meaning, so I think has* is a better name.
Change-Id: Ia2a8a276c1057bde913eb755cc1a7a559d953774
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/315960
Commit-Queue: Bob Nystrom <rnystrom@google.com >
Reviewed-by: Bob Nystrom <rnystrom@google.com >
Auto-Submit: Jake Macdonald <jakemac@google.com >
2023-07-24 20:51:38 +00:00
5220b9e5f7
Add Extension declaration introspection and extension macros
...
Bug: https://github.com/dart-lang/language/issues/3223
Change-Id: I43e0ea17ea1bf8dbb41ad899675ac25d26ca568f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/315300
Commit-Queue: Jake Macdonald <jakemac@google.com >
Reviewed-by: Bob Nystrom <rnystrom@google.com >
Auto-Submit: Jake Macdonald <jakemac@google.com >
2023-07-24 15:24:10 +00:00
9803ffef27
Add support for macros adding mixins and interfaces to existing types in
...
the types phase.
Also seales the Code types hierarchy to block users from attempting to
create their own subclasses.
Bug: https://github.com/dart-lang/language/issues/3211
Change-Id: I51ebdfdad6e1fba3c19ef91f25e238730e98e740
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/314821
Auto-Submit: Jake Macdonald <jakemac@google.com >
Reviewed-by: Bob Nystrom <rnystrom@google.com >
Commit-Queue: Jake Macdonald <jakemac@google.com >
2023-07-21 15:18:33 +00:00
1b99100e2e
Add API for resolving any identifier in the final macro phase.
...
- Rename declarationOf to typeDeclarationOf.
- Add declarationOf api for general declarations.
- Tighten the type of typeDeclarationOf in the final phase to avoid unnecessary
casts in user code.
- Refactor message handling a bit to unify the error handling.
Bug: https://github.com/dart-lang/language/issues/3216
Change-Id: Ia61da19374abec77853d37e110a08f7dfe0d3b10
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/314280
Commit-Queue: Jake Macdonald <jakemac@google.com >
Auto-Submit: Jake Macdonald <jakemac@google.com >
Reviewed-by: Bob Nystrom <rnystrom@google.com >
2023-07-19 13:56:08 +00:00
c5bd32bac2
Major refactor to simplify the macro introspection interfaces.
...
Each phase now only has a single interface, instead of several of them. This
reduces the number of classes dramatically and also reduces the number of
objects actually sent over the wire.
It also means fewer things to name and a less polluted namespace.
Change-Id: Ib84b76ac4c0a04abfac5fd5650a228046b1bf1d4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/313721
Reviewed-by: Bob Nystrom <rnystrom@google.com >
Commit-Queue: Jake Macdonald <jakemac@google.com >
2023-07-17 17:28:35 +00:00
4f8061da63
Add MetadataAnnotation class and metadata fields to relevant objects
...
Bug: https://github.com/dart-lang/language/issues/1930
Change-Id: I3ba6facd4c0487b0af18108c8d1db21ee6d5a498
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/313640
Auto-Submit: Jake Macdonald <jakemac@google.com >
Reviewed-by: Bob Nystrom <rnystrom@google.com >
Commit-Queue: Jake Macdonald <jakemac@google.com >
2023-07-14 15:55:20 +00:00
1a13ea6c05
Add a disposeMacro api, with TODOs in the implementations to call it.
...
Change-Id: I38049ca8b851c2203ddaaa729ef651e7802a1d2b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/312860
Auto-Submit: Jake Macdonald <jakemac@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Commit-Queue: Johnni Winther <johnniwinther@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2023-07-10 12:01:49 +00:00
f254c8a4ba
Add library macro definitions and support for executing them.
...
These are intended to be applied by annotating a library directive.
Note that some parameter types had to be widened since `Library` is not a subtype of `Declaration`. Ultimately I think that is fine though.
Bug:https://github.com/dart-lang/language/issues/2839
Change-Id: Ia1311c8aea729f2bd8b76173ce4c7595a6a37a42
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/312140
Reviewed-by: Bob Nystrom <rnystrom@google.com >
Auto-Submit: Jake Macdonald <jakemac@google.com >
Commit-Queue: Jake Macdonald <jakemac@google.com >
2023-07-05 18:56:53 +00:00
34f25c4a28
Add library introspection apis for macros.
...
Allows you to ask for the types in a library in the declarations phase, and all
the top level declarations in the definitions phase.
Bug: https://github.com/dart-lang/language/issues/2839
Change-Id: If0f8fb777fd8a006d686d457cf5d5ca11fcca9ee
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/311900
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Jake Macdonald <jakemac@google.com >
Reviewed-by: Bob Nystrom <rnystrom@google.com >
2023-06-29 22:05:58 +00:00
d1ecf01f71
Cache remote objects by ID, only send IDs for already sent objects
...
This is done through a synchronized cache between the server and client. When serializing a remote instance, if the server has already serialized that object then it will only send the ID in the future.
These caches currently only live as long as a single macro application in a given phase, but could live longer in the future. They do need to get reliably cleared out to avoid memory leaks though, and the shorter lifetime is easier to manage consistently.
This also allowed me to remove the specialized server/client modes (clients would always only send back IDs previously).
Change-Id: I4e8a102403153829d66b0ac379636f5a95a70cea
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/311420
Commit-Queue: Jake Macdonald <jakemac@google.com >
Reviewed-by: Bob Nystrom <rnystrom@google.com >
2023-06-26 22:36:37 +00:00
b9bcfa7004
add Library and LanguageVersion classes, all declarations now have a library
...
Bug: https://github.com/dart-lang/language/issues/2839
Change-Id: Id09b2da070302b67f7c9921f1ad8a6d91a129f77
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/311000
Reviewed-by: Bob Nystrom <rnystrom@google.com >
Commit-Queue: Jake Macdonald <jakemac@google.com >
2023-06-22 20:37:14 +00:00
96dcb2a5ab
add support for type annotations and code arguments
...
Change-Id: I14ad05e810494de94f7935b7ca11b1922f90ecda
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/309021
Reviewed-by: Bob Nystrom <rnystrom@google.com >
Commit-Queue: Jake Macdonald <jakemac@google.com >
2023-06-16 16:59:06 +00:00
4590fc83e7
Reland "Add wrappers for macro arguments to help with serialization."
...
The type arguments have to be explicitly given for collection types,
but this should be doable given they are all constants and only certain
types are allowed.
Change-Id: I2721f37d194d73de1df81302298101adeb87534c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/309460
Commit-Queue: Jake Macdonald <jakemac@google.com >
Reviewed-by: Bob Nystrom <rnystrom@google.com >
2023-06-16 14:02:05 +00:00
396ed71267
Revert "Add wrappers for macro arguments to help with serialization."
...
This reverts commit ea7e014c3chttps://github.com/dart-lang/language/issues/2212
> Change-Id: I14a688ed294cf060c004849efa975b5bef053d5b
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/308202
> Reviewed-by: Bob Nystrom <rnystrom@google.com >
> Reviewed-by: Johnni Winther <johnniwinther@google.com >
> Commit-Queue: Jake Macdonald <jakemac@google.com >
> Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Bug: https://github.com/dart-lang/language/issues/2212
Change-Id: I402802c7a1c27f9aee3f23baef8c0deb71ec06e9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/309284
Commit-Queue: Ilya Yanok <yanok@google.com >
Reviewed-by: Alexander Thomas <athom@google.com >
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com >
2023-06-14 15:34:37 +00:00
ea7e014c3c
Add wrappers for macro arguments to help with serialization.
...
In particular this allows us to reproduce type arguments for collections in the
macro expansion isolate.
The type arguments have to be explicitly given for collection types,
but this should be doable given they are all constants and only certain
types are allowed.
Bug: https://github.com/dart-lang/language/issues/2212
Change-Id: I14a688ed294cf060c004849efa975b5bef053d5b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/308202
Reviewed-by: Bob Nystrom <rnystrom@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Commit-Queue: Jake Macdonald <jakemac@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2023-06-14 14:54:30 +00:00
310baf2737
mark all public interfaces as abstract interface classes
...
make Code a sealed type, and all subtypes base classes
Change-Id: I328b6a25446dc89e88ae2f1c7e137b969f1b86ce
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/306682
Reviewed-by: Bob Nystrom <rnystrom@google.com >
Commit-Queue: Jake Macdonald <jakemac@google.com >
2023-06-01 19:30:41 +00:00
cb4c9c74de
Add support for mixin declarations in the macro APIs
...
Adds MixinDeclaration/IntrospectableMixinDeclaration for introspection.
Adds MixinTypesMacro/MixinDeclarationsMacro/MixinDefinitionsMacro macro
interfaces.
Updates supporting serialization/execution code and tests.
Change-Id: I57245fe7d177b6d5ba57649455fbd844ba1f85c3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/294380
Reviewed-by: Bob Nystrom <rnystrom@google.com >
Commit-Queue: Jake Macdonald <jakemac@google.com >
2023-04-18 16:04:00 +00:00
70559a9514
Add support for enums in the macro APIs
...
This includes introspection support, support for annotating and executing macros targeted at enums and enum entries, and support for creating library augmentations of enums with proper syntax (including enum entries).
I also refactored some of the Class support to be more general so we can share interfaces where appropriate.
Change-Id: Ie9111ff280405496e55e32478a19c104341aee37
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/294100
Commit-Queue: Jake Macdonald <jakemac@google.com >
Reviewed-by: Bob Nystrom <rnystrom@google.com >
2023-04-07 19:57:55 +00:00
1eed933de0
[macros] add RecordTypeAnnotation and RecordField introspection types, as well as
...
RecordTypeAnnotationCode and RecordFieldCode for building Record type
annotations as code instances
Change-Id: I3430a644cd2dc45c7a220f66897be20e1399bf15
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/291640
Commit-Queue: Jake Macdonald <jakemac@google.com >
Auto-Submit: Jake Macdonald <jakemac@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
2023-03-29 14:23:00 +00:00
b165921081
[macros] change keyword getters to has* style names and fix up usages
...
Change-Id: I996b7cc2cd6e958c826db892978ea8de8bf78281
Bug: https://github.com/dart-lang/language/issues/2930
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/289902
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Commit-Queue: Jake Macdonald <jakemac@google.com >
2023-03-21 19:36:54 +00:00
f5321673ad
[macros]: Add new class modifiers to ClassDeclaration
...
Change-Id: I9aa2b0156a99674cd377bb7686a9f70c38642ff6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/289084
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Auto-Submit: Jake Macdonald <jakemac@google.com >
2023-03-20 15:55:04 +00:00
40e18905f2
Fixed various typos in a lot of files
...
Closes https://github.com/dart-lang/sdk/pull/49478
TEST=Manual
GitOrigin-RevId: f4c9c6869dfe73639295e86574a021523b3d374d
Change-Id: I134a97caed4eec59d70e9cbca16b7e9a472cf2c1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/251902
Reviewed-by: Michael Thomsen <mit@google.com >
Commit-Queue: Alexander Thomas <athom@google.com >
Reviewed-by: Aske Simon Christensen <askesc@google.com >
Reviewed-by: Kevin Chisholm <kevinjchisholm@google.com >
Reviewed-by: Alexander Thomas <athom@google.com >
2022-07-25 12:21:59 +00:00
e43aad1984
This is a precursor CL to a client side only InterfaceType class, which requires the ability to look at type parameters for arbitrary types in the program, in the declaration phase.
...
Move TypeDeclarationResolver to be available in the Declaration phase.
Add IntrospectableType interface, and IntrospectableClassDeclaration which implements it (we will eventually have IntrospectableMixinDeclaration, IntrospectableEnumDeclaration, etc).
Migrate ClassIntrospector to InterfaceIntrospector, which operates on IntrospectableType instances instead of ClassDeclaration instances.
Question: Possibly `InterfaceIntrospector` should have a different name, maybe just `TypeDeclarationIntrospector`?
Change-Id: Ifd202bad61eeae5f7d76d769d9d96a866c0fecdb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/247060
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Jake Macdonald <jakemac@google.com >
2022-06-28 14:02:12 +00:00
9846fe2621
Add FunctionTypeParameter and Parameter classes
...
Bug: https://github.com/dart-lang/language/issues/2208
Change-Id: I2a9bed6cc243eef2bfa313f7280d1d60c51a7b36
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/242140
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Commit-Queue: Jake Macdonald <jakemac@google.com >
2022-04-22 19:20:19 +00:00
aa1596735a
support Set instances in macro arguments, add some more testing of various supported Argument types
...
Change-Id: I0d61a6d88dba41421fe8f3cbd3e14c62bbfa4843
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/241682
Auto-Submit: Jake Macdonald <jakemac@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2022-04-19 20:18:38 +00:00
1f543bcedf
Refactor how actual executor instances are created.
...
- removes the `loadMacro` api entirely
- adds new apis to MultiMacroExecutor
- registerExecutorFactory
- unregisterExecutorFactory
- libraryIsRegistered
- Removes the MacroClassIdentifier, instantiateMacro takes a library uri and class name
- Drop precompiledMacroUris from CompilerOptions, only have a macroExecutor now
Change-Id: Ic33933b34dbfd637da3d841ff496582f688dcd87
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239466
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Jake Macdonald <jakemac@google.com >
2022-04-05 19:25:13 +00:00
ef413b95e0
add a socket communication option for the process executor
...
Change-Id: I0bf2ca9c8737ec0e0035e1e8e42a5e3aa3ea813c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239581
Reviewed-by: Jens Johansen <jensj@google.com >
Auto-Submit: Jake Macdonald <jakemac@google.com >
Commit-Queue: Jake Macdonald <jakemac@google.com >
2022-03-31 16:35:05 +00:00
e50b7e77b8
[macro] Support fresh names in MacroExecutor.buildAugmentationLibrary
...
This adds support for generating truly unique fresh names when building
augmentation library code. The synthesized names are used for import
prefixes and as placeholders for not-yet-inferred omitted type
annotations.
Change-Id: I6fe9bc37b39a243c93187f561ee32e07237341f1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/237823
Reviewed-by: Jake Macdonald <jakemac@google.com >
Commit-Queue: Johnni Winther <johnniwinther@google.com >
2022-03-22 16:30:08 +00:00
ded8936d35
Add TypeInferrer interface, this is what macro authors will use to infer real types from OmittedTypeAnnotations.
...
Bug:https://github.com/dart-lang/language/issues/2154
Change-Id: I00484ddbd09a3c2371b96e540b9926144d80c832
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/237844
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Commit-Queue: Jake Macdonald <jakemac@google.com >
2022-03-21 16:19:47 +00:00
8d2c630052
add OmittedTypeAnnotation and support in code objects
...
Bug: https://github.com/dart-lang/language/issues/2154
Change-Id: Ie48d308a822798da22ea38954774e393f81e2e2a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/237740
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Commit-Queue: Jake Macdonald <jakemac@google.com >
2022-03-18 14:30:07 +00:00
2c430537c6
add IdentifierResolver api, which allows you to get identifiers for a
...
given symbol in a given library
Change-Id: I665b3bd2fa6fe7bb64375873e9ae9343e7922a3b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/234904
Auto-Submit: Jake Macdonald <jakemac@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Reviewed-by: Chloe Stefantsova <cstefantsova@google.com >
Commit-Queue: Johnni Winther <johnniwinther@google.com >
2022-03-03 16:51:50 +00:00
fb5503960f
Add a map of class name to augmentations in MacroExecutionResults to assist with merging.
...
There should now only be a single `augment class` declaration (per augmented class) in a given augmentation library.
Change-Id: I32a56baef63a0658df23b3c52e398597c09f8ba2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/234106
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Commit-Queue: Jake Macdonald <jakemac@google.com >
2022-02-24 17:31:21 +00:00
621ea99c80
Work around windows test failures
...
This directory sometimes fails to delete due to files being still "in use".
If we have a better fix than just ignoring it let me know, but its just a temp dir used in a test.
Change-Id: I5c8e76192230cf2b033d9bcb4a86940ddf974517
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/233522
Auto-Submit: Jake Macdonald <jakemac@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Commit-Queue: Johnni Winther <johnniwinther@google.com >
2022-02-17 22:27:41 +00:00
7822eb9107
Add a macro executor which spawns and talks to a different process.
...
This also:
- Adds support to the bootstrap code to handle communicating via sendPort or stdio
- Refactors pretty heavily the isolate executor code such that it can be reused.
- Refactors the isolated executor test into a shared test for all executors
- Removes the mirror based executor entirely - I don't see a path forward with this one.
- Reorganizes all executor based files under macros/executor
Change-Id: I2fc6bb3e6ce56c8b331719f4dc08617b3a521398
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/233200
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Commit-Queue: Jake Macdonald <jakemac@google.com >
2022-02-17 20:40:21 +00:00
David Morgan