dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
69,240 Commits 2 Branches 0 Tags
c81efbe59aab99f969ea7af1ed722c5fb101c19c
Commit Graph

3368 Commits

Author SHA1 Message Date
Sam Rawlins 327b1eb24f analysis_server: Make private fields final where possible 
Change-Id: Ibdeb7e66f07bf81205d70ac5d1c4cb4aa5a97671
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129360
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2020-01-08 22:08:02 +00:00
pq d9570f907e fix for avoid_redundant_argument_values 
UPDATE (1/3): blocked until new linter lands.

See: https://github.com/dart-lang/linter/issues/1927

Change-Id: I432f7c61aa9d5b6b0c0abda798f3d731e5fc93b2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/130160
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-01-08 20:36:20 +00:00
Danny Tuppeny c8c367bb10 Add valueRange field to LSP Flutter Outline attributes 
Include range of values in LSP FlutterOutline notifications

Change-Id: I07cbe970d553f793dbdb4cb282807eec12720017
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/130680
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-01-08 20:10:06 +00:00
Brian Wilkerson 5b6bdaba64 Gracefully handle a race condition in code completion (issue 40008) 
Change-Id: I4dcef63210e2318594fe15484e00b72ca126e49a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/130760
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Devon Carew <devoncarew@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-01-08 19:03:55 +00:00
Konstantin Shcheglov e85e203e73 Deprecate DartType.name 
Change-Id: If3a967bba976aa78493764513edbb3d406b08d27
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/130625
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-01-08 07:00:59 +00:00
Sam Rawlins 1f55149f87 migrator: Fix HTML-rendered text in navigation and tooltips 
Fixes #39830

The instrumentation_output_test.dart was very old; used dead LibraryInfo class.
Moved this test, renamed to unit_renderer_test.dart.

Change-Id: I8a7538ab3d152944fd93ee6dcab39202344b613b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/130562
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2020-01-07 21:48:10 +00:00
Brian Wilkerson e5705943d8 Enable prefer_conditional_assignment in several packages 
Other than the changes to the code generators and the analysis options
files, the changes were all generated by dartfix.

Change-Id: I80055e3992452c5b40eed41ac79807cf5c932976
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/130340
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-01-06 05:19:19 +00:00
Brian Wilkerson 75e557cdea Add a fix for prefer_collection_literals by extracting the assists to make them reusable 
The code to convert to a list or map literal is essentially unchanged,
but I had to make several changes to extract `ConvertToSetLiteral` and
make it work as a fix, primarily in the conversion of invocations of
`toSet`.

Change-Id: I365f5fc84f4a037b31ec69d78b05d7d5574666ad
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/130220
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-01-05 17:02:57 +00:00
Danny Tuppeny becc97c8a2 Show parens in LSP workspace symbols for methods/functions 
Change-Id: I7f428eefbc4783dcd0ec3c2f16ed1e9d1ef7a903
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129714
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-01-03 15:49:39 +00:00
Konstantin Shcheglov 219282fe5b Extract individual assists / fixes into separate classes. 
I noticed that assist_internal and fix_internal have 3500+ and 5000+
lines, and base_processor seems doomed to repeat their fate. If we
could keep separate assists and fixes in separate classes and libraries,
we could isolate their specific machinary of helper classes and methods.
And maybe even improve code with time.

This CL is a proposal for a way to do this.

We share CorrectionBuilderContext across multiple producers, so overhead
is small - only creating producer instances and setting the context.

I considered separating assists and fixes into corresponding directories,
but when we have shared builders, we would need to put builders into
yet another directory, and have three libraries that are named
similarly - xyz_builder.dart, xyz_assist.dart, xyz_fix.dart... Not nice.
So, hopefully we don't have accidential name collisions.

R=brianwilkerson@google.com, pquitslund@google.com

Change-Id: Iacf0b27a40227645f249e69921f2b8d9bfe1d5ca
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129820
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-01-02 21:06:33 +00:00
Konstantin Shcheglov d5c4099d1b Remove BUILT_IN_IDENTIFIER_AS_TYPE error code for 'addAsync' quick fix. 
We report UNDEFINED_IDENTIFIER_AWAIT instead.

R=brianwilkerson@google.com

Change-Id: I9950e4a332b2a4f28232a36631f2f809d14068cd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/130008
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-01-02 19:44:09 +00:00
Danny Tuppeny 7981947f75 Don't statically register LSP capabilities that will be dynamically registered 
Fixes https://github.com/dart-lang/sdk/issues/39949.

Bug: https://github.com/dart-lang/sdk/issues/39949
Change-Id: I3a18ecfafae04d2a79841ead1481c8ad6c6cee83
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129711
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-01-02 17:23:06 +00:00
Brian Wilkerson 91d6e1a0a7 Enable annotate_overrides in several packages 
Other than analysis_server/test/analysis/notification_overrides_test.dart,
which had a naming conflict, all of the changes were made using dartfix.

Change-Id: I911dd75dcdee00420caa48724125e86d47c8857d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/130002
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-01-01 21:31:40 +00:00
Brian Wilkerson d85f295496 Minor cleanup of DartFixInfo 
Change-Id: I0a6d2b2fcac992471952fe3fcb7bfec1aea8d9c3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/130001
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-01-01 21:23:45 +00:00
Brian Wilkerson beb2ba31f7 Improve the fix for avoid_init_to_null to match the lint 
Change-Id: Idc23dfebd96bb98125328e0297bfc3d81baa9775
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/130000
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-01-01 21:23:36 +00:00
Konstantin Shcheglov 9445dcc105 Use DartType.isDartCoreList in analysis_server. 
R=brianwilkerson@google.com, devoncarew@google.com

Change-Id: I64cf52a06b08577215e7763f047f0cbea6390209
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129830
Reviewed-by: Devon Carew <devoncarew@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-12-30 20:49:12 +00:00
Devon Carew 37b78b601d [analyzer] improve the cursor insertion position for required params 
Change-Id: I28f3d4677de34d3dc6e28e9e71d73b99c895615c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129825
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2019-12-30 01:09:48 +00:00
Brian Wilkerson 4264c5ebd8 Add a fix for prefer_if_null_operators 
Change-Id: I5290016b069d3e31f7b370dbc85d1a6ed65b57f1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129822
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-12-29 17:31:47 +00:00
Devon Carew 28a1067b25 [analyzer] insert missing params before child/children 
Change-Id: Ic2c19ebcb8e4c6a7d89c2c1317c18ebd00bc6e96
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129823
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2019-12-29 04:05:16 +00:00
Brian Wilkerson 7d41ae7d15 Enable unnecessary_this in several packages 
Change-Id: I743066d66dbf1dff984e8f8bf5b7a472c9bc7ff7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129821
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-12-28 20:43:16 +00:00
Brian Wilkerson 98cc7d2729 Enhance the fix for unnecessary_this to handle constructor initializers 
Change-Id: I751913abf213c42de8d66508012e280438f1f11d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129810
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-12-27 21:14:45 +00:00
Brian Wilkerson c547f5d933 Enable prefer_generic_function_type_aliases in most of the packages 
Change-Id: I1338e731aa3f42f67fec605b20455a83fd5fce43
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129760
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-12-27 00:43:14 +00:00
Konstantin Shcheglov 2fb3f09948 Extract TypeProvider class into lib/dart/element/type_provider.dart file 
Change-Id: I96cdfccc33e35a9625c14a89a08826758eac0f2c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129601
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-12-26 21:31:04 +00:00
Brian Wilkerson 57ef46ad40 Add newly added fixes to the master list (TBR) 
Change-Id: Ic6109ba20c86eadf893e41b940c305da85ffdf9c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129740
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-12-26 17:14:54 +00:00
Brian Wilkerson a8570355bb Add a fix for prefer_generic_function_type_aliases 
Change-Id: Ifc9788cc6228a677ba425a2b0b283eca0155477a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129720
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-12-26 15:28:04 +00:00
Brian Wilkerson 7dcd5aa2fa Add a fix for prefer_adjacent_string_concatenation 
Change-Id: I730789ee91c48fb98b95fa013daac93940ff42fe
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129660
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-12-26 15:27:56 +00:00
Brian Wilkerson ead0993f14 Address comments from a previous CL 
Change-Id: Ie0c452b054b8888d9d3bf1495d25ea4f582fb879
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129561
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-12-26 15:16:04 +00:00
Brian Wilkerson 8736fec094 Add a fix and assist for omit_local_variable_types and enable it through dartfix 
Change-Id: If0348d0463e73abbc5c0d20127bc9f22f93e53de
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129480
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-12-23 21:59:00 +00:00
pq 77f645ed71 assist to surround w/ setState 
Change-Id: Ia441479bc15708fe95343e234bbdf4d91966aa5a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129460
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-12-23 18:56:50 +00:00
Sam Rawlins 71fb1ba3a8 analysis_server: clean up 2 more pedantic lints 
Change-Id: I8095e69ece227b95522439fae571f152db4e3b25
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129337
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2019-12-23 02:49:07 +00:00
Devon Carew e7f0402ebf [analyzer] disable crash reporting for the AngularDart analysis plugin 
Change-Id: I49dddc4901c9cada643c5c024b8580f06c81a0d6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129331
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2019-12-22 23:04:57 +00:00
Brian Wilkerson 4a639e8df2 Add support to dartfix for the remaining pedantic lints (for which a fix is already implemented) 
Change-Id: I6d7b0df1ce4fc7377697d4c66b78f2fb0e95b5c4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129362
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-12-21 22:31:49 +00:00
Konstantin Shcheglov ca202b9582 Remove unnecessary isSubtypeOf() in ExtensionMemberContributor. 
We either can infer the valid extended type, or we get null.

Change-Id: I6d7912191a432146f6acf97d7d05411724342b16
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129334
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-12-21 21:03:16 +00:00
Brian Wilkerson cfca5ea9f2 Fix NPE when describing a function in the info builder 
I didn't track it down, but throwing an exception here appears to cause
the migration engine or preview tool to hang. It was preventing the
flutter package from being migrated.

Change-Id: I0c2454fce5622a9768c2e3ff69514f83ffcd8a3f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129180
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
 2019-12-21 17:28:56 +00:00
Brian Wilkerson 47c73558ef Simplify the process of adding support for lint-based fixes in dartfix 
This removes the need for one of the 2 or 3 changes we needed to make.
If you like this approach we can apply it to other kinds of fixes as
well.

Change-Id: I31dc9412dbd77b19f974cf93ae10fde38da62b24
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129261
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-12-20 23:13:24 +00:00
Konstantin Shcheglov 9555c0a7d8 GenericInferrer gets all information from TypeSystem. 
Change-Id: I1d3a5626a7ffda33ea7708b6d9f3b9a3b4f1a4f3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129308
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-12-20 20:25:04 +00:00
Brian Wilkerson dd306df959 Fix an NPE when computing a proximateTargetForNode when the node is null 
I wasn't able to figure out how we got a node info with no AST node, so
I don't know how to write a test for this. Happy to let someone else
follow up.

Change-Id: I4fe745f63641c8f64a611b37d78f86dc50d36f1b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129200
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-12-20 01:16:51 +00:00
Konstantin Shcheglov 21354dccc9 Remove SdkExtUriResolver. 
Initial:  https://dart-review.googlesource.com/c/sdk/+/128770
Reverted: https://dart-review.googlesource.com/c/sdk/+/128820

R=brianwilkerson@google.com

Change-Id: I446d0ddf130712e94aab756e04c91ab4b5e83aeb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129120
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-12-20 01:08:49 +00:00
Brian Wilkerson 52c6620986 Enable unnecessary_const in analysis_server 
Change-Id: I44d9902cb23d005ebedd4bc37d57d3751a8ebdc5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129100
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-12-19 17:32:52 +00:00
Brian Wilkerson efe76bd5c5 Add support to dartfix for prefer_single_quotes 
Change-Id: Ifeb2ecdfcd391f22d90ee9ede5660d11ffb61804
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128986
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-12-19 01:59:49 +00:00
Konstantin Shcheglov 82f1f2f1b0 Remove AnalysisOptionsImpl.strongModeHints 
Change-Id: I61b8aefb4935160bec20e52fb9c9482079387c74
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128848
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-12-18 20:11:16 +00:00
Brian Wilkerson 4043a6fce3 Remove unnecessary uses of new in analysis_server 
Other than analysis_options.yaml, all of the changes were from running
dartfix.

Change-Id: I92411642f12a00fc6bd0bfd24dd60fe67f0fed16
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128845
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-12-18 19:01:51 +00:00
Konstantin Shcheglov becb0c0b85 Revert "Remove SdkExtUriResolver." 
This reverts commit 7ef8822c2a.

Reason for revert: breaks Flutter build because dartdoc is not updated there yet.

Original change's description:
> Remove SdkExtUriResolver.
> 
> R=​brianwilkerson@google.com
> 
> Change-Id: If0d7bb91e9b1c42e15935b315288fa8e3a000c6d
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128770
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
> Commit-Queue: Konstantin Shcheglov <scheglov@google.com>

TBR=scheglov@google.com,brianwilkerson@google.com

Change-Id: I0c9a26662a6fe6abac558313c14949886364d28e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128820
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-12-18 01:07:34 +00:00
Konstantin Shcheglov 7ef8822c2a Remove SdkExtUriResolver. 
R=brianwilkerson@google.com

Change-Id: If0d7bb91e9b1c42e15935b315288fa8e3a000c6d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128770
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-12-18 00:22:15 +00:00
Brian Wilkerson 8c9cbb5ee1 Allow the full path in the URL used to open the preview tool 
Change-Id: I0bd2d06fa72918d8f12a7b2c78b96ea8bd03ea26
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128740
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-12-17 18:22:36 +00:00
Danny Tuppeny 62e5531e36 Add a Flutter Outline Notification to the LSP server 
Change-Id: Ifbff7d88df7e468cfba383fda89160c7d3d5ee33
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128662
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-12-17 17:46:36 +00:00
Brian Wilkerson 2eba06d26f Stop using preview-dir and preview-port values and always open the preview tool 
Change-Id: I1ae6aeeb95b1a976c23fe23867a6bec9b453806e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128463
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-12-16 23:28:35 +00:00
Brian Wilkerson f2ac0784f1 Add a fix and assist to add a return type 
Change-Id: I7b683953d4b90c1863477b9fcf2e7f34f0955450
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128560
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
 2019-12-16 18:32:55 +00:00
Brian Wilkerson bae7255c83 Add support to dartfix to fix unnecessary new and const lints 
Change-Id: I8345ea6afd5aa43bda4855b24d101c04b177ae80
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128522
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-12-16 15:33:11 +00:00
Sam Rawlins 84308858e8 Highlight line that is targeted; fix some linking 
Change-Id: I4c5758ddd5ffef6e874cbee140bcbfdfd8eb8e81
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128460
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2019-12-14 00:25:34 +00:00