c1eb44e3d0
Fix for getContextAttributes which wraps bare dictionary into a Dart type.
...
R=sra@google.com
Review URL: https://codereview.chromium.org//35863006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29221 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-24 22:32:46 +00:00
3253eb3b84
Update status files to account for 14400 being fixed.
...
R=vsm@google.com
Review URL: https://codereview.chromium.org//40443004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29215 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-24 21:51:53 +00:00
0824f81fbb
Fix dartium test status.
...
Review URL: https://codereview.chromium.org//40853002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29187 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-24 17:35:27 +00:00
a61f6f2ff0
Mark js_test as failing for IE10
...
BUG=
Review URL: https://codereview.chromium.org//38343003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29141 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-24 01:28:02 +00:00
7e685302b9
Add back unseparated out version of method overloads in dart:html.
...
BUG=
R=blois@google.com
Review URL: https://codereview.chromium.org//34733007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29135 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-24 00:07:45 +00:00
47d5450a02
Remove fail status for html/js_test and IE
...
BUG=
R=jacobr@google.com
Review URL: https://codereview.chromium.org//38253002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29132 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-23 22:37:11 +00:00
45e20b5921
"Fix" dart:js tests in IE9
...
BUG=
R=jacobr@google.com
Review URL: https://codereview.chromium.org//35173004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29125 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-23 21:12:36 +00:00
1661b31233
attempt to get safari/ie green
...
audiocontext_test is failing for reasons I don't understand (browser update?)
node_validator_test needs to skip TemplateElement if not supported
Review URL: https://codereview.chromium.org//29673003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29101 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-23 17:27:42 +00:00
15e086338d
Revert "Revert "Removing some deprecated members""
...
Take-two of https://code.google.com/p/dart/source/detail?r=29022
The issue with the original was that addEventListener was changed to private, but this caused the IDB classes which override it to not override it any longer. This was breaking C++ multiple inheritance type casts. Fix is to make addEventListener public.
BUG=
R=efortuna@google.com
Review URL: https://codereview.chromium.org//35013003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29051 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-23 00:44:10 +00:00
de7c68ce3a
Test for OscillatorNode.type=. Fix bug in StringGetPeerHelper when passed an immediate object. Fix asserts when getting typed data address to allow for empty arrays.
...
BUG=http://dartbug.com/11984
R=asiva@google.com , vsm@google.com
Review URL: https://codereview.chromium.org//28973003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29049 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-23 00:12:09 +00:00
3aef09e008
Revert "Removing some deprecated members"
...
For some reason this broke indexed_db on Dartium, I debugged in some but need more time to understand. The completed event is not firing.
TBR
BUG=
Review URL: https://codereview.chromium.org//32523007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29033 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-22 20:20:32 +00:00
7b54bac06a
Removing safe_dom_test
...
It relied on deprecated APIs which have been removed, and has been eclipsed by the node_validator_test
TBR
BUG=
Review URL: https://codereview.chromium.org//35883002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29028 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-22 19:32:04 +00:00
e2c4716609
Removing some deprecated members
...
These are all DOM APIs that we had annotated as deprecated but not actually removed. They've all been deprecated for quite a while.
BUG=
R=efortuna@google.com
Review URL: https://codereview.chromium.org//30353003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29022 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-22 18:42:01 +00:00
8b4e5e92ba
"Reverting 29013"
...
TBR
BUG=
Review URL: https://codereview.chromium.org//35723002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29017 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-22 18:25:40 +00:00
f4e40d6d9a
Make getLineDash return [] instead of null if it has not yet been set.
...
BUG=
R=blois@google.com
Review URL: https://codereview.chromium.org//27983005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29013 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-22 17:40:58 +00:00
c1a11e55d5
Adding validation that Custom element constructor has zero args
...
BUG=13800
R=vsm@google.com
Review URL: https://codereview.chromium.org//30283002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29011 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-22 17:20:46 +00:00
cf9be8e65b
Tightening up custom element registration for dart2js
...
BUG=14093
R=sra@google.com
Review URL: https://codereview.chromium.org//34203002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29007 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-22 16:40:56 +00:00
980834fe33
Validating that types which require extendsTag actually provide it
...
BUG=14292
R=vsm@google.com
Review URL: https://codereview.chromium.org//32703006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29004 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-22 16:14:17 +00:00
623f40c33a
Fixed type error.
...
R=vsm@google.com
Review URL: https://codereview.chromium.org//34103002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28974 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-22 00:29:39 +00:00
6452efa6f5
Updated tests for fillText to better account for off-by-one errors.
...
Review URL: https://codereview.chromium.org//33833003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28969 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-21 23:18:14 +00:00
0177ed7ae4
CanvasRenderingContext2D.fillText now works correctly with null maxWidth.
...
BUG=13369
R=efortuna@google.com
Review URL: https://codereview.chromium.org//29273005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28963 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-21 22:09:07 +00:00
8e4205db3a
Reapply remove upgradeCustomElement methods.
...
BUG=
R=blois@google.com
Review URL: https://codereview.chromium.org//33593003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28960 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-21 21:55:40 +00:00
37989cf2ce
"Reverting 28947"
...
TBR
BUG=
Review URL: https://codereview.chromium.org//33643002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28949 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-21 20:48:18 +00:00
3a4a3ba95f
Remove Platform.upgrateCustomElements.
...
BUG=
R=blois@google.com
Review URL: https://codereview.chromium.org//31993005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28947 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-21 20:21:28 +00:00
6bb7f29928
Utility methods used for dartium debugger integration.
...
In addition, added back two DOM methods required by the chrome dev tools that had been removed from dart:html
I'm not thrilled about adding back className but the devtools use className in 495 places so figuring out which places are actually talking about classNames of inspected objects and which ones are just internal uses of className inside the devtools would be a pain.
As the browser has a String "class" attribute I do think it is natural to provide at least a read only className in addition to classes.
This changes goes along with the larger CL
https://codereview.chromium.org/18169002/
which I will be sending out for general review in a little bit.
BUG=
R=blois@google.com
Committed: https://code.google.com/p/dart/source/detail?r=25032
Review URL: https://codereview.chromium.org//18125007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28904 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-19 04:58:45 +00:00
5ee178076a
A few API changes:
...
Remove Callback in favor of directly using closures or JsFunction.withThis().
Move jsify() to a named constructor on JsObject.
- Throw on types other than Map and Iterable.
- Handle cycles
Add JsObject.fromDartObject() which force a transferrable native to be proxied.
Still to do: Reach a conclusion on Serializable
BUG=
R=vsm@google.com
Review URL: https://codereview.chromium.org//27514003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28902 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-19 04:36:10 +00:00
e7aef33a2c
Fixing custom element type extensions in Dartium to have correct native type ID
...
This is in support of the recent change to write the native type ID to the Dart wrappers
Dart changes for https://codereview.chromium.org/27769002/
BUG=14190
R=vsm@google.com
Review URL: https://codereview.chromium.org//29033003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28899 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-18 23:43:45 +00:00
c378b0bf0a
Adjust IDB test to work for JS as well.
...
BUG=
Review URL: https://codereview.chromium.org//30073002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28889 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-18 22:33:30 +00:00
108c404e0d
Adjust test to determine problem.
...
BUG=
Review URL: https://codereview.chromium.org//29943004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28885 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-18 22:07:11 +00:00
72bed362c8
Update idb tests to verify correct number behavior.
...
BUG=
R=blois@google.com
Review URL: https://codereview.chromium.org//26308004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28881 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-18 21:42:38 +00:00
3f84b4aa76
Revert "Fix status file."
...
This reverts commit a272b4baa26913a2848fe30fe60b35ea7e5841ff.
BUG=
Review URL: https://codereview.chromium.org//29503003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28871 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-18 18:58:26 +00:00
d5ae524fc0
Fix status file.
...
R=jacobr@google.com
Review URL: https://codereview.chromium.org//29403002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28865 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-18 17:48:53 +00:00
cf134382a1
Set.add returns true if item has been added, otherwise false
...
BUG= https://code.google.com/p/dart/issues/detail?id=3546
R=floitsch@google.com
Review URL: https://codereview.chromium.org//26280002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28863 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-18 17:24:24 +00:00
9c2f329e56
Remove defaultSelected property.
...
BUG=https://code.google.com/p/dart/issues/detail?id=4958
R=blois@google.com
Review URL: https://codereview.chromium.org//27516011
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28832 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-17 22:38:47 +00:00
358392883c
Adding ElementEventStream.capture
...
Also making Element.on[] return an ElementStream.
BUG=13214
R=efortuna@google.com
Review URL: https://codereview.chromium.org//26135004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28819 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-17 20:19:46 +00:00
a86bee09de
Fix for events not firing on sanitized elements
...
Issue was that the events weren't being raised when the elements were in documents without views.
BUG=14184
R=efortuna@google.com
Review URL: https://codereview.chromium.org//26557004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28817 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-17 19:58:14 +00:00
3ec5039dfe
Fixing XHR responseHeaders test
...
Was relying on overrideMimeType but not all platforms support that.
TBR
BUG=
Review URL: https://codereview.chromium.org//27280003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28816 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-17 19:26:08 +00:00
e32d5c24c3
Cleanup JS() expressions.
...
New Constructor for JsObject that preserves the correct prototype.
Type check user-supplied values that pass through to JS().
Don't call _convertToJs(this)
Based on: https://chromiumcodereview.appspot.com/26092003/
R=ahe@google.com , alexandre.ardhuin@gmail.com
Review URL: https://codereview.chromium.org//26270003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28813 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-17 18:13:40 +00:00
cb304c5ea7
Adding HttpRequest.responseHeaders
...
The code is mostly from Closure's getResponseHeaders function, with modifications to make the keys case-insensitive (following jQuery's model).
BUG=13584
R=efortuna@google.com
Review URL: https://codereview.chromium.org//26893008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28812 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-17 18:11:00 +00:00
e3b35dabb6
Renaming Node.document back to Node.ownerDocument
...
With custom elements, the document instance variable creates an odd conflict with the document global.
BUG=14099
R=jmesserly@google.com
Review URL: https://codereview.chromium.org//27602002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28810 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-17 17:55:38 +00:00
92eb23301a
Mark event_customevent_test as failing
...
Review URL: https://codereview.chromium.org//26253004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28801 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-17 13:29:13 +00:00
51802fcac3
Fixing custom event test on IE
...
For some reason, Event.preventDefault on IE is not triggering defaultPrevented back at the call site.
BUG=
R=vsm@google.com
Review URL: https://codereview.chromium.org//27536010
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28767 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-17 00:05:39 +00:00
333054ee75
Supporting non-SSVs in CustomEvent.detail
...
BUG=12641
R=vsm@google.com
Review URL: https://codereview.chromium.org//27308006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28758 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-16 23:09:33 +00:00
aa578e1395
Updating element_offset status
...
Test was marked as flaking on dart2js because of 13296, but is now flaking on Dartium.
BUG=
R=dgrove@google.com
Review URL: https://codereview.chromium.org//26247008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28747 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-16 20:41:39 +00:00
fc6e40c7e3
Minor tweak to indexeddb_3 test transaction handling
...
BUG=
R=sra@google.com
Review URL: https://codereview.chromium.org//26554008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28733 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-16 16:33:26 +00:00
c4c19f058a
Wait for transaction to complete, before continuing.
...
This is now required, since futures will be completed within the same
transaction window.
BUG=
R=floitsch@google.com
Review URL: https://codereview.chromium.org//27490003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28720 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-16 12:16:57 +00:00
19655e4e6b
Revert "Revert "Removing setImmediate and hiding WindowTimers interface""
...
Issue was that requestAnimationFrame got removed from Dartium during a merge conflict :(
BUG=
R=efortuna@google.com
Review URL: https://codereview.chromium.org//27441002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28700 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-16 00:50:49 +00:00
8e255ada0f
Revert "Removing setImmediate and hiding WindowTimers interface"
...
This reverts commit 28690.
TBR
BUG=
Review URL: https://codereview.chromium.org//27440002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28696 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-16 00:16:59 +00:00
303710040b
Removing setImmediate and hiding WindowTimers interface
...
These timing APIs are all redundant with dart:async and those versions should be used instead.
BUG=
R=efortuna@google.com
Review URL: https://codereview.chromium.org//26534005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28690 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-15 23:52:09 +00:00
03eb80a189
Maintain referential integrity of proxy instances in dart:js
...
Rename DartProxy to DartObject in JavaScript to be symmetrical with JsObject
R=ahe@google.com , alexandre.ardhuin@gmail.com
Review URL: https://codereview.chromium.org//26092003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28686 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-15 21:43:16 +00:00
amouravski@google.com