Commit Graph

726 Commits

Author SHA1 Message Date
scheglov@google.com c3fc4e987a Issue 5588. Don't report errors when preProcessLibraryDirectives()
http://code.google.com/p/dart/issues/detail?id=5588

We will report same errors when we will make complete parsing.

R=messick@google.com
BUG=

Review URL: https://codereview.chromium.org//11048013

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13182 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-03 16:16:48 +00:00
danrubel@google.com 6b5bddecb9 Fix NPT when visiting qualifier in property access
Review URL: https://codereview.chromium.org//11037010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13094 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-02 00:48:36 +00:00
brianwilkerson@google.com fddbc47bc0 Minor bug fix
Review URL: https://codereview.chromium.org//11034012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13087 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-01 21:40:59 +00:00
pquitslund@google.com be83083ccd Dart analyzer fixes to improve pluggability.
More fixes in the service of supporting analysis of resources that are non-resident.  Notably a pluggable UrlLibrarySource and a repurposable SystemLibrariesReader.

NOTE (API Change): SystemLibraryProvider is now an abstract class, suitable for client customization. 
Review URL: https://codereview.chromium.org//11027006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13084 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-01 20:15:30 +00:00
brianwilkerson@google.com 6d1d55c743 Report error for non-const map literals used as statements (issue 5299)
Review URL: https://codereview.chromium.org//11000054

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13041 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-28 22:03:21 +00:00
brianwilkerson@google.com 8855e8143b Additional fixes for cascades (issue 5146)
Review URL: https://codereview.chromium.org//10986095

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13039 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-28 20:07:33 +00:00
scheglov@google.com 112281a50e Issue 3968. Report error if cycle in redirecting factory constructors
http://code.google.com/p/dart/issues/detail?id=3968

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//10983089

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13036 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-28 18:20:57 +00:00
brianwilkerson@google.com c45dd539f6 Remove support for impossible AST structure (and a couple of warnings)
Review URL: https://codereview.chromium.org//10984093

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13035 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-28 18:07:12 +00:00
brianwilkerson@google.com 27c9cf7158 Report escaped newlines in string literals (issue 5296)
Review URL: https://codereview.chromium.org//10979081

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13031 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-28 17:29:17 +00:00
pquitslund@google.com fa6bafbcc0 Fix to exclude patch files from search results (dartbug.com/5492).
Review URL: https://codereview.chromium.org//10984082

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13029 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-28 16:59:31 +00:00
brianwilkerson@google.com c7d232b840 Fix the build
Review URL: https://codereview.chromium.org//10977081

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13024 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-28 16:03:31 +00:00
brianwilkerson@google.com 4d6452145c First step toward fixing cascades (issue 5062)
Review URL: https://codereview.chromium.org//10984081

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13023 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-28 14:53:12 +00:00
scheglov@google.com dd0a0b39d8 Issue 5350. Type variable should be accessible in instance field
http://code.google.com/p/dart/issues/detail?id=5350

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//10991064

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12988 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-28 00:17:59 +00:00
pquitslund@google.com 6ad979ab73 Virtual filesystem support for dart_analyzer.
Review URL: https://codereview.chromium.org//10986073

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12983 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-27 21:50:58 +00:00
scheglov@google.com a7a4a4411f Issue 5447. Wern when concrete class has unimplemented members
http://code.google.com/p/dart/issues/detail?id=5447

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//10987076

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12977 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-27 18:01:10 +00:00
brianwilkerson@google.com c1be0e7612 Parse and report error for const parameters (issue 5289)
Review URL: https://codereview.chromium.org//10990086

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12971 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-27 16:34:03 +00:00
scheglov@google.com 344cc4b415 Quick fixes 'Create class' and 'Create constructor'
http://code.google.com/p/dart/issues/detail?id=5325

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//10996036

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12953 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-27 12:46:07 +00:00
scheglov@google.com c67487ccd6 Fix for NPE with StringLiteral in toString()
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//10990074

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12940 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-27 04:06:14 +00:00
scheglov@google.com 16996b9fdb Tweaks for @deprecated and @override presentation
R=brianwilkerson@google.com,devoncarew@google.com
BUG=

Review URL: https://codereview.chromium.org//10984033

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12901 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-26 11:52:23 +00:00
scheglov@google.com ef41e134fe Issue 5255. Override setter-only field with instance variable
http://code.google.com/p/dart/issues/detail?id=5255

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//10986033

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12880 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-25 20:43:14 +00:00
scheglov@google.com 4eb06ae32b Issue 5440. Fixes for exceptions during resolving
http://code.google.com/p/dart/issues/detail?id=5440

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//10986026

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12864 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-25 18:10:21 +00:00
scheglov@google.com 7f8731cb50 Issue 5292. Unreferenced imported identifiers should not be an error
http://code.google.com/p/dart/issues/detail?id=5292

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//10979013

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12847 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-25 16:34:48 +00:00
scheglov@google.com 1d60036e44 Issue 5327. Fix for invalid 'instantiation of a class with the inherited abstract members'
http://code.google.com/p/dart/issues/detail?id=5327

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//10962047

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12753 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-22 19:01:02 +00:00
scheglov@google.com 082dd8cc31 Issue 5302. Type alias type parameters should not conflict with formal parameters
http://code.google.com/p/dart/issues/detail?id=5302

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//10961058

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12752 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-22 18:56:40 +00:00
scheglov@google.com 018d23bb22 Issue 5295. Reference to undefined static setter should be a warning not an error
http://code.google.com/p/dart/issues/detail?id=5295

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//10966047

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12751 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-22 18:54:38 +00:00
brianwilkerson@google.com 48b5aa8f60 Allow static fields without types (issue 5149)
Review URL: https://codereview.chromium.org//10957040

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12720 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-21 16:14:27 +00:00
scheglov@google.com c0a0b5db5e Issue 5293. Invocation of an undefined static method should be a warning, not an error
http://code.google.com/p/dart/issues/detail?id=5293

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//10963028

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12716 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-21 15:06:21 +00:00
scheglov@google.com 4792aeac49 Issue 5255. Remember 'overridden' for getters/setters and fields
http://code.google.com/p/dart/issues/detail?id=5255

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//10961038

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12714 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-21 14:43:16 +00:00
scheglov@google.com d6a06d9070 Issue 5240. Using a non-type in a const object expression is an error, not a warning
http://code.google.com/p/dart/issues/detail?id=5240

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//10970024

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12711 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-21 14:14:03 +00:00
scheglov@google.com 51adcdda3b Fixes for raw string and block clean ups
R=danrubel@google.com
BUG=

Review URL: https://codereview.chromium.org//10962014

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12709 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-21 14:11:51 +00:00
scheglov@google.com 3c4080aff2 Issue 5163. Constructor/member name conflict should be error
http://code.google.com/p/dart/issues/detail?id=5163

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//10969024

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12660 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-20 21:31:09 +00:00
pquitslund@google.com 1999601afd "No SDK, No Problem!" (take 2)
When there's no SDK,

  * don't start the analysis server
  * or the indexer
  * and don't try and constitute the dart model

(NOTE: this addresses the issue where we have no SDK on initial plugin install.)
Review URL: https://codereview.chromium.org//10960002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12647 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-20 17:18:44 +00:00
brianwilkerson@google.com 48b7ae58bd Preparation for reporting an error for deprecated raw strings (issue 4815)
Review URL: https://codereview.chromium.org//10941052

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12643 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-20 14:46:27 +00:00
scheglov@google.com c78a9cf2cd Clean up to migrate parseInt() and parseDouble() to int.parse() and double.parse()
R=messick@google.com
BUG=

Review URL: https://codereview.chromium.org//10959006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12641 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-20 14:29:56 +00:00
scheglov@google.com dda26cdfaa Issue 5162. Report error when initializing already initialized final field
http://code.google.com/p/dart/issues/detail?id=5162

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//10943034

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12594 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-19 19:37:06 +00:00
keertip@google.com 949ea1e14b fix PackageLibraryManager to resolve self links to right file
Review URL: http://codereview.chromium.org//10951031

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12593 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-19 19:22:36 +00:00
scheglov@google.com 627f9805df Issue 5232. Type variables are in static scope, but using them is error
http://code.google.com/p/dart/issues/detail?id=5232

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//10939037

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12588 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-19 18:57:37 +00:00
scheglov@google.com f0ae22c830 Issue 5215. Invocation identical(x,y) is compile-time constant
http://code.google.com/p/dart/issues/detail?id=5215

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//10942020

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12569 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-19 15:55:44 +00:00
scheglov@google.com eb7e217a49 Issue 5116. Support both 'dynamic' and 'Dynamic'
http://code.google.com/p/dart/issues/detail?id=5116

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//10939027

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12567 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-19 15:40:22 +00:00
scheglov@google.com c095d071e9 Issue 5052. Analyzer should treat assert as a keyword
http://code.google.com/p/dart/issues/detail?id=5052

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//10949015

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12566 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-19 15:30:12 +00:00
scheglov@google.com b6da1f820e Issue 2862. Report warning if switch/case does not end with break, continue, return or throw
http://code.google.com/p/dart/issues/detail?id=2862

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//10942019

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12565 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-19 15:22:58 +00:00
karlklose@google.com d90d5b1698 Reapply 'Add runtimeType() to Object which returns canonicalized instances of Type'.
This CL fixes a bug in https://chromiumcodereview.appspot.com/10908142/ which generated unneeded type information leading to runtime regression.

Original committed in 12491 and reverted in

R=ngeoffray@google.com

Review URL: https://codereview.chromium.org//10941031

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12540 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-19 08:56:06 +00:00
scheglov@google.com a17964f959 Issue 5153. Setter should not conflict with method
http://code.google.com/p/dart/issues/detail?id=5153

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//10943012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12528 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-19 01:17:29 +00:00
pquitslund@google.com 666341c3f7 Expose translatedUri (for clients who want to normalize URIs).
Review URL: https://codereview.chromium.org//10945011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12507 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-18 17:31:41 +00:00
ricow@google.com 5bcc7e0092 Revert r12491
This is causing checked mode failures on the buildbot.
Review URL: https://codereview.chromium.org//10949003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12500 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-18 14:40:15 +00:00
karlklose@google.com 59e0304206 Add runtimeType() to Object which returns canonicalized instances of Type.
BUG=3903

Review URL: https://chromiumcodereview.appspot.com//10908142

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12491 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-18 12:12:07 +00:00
brianwilkerson@google.com 342ea14996 Fix the length of this expression nodes (issue 5185)
Review URL: https://codereview.chromium.org//10928236

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12459 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-17 21:54:14 +00:00
brianwilkerson@google.com a9b557d9cd Add metadata for type variables (issue 4056)
Review URL: https://codereview.chromium.org//10933128

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12446 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-17 17:46:59 +00:00
scheglov@google.com 6fffdf490a Issue 5148. Error on abstract method in concrete class needs to be a warning
http://code.google.com/p/dart/issues/detail?id=5148

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//10914318

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12445 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-17 17:09:27 +00:00
scheglov@google.com d6802247b5 Issue 5082. It is an error if argument to '?' is not a formal parameter
http://code.google.com/p/dart/issues/detail?id=5082

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//10928230

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12438 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-17 15:09:52 +00:00