dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
74,983 Commits 2 Branches 0 Tags
c2bc119c210c81053750c06eaed8328131a017ea
Commit Graph

848 Commits

Author SHA1 Message Date
Brian Wilkerson d0ac759927 Initial parser for the data-driven fixes data file 
This is very incomplete, but allows us to read rename changes, which will
enable us to get a steel thread in place.

Change-Id: I3259f64bd6d3dc1fdc4894d2b08b5388e8652dac
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/159642
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-08-21 19:11:30 +00:00
Konstantin Shcheglov eb51dbc403 Fix prefix start for locations before a token. 
Bug: https://buganizer.corp.google.com/issues/161242256
Change-Id: I67a5ee774090f155d53e9c71e7a06d848e1d9c72
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/159324
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Keerti Parthasarathy <keertip@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-08-20 15:51:59 +00:00
Brian Wilkerson 3c5a081c08 Update modify_parameters to handle post-deprected APIs 
I also removed the support for updating overrides. I realized, after I'd
started to implement it, that we can't capture enough information in the
text file to be able to update overrides. I have an idea for an
alternative, but would love to hear any thoughts you might have.

Change-Id: I2c55e944384869f853e32238995c659aab49f520
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/159380
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-08-19 21:08:27 +00:00
Brian Wilkerson 11ba8cb2dd Drop the suffix "Change" from class names 
I don't think it adds value, but if you disagree I'll add it to the
class ModifyParameters for consistency.

Change-Id: Ib823dd482d13a2ae9eb355298d3db813a3791fb4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/159301
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-08-19 16:59:16 +00:00
Brian Wilkerson 4af6831020 Add support for modifying parameters in a data-driven fix 
Change-Id: I756df3e665c24cbf5131a0aae1c1526c08a5d172
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/158940
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-08-18 14:56:40 +00:00
pq 6e62a0435d bulk fix for unnecessary_brace_in_string_interps 
Change-Id: I47e846994d727d84564ba8f7daf7a8e6334417c7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/158143
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-08-17 18:32:59 +00:00
pq 4049442385 bulk fix for prefer_iterable_whereType 
Change-Id: I490bb4cc6e03adb606b45a5aae9dbbc763747124
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/158364
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-08-13 00:40:18 +00:00
pq 0673922e22 bulk fix for use_rethrow_when_possible 
Change-Id: I67b4022109c5b4dccaf3d716f9b4328bf5cdc758
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/158360
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-08-12 21:19:08 +00:00
Brian Wilkerson f532f023ff Remove the convert_argument_to_type_argument change 
This functionality will be supported by a combination of
add_type_parameter and remove_parameter.

Change-Id: Ie9970cd87963519f3c7c6fd55f46cd0e89fafc9a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/158344
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-08-12 19:53:08 +00:00
pq ab7c1e5904 bulk fix for prefer_generic_function_type_aliases 
Change-Id: Iebe4c3a11a37a0dedb0dbaef5c001e848ae29a3e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/158340
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-08-12 19:27:48 +00:00
Brian Wilkerson d6a901e64d Add an add_type_parameter change to the data driven fix support 
The intention is for this and another change that allows function
parameters to be removed to replace the change_argument_to_type_argument
change.

Change-Id: I521c20262d5a78d3156c2b53babcf5d610028c67
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/158205
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-08-12 18:32:16 +00:00
pq e3d30b8331 bulk fix for prefer_if_null_operators 
Change-Id: I392debf03af58d3f597b5f377eaf65d400a5db35
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/158164
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-08-12 16:45:20 +00:00
pq b989ccf733 bulk fix for unawaited_futures 
Change-Id: I0d53fe9d31b22a08585ea625a5dfbbf5ed5187e5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/158104
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-08-11 15:23:49 +00:00
pq e2a67723ca bulk fix for prefer_final_fields 
Change-Id: Iabfb6aae5186171f4143d23aeb18a124ceab4a0a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157920
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-08-10 15:10:41 +00:00
pq b0d007a931 bulk fix for type_init_formals 
Change-Id: I8b79e30f2ea811b97caa8fda1297dda054bbcc05
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157860
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-08-08 05:04:50 +00:00
Konstantin Shcheglov 940d7effbd Fix for crash in AddMissingEnumCaseClauses. 
R=brianwilkerson@google.com, pquitslund@google.com

Change-Id: I0dc8c3158eb4b46247e415ff36c33991598bce9c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157861
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-08-08 01:22:53 +00:00
pq 06cce87374 bulk fix for unnecessary_this 
Change-Id: I61c0173c8fb1fd02d6119412bf925d08126a7a0b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157822
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-08-07 22:58:17 +00:00
pq 768fd39317 bulk fix for unnecessary_overrides 
Change-Id: I9cdd051d7dcde5c9a9495e04cf0e7765aac8e714
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157720
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-08-07 15:30:55 +00:00
pq b86f267151 bulk fix for unnecessary_lambdas 
Change-Id: Idbf116b5194c122fae59526c3fc70b8a88f1b8a6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157494
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-08-07 03:56:05 +00:00
pq a2fdeaaa53 bump linter to 0.1.118 
Change-Id: Id8277810091fbc3431131cb4182532c335d82773
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157476
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-08-06 23:11:09 +00:00
Brian Wilkerson eaf94c5897 Add a quick fix to make a return type nullable 
Change-Id: I6e400a5d46f9725586cb5f24601013abf7b3ebb5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157603
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-08-06 23:09:19 +00:00
Brian Wilkerson 3bc6345ad6 Add a new fix to replace null-aware operators with the non-null-aware version when the receiver is non-nullable 
Change-Id: Id51ae969fb7d64ca6d3dd7869bb3886417231f3e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157473
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-08-06 20:17:52 +00:00
Konstantin Shcheglov 5276973b22 Test and fix for completion in a part. 
R=brianwilkerson@google.com, keertip@google.com

Change-Id: I7653a24a3a315b2be51e50f223284537e5830b1d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157469
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-08-06 16:08:59 +00:00
Devon Carew 31335728d1 [analyzer] add a new wrap with widget for SizedBox 
Change-Id: Ib94b254ebdff82309d8761c8bb769e15e19d23ed
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157423
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-08-06 04:34:26 +00:00
pq 1bb842869f bulk fix for prefer_spread_collections 
Change-Id: I612d9286e8233fe70da8150cf0ba1fa23c9d039b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157440
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-08-05 22:27:19 +00:00
pq 865495fd6e bulk fix for prefer_single_quotes 
Change-Id: Ida0db0118948115042ebac65b4a8a3438a1b09bf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157403
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-08-05 20:17:39 +00:00
pq 207b68d5b4 bulk fix for prefer_if_elements_to_conditional_expressions 
Change-Id: I7b76d437d948680729150e7c5eef99efac3567d5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157140
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-08-05 19:11:29 +00:00
pq e41b4c1357 bulk fix for prefer_is_not_empty 
Change-Id: I9188d344f03823d4ab2d7eb46f134910d271e527
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157062
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-08-04 18:24:49 +00:00
pq af8767e9c8 bulk fix for prefer_is_empty 
Change-Id: I5c4cdb5b87ccbab8e257a45c33fe78d2d41923e9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157024
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-08-04 17:17:19 +00:00
pq bd65d441f5 bulk fix for prefer_conditional_assignment 
Change-Id: I45e979bc00da0d8a5a8a257ce0fbd484137c143d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/156981
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-08-04 02:01:13 +00:00
Brian Wilkerson 0a19e8dbfe Add test requested in earlier CL 
Change-Id: I112004e06150ed913d64b77f272a4ae85c6ef61a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/156926
Auto-Submit: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-08-03 23:53:23 +00:00
pq 43c68d782d bulk fix for prefer_adjacent_string_concatenation 
Change-Id: I873d3531307a9685dc0950aa2fc2119af5abdd0e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/156925
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-08-03 22:40:07 +00:00
pq 2bf777ea6e bulk fix for omit_local_variable_types 
Change-Id: I1cc6eb6c7423ded3c5694728271cec52341ff98a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/156960
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-08-03 20:59:31 +00:00
pq 987c9e347c bulk fix for null_closures 
Change-Id: I20e57da5b95868551216b9b0a095e82116c3585e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/156940
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-08-03 19:14:22 +00:00
Brian Wilkerson ac79402072 remove-duplicate-case should not remove statements if there are cases that fall through to them 
Change-Id: I2094335d06e62eeb184f78b14e6028fdb5341dba
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/156849
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-08-03 18:50:21 +00:00
pq d427ab510d bulk fix for no_duplicate_case_values 
Change-Id: I4925113c44d5042062ccaabea680a07eedf7bfdd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/156848
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-08-03 18:11:51 +00:00
Brian Wilkerson 4121cf3cb4 Add a quick fix to add a null check operator 
Change-Id: Ie85ab236015057c2cb0255cc1548605e5b01e908
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/156783
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-08-01 01:17:11 +00:00
Konstantin Shcheglov 28c20c0861 Fix for crash in ReplaceCascadeWithDot, simplify it. 
R=brianwilkerson@google.com

Change-Id: I3243203e42856b6a4e65603aafb708473bdfe3fc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/156701
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-08-01 00:32:01 +00:00
pq 5553dcbea7 bulk fix for hash_and_equals 
Change-Id: Ifbca2871bbf90f8c1ea3e3ae6dd6ef9e8b5b00c6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/156780
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-07-31 22:28:20 +00:00
Brian Wilkerson dc908e076b Do not suggest an explicit cast when the only difference is the nullability of the type 
Change-Id: Ibb20fd5d3ced4ca13bb604bbe42eced16903de9e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/156723
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Jaime Wren <jwren@google.com>
 2020-07-31 19:00:20 +00:00
Konstantin Shcheglov dfb3720cda Changes to analysis_server/ to be compatible with the breaking changes to analyzer/. 
Change-Id: I606072798633601d78f38c0035b579d93875ef3e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/156601
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-07-31 17:04:58 +00:00
pq 4894e34f1f bulk fix for empty_statements 
Change-Id: I92c2dd5333d9b505a2c37b5936199895ab928fad
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/156700
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-07-31 16:27:10 +00:00
pq b10f22c7f5 bulk fix for empty_constructor_bodies 
Change-Id: Iffd3b80e6316372986374dc6b66cae24bd287dfa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/156604
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-07-31 14:30:00 +00:00
pq 2dca5ad318 bulk fix for empty_catches 
Change-Id: Ia1cc3aefd79968bba0ff43f7ac9016e68ee2195a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/156600
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-07-31 01:29:45 +00:00
pq 2b51d59e69 bulk fix for use_curly_braces 
Change-Id: Ia1a9fdde3d283cab94455aa4277d26e2d09998cd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/156586
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-07-31 00:02:24 +00:00
pq f640e58e45 bulk fix for await_only_futures 
Change-Id: Ic643ef1fd0e8374ecce7fffff34fc9b6f7e8550c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/156580
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-07-30 21:26:04 +00:00
Konstantin Shcheglov 0a06e86e57 Test that prefix based filtering in Cider does not use following identifier. 
Change-Id: Ieb37a1adce3ab2fb7bdc49fcb1d263b3940fd1e0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/156483
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-07-30 17:34:18 +00:00
Konstantin Shcheglov e60a0315dd Fix for crash in RemoveEmptyConstructorBody. 
R=brianwilkerson@google.com

Change-Id: I0fe17e9fe96028c5286f509c3bf9ec16248f4841
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/156401
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-07-29 22:01:59 +00:00
pq e12a536edb bulk fix for avoid_types_on_closure_parameters 
Change-Id: Id080559bc2a18fd8ce4c8eb59412c4461d8dac39
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/156340
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-07-29 19:45:25 +00:00
Brian Wilkerson 15fb170ffb Enable the new code completion relevance feature 
The new feature will be enabled by default but the option still exists
so that users can disable it if they want/need to.

Change-Id: I9e001b00b5dfe132a6b7bcfdcacd3143fb24f65c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/156121
Reviewed-by: Jaime Wren <jwren@google.com>
Reviewed-by: Devon Carew <devoncarew@google.com>
 2020-07-29 17:14:44 +00:00