dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
67,470 Commits 2 Branches 0 Tags
c19adc635542004d2c2cdac55b447e7175391bf8
Commit Graph

4383 Commits

Author SHA1 Message Date
Ari Aye 630100fb16 Don't allow ML to suggest punctuation by reference 
This change filters out any predictions for names that
are neither alphanumeric nor strings.

Change-Id: I515ca1263a05f234b263ab6d01cd41f80704ea3b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121805
Commit-Queue: Ari Aye <ariaye@google.com>
Reviewed-by: Jaime Wren <jwren@google.com>
 2019-10-16 21:05:36 +00:00
Sam Rawlins 2cee751fb9 dartfix: Don't sort edits when using --outputDir; fixes #38924 
Change-Id: Id60264f6543fc9abff2180169dc363315d8e42a6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121862
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
Auto-Submit: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2019-10-16 18:31:16 +00:00
Devon Carew e47ab49f0c [analyzer] add a diagnostics page for ml completion 
Change-Id: Iaddef290048be2246372ada03828c6f282e94efb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/120900
Reviewed-by: Ari Aye <ariaye@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2019-10-16 15:46:43 +00:00
Sam Rawlins f1657ab934 NNBD i13n: Handle returned values in deeper expressions 
Change-Id: I109ce111f0e0eb9c2b172c9f86aa4e3cbda482c0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121769
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2019-10-16 00:41:22 +00:00
Jaime Wren cf9c6134b8 Move consumerName(Request) from the analysis server generator to codegen_java.dart 
Change-Id: I864a02dbba609809420479d392071af43e7931c0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121807
Reviewed-by: Jaime Wren <jwren@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Jaime Wren <jwren@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Auto-Submit: Jaime Wren <jwren@google.com>
 2019-10-16 00:06:42 +00:00
Sam Rawlins 2e6695f6f9 NNBD i13n: Add line numbers 
Change-Id: Ifd81b3e99a3e8c0a1b1a0b6dbe29ad545f6e50f3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121779
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2019-10-15 23:48:32 +00:00
Devon Carew 81679a2ab4 [analyzer] reduce the default number of times we repeat a benchmark 
Change-Id: Ie9a9b0d58464c6b78e3a707975fda773e043d403
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121804
Reviewed-by: Jonas Termansen <sortie@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2019-10-15 22:52:56 +00:00
Sam Rawlins cfe25c7e95 NNBD i13n: Sort navigation links 
Change-Id: I32d21b26f3c813907308e9768a01a4cb9d45d1fc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121768
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Auto-Submit: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2019-10-15 22:37:08 +00:00
Ari Aye e642af52a5 Fix behavior of ML query construction 
This is one of the rare cases where the comment was correct
and the code was wrong. If we've typed class FooB^ then the
query should be ['class'] whereas typing void main(^ should
result in the query ['void', 'main', '('].

Change-Id: I5f53fa70c1ddfd1803e5697cdaaaf7d3b73f5ae2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121778
Reviewed-by: Jaime Wren <jwren@google.com>
Commit-Queue: Ari Aye <ariaye@google.com>
 2019-10-15 22:33:25 +00:00
Ari Aye 95bd6a2888 Fix --completion-model flag 
Either setting --completion-model=/path/to/model/folder explicitly or
setting --enable-completion-model should turn on ML code completion.
This preserves the behavior that --no-enable-completion-model will
override --completion-model but fixes the bug where an omitted
--enable-completion-model flag will also override --completion-model.

Change-Id: I49a40a29c3444192e551fdcc4a51690f26969685
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121803
Reviewed-by: Devon Carew <devoncarew@google.com>
Commit-Queue: Ari Aye <ariaye@google.com>
 2019-10-15 22:24:13 +00:00
Konstantin Shcheglov c5498891fc Don't suggest class member completions for ExtensionOverride targets. 
Change-Id: Ic3e2ef31cc42ccf4d16688050b894a50e5a8f51e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121765
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-10-15 20:58:29 +00:00
pq 5300ce4a2d ADD_DIAGNOSTIC_PROPERTY_REFERENCE assist 
Change-Id: I0acd3254eb309e95cce211612d6c1a11db5789bd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121800
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-10-15 19:54:59 +00:00
pq 3e497dd00a diagnostic function field support 
See: https://github.com/dart-lang/sdk/issues/38633

Follow-up from: https://github.com/flutter/flutter/pull/42447#discussion_r335025065


Change-Id: Idd3cbc4b3419e792d6b81e02bd556b35faaef8c7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121770
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2019-10-15 19:06:19 +00:00
Sam Rawlins 19e2f03421 NNBD i13n: Fix non-target reasons and add failing test for method return inheritance 
Change-Id: I3cee0c8972f1657abac89b1d9251ccc5e05d070f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121767
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2019-10-15 17:56:08 +00:00
Konstantin Shcheglov abecefd1ac Forward compatible portion of CL that does not set types for identifiers that are not expressions. 
The full CL:
https://dart-review.googlesource.com/c/sdk/+/119761

Change-Id: I9c909a4e1eec5d05f5718849ea45da79f01c5291
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121643
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-10-15 17:29:07 +00:00
Ari Aye 70a7ef3f58 Implement pointer mixture network 
Here we can see the mixture network is assigning probability mass
to a new, project-specific name by reference https://i.imgur.com/6Zbs2qf.png.

I also took this opportunity to decrease model size targeting 100M, in line
with our original size goals.

My initial strategy was to implement a separate pointer network
in https://dart-review.googlesource.com/c/sdk/+/117005 but having
a single network that can assign probability mass across local
references and vocabulary lexemes is better since

1) only one network and model file
2) no need to coalesce predictions from multiple models

Change-Id: I23cfc2ece61ce30bb69785149a5a6cf1604af18d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121461
Commit-Queue: Ari Aye <ariaye@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-10-14 18:25:56 +00:00
Brian Wilkerson 263bfd9635 Use relative URLs for navigation to enable publishing the output 
Change-Id: I6948fb10ec44abbb87c72dfc3f1a7277ec1ee7c4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121660
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-10-14 18:19:36 +00:00
Konstantin Shcheglov dc0db066e6 Remove ChangeSet from engine.dart 
Change-Id: I289c5edd0c3e52a873013f8c52d8202bf29cf3be
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121560
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-10-14 17:45:56 +00:00
Devon Carew ec86737818 [analyzer] fix an issue where the field analysisServerOptions.enableCompletionModel was not used 
Change-Id: Ib7dd53eb9ff97a0a646b487e4e5d71da0ced07c6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/120920
Reviewed-by: Ari Aye <ariaye@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2019-10-10 21:52:03 +00:00
Devon Carew 62934463f2 only write posix style paths in the convertToRelativeImport quickfix 
Bug: https://github.com/dart-lang/sdk/issues/38810
Change-Id: I7e941e7a27ce42fb703977a0e0f015d5864973e8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121142
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2019-10-10 21:48:43 +00:00
Brian Wilkerson b08d7756bd Prevent NPE in code completion when completing inside unnamed extension (issue 38798) 
Change-Id: Ia7041b236bd3f64662b5e0167de7b7343cfcf68a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121147
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-10-10 21:32:22 +00:00
pq b8943f7056 improve codegen for unscoped and enum diagnostic properties 
See: https://github.com/dart-lang/sdk/issues/38633

Change-Id: Ie10dcde92e0e054271fe0e965ed810ac3834120b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121160
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-10-10 20:57:42 +00:00
Sam Rawlins 857f0e9e99 NNBD i13n: Re-introduce formatting 
Change-Id: I88ebe8f1f0b8f9655bb7a9f9bc83545d6f068618
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121020
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2019-10-10 14:11:39 +00:00
Sam Rawlins 7b9a26ee6f NNBD i13n: ctor nav targets and details w/o targets 
* NavigationTargets which are ConstructorDeclarations should point to the
  constructor's name or its return type for unnamed constructors.
* Details which don't included useful targets, like "this parameter is
  optional and has no default value", should just have detail descriptions,
  but not be links.

Change-Id: I3562bb708c40aa1fcf1de5df5519f1f4037517cb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/120761
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-10-10 05:30:07 +00:00
Devon Carew 50d6a3d022 [analyzer] move the ml model from sdk/model to sdk/bin/model 
Change-Id: I64aad93770c5c0870c1a5052bb5a1192738f1cf3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/120901
Reviewed-by: Keerti Parthasarathy <keertip@google.com>
Reviewed-by: Ari Aye <ariaye@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2019-10-09 19:26:34 +00:00
Ari Aye 4227933c3a Disallow model-only suggestions if static analysis suggests a named argument 
Bug: https://github.com/dart-lang/sdk/issues/38404
Change-Id: I72b505cb5bee1f463c0ec6b0a1e9e60c5b7ea518
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/117767
Commit-Queue: Ari Aye <ariaye@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-10-09 18:13:48 +00:00
Brian Wilkerson 091568dcc9 Rework the way tag insertion works to allow nested tags and multiple tags for the same region 
Change-Id: I8f014fe7bdae72c21d5df4f5e45169c610df632e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/120921
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-10-09 16:25:30 +00:00
Brian Wilkerson 9ababcf650 Improve message for overriding methods 
Change-Id: I6fed64a852f94f2323972f511be4015a22fb4ebd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/120746
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-10-09 00:12:50 +00:00
Sam Rawlins 8513b169da NNBD i13n: Fix some navigation targets and text 
Change-Id: Iba6befb86453353823c1702405057f83fff64456
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/120723
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-10-08 20:54:08 +00:00
Sam Rawlins 17388522ea NNBD i13n: Fix un-highlighting targeted nodes 
Change-Id: I59b0ea5baebc8721f151705196cdf69f0532af21
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/120623
Auto-Submit: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2019-10-08 16:31:51 +00:00
Konstantin Shcheglov a389015083 Rewrite MethodInvocation to FunctionExpressionInvocation when the target is not a method. 
Failing tests for DDC are tracked in the following issue:
https://github.com/dart-lang/sdk/issues/38749

Change-Id: I96e0fe9bc87509b99ba982be4572d4ad4f133cca
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/120342
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-10-08 00:22:39 +00:00
Konstantin Shcheglov b00453c68a Create synthetic FunctionType in quick fixes. 
R=brianwilkerson@google.com

Change-Id: I3e34bc043bfd45c242213b037da609f27341bdad
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/120561
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-10-07 14:10:39 +00:00
Devon Carew 3e3406d20e [sdk] remove the dart:_chrome package 
Change-Id: I5b62984fb7d4cd5dd9ed6f4a02ed91e08ed71e8e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/120005
Reviewed-by: Vijay Menon <vsm@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2019-10-06 23:50:09 +00:00
pq 69b612beec diagnostic ref fix for fall-through types 
See: https://github.com/dart-lang/sdk/issues/38633

Change-Id: I5fd1328a5ad234e6216631007ecbcc459bfa36e9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/120340
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2019-10-04 23:06:12 +00:00
Devon Carew 73d880b949 [analyzer] add a quick fix for the prefer_relative_imports lint 
Change-Id: Ic69ebe799f425fd09e002b65d66a4382f5f96ead
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/120160
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
 2019-10-04 20:13:07 +00:00
Brian Wilkerson 9271895f56 Remove an accidentally committed soloTest annotation (TBR) 
Change-Id: If3791de34f0f063a50570b8713c9340821d901d8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/120220
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-10-04 19:24:06 +00:00
Mike Fairhurst c3053f0eb2 [nnbd_migration] Restrict downcasts; make all type parameters nullable. 
This makes trial_migration.dart report two new exceptions:

_EdgeBuilder&GeneralizingAstVisitor&_AssignmentChecker._checkAssignment (package:nnbd_migration/src/edge_builder.dart:2169:14) (x30)
_EdgeBuilder&GeneralizingAstVisitor&_AssignmentChecker._checkDowncast (package:nnbd_migration/src/edge_builder.dart:2351:14) (x7)

30 & 7 is not great but not terrible. These also do not break path, logging, or
charcode.

Failing tests show why we cannot correctly cover remaining cases without
a larger CL.

Change-Id: I6e510db147f60cc8ee047d45e4ce2d95d26cccc4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119533
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
 2019-10-04 18:31:48 +00:00
pq 80f683417b when fixing missing diagnostic refs, add debugFillProperties method if undefined 
See: https://github.com/dart-lang/sdk/issues/38633

Change-Id: If82922a38243e144ad2ec0038d8642c17f458df8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/120140
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-10-04 17:34:15 +00:00
Brian Wilkerson 42a1ba7e14 Improve the messages from the migration tooling 
Change-Id: I8ed53936cf56f154040d53e88190a114a6133555
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/120006
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-10-04 12:43:45 +00:00
pq 0a63bd4b0a diagnostic fix support for colors, iterables, lists, matrices 
See: https://github.com/dart-lang/sdk/issues/38633

Change-Id: I8d7baa32bcea22f2c162bd9d77c7dd0b95b308de
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119901
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2019-10-03 20:05:33 +00:00
pq 512d763b9d diagnostic property types support 
Adds support for:

* ints
* doubles
* enums
* Strings

Up next: Colors, Iterables, Transforms and a catch-all.

Also note the TODO to change how types are being written (will be needed for Iterables).

See: https://github.com/dart-lang/sdk/issues/38633

Change-Id: I9d545ce9e090059ae330f9ae5dadf8e7d4b373c7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119725
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-10-03 02:12:39 +00:00
Brian Wilkerson f2816eeb0d Add a test, a TODO, and a minor display enhancement 
Change-Id: Iee53c429839b36426677916f13878b1a3313bef3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119767
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-10-02 22:23:41 +00:00
Brian Wilkerson bb342ec83f Fix a test breaking the windows bot 
Change-Id: I8192597a93ceb043585da0dc51f194e99bc2422c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119701
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-10-02 20:01:40 +00:00
pq 5a174aa2df getter support for fixing missing diagnostic property references 
Change-Id: Iac5523b90f3f753107cf5dc22c3cd211a21ae040
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119681
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-10-02 18:11:20 +00:00
Brian Wilkerson fee4fe8241 Generate output files for files outside the migrated package 
This allows navigation to work from migrated files, but some navigation
from unmiograted files doesn't work.

This also causes the content of the output directory to be deleted
before generation starts so that old files won't confuse the user.

Change-Id: I0007d811e56b82cb6b91582e3237c7383ae2d060
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119660
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-10-02 16:31:19 +00:00
Mike Fairhurst 2590d065f1 Update test_reflective_loader, use @SkippedTest 
Change-Id: I17f8da88a4587a7ad51038ca796f138231021fe9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119583
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Auto-Submit: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-10-02 00:02:21 +00:00
Brian Wilkerson a7b03453d1 Sort the instrumentation renderer. 
There are no changes other than the sorting.

Change-Id: Ifcb6874324714cad954138a857416b6046bd276e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119585
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Auto-Submit: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-10-01 22:19:40 +00:00
pq 23aca57eda fix for adding boolean diagnostic property references 
very constrained support for fixing `diagnostic_describe_all_properties` for the boolean field case.

still todo:

* tests for no debugFillProperties method
* tests for getters
* support for ColorProperty -- for Color
* support for EnumProperty -- for any enum class
* support for IntProperty -- int
* support for DoubleProperty -- double
* support for IterableProperty -- any iterable
* support for StringProperty -- string
* support for TransformProperty -- Matrix4
* support for DiagnosticsProperty for any T that doesn't match one of the other cases

(at least)

See: https://github.com/dart-lang/sdk/issues/38633




Change-Id: Ie6875f49914e54d3b4539fcb51a231da688bdf18
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119536
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-10-01 21:34:00 +00:00
Brian Wilkerson 6ec36b786f Generate a file for each compilation unit rather than for each library 
Change-Id: I9a1e812115ba616d0bea57ad6e813c993d1e65d9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119539
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-10-01 21:31:29 +00:00
Brian Wilkerson 431176ea26 Add non-nnbd-specific navigation 
Change-Id: I7b641a89ed935000c54b6f769f50aaf634cdcda8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119531
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-10-01 20:15:36 +00:00