Commit Graph

863 Commits

Author SHA1 Message Date
scheglov@google.com be31b47690 Issue 8051. dart_analyzer return codes on errors
http://code.google.com/p/dart/issues/detail?id=8051

R=devoncarew@google.com,whesse@google.com
BUG=

Review URL: https://codereview.chromium.org//12041051

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17622 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-25 00:47:48 +00:00
scheglov@google.com 321bcf58e4 Issue 7597. Use foo= when setter requested, even if there is method foo().
http://code.google.com/p/dart/issues/detail?id=7597

Language/07_Classes/3_Setters_A04_t04
Language/07_Classes/4_Abstract_Instance_Members_A02_t01
are not changed because they are part of huge list of tests which promis to don't have static type errors, but have them.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//12039056

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17520 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-24 05:15:39 +00:00
scheglov@google.com cc4b22ea10 Issue 8059. Disallow mixing in classes that use 'super' from any member.
http://code.google.com/p/dart/issues/detail?id=8059

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//12039054

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17518 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-24 01:00:29 +00:00
scheglov@google.com 1bf84876fc Issue 7598. Skip metadata when parse directives for LibraryUnit.
http://code.google.com/p/dart/issues/detail?id=7598

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//12038042

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17485 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-23 18:08:47 +00:00
scheglov@google.com 06a378f5dd Issue 7605. Check separately getters and setter implementation when check for abstratc members.
http://code.google.com/p/dart/issues/detail?id=7605

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//11896057

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17482 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-23 17:56:19 +00:00
scheglov@google.com e61663d00e Issue 7633. Report error when instance field is accessed from factory constructor.
http://code.google.com/p/dart/issues/detail?id=7633

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//12045040

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17479 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-23 17:45:41 +00:00
scheglov@google.com b1bdb27a12 Issue 7802. Fix for redundant casts.
http://code.google.com/p/dart/issues/detail?id=7802

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//12038040

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17476 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-23 17:33:57 +00:00
scheglov@google.com b806f5f3f9 Issue 7884. Use UTF-8 for output.
http://code.google.com/p/dart/issues/detail?id=7884

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//12036045

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17475 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-23 17:31:47 +00:00
scheglov@google.com 761ea9993f Issue 8025. Disallow mixing in classes that have constructors.
http://code.google.com/p/dart/issues/detail?id=8025

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//12048003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17473 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-23 17:26:46 +00:00
scheglov@google.com 76771f343e Issue 8006. Allow abstract modifier for typedef mixin applications.
http://code.google.com/p/dart/issues/detail?id=8006

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//12039027

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17429 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-22 22:39:32 +00:00
scheglov@google.com 23bf0056b3 Issue 8022. Report compile-time error when using mixing with not Object superclass.
http://code.google.com/p/dart/issues/detail?id=8022

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//12038035

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17428 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-22 22:28:42 +00:00
scheglov@google.com 804db39323 Issue 7980. Report problem when type 'dynamic' is shadowed.
http://code.google.com/p/dart/issues/detail?id=7980

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//12045032

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17425 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-22 21:12:12 +00:00
scheglov@google.com d8d842ffe1 Issue 8038. Don't report 'is not a function type' if class has 'noSuchMethod'.
http://code.google.com/p/dart/issues/detail?id=8038

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//12039023

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17424 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-22 21:09:28 +00:00
danrubel@google.com fd96d93fa9 fix http://code.google.com/p/dart/issues/detail?id=7999
BUG=

Review URL: https://codereview.chromium.org//12035007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17364 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-21 16:55:12 +00:00
messick@google.com 16310f7a09 Add support for mixins to code completion.
Review URL: https://codereview.chromium.org//11824043

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16890 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-09 22:06:14 +00:00
scheglov@google.com 82f1c72f92 Initial support for mixins in dartc.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//11776037

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16864 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-09 17:13:02 +00:00
scheglov@google.com 954a07bf60 Switch 'default' is allowed to have fall-through
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//11793004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16740 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-07 19:37:49 +00:00
scheglov@google.com 24b0b71035 Issue 7671. Type of field accessed using inferred type has same type quality.
http://code.google.com/p/dart/issues/detail?id=7671

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//11793002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16658 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-04 22:57:32 +00:00
scheglov@google.com 63d5737d74 Issue 6578. Move 'getter/setter static mismatch' into type problems
http://code.google.com/p/dart/issues/detail?id=6578

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//11788004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16650 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-04 22:12:29 +00:00
scheglov@google.com 244a18ff6a Fix for renaming named constructor reference in 'super' invocation.
R=messick@google.com,pquitslund@google.com
BUG=

Review URL: https://codereview.chromium.org//11665018

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16468 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-23 02:35:10 +00:00
scheglov@google.com 1b5865ea38 Fix for CCE when super() is used outside of constructor (and class at all)
From feedback error log.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//11644091

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16467 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-23 02:02:55 +00:00
scheglov@google.com 69eb9c8c9c Issue 7532. Fix for NPE in SemanticHighlightings
http://code.google.com/p/dart/issues/detail?id=7532

R=messick@google.com
BUG=

Review URL: https://codereview.chromium.org//11648026

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16465 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-22 02:02:15 +00:00
scheglov@google.com 642b8dfd3c Issue 3223. Don't report warning when call variable with not-function inferred type.
http://code.google.com/p/dart/issues/detail?id=3223

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//11633024

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16356 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-20 03:18:24 +00:00
devoncarew@google.com b5131437f5 Protect against concurrent modification exceptions in a new version of guava.
Review URL: https://codereview.chromium.org//11644028

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16349 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-19 22:37:16 +00:00
devoncarew@google.com b2967054a7 Fix 2 failing tests on windows.
Remove 4 failing (and obsolete) tests on windows.
Enable proper reporting of junit test failures for windows.
Review URL: https://codereview.chromium.org//11638015

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16333 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-19 18:21:38 +00:00
scheglov@google.com a3dcd4e8f8 Issue 7469. Report error if type appears in for extends and implements clauses
http://code.google.com/p/dart/issues/detail?id=7469

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//11612027

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16282 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-18 19:49:12 +00:00
scheglov@google.com 0abc92dae5 Tweak to support 'dart.core' as core library name.
Needed to commit again https://codereview.chromium.org/11419032/

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//11615031

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16278 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-18 19:11:20 +00:00
devoncarew@google.com 9743106bba Fix for a file encoding isuse in DartAnnotation.java.
https://code.google.com/p/dart/issues/detail?id=7431
Review URL: https://codereview.chromium.org//11606018

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16264 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-18 17:30:58 +00:00
scheglov@google.com 2c93012cc4 Issue 6971. Don't report error for using built-in identifier as part of parameterized type.
http://code.google.com/p/dart/issues/detail?id=6971

It seems that this is official position of Gilad, so I just do what is he thinks is right.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//11571029

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16180 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-14 21:24:38 +00:00
scheglov@google.com 47346c8fa4 Issue 7093. Support for inlining function references.
http://code.google.com/p/dart/issues/detail?id=7093

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//11577022

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16170 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-14 17:54:26 +00:00
scheglov@google.com 7ed0ec0e3d Issue 7373. Fix for marking abstract methods as overriding themselves.
http://code.google.com/p/dart/issues/detail?id=7373

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//11569021

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16143 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-13 22:25:49 +00:00
scheglov@google.com 4d1840ce18 Issue 6974. Report warning when arguments are given for 'dynamic' or type variable.
http://code.google.com/p/dart/issues/detail?id=6974

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//11569014

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16135 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-13 19:12:39 +00:00
scheglov@google.com 694b17e439 Issue 6971. Fixes for using built-in identifier as import prefix.
http://code.google.com/p/dart/issues/detail?id=6971

Only first part of issue.
I don't agree that code like this is valid:
   abstract<dynamic> v;

I think "abstract" here is still type annotation, so error should be reported.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//11549028

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16086 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-13 01:16:41 +00:00
scheglov@google.com 3d808f8e63 Issue 7271. If class has method call() with type F, class should be considered as subtype of function type F
http://code.google.com/p/dart/issues/detail?id=7271

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//11442061

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16058 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-12 20:02:51 +00:00
scheglov@google.com 2069cc083d Issue 2862. Report warning when 'default' of switch has fall-through.
http://code.google.com/p/dart/issues/detail?id=2862

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//11555015

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16052 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-12 17:15:11 +00:00
scheglov@google.com a691a8955c Issue 6836. Reference to prefixed undeclared identifier in static context is also warning
http://code.google.com/p/dart/issues/detail?id=6836

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//11548014

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16050 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-12 16:56:30 +00:00
scheglov@google.com 2a7af69179 Issue 7278. Report static warnings for redirecting factory constructors
http://code.google.com/p/dart/issues/detail?id=7278

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//11549014

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16046 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-12 16:32:37 +00:00
scheglov@google.com 67eca2faa2 Issue 6710. Report error for function libteral with return type and name.
http://code.google.com/p/dart/issues/detail?id=6710

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//11533010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16019 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-12 06:23:35 +00:00
scheglov@google.com 1f37d21d41 Issue 7282. Report error for deprecated === and !==
http://code.google.com/p/dart/issues/detail?id=7282

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//11534013

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15989 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-11 18:26:02 +00:00
keertip@google.com ab854d4573 fix for dartbug.com/7234 - URI exception for web_audio
Review URL: https://codereview.chromium.org//11515006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15931 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-10 20:52:01 +00:00
scheglov@google.com b7cbab1a19 Enabled reporting problems in some libraries.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//11464004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15802 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-06 19:14:50 +00:00
scheglov@google.com 3e298ec9ed Ignore not all, but only some problems in dart:core
http://code.google.com/p/dart/issues/detail?id=7128

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//11447018

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15760 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-05 23:06:28 +00:00
scheglov@google.com 0aa59c4802 Issue 7128. Don't show problems in dart:core
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//11415291

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15701 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-04 19:43:13 +00:00
scheglov@google.com 4769c45988 More co19 clean up.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//11421216

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15700 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-04 18:58:24 +00:00
scheglov@google.com 5679566f2d More co19 triage.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//11428131

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15644 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-03 17:49:07 +00:00
scheglov@google.com 17d16e41d7 Triage and fixes for co19 library tests.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//11416307

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15643 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-03 17:30:21 +00:00
scheglov@google.com 47d52ca683 Triage some co19 tests.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//11414264

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15597 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-30 20:19:43 +00:00
scheglov@google.com 9d80840238 Analyze Dart scripts in HTML files.
Right now only for adding markers.

R=devoncarew@google.com,danrubel@google.com
BUG=

Review URL: https://codereview.chromium.org//11348291

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15533 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-29 18:54:50 +00:00
scheglov@google.com 04e18f28de Triage some co19 tests.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//11418233

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15527 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-29 17:39:02 +00:00
keertip@google.com ee9aba4f8e yet another fix for dart: with "_"
Review URL: https://codereview.chromium.org//11415186

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15513 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-29 12:32:41 +00:00