Commit Graph

850 Commits

Author SHA1 Message Date
John Messerly aa85651820 fix #27403, use AST summaries in DDC
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2353133004 .
2016-09-20 17:55:09 -07:00
Jacob Richman bad7f76374 Fix crashes due to attempts to create an identifier name containing the word <bottom>. Likely there is a better fix but this appears to work for now.
BUG=
R=jmesserly@google.com

Review URL: https://codereview.chromium.org/2354603003 .
2016-09-19 14:52:12 -07:00
John Messerly a4734d4b33 fix #27353, support @checked covariant parameters in DDC
Seems pretty straightforward. Just added a simple test for now.

R=leafp@google.com

Review URL: https://codereview.chromium.org/2340463009 .
2016-09-15 15:42:04 -07:00
Jacob Richman 7341e3d34c Cleanup. Fix new analyzer errors due to recent strong mode changes.
BUG=

Review URL: https://codereview.chromium.org/2338323004 .
2016-09-15 10:45:05 -07:00
Jacob Richman 35e7c4c5f5 Always write the source map even if it is inlined. This simplifies bazel rules.
BUG=
R=jmesserly@google.com

Review URL: https://codereview.chromium.org/2342643003 .
2016-09-15 10:33:22 -07:00
Brian Wilkerson ecc84b26a4 Break up another large file
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2342733002 .
2016-09-15 07:49:27 -07:00
Jacob Richman bda62939a2 Support generating inlined source maps and wrapping module contents within a JavaScript eval block to improve the debugging experience.
BUG=
R=vsm@google.com

Review URL: https://codereview.chromium.org/2337213003 .
2016-09-14 10:54:47 -07:00
Vijay Menon 9732138317 Testing support for FF and Safari
Also travis support for testing FF.  See:

https://travis-ci.org/dart-lang/sdk/builds/159331789

On FF 48, 1965 out of 1979 tests are passing.  Run locally:
DDC_BROWSERS=Firefox npm test

On Safari 10 (tech preview), it fails immediately due to a static method named "caller".  We disallow it as a field, but not a method right now.  If I hack that out, 1972 out of 1979 tests appear to pass.

Run locally by installing tech preview and running:
DDC_BROWSERS=Safari SAFARI_BIN=/Applications/Safari\ Technology\ Preview.app/Contents/MacOS/Safari\ Technology\ Preview npm test
R=jmesserly@google.com, rnystrom@google.com

Review URL: https://codereview.chromium.org/2334763002 .
2016-09-14 08:41:43 -07:00
Brian Wilkerson 1f10422fd5 Update uses of deprecated API in ddc
R=jmesserly@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/2338883002 .
2016-09-13 11:44:38 -07:00
Vijay Menon e52613f151 Fix error message
R=jacobr@google.com

Review URL: https://codereview.chromium.org/2329493002 .
2016-09-09 09:02:50 -07:00
Bob Nystrom 33ff9a3d4f Fix type errors in sort().
If a comparer isn't provided, it was silently assuming the element type
implements Comparable, even though that isn't required. Fixed to add a
manual cast at each comparison.

A stricter faster approach might be to check that the type argument
itself is a type that implements Comparable, but I don't know if that's
too pessimistic, or even possible to do.

R=vsm@google.com

Review URL: https://codereview.chromium.org/2311513002 .
2016-09-08 17:14:36 -07:00
Bob Nystrom 8c7dd5cd04 Cast InternalMap to Map.
It's a tag interface that doesn't declare that it implements Map but all
classes that implement it also implement Map, so just do a cast.

R=vsm@google.com

Review URL: https://codereview.chromium.org/2304323002 .
2016-09-08 16:23:45 -07:00
John Messerly 48817e61f7 fix strong mode messages in pkg/dev_compiler
R=vsm@google.com

Review URL: https://codereview.chromium.org/2314193002 .
2016-09-07 09:06:24 -07:00
Jacob Richman 38724f0626 Update web_command code so that it continues to use the legacy module loader. Drive by removal of misleading comments.
BUG=
R=jmesserly@google.com

Review URL: https://codereview.chromium.org/2303163002 .
2016-09-06 09:57:05 -07:00
Vijay Menon 0c8cd45dea Regen and fix expectations
Caught by travis :-)

TBR=jmesserly@google.com

Review URL: https://codereview.chromium.org/2300753006 .
2016-09-01 15:11:40 -07:00
Vijay Menon 9af2fb0115 More DDC mirrors support
(Note, this is a straight migration of the old DDC repo CL. :-))

R=jmesserly@google.com

Review URL: https://codereview.chromium.org/2301973002 .
2016-09-01 10:13:31 -07:00
Vijay Menon 2bc19eaa64 Remove deprecated code
Updating to the latest analyzer.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/2289263004 .
2016-08-30 15:39:38 -07:00
Vijay Menon feb77b40a4 Bind this in ng2 hack code
R=jmesserly@google.com

Review URL: https://codereview.chromium.org/2291873002 .
2016-08-29 16:41:29 -07:00
Vijay Menon 6a1a03add4 Make source map paths relative
R=jmesserly@google.com

Review URL: https://codereview.chromium.org/2288453002 .
2016-08-26 16:31:53 -07:00
Bob Nystrom 4b321d0ecd Import "NoInline" into core so StackTrace's use of it resolves.
R=vsm@google.com

Review URL: https://codereview.chromium.org/2277753005 .
2016-08-25 17:08:52 -07:00
John Messerly 8081afc785 fix travis bots
- increase timeout so we load all tests
- mark a few more failures
- skip unittest tests until we re-triage them

Review URL: https://codereview.chromium.org/2279053002 .
2016-08-25 13:23:14 -07:00
John Messerly bc50963a61 fix writing summaries
I also renamed "outPath" so this bug is less likely to happen in the future :)

R=vsm@google.com

Review URL: https://codereview.chromium.org/2279833002 .
2016-08-25 10:40:09 -07:00
John Messerly c1139934a7 fix #626, add AMD module format and make it default
R=nweiz@google.com, vsm@google.com

Review URL: https://codereview.chromium.org/2249233002 .
2016-08-25 09:39:36 -07:00
Jacob Richman 87577db2b2 Add dart:js_util library and tests to ddc. This library is already added to dart2js and dartium.
BUG=
R=jmesserly@google.com

Review URL: https://codereview.chromium.org/2269963005 .
2016-08-24 09:13:06 -07:00
Vijay Menon 8442efa4d3 Support call methods on functions
Fixes #624

R=jmesserly@google.com

Review URL: https://codereview.chromium.org/2255993002 .
2016-08-18 07:51:17 -07:00
Vijay Menon d90d172d8b Remove deprecated DirectoryBasedDartSdk
We're getting bot failures due to analyzer deprecation messages.

R=brianwilkerson@google.com, jmesserly@google.com

Review URL: https://codereview.chromium.org/2258873002 .
2016-08-18 07:47:45 -07:00
John Messerly a076edad94 roll analyzer
R=vsm@google.com

Review URL: https://codereview.chromium.org/2254883002 .
2016-08-17 21:10:21 -07:00
John Messerly 9b421ebb4f fixes #627, update DDC Future.then signature
R=leafp@google.com

Review URL: https://codereview.chromium.org/2259433002 .
2016-08-17 10:25:10 -07:00
John Messerly 36273565e3 fixes #610, incorrect help output
R=nweiz@google.com

Review URL: https://codereview.chromium.org/2244703003 .
2016-08-12 15:06:41 -07:00
John Messerly 0aa5cbd128 fix #620, infer the input files from sources
also simplifies build of packages used by our tests
this caused a bunch of tests that use parts to start passing

R=nweiz@google.com

Review URL: https://codereview.chromium.org/2234343003 .
2016-08-11 13:19:36 -07:00
Vijay Menon 8fec051a8e Mark recursive_inheritance_test as passing
This will get the dev and master bots green.

Will need to bump the pubspec on analyzer (once published) to make stable green after this.

R=leafp@google.com

Review URL: https://codereview.chromium.org/2214263005 .
2016-08-05 09:35:01 -07:00
Vijay Menon 3ddb76b95c Reify type params on map literals
Fixes #621

R=jmesserly@google.com, leafp@google.com

Review URL: https://codereview.chromium.org/2211293002 .
2016-08-05 07:16:02 -07:00
Vijay Menon 144cca4b62 Roll DDC to latest dart:html
R=jacobr@google.com

Review URL: https://codereview.chromium.org/2207273002 .
2016-08-03 17:55:05 -07:00
Vijay Menon b324b14105 Regen with latest analyzer
TBR=jmesserly@google.com

Review URL: https://codereview.chromium.org/2212663002 .
2016-08-03 17:32:17 -07:00
Priscilla Lee 411de08847 Added list of imports to library modules (needed in order to discover filepaths of summaries, allowing the dev_compiler to run in the browser).
BUG=
R=jacobr@google.com, jmesserly@google.com

Review URL: https://codereview.chromium.org/2208883002 .
2016-08-03 15:47:57 -07:00
Brenna Milligan 3b7e5eed8c Updated sdk
BUG=
R=jacobr@google.com

Review URL: https://codereview.chromium.org/2206843002 .
2016-08-02 17:16:07 -07:00
Brenna Milligan 8b0b57844b Get rid of library proto information for debugger libraries
BUG=
R=jacobr@google.com

Review URL: https://codereview.chromium.org/2208533003 .
2016-08-02 17:08:27 -07:00
Vijay Menon 0fd3e8821c Fix wrt analyzer tip
This sidesteps #618 for now.

R=jmesserly@google.com

Review URL: https://codereview.chromium.org/2209473002 .
2016-08-02 14:42:06 -07:00
Vijay Menon bd789e912b Remove source file check
This is breaking downstream build rules.

TBR=leafp@google.com

Review URL: https://codereview.chromium.org/2199123003 .
2016-08-02 13:35:50 -07:00
Brenna Milligan a7dc32f424 Deprecation of ClassMetadata wrapper for Class formatters so a stand-alone class is recognizable.
BUG=
R=jacobr@google.com

Review URL: https://codereview.chromium.org/2205733002 .
2016-08-02 09:43:02 -07:00
John Messerly e51f9de339 fixes #616, statics on callable functions
also fixes `this` for them

R=vsm@google.com

Review URL: https://codereview.chromium.org/2200913002 .
2016-08-01 17:12:37 -07:00
John Messerly 344124e4a1 fix optional params to mock methods, allow all signatures
switches to use the same technique as `dsend`

R=vsm@google.com

Review URL: https://codereview.chromium.org/2201973002 .
2016-08-01 16:21:59 -07:00
Vijay Menon 437cca2923 Rename build-root to library-root
First step on #557.  Will eliminate the deprecated flag once upstream
uses are switched over.

R=jmesserly@google.com

Review URL: https://codereview.chromium.org/2197243002 .
2016-08-01 08:30:32 -07:00
Vijay Menon b2353d7513 Fix analyzer error
This is breaking travis.

TBR=jmesserly@google.com

Review URL: https://codereview.chromium.org/2199473002 .
2016-07-29 14:31:46 -07:00
Priscilla Lee d2ec49d1f7 Working compiler in browser.
BUG=
R=jmesserly@google.com

Review URL: https://codereview.chromium.org/2183603003 .
2016-07-29 09:18:13 -07:00
Brenna Milligan d18ab46592 Addition of StackTrace formatters
R=alanknight@google.com, jacobr@google.com

Review URL: https://codereview.chromium.org/2189673002 .
2016-07-27 15:14:55 -07:00
John Messerly 0f29ee9618 Remove DDC custom error list now that strong mode analyzer handles it
R=leafp@google.com

Review URL: https://codereview.chromium.org/2102053003 .
2016-07-27 13:10:57 -07:00
John Messerly 18769af805 restore code_generator file from b770039, the nSM mock fix
Review URL: https://codereview.chromium.org/2189683002 .
2016-07-27 09:49:58 -07:00
Brenna Milligan d7c7c19c54 Library children object fix
R=alanknight@google.com, jacobr@google.com

Review URL: https://codereview.chromium.org/2176233002 .
2016-07-25 17:44:59 -07:00
Brenna Milligan 3d03bee32d Library custom formatters
R=alanknight@google.com, jacobr@google.com, jmesserly@google.com

Review URL: https://codereview.chromium.org/2164763005 .
2016-07-22 14:15:53 -07:00