Commit Graph

1562 Commits

Author SHA1 Message Date
johnmccutchan@google.com dc9f902fb1 Fix code coverage (again!)
BUG=
R=koda@google.com

Review URL: https://codereview.chromium.org//346763007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37617 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-23 21:05:15 +00:00
koda@google.com d3c0913a3d Make retained size human-readable.
BUG=dart:19444
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//350573002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37614 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-23 19:47:07 +00:00
koda@google.com bd979f84d5 Send allocation stats with each class and show in class view.
For each class, if there are any allocations, shows current number of instances, shallow size, and the already existing link for retained size.

Also refactor code in ClassTable to reduce duplication.

R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//345543003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37566 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-20 20:17:42 +00:00
johnmccutchan@google.com 9aeb79505a Fix Observatory code coverage
BUG=
R=koda@google.com

Review URL: https://codereview.chromium.org//345113002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37555 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-20 16:06:30 +00:00
asiva@google.com 857304304f Do not add '-p' and 'c' options to VM options, the VM flag processing
functionality only accepts flags with the '--' prefix. It silently
ignores all following options if an invalid option is specified.

R=srdjan@google.com

Review URL: https://codereview.chromium.org//348653002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37517 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-19 21:00:50 +00:00
johnmccutchan@google.com 452545ddcd Visual refresh of allocation profile page
- Redo layout of page.
- Show human readable strings for used, free, and external memory for each space.
- Track time of last forced GC/accumulator reset in isolate and display them in allocation profile page.
- Track allocation statistics on Class object itself.
- Make isolate's heap reporting use heap's PrintToJSON.
- Manually insert allocation profile table rows into dom (removes usage of template repeat).
- Add some timing information to allocation profile page update (to help diagnose slow downs).

Other changes:
- Upgrade to Polymer 0.11-dev (finally ends erroneous console spam).
- Replace enteredView/leftView with attached/detached (polymer change).
- Add <link> tag to polymer.html for each element (polymer change).
- Move <script> tag outside of element (uniformity, clarity).
- Remove unused collapsible-content element.

R=koda@google.com

Review URL: https://codereview.chromium.org//342513004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37456 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-18 17:39:37 +00:00
hausner@google.com 6cc8cbc53b Adding embedder API function Dart_FinalizeLoading
Embedder must call Dart_FinalizeLoading when all outstanding
load requests are satisfied, to complete the deferred loading
futures.

R=asiva@google.com

Review URL: https://codereview.chromium.org//341543004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37423 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-17 21:05:30 +00:00
johnmccutchan@google.com 1833604ae6 Show pid on Observatory VM page
BUG=
R=koda@google.com

Review URL: https://codereview.chromium.org//331323002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37415 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-17 20:15:49 +00:00
johnmccutchan@google.com c3211b9608 Avoid calling anything related to signals on Windows
BUG=

Review URL: https://codereview.chromium.org//339193003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37402 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-17 15:58:05 +00:00
johnmccutchan@google.com 7a761048f3 Wrap signal listening with try catch to fix Windows
BUG=

Review URL: https://codereview.chromium.org//343433004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37398 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-17 14:46:47 +00:00
johnmccutchan@google.com 164a3500ef SIGQUIT toggles VM service HTTP server
R=ajohnsen@google.com

Review URL: https://codereview.chromium.org//237113002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37396 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-17 14:26:38 +00:00
koda@google.com 9280007de5 Limit canvas height in heap map.
Apparently many broswers fail to display a canvas taller than 6K-8K pixels.

This is a stop-gap solution that stops loading pages when max height has
been reached, and displays the correct total count for the user.

Longer-term, we should provide a less detailed, high-level view for huge heaps.

R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//330333004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37366 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-16 17:09:23 +00:00
lrn@google.com 31eeb6caf2 Revert "New, more validating, parser for URI." and follow-up patches.
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//337033003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37359 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-16 12:32:35 +00:00
lrn@google.com 7c9b3a3bdd Another case of the VM getting a path into Uri.parse.
Committed: https://code.google.com/p/dart/source/detail?r=37354

Committed: https://code.google.com/p/dart/source/detail?r=37356

Review URL: https://codereview.chromium.org//333283002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37358 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-16 11:39:08 +00:00
lrn@google.com cf354f55a9 Another case of the VM getting a path into Uri.parse.
Committed: https://code.google.com/p/dart/source/detail?r=37354

Review URL: https://codereview.chromium.org//333283002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37356 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-16 11:18:32 +00:00
lrn@google.com a1de66e743 Another case of the VM getting a path into Uri.parse.
Review URL: https://codereview.chromium.org//333283002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37354 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-16 11:11:40 +00:00
lrn@google.com 6ad8f0c920 Another case of VM using Uri.resolve on something not a URI reference.
R=ajohnsen@google.com

Review URL: https://codereview.chromium.org//339563003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37353 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-16 10:16:08 +00:00
lrn@google.com 0675e78d5b Remove another case of _sanitizeWindowsPath before Uri.file
Remove the now unused function as well.

Review URL: https://codereview.chromium.org//338783002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37351 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-16 09:19:42 +00:00
lrn@google.com ff80d6e997 Remove extra windows-char-sanitization, duplicationg and breaking the one in Uri.file.
Review URL: https://codereview.chromium.org//335093002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37349 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-16 08:06:52 +00:00
lrn@google.com c7d98e335b New, more validating, parser for URI.
BUG= https://code.google.com/p/dart/issues/detail?id=16081
R=ajohnsen@google.com, fschneider@google.com, sgjesse@google.com

Review URL: https://codereview.chromium.org//321543003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37346 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-16 07:00:22 +00:00
hausner@google.com 4eac05607f Lazy loading of deferred libraries
Defer reading of source code of deferred libraries until the
Dart code executes the loadLibrary() call.

R=iposva@google.com

Review URL: https://codereview.chromium.org//328923002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37334 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-13 22:43:31 +00:00
johnmccutchan@google.com ee66efac38 Upgrade to polymer_expressions 0.11.1
R=iposva@google.com

Review URL: https://codereview.chromium.org//322243002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37204 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-10 22:04:23 +00:00
ajohnsen@google.com cdaf11dc9d Don't use kFSEventStreamCreateFlagNoDefer as it messes with event flushing.
BUG=
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//321133002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37171 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-10 10:44:20 +00:00
ajohnsen@google.com b908de9ec0 Add HttpServerConnection to Observatory.
BUG=
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//302173007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37166 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-10 07:33:37 +00:00
ajohnsen@google.com 8719f3834b Add Observatory test of io.
Initially a single test of a HttpServer. More will follow.

This also fixes the case where we don't 'block' when binding to a
ServerSocket. We should not close until the socket is explicitly closed.

BUG=
R=johnmccutchan@google.com, sgjesse@google.com

Review URL: https://codereview.chromium.org//311153003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37164 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-10 07:13:52 +00:00
ajohnsen@google.com cee2d6e82e Correctly truncate in Windows eventhandler.
BUG=
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//323823002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37163 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-10 07:12:52 +00:00
iposva@google.com 551e5f845a - Report CodeSize instead of runtime for benchmarks reporting snapshot sizes.
R=asiva@google.com

Review URL: https://codereview.chromium.org//314383002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37156 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-10 05:20:52 +00:00
johnmccutchan@google.com 045bc93c93 Regenerate Observatory JS
Forgot to regenerate for: https://codereview.chromium.org/322483005

Review URL: https://codereview.chromium.org//320233005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37128 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-09 18:08:41 +00:00
johnmccutchan@google.com f181f240e4 Final Observatory 1.5 fixes
- Don't request the empty path from service.
- Don't replace the url path (Fixes Dartium).
- Disable dart:io link until UI is completed.
- Disable back and forward buttons because they act weird in DevTools.

R=turnidge@google.com

Review URL: https://codereview.chromium.org//322483005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37125 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-09 18:04:38 +00:00
vegorov@google.com d30ecd3fcd Fix Win64 build of Dart VM.
1. Build script tools/build.py now actually builds X64 target when x64
is passed as an architecture:

- GYP files set 'msvs_configuration_platform': 'x64' for Win_x64
configuration;

- NSS related files are fixed to have correct set of defines for ia32
and x64 builds and include right files. A os_windows.c file added to
work-around inability to have different sets of source files per
configuration. Originally this was controlled through target_arch GYP
define and required regeneration of the solution.

- build.py passes Win32 or x64 platform to devenv as part of build
configuration argument;

2. Dart VM now supports Win64 ABI. ABI description is moved into a
separate class CallingConventions in constants_x64.h.

BUG=http://dartbug.com/7792
R=iposva@google.com, ricow@google.com, srdjan@google.com

Review URL: https://codereview.chromium.org//317773002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37078 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-06 12:14:15 +00:00
iposva@google.com 1d2085e773 - Fix truncation in Socket calls.
R=asiva@google.com

Review URL: https://codereview.chromium.org//312343002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37037 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-05 17:33:52 +00:00
srdjan@google.com f4a625f895 Do not write protect code when running standalone. Improves startup performance.
R=asiva@google.com

Review URL: https://codereview.chromium.org//312313002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37032 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-05 16:56:46 +00:00
ajohnsen@google.com 9ddf98ffb8 Mark handle as invalid, when datagram socket is closed.
BUG=

Review URL: https://codereview.chromium.org//315173003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37030 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-05 15:56:59 +00:00
johnmccutchan@google.com c94e8b090a Redo LocationManager to use HTML5 History API
Make a Class ServiceObject
Introduce application Panes
Intercept all "application link" click events and manually dispatch them to LocationManager.
Add <nav-control> that adds back and forward buttons

Rolled in:

* https://codereview.chromium.org/306723002
* Revert to HttpVM

R=turnidge@google.com

Review URL: https://codereview.chromium.org//308673012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37014 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-04 21:01:02 +00:00
ajohnsen@google.com 58e0c32205 Don't issue new directory reads, if we already got unhandled data.
BUG=

Review URL: https://codereview.chromium.org//319503005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37006 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-04 18:50:40 +00:00
ajohnsen@google.com 90db41af31 Fix previous fix, by still making 'handle' the socket.
BUG=

Review URL: https://codereview.chromium.org//316813006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36999 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-04 15:56:47 +00:00
ajohnsen@google.com f8d735521c Don't use same value for socket() and handle(), as they are different concepts.
BUG=
R=kasperl@google.com

Review URL: https://codereview.chromium.org//313083004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36995 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-04 14:16:50 +00:00
ajohnsen@google.com 69a7b746ef Fix double-closing of handles in Windows EventHandler.
BUG=
R=kasperl@google.com

Review URL: https://codereview.chromium.org//315003002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36991 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-04 11:53:53 +00:00
ajohnsen@google.com 146f95135e Use 'Directory.watch' on Windows in pkg/watcher, instead of pooling.
This is a close copy of MacOS, except for the special handling on mac, and the extra watcher on Windows for detecting if the watched folder is deleted.

BUG=https://code.google.com/p/dart/issues/detail?id=14428,https://code.google.com/p/dart/issues/detail?id=18108,http://code.google.com/p/dart/issues/detail?id=19189
R=kasperl@google.com, sgjesse@google.com

Review URL: https://codereview.chromium.org//312743002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36988 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-04 10:23:32 +00:00
johnmccutchan@google.com f689c775dc Remove polymer source maps from standalone VM Observatory build
BUG=
R=asiva@google.com

Review URL: https://codereview.chromium.org//309343005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36946 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-03 21:18:08 +00:00
turnidge@google.com 40d6a1de87 Observatory now uses websockets to communicate with the vm.
- Added WebSocketVM class.

- Changed the vmservice websocket request format from:
     path: ['this', 'is', 'the', 'old]
  to:
     request: 'this/is/the/new'

- Updated tests.

R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//305603004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36894 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-02 19:56:03 +00:00
ajohnsen@google.com 8b612e8780 Add read/write stats to Socket and RandomAccessFile.
BUG=
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//298353002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36738 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-28 13:29:51 +00:00
johnmccutchan@google.com f5d6c4106e Fix test breakage in socket_patch.dart
Review URL: https://codereview.chromium.org//307553008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36736 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-28 11:45:29 +00:00
johnmccutchan@google.com e46aa81943 Create a ServiceObject for a socket
R=ajohnsen@google.com

Review URL: https://codereview.chromium.org//303673009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36735 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-28 11:25:12 +00:00
johnmccutchan@google.com 1f62dad54d Add Proces owner of socket and fix printing of non-network sockets
R=ajohnsen@google.com

Review URL: https://codereview.chromium.org//300883002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36729 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-28 07:15:02 +00:00
turnidge@google.com 8db11b79ac Show flags in Observatory.
Add vm support for setting flags through vm service (UI coming soon).
e.g.
  http://127.0.0.1:8181/#/flags/set?name=some_flag&value=100

--

I reworked the Flags class to use a growing array rather than a linked list to store flags.  This means that we don't need to go through the hassle of building an array and sorting every time that we print/printjson.

R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//299143007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36712 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-27 21:27:17 +00:00
zra@google.com 9c73009ff9 Prepares for arm64 cross-build.
With this change, the cross-build succeeds with the Linaro arm64 toolchain.

R=regis@google.com

Review URL: https://codereview.chromium.org//303443010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36698 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-27 18:05:20 +00:00
ajohnsen@google.com 9c7979ed1f Add 'owner' field to sockets, that point to a potential IO resource using that Socket.
BUG=
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//304513004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36680 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-27 14:10:31 +00:00
ajohnsen@google.com 217e8b8605 Add WebSockets to Observatory.
BUG=
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//300043011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36667 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-27 11:37:51 +00:00
johnmccutchan@google.com a71fa873b1 Add processes to Observatory
R=ajohnsen@google.com

Review URL: https://codereview.chromium.org//307503002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36665 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-27 11:20:30 +00:00