Commit Graph

12 Commits

Author SHA1 Message Date
lrn@google.com 1ec6c5c1db Revert "Add "last" setter to List."
After discussion, we decided not to change the List interface for something that is just a convenience.

Also revert "Mark pkgbuild/pkg/collection as failing when using repository packages"

R=sgjesse@google.com

Review URL: https://codereview.chromium.org//331833003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37307 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-13 09:40:22 +00:00
lrn@google.com f528beb9f2 Add "last" setter to List.
This allows assigning directly as `list.last = value` instead of
having to use the longer `list[list.length - 1] = value`.
It's just an abbreviation, like `list.last` is for reading.

If you use a List as a stack (which is a perfectly good use of it),
modifying the last element like this is a natural operation.

R=sgjesse@google.com

Review URL: https://codereview.chromium.org//315173005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37255 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-12 08:11:22 +00:00
jmesserly@google.com 06f8f2d16b [html5lib] implement querySelector/querySelectorAll
BUG= https://code.google.com/p/dart/issues/detail?id=18508

* tests from https://github.com/w3c/web-platform-tests/tree/master/selectors-api, kept as close to original as I could.

* src/query_selector.dart is most interesting file. It implements enough of selectors to pass the basic web platform tests. Ironically, it was the easiest part of this CL...

* many fixes to csslib. Almost all of the selector tests were skipped (https://github.com/dart-lang/csslib-test-suite/blob/master/suite/selectors3/selectors3_test.dart) and there was a lot of things broken: unicode, escaping, incorrectly treating ident-tokens as units, probably more that I am forgetting :). Fixed as much as I could without doing major surgery.

* a bunch of fixes to the htm5lib DOM to bring it closer in alignment with dom.spec.whatwg.org and dart:html. The driving force was to minimize the changes needed on the W3C tests.

Note: haven't updated things that depend on html5lib like Polymer yet.

R=sigmund@google.com

Review URL: https://codereview.chromium.org//268623002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35941 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-08 21:41:05 +00:00
jmesserly@google.com b9fbc30785 [html5lib] api updates: localName
R=sigmund@google.com

Review URL: https://codereview.chromium.org//178303009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33004 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-25 04:07:47 +00:00
jmesserly@google.com d48a43957f [html5lib] triple slash comment style
Also improves ./tools/line_doc_comments.dart to warn about lines >= 80 chars, to make it easier to catch these.

R=sigmund@google.com

Review URL: https://codereview.chromium.org//178843003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32997 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-25 00:36:13 +00:00
jmesserly@google.com 1a4a399ea5 fix imports link rel=stylesheet
fixes https://code.google.com/p/dart/issues/detail?id=16648

also:
* adds a few DOM APIs to html5lib that it was missing
* removes a broken test from html5lib
* fixes polymer's dependency on analyzer

R=sigmund@google.com

Review URL: https://codereview.chromium.org//162093002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32679 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-13 23:22:48 +00:00
kevmoo@google.com 030a0ac329 pkg/third_party/html5lib: lots of cleanup
make a lot of things constants
updated pub dependencies
unused imports

R=jmesserly@google.com

Review URL: https://codereview.chromium.org//157983005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32528 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-10 23:52:45 +00:00
lrn@google.com e3713a08d4 Make List.shuffle take an optional Random object to use.
R=floitsch@google.com

Review URL: https://codereview.chromium.org//25931003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28305 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-07 12:07:30 +00:00
lrn@google.com 55a8a72ca6 Add List.shuffle().
Will add tests too.

R=floitsch@google.com

Review URL: https://codereview.chromium.org//24740003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28206 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-03 11:09:01 +00:00
floitsch@google.com e95105d602 Remove dart:utf in third_party.
R=jmesserly@google.com

Review URL: https://codereview.chromium.org//23493006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26796 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-28 15:40:46 +00:00
jmesserly@google.com 29397a566d html5lib -- workaround dart2js checked issues
Review URL: https://codereview.chromium.org//23221002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26161 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-14 22:09:44 +00:00
jmesserly@google.com d1f780df0b move html5lib code into dart svn repo
also gets the tests running

Changes to scripts:
* pkg/pkg.gyp: add 'third_party' to list of folders to search
* tools/publish_pkg.py: update copyright year
* tools/publish_all_pkgs.py: also include pkg/third_party

Changes to html5lib:
* pubspec.yaml -- removed versions
* README.md -- removed some historical notes
* added html5lib.status
* test/browser -- rename browser_tests to browser_test so test framework finds it
* test/parser_test.dart, test/parser_feature_test.dart -- moved dart:io test into parser_test so parser_feature_test can work in browser
* test/support.dart -- now finds the data folder relative to entry point script
* test/support.dart -- rename "pathos" import to "path"

Not changed:
* ./test/run.sh still works for testing, in addition to ./tools/test.dart

R=dgrove@google.com, ricow@google.com, sigmund@google.com

Review URL: https://codereview.chromium.org//22375011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26152 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-14 20:59:46 +00:00