Commit Graph

3333 Commits

Author SHA1 Message Date
jmesserly@google.com 0f317b4fd4 fix chrome 35 polymer status
also mark one test passing on ie9 now

One test is failing due to 35 having buggy custom elements, and I guess the newest polyfill removed the workaround(s)

For now I marked status as failing, though bots will go red unfortunately when Chrome does update. I left the comment there to make it obvious to whoever sees that later.

Review URL: https://codereview.chromium.org//333223011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37635 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-24 02:04:54 +00:00
sigmund@google.com c3c6ea0100 Warn about accessing private properties, but don't choke on it.
R=jmesserly@google.com

Review URL: https://codereview.chromium.org//329403007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37634 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-24 01:22:19 +00:00
jmesserly@google.com c3cf7404ae rename d-auto-binding to auto-binding-dart
appending -dart to ports seems like a more generic convention

R=sigmund@google.com

Review URL: https://codereview.chromium.org//350763003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37633 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-24 00:47:18 +00:00
jmesserly@google.com 1aa432e42b test updates from latest web component polyfill roll
It's fun when tests "fail" because they're now passing :)

Review URL: https://codereview.chromium.org//350653007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37632 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-23 23:43:08 +00:00
jmesserly@google.com d12f8b560b update polymer and platform.js
R=sigmund@google.com

Review URL: https://codereview.chromium.org//349313005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37629 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-23 22:49:17 +00:00
scheglov@google.com 03819fe9e0 Analyzer snapshot to with FunctionElement.identifier fix.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//346303003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37625 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-23 22:03:08 +00:00
paulberry@google.com 940f84df33 Remove dead code for tracking pubspec.yaml files.
Now that we are using "pub list-package-dirs" to find the packages
associated with a context, we no longer need to explicitly track the
presence or absence of a "pubspec.yaml" file within the context.

Note that we will have to watch the "pubspec.lock" file in order to
decide when to re-run "pub list-package-dirs", but we'll do this using
a different mechanism, since the decision of which file(s) to watch is
the responsibility of pub, and communicated to us through the JSON
output of "pub list-package-dirs".  This will be addressed in a future
CL.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//353453004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37620 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-23 21:33:18 +00:00
nweiz@google.com c718393be3 Make StringScannerException extend SpanFormatException.
R=rnystrom@google.com
BUG=

Review URL: https://codereview.chromium.org//343043002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37619 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-23 21:10:55 +00:00
nweiz@google.com 312c1f5c11 Make YamlException inherit from SpanFormatException.
R=rnystrom@google.com

Review URL: https://codereview.chromium.org//342943006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37618 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-23 21:07:00 +00:00
scheglov@google.com c6bba5ff20 A FileManager implementation to keep each index file in a separate file system file.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//346273005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37615 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-23 20:00:38 +00:00
scheglov@google.com b5d098a4a2 Move split_store.dart to the store/ folder and extract collections/codecs.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//351453004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37610 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-23 17:18:14 +00:00
paulberry@google.com 87ce2785b6 Allow "null" as a synonym for [] or {} in the analysis server API.
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//342383002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37608 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-23 16:51:59 +00:00
scheglov@google.com bacedfcbc1 Migrate protocol_test.dart to reflective tests.
1. Drop static.
2. Replace @runTest with 'test_' method name prefix.
3. Drop direct setUp() invocation.
4. Format.
5. Sort.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org//349103003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37605 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-23 15:37:01 +00:00
danrubel@google.com 0e5687a619 close channel and exit analysis server on editor shutdown
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//349573004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37597 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-23 12:49:24 +00:00
kustermann@google.com 51f349ed66 Throw a StateError if read()/readAsString() is called multiple times
R=kevmoo@google.com, sgjesse@google.com

Review URL: https://codereview.chromium.org//342323004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37584 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-23 08:31:18 +00:00
scheglov@google.com a1f04edbf2 Require typed_mock >= 0.0.4, as we use functions from 0.0.4 now.
R=danrubel@google.com, brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//350613002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37579 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-23 04:24:09 +00:00
paulberry@google.com 4531158428 Allow multiple dirs per package in the data returned by "pub list".
R=scheglov@google.com

Review URL: https://codereview.chromium.org//341273007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37565 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-20 20:12:42 +00:00
scheglov@google.com 5f8931c039 Use single quotes for index store.
R=paulberry@google.com, brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//347153002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37564 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-20 18:20:53 +00:00
scheglov@google.com 8b273420e3 Explicitly remove AnalysisContext from ContextCodec.
R=paulberry@google.com, brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//347133002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37563 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-20 18:18:12 +00:00
scheglov@google.com bd4cb891ef Port SplitIndexStore to Dart.
R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org//348773003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37556 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-20 16:18:19 +00:00
jwren@google.com dd026ede46 Nit fix: _HighlighRegion->_HighlightRegion
R=paulberry@google.com

Review URL: https://codereview.chromium.org//345863002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37554 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-20 16:04:52 +00:00
paulberry@google.com e9fa53425c Use "pub list-package-dirs" to resolve package URIs in analysis server.
R=scheglov@google.com

Review URL: https://codereview.chromium.org//341893010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37552 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-20 14:42:01 +00:00
ahe@google.com 98523c01f8 Update imports to use package:compiler and package:try.
R=floitsch@google.com, johnniwinther@google.com

Review URL: https://codereview.chromium.org//341923005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37538 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-20 10:33:46 +00:00
karlklose@google.com 3c13a0b8e5 Change test expectation.
TBR=johnniwinther@google.com,ricow@google.com

Review URL: https://codereview.chromium.org//342273002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37535 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-20 07:42:00 +00:00
nweiz@google.com 618df8243a Fix a bug in FixedSpan.getLocationMessage.
R=jmesserly@google.com

Review URL: https://codereview.chromium.org//346993002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37531 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-20 02:12:33 +00:00
nweiz@google.com c9e7ddb65f Improve the readability of some human-consumed strings in source_maps.
R=jmesserly@google.com

Review URL: https://codereview.chromium.org//346983002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37530 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-20 01:55:41 +00:00
nweiz@google.com 80c26b96d7 Properly handle synchronous errors in Chain.capture.
R=rnystrom@google.com
BUG=19542

Review URL: https://codereview.chromium.org//344953002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37520 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-19 21:12:35 +00:00
nweiz@google.com e833411604 Fix a barback bug where a closed stream could get an event.
R=rnystrom@google.com
BUG=19540

Review URL: https://codereview.chromium.org//343963003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37519 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-19 21:10:15 +00:00
scheglov@google.com 6b6467a9ca New analyzer snapshot.
R=paulberry@google.com, brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//348673002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37516 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-19 20:58:28 +00:00
nweiz@google.com 476d5555bd Add SpanException and SpanFormatException classes to source_maps.
It's often useful to associate source range information with an
exception in a way that will get printed along with that exception but
can be pulled out and manipulated directly. It's especially useful if
there's a common superclass/interface for doing so that can be shared
across packages. This adds that superclass.

R=sigmund@google.com

Review URL: https://codereview.chromium.org//348493004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37509 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-19 19:28:45 +00:00
sigmund@google.com b3dc635973 Update mock of dart:core in polymer compiler (fixes dartbug.com/19560)
R=jmesserly@google.com

Review URL: https://codereview.chromium.org//330063007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37507 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-19 18:50:34 +00:00
paulberry@google.com 1eacc4f343 Add support for adding/removing pubspec.yaml files.
Since this probably won't happen very often, we don't go to a great
deal of effort to handle it efficiently--we just destroy the old
context and create a new one.

R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//340773005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37496 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-19 14:55:27 +00:00
vsm@google.com d198ce27e5 Update status for flaky test
R=whesse@google.com

Review URL: https://codereview.chromium.org//347763002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37485 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-19 11:07:40 +00:00
lrn@google.com 736db44293 New Uri.parse and validation.
Ensures that the resulting URI is valid.
Escapes invalid characters except the gen-delim group of delimites, where
escapes are allowed.

R=ajohnsen@google.com, sgjesse@google.com

Review URL: https://codereview.chromium.org//335373003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37479 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-19 09:05:07 +00:00
jmesserly@google.com c053cbaefe web_components: fix extending another custom element
R=sigmund@google.com

Review URL: https://codereview.chromium.org//341003002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37472 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-19 01:29:39 +00:00
brianwilkerson@google.com 3ada3b02d7 Implement analysis.updateOptions
R=paulberry@google.com

Review URL: https://codereview.chromium.org//335123008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37467 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-18 21:27:51 +00:00
sigmund@google.com e078a19b6e Remove use of deprecated property in TodoMVC
R=jmesserly@google.com

Review URL: https://codereview.chromium.org//341843003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37466 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-18 21:04:00 +00:00
scheglov@google.com 4b67b3a4c6 'Element' and 'Outline' implementations for the new server API.
R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org//340183003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37463 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-18 20:44:24 +00:00
scheglov@google.com e24abbc13f Fix for subscribing for notifications after analysis.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//339933006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37455 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-18 17:38:34 +00:00
scheglov@google.com bf65a5694e Extract 'DartUnitHighlightsComputer' tests into a separate file.
Use constants.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//338683003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37452 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-18 16:34:08 +00:00
ahe@google.com a9983b0399 Packages for Try Dart and dart2js.
package:compiler and package:try.

R=ricow@google.com

Review URL: https://codereview.chromium.org//315943003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37437 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-18 06:43:12 +00:00
jmesserly@google.com 735e73e5c1 eventController interop with polymer.js
BUG=
R=sigmund@google.com

Review URL: https://codereview.chromium.org//340693002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37435 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-18 02:33:17 +00:00
jmesserly@google.com 7e7eb86d1b polymer: fix analyzer warning
Review URL: https://codereview.chromium.org//340553006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37434 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-17 23:35:34 +00:00
jmesserly@google.com d061f34cc8 avoid addEventListener in Polymer
workaround for: https://code.google.com/p/dart/issues/detail?id=17406
...to prevent silent failures when dirty checking doesn't happen

R=sigmund@google.com

Review URL: https://codereview.chromium.org//347463002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37432 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-17 23:08:12 +00:00
scheglov@google.com 8df494e4b4 PackageMapUriResolver for Dart server.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//337383005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37431 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-17 22:52:22 +00:00
jmesserly@google.com c27264ca6f fix type annotation of $
R=sigmund@google.com

Review URL: https://codereview.chromium.org//342533003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37428 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-17 22:21:08 +00:00
paulberry@google.com 86d2b07b6b Change contract for ChangeSet to reflect AnalysisContext behavior.
The analysis server relies on changedSources having no effect on files
whose contents are already overridden, and we don't want to rely on
undefined behavior.

This shouldn't affect any clients; we are just specifying the behavior
that already existed.

Also, avoid unnecessarily invalidating analysis when changedSources
contains a source that is already overridden.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//341533005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37426 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-17 21:22:20 +00:00
brianwilkerson@google.com 4ad29a2671 Implemented analysis.setPrioritySource
R=paulberry@google.com

Review URL: https://codereview.chromium.org//332993006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37412 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-17 18:44:23 +00:00
paulberry@google.com 3ab000840c Trigger re-analysis when a file changes on disk.
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//332383006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37408 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-17 18:07:57 +00:00
vsm@google.com 42d351783e Update status files for debug timeouts
These tests are timing out on Dartium in debug mode.  The time outs are due to actually assertion failures.  See filed bugs for each test.

R=whesse@google.com

Review URL: https://codereview.chromium.org//337333002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37390 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-17 09:32:47 +00:00