dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
86,948 Commits 2 Branches 0 Tags
bd2d261bc6a82ae2bece034d4aba2cbc4e14c178
Commit Graph

3219 Commits

Author SHA1 Message Date
Konstantin Shcheglov b2b50f7fc6 Make RecordTypeImpl structured, without elements. 
Change-Id: I7e06c728037f2b94609165394a40388979269cc0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/256420
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-08-25 19:47:03 +00:00
Konstantin Shcheglov 66c09b2fd2 Update ReplacementVisitor to support RecordType. 
Change-Id: I4ada89fc87709dd15f2add86005d6c8927d7b773
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/255684
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-08-18 20:09:44 +00:00
Konstantin Shcheglov c9febdd4e3 Update display string for promoted type parameter type. 
Bug: https://github.com/dart-lang/sdk/issues/49692
Change-Id: I4f61dfe9bb123f000cb253f14a0733063f16acde
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/255547
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-08-18 17:26:34 +00:00
Brian Wilkerson 6f92ce778a Implement AstBuilder support for record literals 
Change-Id: I54f7a04d240f613185d5b114802fb1da4f974269
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/255260
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-08-16 21:03:12 +00:00
Konstantin Shcheglov ba633b92c0 Extract AbstractTypeSystemTest into type_system_base.dart 
Change-Id: I9b98dab72de5c97923bbcf361c9482129700aefd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/255320
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-08-16 18:26:22 +00:00
Konstantin Shcheglov b9f0b2ed8b Implementations for RecordTypeAnnotation nodes. 
Change-Id: Ice4425e70b62fc68d4ad3aa97faf6e56f4076781
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/255144
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-08-15 22:35:26 +00:00
Brian Wilkerson 65058f87e1 Add visitor support for record literals 
Change-Id: I8f5aff11786a75ce02a8f3483585dc0513ae2c86
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/255142
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2022-08-15 20:00:46 +00:00
Konstantin Shcheglov c66faf9f3a RecordElement.instantiate(), substitution, type alias. 
Change-Id: Icd0e234e57d17a1c86140ed58fc9732da31bf1b3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/254942
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-08-15 17:31:36 +00:00
Konstantin Shcheglov 293c39cfce Add RecordElement, RecordTypeImpl, implement basic subtyping. 
Change-Id: I54ac91dfc5a4e01b6f960b865d3d73d11bd0cd84
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/255040
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-08-13 00:56:51 +00:00
Konstantin Shcheglov 82e33cc598 Add DartType.element2 
Unfortunately my idea about checking for specific `DartType` subtype,
and only then asking for the element is too punitive. It almost
works in google3, but the amount and the kind of changes I had to
do make me realize that we should keep `get elementX` in `DartType`.

I guess this is the same as we had in AST when `get constructors`
does not make sense for mixins (?), but works for classes and enums,
and it is easier to pull it into the superclass.

Change-Id: Ibc4fac0b95d63748fa65de96d29300f477fdfc76
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/254482
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-08-11 16:01:48 +00:00
Konstantin Shcheglov f4c009dc33 Deprecate Declaration.declaredElement, use 'declaredElement2' instead. 
This is necessary to separate `ClassElement`, `EnumElement`, and `MixinElement`. And, in the future, augmentations like `ClassAugmentationElement`, etc.

Change-Id: Iecd2f8707212e53ef56f0e101880c7bab9e5d057
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/254104
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-08-09 17:26:06 +00:00
Konstantin Shcheglov 35413ac2b4 Deprecate getType(), use getClass() instead. 
Change-Id: I58d25a5449dfc79b1d6a092e58268f7a612d378c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/253708
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
 2022-08-05 05:25:17 +00:00
Konstantin Shcheglov 8e5c197d42 Evaluate default values of all default parameters, even required (e.g. required named). 
Bug: https://github.com/dart-lang/sdk/issues/49596
Change-Id: Id9696a6e93499ec4eca164ccb78c39aec5acaaab
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/253705
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-08-04 21:52:56 +00:00
Konstantin Shcheglov cbfad8f802 Deprecate DartType.element, use specific element accessor for InterfaceType, TypeParameterType. 
For `InterfaceType` keep `element2` deprecated and define
`InterfaceElement get element2` instead. Most changes are because
of this.

Change-Id: I13b888610fc707438c3c97b676f1460e7fc2b040
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/253564
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2022-08-04 16:18:06 +00:00
Konstantin Shcheglov 7bfc648617 Use named parameters for more AST implementations. 
Change-Id: I0b47f6b9e87fa773ca08ad1ec8e7afcca69a0527
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/253521
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-08-02 20:03:14 +00:00
Konstantin Shcheglov 71ef76ddfd Deprecate Element.enclosingElement2, use 'enclosingElement3'. 
Change-Id: I0aba589bd42648eb420051cbe04bb3ef435081e0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/253400
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-08-02 18:00:14 +00:00
Konstantin Shcheglov 01173e2aa2 Deprecate 'name' in AST, use 'name2' token instead. 
Change-Id: I867f009dca12208f835199297d2ea85c203c8556
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/252566
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Jake Macdonald <jakemac@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-08-02 16:25:34 +00:00
Konstantin Shcheglov 33b672f789 Use CatchClauseParameter instead of SimpleIdentifier. 
Change-Id: Ib254d05954548d4101fef9c2545d18b2611b59dd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/253100
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-08-01 17:32:04 +00:00
Konstantin Shcheglov d5ea4c0fdc Revert "Deprecate ClassElement.isValidMixin" 
This reverts commit da31cab154.

Reason for revert: I agree to some extent that this method can be useful.

Original change's description:
> Deprecate ClassElement.isValidMixin
>
> Change-Id: I0cc8245b20e2cbe3c201263207f8570a46d6ab15
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/253026
> Reviewed-by: Samuel Rawlins <srawlins@google.com>
> Commit-Queue: Konstantin Shcheglov <scheglov@google.com>

TBR=scheglov@google.com,brianwilkerson@google.com,srawlins@google.com

Change-Id: Ibee8b6260ff8268f9e9f2f05b54c8256febb19d5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/253120
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-07-30 19:48:13 +00:00
Konstantin Shcheglov da31cab154 Deprecate ClassElement.isValidMixin 
Change-Id: I0cc8245b20e2cbe3c201263207f8570a46d6ab15
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/253026
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-07-30 00:36:32 +00:00
Konstantin Shcheglov a8be1c1e0b Deprecate Directive.element, use element2. 
Change-Id: Ic18f9c579bcec0b6406070da04b476be2582a504
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/252721
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-07-26 18:51:47 +00:00
Konstantin Shcheglov 4359108a8b Deprecate ClassOrMixinDeclaration.getField/getMethod 
Change-Id: I312a1214b0babb03a3208dcf306753e0d75f77e6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/252705
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-07-26 16:54:27 +00:00
Konstantin Shcheglov a31337548e Deprecate ClassDeclaration/ClassTypeAlias.isAbstract 
Change-Id: I70fa1714fb31bb611d86054fc4538c01afda6763
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/252563
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Jake Macdonald <jakemac@google.com>
 2022-07-26 01:51:27 +00:00
Konstantin Shcheglov 2f3269faa1 Deprecate 'Element.enclosingElement', switch to enclosingElement2. 
We need this for:
1. CompilationUnitElement changes its enclosing element from LibraryElement to LibraryOrAugmentationElement
2. Similarly PrefixElement.

Change-Id: I5e3719b4ef59d03caab1b20c9172a8c0fd786bdf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/251900
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-07-19 15:44:14 +00:00
Konstantin Shcheglov e23101a16f Rename to LibraryImportElement, LibraryExportElement. 
Change-Id: I0928ca5522d9c67142111a8f3a7eb4d84f114f56
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/251844
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2022-07-18 20:01:18 +00:00
Konstantin Shcheglov 54b7f4b72a Track the VariableElement associated with constant DartObjects. 
The motivation for this functionality is lints which inspect the
declaration of constant values within Dart programs. By giving lints a
small amount of visibility into the intermediate values which were used
to construct constant values, it is possible for lints to validate not
just the resulting constant, but the means by which that constant was
constructed.

Change-Id: I75b3f46222ced88a0c7a7f7887de2994fcfa3f68
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/251682
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-07-16 02:13:03 +00:00
Konstantin Shcheglov 210536e46f Use ExportDirectiveState to build LibraryElement.exports2, add ExportElement2. 
Change-Id: I29242bb6f9514eccc93b1bef207ecd5b1e558571
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/251143
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-07-13 01:48:34 +00:00
Konstantin Shcheglov a943d2707b Use ImportDirectiveState to build LibraryElement.imports2, add ImportElement2. 
Change-Id: I27a0e87a812eb3733ccfc7b98841c4169dc0a070
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/250790
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2022-07-11 16:54:32 +00:00
Konstantin Shcheglov 40db70d5fd Deprecate 'Directive.keyword', use specific 'xyzKeyword'. 
Change-Id: I66ab521df857de07343205aed6335e6d3566eafb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/250442
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2022-07-07 19:55:21 +00:00
Ahmed Ashour df1e5cce34 [analysis_server] Add FlutterConvertToStatelessWidget assist 
Fixes #46011

Change-Id: I14a4498831ed7d91a2ac1350824f5b7d8d0023c1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/250087
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-07-07 16:19:31 +00:00
Konstantin Shcheglov 33d6a341a8 Separate AugmentationImportDirective from ImportDirective. 
Change-Id: I202320513390dbb218ec86fed18fc2943b168dd8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/250413
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-07-02 03:59:21 +00:00
Ahmed Ashour c7a02bc43e [_fe_analyzer_shared] fix 4 spaces comments as code block 
Fixes #49047

Change-Id: I1aa08fc417365ca894467b15d5094ea203f01940
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/245162
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: William Hesse <whesse@google.com>
 2022-07-01 15:55:00 +00:00
Jens Johansen 183863e5bf [parser] More recovery of await in non-async context 
Fixes https://github.com/dart-lang/sdk/issues/49116

Change-Id: I6b3f4bd88b17da5703dc268df413b3e5bb2e7d87
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/249605
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2022-06-29 07:11:06 +00:00
Jens Johansen b3917f7d5b [parser] Parse nullable type correctly after is/as when followed by '{' 
E.g. nullasble cast last in initializer list followed by constructor
body.

Fixes https://github.com/dart-lang/sdk/issues/49132

Change-Id: I28633762444048b5e26b4b8343494302544344df
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/249602
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2022-06-28 12:43:03 +00:00
Jens Johansen 7052965647 [parser] Parse nullable type correctly after is/as when followed by '}' 
Fixes https://github.com/dart-lang/sdk/issues/48999

Change-Id: I42d7ec4110bb2cd212afbf7aae694f6a867b4423
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/249601
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2022-06-27 08:42:51 +00:00
Ahmed Ashour 85700570f6 Fix typos 
Fixes #49241

TEST=ci

Change-Id: I6117bf816fc8c4613cce66927f952fef75632725
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/248120
Reviewed-by: Alexander Thomas <athom@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
Reviewed-by: Nicholas Shahan <nshahan@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-06-15 11:08:28 +00:00
Konstantin Shcheglov 283a66da00 Move a few mixin inference tests to element model tests. 
Bug: https://github.com/dart-lang/sdk/issues/49208
Change-Id: I2e3fba9ef4d8023549486e7dc810c57dc8e1eaa1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/247800
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2022-06-09 19:18:43 +00:00
Konstantin Shcheglov 4cf8091c8d Remove PartWithoutLibraryResult, consider a part to be a library instead. 
Bug: https://github.com/dart-lang/sdk/issues/49046
Change-Id: I20413cd2b2ff284d2e4b92949f057c97b98fb49b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/246042
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-05-25 20:51:04 +00:00
Konstantin Shcheglov 33b6483ad1 Support for AugmentationFileStateKind. 
Change-Id: Ib32b7b56739d89118c9a497087dc5066bab177dd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/245680
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-05-25 16:54:38 +00:00
Konstantin Shcheglov 99000b22e0 Include Expression.staticParameterElement into textual dumps. 
Change-Id: I066a380e4a83043c65260e9d93b7588735d6e3ab
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/245904
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-05-25 16:38:16 +00:00
Konstantin Shcheglov f0a07ac120 Enforce use_super_parameters in analyzer/. 
Change-Id: I92a002d69a10b83b9600455156a43c1592439477
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/245420
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-05-19 19:36:41 +00:00
Paul Berry f5af2d9e77 Use ParameterMember when substituting function types. 
This ensures that the parameters from the function type still point to
the original function declaration (previously, they were synthetic
parameters).  This should lead to a better user experience in editor
integration, by ensuring that the editor can still find the parameter
declarations associated with parameters in generic function
invocations.

Fixes #48500.

Change-Id: I10a0dd54e7c70e1d0d05dced37565c35bcaabfd0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/243524
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2022-05-12 19:29:05 +00:00
Konstantin Shcheglov 6f12e894c0 Use assertResolvedNodeText() for assignment tests. 
Change-Id: I2e35219e4ddaad6e81d500c8ee6602cfca886b86
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/243162
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2022-05-01 16:34:13 +00:00
Jens Johansen 7a0b8f850b [parser] Rename Token impl classes to avoid name conflicts 
Change-Id: I72cefa071429b048facc16e2be0942077010072c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/238084
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2022-04-19 08:27:37 +00:00
Konstantin Shcheglov 20b560226e Rename newFile2() to newFile(). 
Change-Id: I1c2a4f15dee607a0a6241dfaf2d764a7d284389b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/241510
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-04-19 02:59:57 +00:00
Konstantin Shcheglov 139385c615 Breaking changes for analyzer version 4.0.0 
Change-Id: I26961f29f9171e94db2f5c95f1f8af5fd01bb9b9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/233681
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-04-07 06:52:27 +00:00
Konstantin Shcheglov 80e2bfa877 Issue 48719. Fix for constant evaluation and generic class with super-formal. 
Bug: https://github.com/dart-lang/sdk/issues/48719
Change-Id: I7ecf986e17c21bfe010a97d482a0ce30891ccfc9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239728
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-03-31 22:14:07 +00:00
Ahmed Ashour f4851dd56d Better error message when no errors were found. 
Fixes #48713

Change-Id: Icbe3e2c0bdf2bba0b66d04a30f6b900e5d4f8c1d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239641
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-03-31 16:30:18 +00:00
Konstantin Shcheglov 7022b2d8fb Issue 48688. Fix for adding unnamed extension to the scope. 
Bug: https://github.com/dart-lang/sdk/issues/48688
Change-Id: I8e5225b93a5cc39b53e8ccfb162c86b180e3fa86
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239122
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-03-28 20:23:20 +00:00
Konstantin Shcheglov 143fe67673 Make fields in CompilationUnitElementImpl final and/or non-nullable. 
Change-Id: I604ad776196fa90bccf2ba06fa282fa0e7979d18
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/238740
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-03-25 01:20:19 +00:00