dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
86,948 Commits 2 Branches 0 Tags
bd2d261bc6a82ae2bece034d4aba2cbc4e14c178
Commit Graph

4981 Commits

Author SHA1 Message Date
Brian Wilkerson a3f8672778 Add a highlight kind for record literals 
I don't think that there are any other highlight kinds we're going to
want to add, but if you can think of any please let me know.

I'll add code to actually associate the kind with record literals in the
next CL.

Change-Id: I15922984d96c2d0c7d97ea3f3832a95a68172968
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/256524
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-08-26 21:22:53 +00:00
Danny Tuppeny 857a0d2e66 [analyzer] Resolve comment references for inherited members 
Fixes https://github.com/Dart-Code/Dart-Code/issues/4114.

Change-Id: I47fe2909e4d09366c1e2f432c31076ba690fac7e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/256162
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-08-25 14:29:43 +00:00
pq 103a2fa642 [dart fix] detect and report un-enabled lints 
Change-Id: Ie113348ae442f93ae2ea49afb2ed1b0305a6da03
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/256245
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2022-08-25 04:23:12 +00:00
pq c0e74c4433 [dart fix] report undefined diagnostics 
Fixes: https://github.com/dart-lang/sdk/issues/49699

Change-Id: Ia412e4dce51b0887c3cd0d9b6d91f0ace926bea3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/256243
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2022-08-24 20:35:59 +00:00
Danny Tuppeny ece330a700 [analysis_server] Include annotation completions at end of class 
Fixes https://github.com/Dart-Code/Dart-Code/issues/3182.

Change-Id: I93d7606cbbf9c527f31dcf9d0fb502dac581abc1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/256068
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-08-24 19:25:39 +00:00
Danny Tuppeny 177147bac3 [analysis_server] Improve handling of document modifications while computing completions 
This prevents an issue where typing during completion can cause completion requests to completely fail (returning 0 items) just because snippets couldn't
be computed.

Change-Id: I20fb457a700ec12317d0146b3364e6f1a4f96177
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/256214
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-08-24 15:53:00 +00:00
pq 1b2644afd2 [bulk fix] report undefined diagnostics 
Change-Id: I4abe1e83c56e632f91a81510ec0a35b521cd11d7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/255541
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2022-08-18 16:11:36 +00:00
Konstantin Shcheglov 05d01e79cc Highlight 'required' in SuperFormalParameter. 
Change-Id: Ia25378e88eced277bb6242c8cea6bbf09dbb521a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/255601
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
 2022-08-18 15:56:17 +00:00
pq c4766b319a bulk fix support for specified diagnostics 
Change-Id: Ifa98da5466b0efb1b88cfa17d06b6b4e1d4ba8d3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/255340
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2022-08-17 17:50:03 +00:00
Jens Johansen 8a1dbb160f [parser] Parse record literals 
This is the first stab at implementing the record expressions from
https://github.com/dart-lang/language/blob/master/working/0546-patterns/records-feature-specification.md

Change-Id: I2adb6cb3cd50d4ee45e144e86ec7011d046f6170
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/253783
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Michael Thomsen <mit@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-08-16 06:36:36 +00:00
Konstantin Shcheglov 4eb511da43 Replace more Bazel with Blaze, some simplifications. 
Change-Id: I096860e17ce56c2f602718f11706f24989c1f65b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/255141
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-08-15 19:50:46 +00:00
Konstantin Shcheglov 293c39cfce Add RecordElement, RecordTypeImpl, implement basic subtyping. 
Change-Id: I54ac91dfc5a4e01b6f960b865d3d73d11bd0cd84
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/255040
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-08-13 00:56:51 +00:00
Konstantin Shcheglov f3d919308f Use different marker file to identifier Blaze workspace. 
Bug: https://github.com/dart-lang/sdk/issues/49629
Change-Id: I8f1496735373494745a79d502488a217e3c71223
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/254480
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2022-08-10 19:58:43 +00:00
Konstantin Shcheglov 43065920cc Rename Bazel to Blaze - files, classes, methods. 
No changes to implementation yet, we still look for both Blaze and Bazel.

Bug: https://github.com/dart-lang/sdk/issues/49629
Change-Id: Iaf1b1cc2c9a8cf28d8bbfb5541819a1f5c8a3de6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/254343
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-08-10 16:00:18 +00:00
Konstantin Shcheglov f4c009dc33 Deprecate Declaration.declaredElement, use 'declaredElement2' instead. 
This is necessary to separate `ClassElement`, `EnumElement`, and `MixinElement`. And, in the future, augmentations like `ClassAugmentationElement`, etc.

Change-Id: Iecd2f8707212e53ef56f0e101880c7bab9e5d057
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/254104
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-08-09 17:26:06 +00:00
Brian Wilkerson 0a1793eb5d Move the tests for legacy refactorings 
This reflects the recent change to the implementation classes.

Change-Id: I0867a274c830d34f46c858713f0df511b7b811c8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/254066
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-08-09 04:22:42 +00:00
Brian Wilkerson 60773b9135 Rename two classes 
Change-Id: I3fe6f0e4a4f3e8d04994a21c97e608fe8065e5ac
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/253902
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2022-08-08 04:11:19 +00:00
Danny Tuppeny 139d150b23 [analysis_server] Remove use of SuggestionSets from LSP 
Always use NotImportedContributor.

Change-Id: I3ed518f2d84d10600a5ea27bc88282762573ef2e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/253784
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-08-05 17:08:27 +00:00
Konstantin Shcheglov 35413ac2b4 Deprecate getType(), use getClass() instead. 
Change-Id: I58d25a5449dfc79b1d6a092e58268f7a612d378c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/253708
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
 2022-08-05 05:25:17 +00:00
Konstantin Shcheglov cbfad8f802 Deprecate DartType.element, use specific element accessor for InterfaceType, TypeParameterType. 
For `InterfaceType` keep `element2` deprecated and define
`InterfaceElement get element2` instead. Most changes are because
of this.

Change-Id: I13b888610fc707438c3c97b676f1460e7fc2b040
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/253564
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2022-08-04 16:18:06 +00:00
Brian Wilkerson 22fe2d2a47 Move the legacy refactoring support into a legacy folder 
There were no changes other than to move the files and update the imports
to match.

Change-Id: I0790d9bf7287d62756ad7534b760689489706d40
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/253602
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2022-08-03 21:37:26 +00:00
Konstantin Shcheglov 71ef76ddfd Deprecate Element.enclosingElement2, use 'enclosingElement3'. 
Change-Id: I0aba589bd42648eb420051cbe04bb3ef435081e0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/253400
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-08-02 18:00:14 +00:00
Konstantin Shcheglov 01173e2aa2 Deprecate 'name' in AST, use 'name2' token instead. 
Change-Id: I867f009dca12208f835199297d2ea85c203c8556
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/252566
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Jake Macdonald <jakemac@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-08-02 16:25:34 +00:00
pq 85d91f95b9 migration to code_style_options 
More migrations to code_style_options.

See: https://github.com/dart-lang/sdk/issues/49558

Change-Id: I8a2e8459ea9e02b9d65a219dad3ec73080001782
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/252965
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-08-01 21:45:34 +00:00
Brian Wilkerson b7edb69e97 Reorganize the snippets support 
Moves multiple classes into their own files. Renames several classes and
the associated test classes. Moves a few of those classes (files) into
the parent directory. Converts snippets to use constructor tear-offs
rather than static method tear-offs.

Change-Id: If1aae3cc468d20ef056e650c0206fcfbf3c94f62
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/253004
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-07-29 14:38:41 +00:00
pq 02a8d42261 use-super-parameters when use_super_parameters is enabled 
Fixes: https://github.com/dart-lang/sdk/issues/49556

Change-Id: Ia22a4f2734b7dd3affe8984ea41984e5b2c263a8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/252961
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-07-29 00:23:31 +00:00
Danny Tuppeny dfe2463517 [analysis_server] Don't include prefixed type names in Outgoing Calls 
Change-Id: Ic305706bf8fcb224c757b85379e69afa5ac8d102
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/252940
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-07-28 18:06:30 +00:00
pq eed97d8778 (conditionally) add trailing commas for wrapping streambuilders 
Related to: https://github.com/dart-lang/sdk/issues/49541

Change-Id: Iba6ce96c12838ad23c035aca64dda233803fac32
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/252866
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2022-07-27 22:48:39 +00:00
pq 933a3cbaf2 wrap with builder: add trailing comma if require_trailing_commas is enabled 
Fixes: https://github.com/dart-lang/sdk/issues/49541

Change-Id: I616919c8f951648431f34646f88abe260af69424
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/252842
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2022-07-27 21:50:19 +00:00
Brian Wilkerson 9312ba0abc Fix rename_to_camel_case to handle screaming caps 
Change-Id: I04564db1c4f47be18949cf16dcf42230db0da6e5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/252562
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2022-07-25 16:08:23 +00:00
Ahmed Ashour 296f114d77 [analysis_server] link failing test to an issue 
Part of #49514

Change-Id: Ie74a149b998a5901c6f1ad2a389403165167aa83
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/252582
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-07-25 16:00:19 +00:00
Brian Wilkerson 56dc3e360a Fix the convert_to_contains fix to remove the second argument 
Change-Id: I2da6b71909dd5ecf725714fb51cd075498712c1d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/252522
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-07-23 14:58:07 +00:00
Ahmed Ashour eefbe1fd14 [analysis_server] add fix for ASSERT_IN_REDIRECTING_CONSTRUCTOR 
Fixes #49486

Change-Id: Ic96d2b347578f574eb67b12ef3dbbddcd9c04d2e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/252080
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-07-21 22:16:06 +00:00
Ahmed Ashour a9ba31a5b2 [analysis_server] add fixes for ABSTRACT_FIELD_INITIALIZER 
Fixes #49488

Change-Id: I48caabef2c038b95ef88cad903fdead47b91c615
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/252081
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-07-21 21:30:26 +00:00
Danny Tuppeny 055774958d [anaysis_server] Cancel in-progress LSP completion requests if another arrives 
Change-Id: Idf49b70750a3427529f71e952aa036fae4c7c6cb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/252422
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-07-21 17:40:06 +00:00
Danny Tuppeny 5741f11f7b [analysis_server] Remove unnecessary imports when organizing imports 
Change-Id: I7a39a9b07adbacc7d3fd5abb3b165b47668e7938
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/252420
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-07-21 15:10:55 +00:00
Danny Tuppeny 71e2aee8a5 [analysis_server] Disallow extract method on all prefixes 
Change-Id: I63ecfab4fad63797358dc2cfb7d5cf79ca444dc7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/252340
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-07-21 14:57:26 +00:00
Danny Tuppeny 0add39a68e [analysis_server] Skip analysis work when overlays are created if content matches previous content- 
May prevent https://github.com/dart-lang/sdk/issues/48051 from occurring since we will no longer call driver.changeFile() for SDK libraries being opened, although it does not resolve the underlying issue.

Change-Id: I5ca53a04842348a584ccc824aaf90ba7f230c002
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/251980
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2022-07-20 22:45:15 +00:00
Danny Tuppeny 210af2940f [analysis_server] Fix loss of comments containing newlines when sorting imports 
Change-Id: Ie264c16d4ec8254ba0394691625a161598e73f5d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/252180
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-07-20 21:23:55 +00:00
Danny Tuppeny 720f7bea37 [analysis_server] Fix assist test on Windows 
Change-Id: I2a85c699140c2fd31ee03524fd2ecac6a0482540
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/252121
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-07-20 18:48:45 +00:00
Ahmed Ashour 157e407450 [analysis_server] don't offer fix when the error in "cannot-ignore" 
Fixes #49464

Change-Id: I9f9f40e5a47604fa422a223f5c54fef3d045a074
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/251941
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-07-20 17:02:25 +00:00
Ahmed Ashour 5459fc133f [analysis_server] associate DEFAULT_VALUE_ON_REQUIRED_PARAMETER with RemoveDefaultValue 
Fixes #47540

Change-Id: I8fa50933f2a7fadf6b11df2b6c385a759f36a8c1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/251940
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-07-19 17:58:22 +00:00
Konstantin Shcheglov 2f3269faa1 Deprecate 'Element.enclosingElement', switch to enclosingElement2. 
We need this for:
1. CompilationUnitElement changes its enclosing element from LibraryElement to LibraryOrAugmentationElement
2. Similarly PrefixElement.

Change-Id: I5e3719b4ef59d03caab1b20c9172a8c0fd786bdf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/251900
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-07-19 15:44:14 +00:00
Ahmed Ashour 09680ec704 [analysis_server] associate INITIALIZING_FORMAL_FOR_NON_EXISTENT_FIELD with ChangeTo 
Fixes #49058

Change-Id: Ie064f0155269282b6c8fa4208f9881ed307c0421
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/251762
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-07-19 04:57:35 +00:00
Danny Tuppeny 89e9801103 [analysis_server] Fix isIncomplete flag for LSP completion when budget is exhausted 
Change-Id: I1cc2ec9e3688383008d0eefc44ec7b94f858c5d5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/251768
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-07-18 21:22:05 +00:00
Konstantin Shcheglov e23101a16f Rename to LibraryImportElement, LibraryExportElement. 
Change-Id: I0928ca5522d9c67142111a8f3a7eb4d84f114f56
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/251844
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2022-07-18 20:01:18 +00:00
Danny Tuppeny 6bbe04d40f [analysis_server] Set selection/selectionLength for Flutter "Wrap with X" widgets 
Fixes https://github.com/Dart-Code/Dart-Code/issues/4061.

Change-Id: I41b54c2641a0eed29e500e1bcc90f9e3945f4f7c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/251766
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-07-18 16:28:27 +00:00
Ahmed Ashour e34c84a4fc [analysis_server] associate DEFAULT_VALUE_ON_REQUIRED_PARAMETER with RemoveRequired 
Part of #47540

Change-Id: Iff1e81a2809ce045dc6dfb9b9567ad934400308e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/251761
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-07-18 16:05:23 +00:00
Konstantin Shcheglov 2e86c1f018 Deprecate AnalysisDriver.dispose(), use dispose2() instead. 
Change-Id: Icfb46bf83f3a1f5828efd76eab1014c4dee0e088
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/251587
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-07-15 17:15:40 +00:00
Danny Tuppeny 0482fa6fb3 [analysis_server] Don't 'await' between calling function and using expect(throwsA) 
This introduces a race where if the function throws before `expect(throwsA)` adds a handler, it becomes an unhandled exception.

Fixes https://github.com/dart-lang/sdk/issues/49455.

Change-Id: I81205f272c9ec211b99bf73af64dab8e4d774e84
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/251550
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-07-15 15:40:40 +00:00