dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
47,150 Commits 2 Branches 0 Tags
bcf2900a262da7da1b0514ff2d2e0fbe22fa5e1c
Commit Graph

148 Commits

Author SHA1 Message Date
Alan Knight 0bb2d5e548 Update DDC html libraries to match SDK 
BUG=
R=vsm@google.com

Review-Url: https://codereview.chromium.org/2899083007 .
 2017-05-25 09:33:23 -07:00
Vijay Menon 6402ad477d Use the dart2js patch for dart:convert to get latest type fixes 
BUG=
R=floitsch@google.com

Review-Url: https://codereview.chromium.org/2896253003 .
 2017-05-24 07:33:19 -07:00
Jacob Richman 58851f2f06 Add ignoreAllErrors option to dart:_runtime 
Supports users who want to try to run broken code while porting a Dart
app to strong mode.

BUG=
R=alanknight@google.com

Review-Url: https://codereview.chromium.org/2893803006 .
 2017-05-19 15:53:08 -07:00
Vijay Menon 92d39a4e08 One more minor mixin fix 
We need to preserve the Mixin constructor to make sure metadata (e.g.,
implements) is injected in the right place.

R=jacobr@google.com

Review-Url: https://codereview.chromium.org/2779063002 .
 2017-05-19 07:41:29 -07:00
Vijay Menon b82b0e29ed DDC fixes for SpeechRecognition 
R=alanknight@google.com

Review-Url: https://codereview.chromium.org/2896463002 .
 2017-05-18 17:05:51 -07:00
Vijay Menon 59e6c332ea Regenerate DDC artifacts 
TBR=rnystrom@google.com

Review-Url: https://codereview.chromium.org/2886403006 .
 2017-05-18 13:29:26 -07:00
Jacob Richman 61b0cbd685 Fix language/stacktrace_rethrow_error_test_withtraceparameter_multi test 
Fix is to remove unexpected frames on the stack trace by inlining
all calls to determine current DDC configuration settings.

BUG=
R=leafp@google.com, vsm@google.com

Review-Url: https://codereview.chromium.org/2879393002 .
 2017-05-15 16:27:42 -07:00
Jacob Richman ff588405fe Fix bugs supporting configuring DDC runtime settings before the application starts. 
I don't see a better way to implement this given how DDC lazily
initializes fields.

BUG=
R=vsm@google.com

Review-Url: https://codereview.chromium.org/2875063003 .
 2017-05-12 15:59:07 -07:00
Leaf Petersen 8cdcfb98e2 Use Null argument for callback arity check in async_error. 
Avoid relying on fuzzy arrow semantics by using Null for the callback type
parameter to be checked against.  Any function of the right arity will pass the "is"
check.

BUG=
R=lrn@google.com

Review-Url: https://codereview.chromium.org/2878553003 .
 2017-05-11 17:36:47 -07:00
Bob Nystrom 979a75c4b3 Fix more errors in DDC SDK. 
R=jacobr@google.com, vsm@google.com

Review-Url: https://codereview.chromium.org/2871363002 .
 2017-05-11 11:22:05 -07:00
Bob Nystrom a68b44924e Disambiguate setters and getters when patching DDC SDK. 
Stdio was having its setters applied twice instead of applying the
getter and setter each once.

R=vsm@google.com

Review-Url: https://codereview.chromium.org/2874713005 .
 2017-05-10 16:56:41 -07:00
Leaf Petersen a2ebe9c809 Update DDC built sdk. 
BUG=
R=vsm@google.com

Review-Url: https://codereview.chromium.org/2873363002 .
 2017-05-10 10:30:33 -07:00
Jacob Richman a35b79f178 Support configuring DDC runtime settings before the application starts and normalize API for configuring runtime settings. 
BUG=
R=vsm@google.com

Review-Url: https://codereview.chromium.org/2874813002 .
 2017-05-10 10:05:49 -07:00
Jennifer Messerly 4c377076bf fix #29585, implement equality for tearoffs 
R=vsm@google.com

Review-Url: https://codereview.chromium.org/2873073002 .
 2017-05-09 16:21:51 -07:00
Vijay Menon 36356c28c1 Better stack trace support 
- Caches stack trace objects (package:stack_trace appears to rely on this)
- Better support for stack traces on primitives

R=jmesserly@google.com

Review-Url: https://codereview.chromium.org/2869463002 .
 2017-05-09 14:58:34 -07:00
Jennifer Messerly 811a9eed1d Revert "Revert "fix #27256, track type bounds for generic functions"" 
This reverts commit 3a23e604e2.

The problem was unrelated to the CL; it appears to be a dart:async break of package:async.

In the meantime we have turned on --unsafe-force-compile to DDC's shapshotting step

Review-Url: https://codereview.chromium.org/2869733006 .
 2017-05-09 14:20:25 -07:00
Vijay Menon 96f9287c0b Regenerate DDC artifacts 
I had to put --unsafe-force-compile back to get the snapshot to build.  Investigating...

TBR=jmesserly@google.com

Review-Url: https://codereview.chromium.org/2873013003 .
 2017-05-09 14:08:47 -07:00
Alan Knight 3a23e604e2 Revert "fix #27256, track type bounds for generic functions" 
This reverts commit b58f826976.

BUG=

Review URL: https://codereview.chromium.org/2870543005 .
 2017-05-09 12:58:03 -07:00
Jennifer Messerly b58f826976 fix #27256, track type bounds for generic functions 
R=vsm@google.com

Review-Url: https://codereview.chromium.org/2867493002 .
 2017-05-09 11:42:40 -07:00
Bob Nystrom 4145a49503 Move Dart versions of math.min() and math.max() into VM patch file. 
For DDC and dart2js, we call the corresponding JS function. This is
shorter and avoids a strong mode type error in the Dart implementation.

R=jmesserly@google.com, lrn@google.com

Review-Url: https://codereview.chromium.org/2858353003 .
 2017-05-05 15:15:21 -07:00
Jennifer Messerly 171f7ba592 fix #29544, mixins to a class with named constructors 
R=vsm@google.com

Review-Url: https://codereview.chromium.org/2859703003 .
 2017-05-04 12:33:45 -07:00
Vijay Menon d5ecaf1088 Loosen type check on runZoned errorHandler 
R=floitsch@google.com, lrn@google.com

Review-Url: https://codereview.chromium.org/2858843002 .
 2017-05-03 05:30:06 -07:00
Jennifer Messerly 5e82b8c2e9 fix #29530, field metadata generation 
R=vsm@google.com

Review-Url: https://codereview.chromium.org/2861503002 .
 2017-05-02 14:45:34 -07:00
Jennifer Messerly eeb0e1d2ae fix #27258, don't allow dynamic set of a final field 
R=vsm@google.com

Review-Url: https://codereview.chromium.org/2847893002 .
 2017-05-01 15:36:32 -07:00
Jennifer Messerly c305d183c3 fix #29504, dcall on object member when a temporary was involved. 
R=vsm@google.com

Review-Url: https://codereview.chromium.org/2848153002 .
 2017-05-01 10:57:49 -07:00
Vijay Menon 7bedf63e1e dart:mirrors workaround for generic methods 
Fixes #29509

R=jmesserly@google.com

Review-Url: https://codereview.chromium.org/2852723002 .
 2017-04-28 20:02:13 -07:00
Bob Nystrom 7f7c681893 Fix a batch of DDC SDK compile errors. 
R=floitsch@google.com, vsm@google.com

Review-Url: https://codereview.chromium.org/2848703003 .
 2017-04-27 17:27:02 -07:00
Vijay Menon aa3966dc84 Fix hot dynamic check in WhereIterator 
R=floitsch@google.com

Review-Url: https://codereview.chromium.org/2843423002 .
 2017-04-27 06:35:37 -07:00
Jennifer Messerly d26bb56575 fix #27971, implement generic function RTTI 
R=vsm@google.com

Review-Url: https://codereview.chromium.org/2832913003 .
 2017-04-21 15:40:44 -07:00
Jennifer Messerly bed6f8242a add an option to turn off errors from strong mode is-checks 
This adds an option and also has our tests run with it turned off.

R=vsm@google.com

Review-Url: https://codereview.chromium.org/2835743002 .
 2017-04-21 15:24:32 -07:00
Jacob Richman 7149b90c7c Tighten up handling of JS types and add test. 
Side effect of this:
Fix bug where helpers in js_mirrors were specifying that name had to have type String when it could really also be a JS Symbol as well.
Fix bug where top level JS interop members using the external keyword but no @JS keyword were not implemented.
Update js_typed_interop_test.dart so it can work in DDC.
Add regression test for jsify call with native function type arguments.

BUG=
R=vsm@google.com

Review-Url: https://codereview.chromium.org/2827333003 .
 2017-04-21 08:44:00 -07:00
Vijay Menon 8a64625d81 Regenerate DDC artifacts 
TBR=jacobr@google.com

Review-Url: https://codereview.chromium.org/2830983002 .
 2017-04-19 16:26:22 -07:00
Jacob Richman 0dbb32f406 Run formatter on dev_compiler. 
BUG=
R=vsm@google.com

Review-Url: https://codereview.chromium.org/2830503002 .
 2017-04-18 16:16:14 -07:00
Jacob Richman b280a7803d Dev compiler debugger related tweaks. 
Optimize dynamic call tracking using random sampling.
Apply source maps to improve dynamic call tracking accuracy.
Dynamic calls within the sdk are now attributed correctly.

Fix bug formatting modules where we were incorrectly flagging them as JS.

BUG=
R=jmesserly@google.com, vsm@google.com

Review-Url: https://codereview.chromium.org/2811343002 .
 2017-04-17 14:57:31 -07:00
Jennifer Messerly b76e2d67cf fix #29346, ensure all nodes are implemented by DDC's code generator 
R=vsm@google.com

Review-Url: https://codereview.chromium.org/2822633003 .
 2017-04-14 10:10:50 -07:00
Vijay Menon bc3089838c Reify implicit casts for FutureOr 
Before landing, two issues to resolve:
(1) We appear to allow sideways casts now without static error - e.g.,

List<Object> -> FutureOr<List<String>>

Is that intended?  If so, it breaks an assumption that implicit casts
are from supertype to subtype.

(2) LUB and FutureOr

It appears that the LUB of, e.g., String and Future<String> is Object.
See fixes in tests to record casts back to FutureOr.

Fixes #29251

R=leafp@google.com

Review-Url: https://codereview.chromium.org/2801683004 .
 2017-04-07 17:33:34 -07:00
Vijay Menon 10c5de82c8 Invoke debugger on nsm 
Missed this one when I added debugger statements earlier

R=jmesserly@google.com

Review-Url: https://codereview.chromium.org/2565183004 .
 2017-04-07 14:45:09 -07:00
Jennifer Messerly 8ada796a86 fix #29233, final fields can be settable in a mock 
also fix #29273, user mixins can override native methods

R=vsm@google.com

Review-Url: https://codereview.chromium.org/2803673007 .
 2017-04-07 14:12:49 -07:00
Vijay Menon 5c3bcff375 DDC fix for foreign futures 
Fixes #29287

R=jmesserly@google.com

Review-Url: https://codereview.chromium.org/2804113002 .
 2017-04-06 14:52:59 -07:00
Jennifer Messerly 247fc68d21 fix #29228, let* precedence should match generated expression 
R=vsm@google.com

Review-Url: https://codereview.chromium.org/2804833002 .
 2017-04-05 12:40:42 -07:00
Jennifer Messerly e4e7dffadb fix #29182, generate top level const fields lazily 
This fixes an ordering issue, but also may help load time.

R=vsm@google.com

Review-Url: https://codereview.chromium.org/2797443007 .
 2017-04-04 16:18:46 -07:00
Jacob Richman 509bcd58e1 Fix type checks and display for JS interop types. 
Re-enable formatter test that had been disabled when someone changed type
name display for Foo<dynamic> types.
Fix bug in how type names were displayed for JS interop types.

BUG=
R=vsm@google.com

Review-Url: https://codereview.chromium.org/2789663005 .
 2017-04-03 08:34:20 -07:00
Vijay Menon 08f085727e Fix ignore on FutureOr 
I'll look into adding tests - these eventually supposed to *not* get ignored (see #27223)

R=leafp@google.com

Review-Url: https://codereview.chromium.org/2788933002 .
 2017-03-31 09:30:16 -07:00
Jacob Richman a7465d942f Update test expectations to reflect errors that are now warning. 
BUG=

Review-Url: https://codereview.chromium.org/2785183003 .
 2017-03-30 14:54:35 -07:00
Vijay Menon 84864e3415 DDC fix for Edge 
Patch from zjd.

R=jacobr@google.com

Review-Url: https://codereview.chromium.org/2780903004 .
 2017-03-29 12:22:45 -07:00
Jennifer Messerly 1c504f8945 Fix #28120, strong mode allows field overrides 
Fix #28119, DDC supports field overrides without @virtual
Fix #28801, devirtualize private fields in DDC where possible
Fix #28589, stop supporting @virtual in strong mode

R=leafp@google.com, vsm@google.com

Review-Url: https://codereview.chromium.org/2781443003 .
 2017-03-28 10:26:36 -07:00
Vijay Menon 50ceaa4c04 Fix for #29003 
This is an alternative to the other CL.  It just uses the result of
dart.mixin instead of declaring a new class.  That preserves the assumption (at least at runtime) that the mixin class directly inherits from Object.

We were also not declaring interfaces for ClassTypeAliases.

R=jmesserly@google.com

Review-Url: https://codereview.chromium.org/2783443002 .
 2017-03-27 16:06:13 -07:00
Vijay Menon ac68d598cf Add patch code for List.filled growable param 
Looks like a missing param doesn't break patch_sdk.  I think this was a recent add.

Fixes #28508

R=jakemac@google.com, jmesserly@google.com

Review-Url: https://codereview.chromium.org/2771953004 .
 2017-03-24 14:27:47 -07:00
Leaf Petersen dba842bcc8 Handle casts from Number to FutureOr<double>. 
Fixes https://github.com/dart-lang/sdk/issues/29128 .

BUG=
R=vsm@google.com

Review-Url: https://codereview.chromium.org/2772573003 .
 2017-03-23 13:33:33 -07:00
Vijay Menon 053d2ce14f Fix for dcall on callable class 
(Note, regenerated files aren't being uploaded)

Fixes #29148

R=leafp@google.com

Review-Url: https://codereview.chromium.org/2774623004 .
 2017-03-23 13:14:58 -07:00