Brian Wilkerson
61e3486ed1
Find drivers even when the file is not a dart file
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2898213004 .
2017-05-23 17:23:30 -07:00
Konstantin Shcheglov
ab9ee72a34
Switch server tests to strong mode.
...
R=brianwilkerson@google.com
BUG=
Review-Url: https://codereview.chromium.org/2903523003 .
2017-05-23 14:58:53 -07:00
Brian Wilkerson
0929b7736e
Convert quick assist support to use AnalysisDriver
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2899843002 .
2017-05-22 13:45:55 -07:00
Ian McKellar
5b6a9392e5
Fix inifinite loop in analysis server. ( #29685 )
...
It was walking up a directory heirarchy looking for a directory named
"lib" but didn't terminate when it reached the root.
2017-05-22 11:46:44 -07:00
Brian Wilkerson
7e47a24c8a
Convert quick fix support to use AnalysisDriver
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2894403003 .
2017-05-22 10:41:57 -07:00
Steve Messick
5455f21565
Fix reparent on windows
...
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/2892963002 .
2017-05-19 10:28:44 -07:00
Brian Wilkerson
a8dc041543
Capture the request time for performance data and support forced shutdown
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2893803004 .
2017-05-19 08:49:47 -07:00
Brian Wilkerson
c1a7070770
Add the ability to whitelist plugins
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2897653002 .
2017-05-19 08:48:32 -07:00
Brian Wilkerson
a6214b3129
Remove more libraries directives from server
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2894883002 .
2017-05-19 08:42:30 -07:00
Brian Wilkerson
daffcecc11
Pass the sdk path to plugins
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2885993004 .
2017-05-17 08:19:49 -07:00
pq
aa491e7133
Support tear-off completions for named params (in constructors) (flutter-intellij#836)
...
R=danrubel@google.com
Fixes: https://github.com/flutter/flutter-intellij/issues/836
Review-Url: https://codereview.chromium.org/2883363002 .
2017-05-16 13:40:33 -07:00
Brian Wilkerson
a03958bfc9
More clean-up after getting common protocol classes
...
R=danrubel@google.com
Review-Url: https://codereview.chromium.org/2880393002 .
2017-05-15 13:01:57 -07:00
Brian Wilkerson
6643349a8f
Minor clean-up
...
R=danrubel@google.com
Review-Url: https://codereview.chromium.org/2885473002 .
2017-05-15 10:09:47 -07:00
Brian Wilkerson
fb982f5476
Make server use the common protocol classes
...
R=danrubel@google.com
Review-Url: https://codereview.chromium.org/2879273002 .
2017-05-15 09:35:46 -07:00
Brian Wilkerson
3085734ef6
Generate common types into a separate library
...
R=danrubel@google.com
Review-Url: https://codereview.chromium.org/2880443006 .
2017-05-13 08:12:14 -07:00
Konstantin Shcheglov
a4fd5d814f
Extract PerformanceLogger from AnalysisDriver.
...
I also added the runAsync().
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review-Url: https://codereview.chromium.org/2883633002 .
2017-05-12 14:27:50 -07:00
danrubel
98825b4918
improve code completion abort request tests
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2876793006 .
2017-05-12 13:28:39 -07:00
Brian Wilkerson
bef53e72e4
Remove unintentional dependency on analysis_server
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2875323002 .
2017-05-12 10:07:37 -07:00
pq
dc64c43480
Unused import cleanup.
...
BUG=
R=danrubel@google.com
Review-Url: https://codereview.chromium.org/2876913002 .
2017-05-11 14:08:47 -07:00
danrubel
66bb2d618e
Remove unused analysisContext from completion request and contributors
...
Now that the analysis server uses the new analysis driver,
the CompletionRequest analysisContext field is always null.
This change removes that field and much of the unused code.
R=brianwilkerson@google.com , pquitslund@google.com
Review-Url: https://codereview.chromium.org/2877653002 .
2017-05-11 09:38:50 -07:00
danrubel
6798cdfcd1
cleanup dart code completion contributors
...
Remove the following unnecessary methods now that analysis driver
resolves everything in the compilation unit upfront.
DartCompletionRequest
* resolveUnits
* resolveImports
* resolveContainingStatement
* resolveContainingExpression
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/2873943003 .
2017-05-11 09:12:36 -07:00
Brian Wilkerson
3b2c3ae5b2
Add support for built-in plugins
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2874803003 .
2017-05-10 13:31:20 -07:00
Steve Messick
55097a44b3
Recover from merge problem
...
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/2868383002 .
2017-05-10 13:12:14 -07:00
Brian Wilkerson
a3ac4253b1
Remove an obsolete error from the spec and an obsolete command-line flag
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2865403005 .
2017-05-10 09:33:43 -07:00
Brian Wilkerson
fbc3f3708d
Remove unused reference to SearchEngine
...
R=danrubel@google.com
Review-Url: https://codereview.chromium.org/2872803003 .
2017-05-09 14:32:12 -07:00
Brian Wilkerson
98e8f17b96
Convert server to use RangeFactory
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2869083002 .
2017-05-09 10:08:14 -07:00
Konstantin Shcheglov
bd1ee32543
Move [file_]byte_store.dart into pkg/front_end/test/src/incremental/.
...
We are going to reuse ByteStore in front_end, also for incremental
compilation.
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review-Url: https://codereview.chromium.org/2869803004 .
2017-05-09 09:12:15 -07:00
pq
11558c8a90
Add trailing commas after Flutter instance creation params fixes (flutter-intellij/#f978).
...
R=brianwilkerson@google.com
Fixes: https://github.com/flutter/flutter-intellij/issues/978
Review-Url: https://codereview.chromium.org/2864373003 .
2017-05-09 07:00:15 -07:00
danrubel
bc310f5f1f
cleanup KeywordContributor
...
R=pquitslund@google.com
Review-Url: https://codereview.chromium.org/2871443003 .
2017-05-08 10:03:39 -07:00
danrubel
959b7c14b8
improve completion for formal param initializers
...
R=pquitslund@google.com
Review-Url: https://codereview.chromium.org/2864233002 .
2017-05-08 06:50:46 -07:00
danrubel
eb15a4c7c9
add constructor initializer completions
...
R=pquitslund@google.com
Review-Url: https://codereview.chromium.org/2869653002 .
2017-05-08 05:52:12 -07:00
Brian Wilkerson
d2bbfb4f77
Make an AstProvider available to AssistProcessors
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2862143003 .
2017-05-05 09:24:30 -07:00
Brian Wilkerson
6c2023bd07
Move ChangeBuilder to analyzer_plugin
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2860383002 .
2017-05-05 07:52:27 -07:00
Brian Wilkerson
0d2bfea054
Remove the use of CorrectionUtilities
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2866603002 .
2017-05-05 06:06:57 -07:00
pq
1a394e975f
Specify types in generated closure args.
...
Follow-up from: https://github.com/flutter/flutter-intellij/issues/975
BUG=
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/2863683002 .
2017-05-04 12:54:23 -07:00
Devon Carew
f6f845c879
Fix a completion exception during import suggestions.
...
BUG=
R=danrubel@google.com
Review-Url: https://codereview.chromium.org/2862793002 .
2017-05-04 09:24:18 -07:00
Brian Wilkerson
4a9092d9c9
Change the ChangeBuilder API to use SourceRange
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2856233003 .
2017-05-04 08:49:01 -07:00
pq
374871da75
Add default implementation when fixing missing required closures (flutter-intellij#975)
...
Fixes: https://github.com/flutter/flutter-intellij/issues/975
Also improves code generation for required lists to include empty list literals.
BUG=
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/2862623002 .
2017-05-03 13:22:52 -07:00
pq
a51af38461
Widget details for Flutter children: param completions.
...
R=brianwilkerson@google.com
See: https://github.com/flutter/flutter-intellij/issues/463
Review-Url: https://codereview.chromium.org/2855883003 .
2017-05-02 13:50:34 -07:00
Brian Wilkerson
9eee213363
Fix bugs found while working on tests
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2849253002 .
2017-05-02 06:15:25 -07:00
Steve Messick
28b7710190
Complete declarations; detect invalid blocks
...
R=brianwilkerson@google.com , scheglov@google.com
Review-Url: https://codereview.chromium.org/2852073002 .
2017-05-01 08:45:41 -07:00
Erik Corry
aa6353b6da
Dart SDK Spelling b, c, and d.
...
R=kmillikin@google.com
BUG=
Review-Url: https://codereview.chromium.org/2850783002 .
2017-05-01 08:28:10 +02:00
jpaulsen
6ff38127d6
New Lint quick-fix: await_only_futures ( #29490 )
2017-04-28 14:00:52 -07:00
jpaulsen
ddd9bb1be2
New Lint quick-fix: avoid_annotating_with_dynamic ( #29489 )
...
New Lint quick-fix: avoid_types_on_closure_parameters
2017-04-28 13:40:51 -07:00
pq
37dbc98df8
Fix null default value access ( #29512 ).
...
BUG=
R=brianwilkerson@google.com , scheglov@google.com
Fixes : #29512
Review-Url: https://codereview.chromium.org/2844323004 .
2017-04-28 11:33:34 -07:00
pq
fa318bf1c7
Fix VERBOSE_FLUTTER_COMPLETIONS flag.
...
(Mis-defined as an option when it should be an arg flag.)
BUG=
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/2854453002 .
2017-04-28 11:20:05 -07:00
Brian Wilkerson
e55812a3f2
Unify the server and plugin versions of the generators
...
R=devoncarew@google.com
Review-Url: https://codereview.chromium.org/2844273003 .
2017-04-28 07:46:29 -07:00
pq
daa399499d
Fix following comma detection in code completion ( #29503 ).
...
BUG=
R=brianwilkerson@google.com
Fixes: https://github.com/dart-lang/sdk/issues/29503
Review-Url: https://codereview.chromium.org/2849703002 .
2017-04-27 16:52:33 -07:00
pq
efb5c5ddc5
Trailing commas for named args in Flutter cons invocations (flutter-intellij#551).
...
* adds trailing commas to named params in Flutter instance creations
* adds trailing commas to default value boilerplate
See https://github.com/flutter/flutter-intellij/issues/551 for action shots. :)
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/2850693002 .
2017-04-27 14:58:02 -07:00
jpaulsen
f929ab15e7
New Lint quick-fix: empty_statements ( #29491 )
2017-04-27 14:10:17 -07:00