61e3486ed1
Find drivers even when the file is not a dart file
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2898213004 .
2017-05-23 17:23:30 -07:00
ab9ee72a34
Switch server tests to strong mode.
...
R=brianwilkerson@google.com
BUG=
Review-Url: https://codereview.chromium.org/2903523003 .
2017-05-23 14:58:53 -07:00
0929b7736e
Convert quick assist support to use AnalysisDriver
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2899843002 .
2017-05-22 13:45:55 -07:00
5b6a9392e5
Fix inifinite loop in analysis server. ( #29685 )
...
It was walking up a directory heirarchy looking for a directory named
"lib" but didn't terminate when it reached the root.
2017-05-22 11:46:44 -07:00
7e47a24c8a
Convert quick fix support to use AnalysisDriver
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2894403003 .
2017-05-22 10:41:57 -07:00
5455f21565
Fix reparent on windows
...
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/2892963002 .
2017-05-19 10:28:44 -07:00
a8dc041543
Capture the request time for performance data and support forced shutdown
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2893803004 .
2017-05-19 08:49:47 -07:00
c1a7070770
Add the ability to whitelist plugins
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2897653002 .
2017-05-19 08:48:32 -07:00
a6214b3129
Remove more libraries directives from server
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2894883002 .
2017-05-19 08:42:30 -07:00
7e11a13cf5
Add requestTime to responses
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2890163004 .
2017-05-18 10:32:47 -07:00
5659afc812
Make instrumentation data structure more regular
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2890193002 .
2017-05-18 09:09:17 -07:00
daffcecc11
Pass the sdk path to plugins
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2885993004 .
2017-05-17 08:19:49 -07:00
7d26ff6d4f
Remove some more library directives
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2884233004 .
2017-05-17 08:02:08 -07:00
d9f1c2620b
Update the log viewer to understand the plugin entries
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2891743002 .
2017-05-17 07:51:42 -07:00
cb258a952c
Remove unused contentHash from results
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2885203002 .
2017-05-16 14:08:11 -07:00
aa491e7133
Support tear-off completions for named params (in constructors) (flutter-intellij#836)
...
R=danrubel@google.com
Fixes: https://github.com/flutter/flutter-intellij/issues/836
Review-Url: https://codereview.chromium.org/2883363002 .
2017-05-16 13:40:33 -07:00
d566906167
cleanup unused incremental resolution
...
* remove unused analyzer incremental resolution
* remove unused Token.applyDelta method
Patch Set 1 is the original CL that was landed and reverted
https://codereview.chromium.org/2876993005
Patsh Set 2 contains additional fixes and test changes
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2884853002 .
2017-05-16 07:53:17 -04:00
a03958bfc9
More clean-up after getting common protocol classes
...
R=danrubel@google.com
Review-Url: https://codereview.chromium.org/2880393002 .
2017-05-15 13:01:57 -07:00
6643349a8f
Minor clean-up
...
R=danrubel@google.com
Review-Url: https://codereview.chromium.org/2885473002 .
2017-05-15 10:09:47 -07:00
0b5bee6c66
Fix a failing test (TBR)
...
Review-Url: https://codereview.chromium.org/2877353003 .
2017-05-15 09:49:22 -07:00
fb982f5476
Make server use the common protocol classes
...
R=danrubel@google.com
Review-Url: https://codereview.chromium.org/2879273002 .
2017-05-15 09:35:46 -07:00
38143be701
Fix an error to fix the bots (TBR)
...
Review-Url: https://codereview.chromium.org/2883883003 .
2017-05-15 09:11:12 -07:00
27f9e5e4ce
Reverse the sense of the flag to make it easier to find test that need to be converted
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2884593003 .
2017-05-15 08:40:40 -07:00
4afc0aeb73
Fix some analysis issues.
...
BUG=
R=danrubel@google.com
Review-Url: https://codereview.chromium.org/2882003002 .
2017-05-13 16:24:47 -07:00
f6f98576ef
Misc fixes to the analysis server spec.
...
BUG=
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/2878273002 .
2017-05-13 14:10:28 -07:00
3085734ef6
Generate common types into a separate library
...
R=danrubel@google.com
Review-Url: https://codereview.chromium.org/2880443006 .
2017-05-13 08:12:14 -07:00
f4d3f6cf45
Remove .iml files from the repository.
...
These files weren't providing enough benefit compared to the confusion
they were causing by showing up frequently in diffs.
R=brianwilkerson@google.com , scheglov@google.com
Review-Url: https://codereview.chromium.org/2878103002 .
2017-05-12 15:06:18 -07:00
a4fd5d814f
Extract PerformanceLogger from AnalysisDriver.
...
I also added the runAsync().
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review-Url: https://codereview.chromium.org/2883633002 .
2017-05-12 14:27:50 -07:00
b5bc14c0b4
Begin writing a TypeInferenceListener interface.
...
In the long term, this is intended to be used to communicate the
results of type inference from the front_end to analyzer. In the
short term, it can be used to debug type inference (by uncommenting
the print statements in type_inference_listener.dart).
R=scheglov@google.com , sigmund@google.com
Review-Url: https://codereview.chromium.org/2878733006 .
2017-05-12 13:31:26 -07:00
98825b4918
improve code completion abort request tests
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2876793006 .
2017-05-12 13:28:39 -07:00
69cc6c3183
convert completion tests to use new analysis driver
...
Update more tests and remove dead code from tests
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/2875223003 .
2017-05-12 11:48:20 -07:00
bdedd6768b
Add a way to use shared CanonicalName root to deserialize Program.
...
This allows for example to add SDK into a Program, then load the
"incomplete" Program A that has only the library A, and name sequences
that references SDK classes. Because we look into the nameRoot which
aleady has SDK CanonicalName(s), we can find these names while filling
the link table and use references which point to the existing SDK
AST nodes. Then we can load another set of library cycles, etc.
At the end we have a set of self-consistent libraries that we can
feed into DillTarget/DillLoader and resolve anothersource target
against it.
This CL is based on https://codereview.chromium.org/2872903005/
which has not been reviewed yet.
R=kmillikin@google.com , paulberry@google.com , sigmund@google.com
BUG=
Review-Url: https://codereview.chromium.org/2874723002 .
2017-05-12 10:42:08 -07:00
bef53e72e4
Remove unintentional dependency on analysis_server
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2875323002 .
2017-05-12 10:07:37 -07:00
e9edd2e568
Fix pubspecs for new analyzer plugin arch dependencies
...
BUG=
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/2877863002 .
2017-05-11 14:37:46 -07:00
dc64c43480
Unused import cleanup.
...
BUG=
R=danrubel@google.com
Review-Url: https://codereview.chromium.org/2876913002 .
2017-05-11 14:08:47 -07:00
66bb2d618e
Remove unused analysisContext from completion request and contributors
...
Now that the analysis server uses the new analysis driver,
the CompletionRequest analysisContext field is always null.
This change removes that field and much of the unused code.
R=brianwilkerson@google.com , pquitslund@google.com
Review-Url: https://codereview.chromium.org/2877653002 .
2017-05-11 09:38:50 -07:00
6798cdfcd1
cleanup dart code completion contributors
...
Remove the following unnecessary methods now that analysis driver
resolves everything in the compilation unit upfront.
DartCompletionRequest
* resolveUnits
* resolveImports
* resolveContainingStatement
* resolveContainingExpression
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/2873943003 .
2017-05-11 09:12:36 -07:00
3b2c3ae5b2
Add support for built-in plugins
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2874803003 .
2017-05-10 13:31:20 -07:00
55097a44b3
Recover from merge problem
...
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/2868383002 .
2017-05-10 13:12:14 -07:00
a3ac4253b1
Remove an obsolete error from the spec and an obsolete command-line flag
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2865403005 .
2017-05-10 09:33:43 -07:00
2a4772a537
Remove unnecessary tests
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2868233003 .
2017-05-10 09:15:36 -07:00
e6c8092cea
Enable analysis driver in tests where possible
...
R=danrubel@google.com , scheglov@google.com
Review-Url: https://codereview.chromium.org/2868353002 .
2017-05-10 09:13:25 -07:00
5b969e04f9
enable new analysis driver for completion sorter tests
...
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/2875483002 .
2017-05-09 16:54:43 -07:00
947413addc
Remove an obsolete flag from test support
...
R=danrubel@google.com
Review-Url: https://codereview.chromium.org/2875433002 .
2017-05-09 16:39:57 -07:00
fbc3f3708d
Remove unused reference to SearchEngine
...
R=danrubel@google.com
Review-Url: https://codereview.chromium.org/2872803003 .
2017-05-09 14:32:12 -07:00
1f893e86a9
Clean up some warnings
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2874443003 .
2017-05-09 13:07:06 -07:00
98e8f17b96
Convert server to use RangeFactory
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2869083002 .
2017-05-09 10:08:14 -07:00
bd1ee32543
Move [file_]byte_store.dart into pkg/front_end/test/src/incremental/.
...
We are going to reuse ByteStore in front_end, also for incremental
compilation.
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review-Url: https://codereview.chromium.org/2869803004 .
2017-05-09 09:12:15 -07:00
11558c8a90
Add trailing commas after Flutter instance creation params fixes (flutter-intellij/#f978).
...
R=brianwilkerson@google.com
Fixes: https://github.com/flutter/flutter-intellij/issues/978
Review-Url: https://codereview.chromium.org/2864373003 .
2017-05-09 07:00:15 -07:00
4eee6cb5ea
Fix constructor invocation type inference.
...
Three problems are fixed:
- I forgot to pass the `downwards` flag when doing downwards inference.
- I forgot to initialize the `formalTypes` and `actualTypes` arrays.
- I wasn't tracking whether constructor type arguments were implicit
or explicit, so constructor type inference wasn't actually
happening.
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2864853002 .
2017-05-08 14:41:56 -07:00
Brian Wilkerson