dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
34,545 Commits 2 Branches 0 Tags
bcde4eee0bf7f2ff7eb577d4e6e30b0c59cbf496
Commit Graph

76 Commits

Author SHA1 Message Date
Lasse R.H. Nielsen edff0face7 Make String.allMatches lazy. 
R=floitsch@google.com, iposva@google.com

Review URL: https://codereview.chromium.org//1273713003 .
 2015-08-12 11:01:21 +02:00
Srdjan Mitrovic 56c91201c3 Fix issue 24043: do not trust the pattern. Enable a 'hidden' test. 
If there is a performance issues, I can add specialized code for String patterns.

BUG=24043
R=rmacnak@google.com

Review URL: https://codereview.chromium.org//1286823003 .
 2015-08-11 14:46:17 -07:00
Lasse R.H. Nielsen babcd4e9c0 Revert "Make EfficientLength public, as EfficientLengthIterable." 
It's still not a good solution for detecting an Iterable with an efficient
length. It's not inherited by, e.g., a DelegatingIterable wrapper or similar
generic Iterable transformers.

Keep this as an internal optimization for quickly detecting the most common
efficient-length Iterable classes (List, Set, Queue, Map.keys/values), but
don't make it public.

A *real* solution would be adding a hasEfficientLength getter to Iterable, or
adding an efficientLength getter that may return null if it's not efficient.
This would something that a wrapper can attach to.

R=sgjesse@google.com

Review URL: https://codereview.chromium.org//1154263003
 2015-05-29 12:52:45 +02:00
lrn@google.com 92c526b2a2 Make EfficientLength public, as EfficientLengthIterable. 
R=iposva@google.com, sgjesse@google.com

Review URL: https://codereview.chromium.org//1104063002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45556 260f80e4-7a28-3924-810f-c04153c831b5
 2015-05-06 09:00:45 +00:00
lrn@google.com f0a07f1eb0 Cleanup URI and use String.replaceRange. 
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//957743002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44023 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-25 14:27:10 +00:00
lrn@google.com 20653fc1fb Add String.replaceRange and use it in replaceFirst{,Mapped}. 
R=floitsch@google.com

Review URL: https://codereview.chromium.org//949753005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44022 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-25 12:17:27 +00:00
lrn@google.com 0b1bb96146 Change _interpolateSingle to use the same value in errors as _interpolate. 
R=iposva@google.com

Review URL: https://codereview.chromium.org//920793002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43942 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-23 08:09:50 +00:00
lrn@google.com a4dc421974 Fix last-minute-typo. 
Review URL: https://codereview.chromium.org//921713002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43721 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-12 10:37:40 +00:00
lrn@google.com 688d50f1c9 Add String.replaceFirstMapped. 
Also refactory VM implementation of checking if a string is one-byte,
and adds dart2js implementation of replaceFirst for non-string/regexp pattern.

BUG= http://dartbug.com/2979
R=floitsch@google.com, iposva@google.com

Committed: https://code.google.com/p/dart/source/detail?r=43716

Review URL: https://codereview.chromium.org//920453002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43718 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-12 09:16:57 +00:00
lrn@google.com 7c9248c642 Revert "Add String.replaceFirstMapped." 
Changes to interpolation should be separate CL.

Review URL: https://codereview.chromium.org//917663004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43717 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-12 09:12:06 +00:00
lrn@google.com 6b9ff4c4d4 Add String.replaceFirstMapped. 
Also refactory VM implementation of checking if a string is one-byte,
and adds dart2js implementation of replaceFirst for non-string/regexp pattern.

BUG= http://dartbug.com/2979
R=floitsch@google.com, iposva@google.com

Review URL: https://codereview.chromium.org//920453002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43716 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-12 09:04:09 +00:00
lrn@google.com 62adbb7ab0 Let Uint16List.setRange detect a String.codeUnits object, and copy directly from the string. 
R=vegorov@google.com

Review URL: https://codereview.chromium.org//856053002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43327 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-30 09:46:04 +00:00
lrn@google.com ab51ccc9f0 Create string efficiently from Uint16List/View. 
R=asiva@google.com, fschneider@google.com

Review URL: https://codereview.chromium.org//864463002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43235 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-28 12:44:44 +00:00
lrn@google.com ab2d914ae3 Avoid extra duplication of substrings during string.replaceAll. 
R=asiva@google.com, zerny@google.com

Review URL: https://codereview.chromium.org//858543002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43059 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-22 08:27:42 +00:00
lrn@google.com 28937c86ae Optimize _GrowableArray._join and _StringBase._interpolate. 
R=fschneider@google.com

Review URL: https://codereview.chromium.org//551823002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40800 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-30 08:28:00 +00:00
lrn@google.com 2ef0e0b993 Fix bad call of RangeError.value in String.fromCharCodes. 
Review URL: https://codereview.chromium.org//608213002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40760 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-29 09:33:08 +00:00
lrn@google.com de514055bf Change restrictions on start/end on String.fromCharCodes. 
Must now be 0 <= start <= end <= iterable.length.

R=sgjesse@google.com

Review URL: https://codereview.chromium.org//605213002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40755 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-29 08:15:49 +00:00
lrn@google.com d57732d359 Optimize int.parse with a radix. 
Handles bignums by parsing chunks of of digits into smis, then
combining the smi into a (potential) bignum, using smi arithmetic as
much as possible.
Use the optimized version for radix 10 and 16 too, instead of going to runtime.

R=fschneider@google.com

Committed: https://code.google.com/p/dart/source/detail?r=40702

Review URL: https://codereview.chromium.org//596763002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40703 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-26 12:13:47 +00:00
lrn@google.com 15ad26af35 Optimize int.parse with a radix. 
Handles bignums by parsing chunks of of digits into smis, then
combining the smi into a (potential) bignum, using smi arithmetic as
much as possible.
Use the optimized version for radix 10 and 16 too, instead of going to runtime.

R=fschneider@google.com

Review URL: https://codereview.chromium.org//596763002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40702 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-26 12:04:43 +00:00
lrn@google.com 8bba32d131 Make String.fromCharCodes take start/end. 
This avoids having to make a sublist of a list of character codes before passing it to String.fromCharCodes.

    new String.fromCharCodes(codes.sublist(start, end))

becomes just

    new String.fromCharCodes(codes, start, end)

R=floitsch@google.com, sgjesse@google.com

Review URL: https://codereview.chromium.org//515183002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40672 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-25 10:45:24 +00:00
lrn@google.com 54ffc4f000 Call special VM interpolate for single element interpolation. 
Fixed at the intermediate language level.

R=fschneider@google.com

Review URL: https://codereview.chromium.org//563973004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40232 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-15 07:19:23 +00:00
lrn@google.com 29ad62131d Add optional startIndex to String.replaceFirst 
BUG= https://code.google.com/p/dart/issues/detail?id=3194
R=lrn@google.com

Review URL: https://codereview.chromium.org//462463003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39490 260f80e4-7a28-3924-810f-c04153c831b5
 2014-08-22 11:27:32 +00:00
lrn@google.com 7b516974b2 Add optional start index to Pattern.allMatches. 
This is a non-breaking change.
Very few classes implement Pattern, so it's also a mostly non-intrusive change.

If we add startIndex to other methods, like replaceFirstMatch, we can use the extra parameter only for non-zero start indices without breaking existing code.

R=ajohnsen@google.com

Review URL: https://codereview.chromium.org//460613002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39119 260f80e4-7a28-3924-810f-c04153c831b5
 2014-08-12 07:13:01 +00:00
lrn@google.com 1ea907017a Special case substring(0, length) to return itself. 
R=ajohnsen@google.com, srdjan@google.com

Review URL: https://codereview.chromium.org//442693002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38919 260f80e4-7a28-3924-810f-c04153c831b5
 2014-08-06 07:00:59 +00:00
lrn@google.com ca66944f5a Performance tweak on int.parse. 
Slower for strings with trailing, but no leading,
whitespace, but significantly faster for strings with no whitespace,
which is presumed to be the most common case.

R=floitsch@google.com, srdjan@google.com

Review URL: https://codereview.chromium.org//398813002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38848 260f80e4-7a28-3924-810f-c04153c831b5
 2014-08-04 07:56:18 +00:00
lrn@google.com f48e9cb218 Address comments on double-parse implementation from earlier CL. 
Comments at https://codereview.chromium.org/368483004/#msg7

R=fschneider@google.com, iposva@google.com

Review URL: https://codereview.chromium.org//381603002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38224 260f80e4-7a28-3924-810f-c04153c831b5
 2014-07-15 08:25:12 +00:00
lrn@google.com 7a32a75dcc Avoid unnecessary copying when parsing doubles. 
R=sgjesse@google.com, vegorov@google.com

Review URL: https://codereview.chromium.org//368483004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37863 260f80e4-7a28-3924-810f-c04153c831b5
 2014-07-01 11:59:31 +00:00
srdjan@google.com 97021b5861 Add class id constants fields to dart:_internal class 'ClassID'. Use the fields in the library (more uses to come). 
R=asiva@google.com

Review URL: https://codereview.chromium.org//351673002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37628 260f80e4-7a28-3924-810f-c04153c831b5
 2014-06-23 22:41:59 +00:00
srdjan@google.com d44423b766 Add VM internal Dart class 'ClassID' used to manage class-ids of known classes. Next CL: add constant fields corresponding to each class id (smiCid, oneByteStringCid, etc). 
R=asiva@google.com

Review URL: https://codereview.chromium.org//345223003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37567 260f80e4-7a28-3924-810f-c04153c831b5
 2014-06-20 20:56:55 +00:00
lrn@google.com 88ba8efed9 Optimize one-byte string's toUpperCase. 
R=ajohnsen@google.com, srdjan@google.com

Review URL: https://codereview.chromium.org//213293002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34812 260f80e4-7a28-3924-810f-c04153c831b5
 2014-04-08 07:19:33 +00:00
ajohnsen@google.com a9f357b4b6 Speed up toLowerCase, by manually inlining the upper-case part. 
Some benchmarks show up to 25% faster toLowerCase.

BUG=
R=lrn@google.com

Review URL: https://codereview.chromium.org//212163005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34423 260f80e4-7a28-3924-810f-c04153c831b5
 2014-03-26 12:19:55 +00:00
lrn@google.com 249d09fd82 Optimize String.fromCharCode. 
BUG= http://dartbug.com/17781
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//212423003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34419 260f80e4-7a28-3924-810f-c04153c831b5
 2014-03-26 11:37:01 +00:00
ajohnsen@google.com fbdb9a85d8 Add optimized _OneByteString.toLowerCase. 
BUG=
R=sgjesse@google.com, sra@google.com, srdjan@google.com

Review URL: https://codereview.chromium.org//209443005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34393 260f80e4-7a28-3924-810f-c04153c831b5
 2014-03-25 21:44:09 +00:00
lrn@google.com f95e190651 Add string.trimLeft/trimRight. 
BUG= http://dartbug.com/5589
R=floitsch@google.com, sgjesse@google.com

Review URL: https://codereview.chromium.org//190853009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33638 260f80e4-7a28-3924-810f-c04153c831b5
 2014-03-13 07:16:51 +00:00
lrn@google.com 69145994de Allow multi-codeunit padding in String.padLeft/padRight. 
Also allow negative repeats.

Based on suggestions from Stephen.

R=sra@google.com

Review URL: https://codereview.chromium.org//171773003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32843 260f80e4-7a28-3924-810f-c04153c831b5
 2014-02-20 07:17:11 +00:00
lrn@google.com a3ad46de0d Add String.repeat, String.padLeft, String.padRight. 
We keep seeing reimplementations everywhere, and reimplementing it ourselves.

BUG= http://dartbug.com/16919
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//172153002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32784 260f80e4-7a28-3924-810f-c04153c831b5
 2014-02-19 12:32:56 +00:00
ajohnsen@google.com 03c7cf69f3 Add optimized String.fromCharCodes path for Uint8List and Int8List. 
BUG=
R=srdjan@google.com

Review URL: https://codereview.chromium.org//74423005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30496 260f80e4-7a28-3924-810f-c04153c831b5
 2013-11-21 06:12:01 +00:00
hausner@google.com c96bc29ab5 Compile time error if name is used before variable is declared 
Implement proper semantics if a name has been referenced in a
block and later a variable with that same name is declared.

Fix library code that was wrong.

Add new language test, delete a couple of tests that are
outdated, file co19 bug 649.

Dart2js and dart2dart are not yet implementing these compile-time
errors.

R=iposva@google.com

Review URL: https://codereview.chromium.org//51533003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29770 260f80e4-7a28-3924-810f-c04153c831b5
 2013-11-01 21:28:31 +00:00
srdjan@google.com 98aad1b1d0 Optimize OneByteString’s contains function for one character patterns (similar to indexOf). 
R=zra@google.com

Review URL: https://codereview.chromium.org//54503004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29701 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-31 21:13:46 +00:00
sgjesse@google.com 36a67fa046 Implement fromEnvironment on bool, int and String 
This implements const constructor fromEnvironment on bool, int and
String.

The VM have the added -Dname=value option to define the value for the
properties. All values are provided by using the -D - nothing is read
from the environment.

If the resulting value is null or - in the case of int.fromEnvironment
- not a number an ArgumentError is thrown.

This CL does not have any implementation for dart2js.

This is a continuation of the change
https://chromiumcodereview.appspot.com/24975002 by iposva@
BUG=
R=iposva@google.com

Review URL: https://codereview.chromium.org//50983002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29642 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-31 05:46:57 +00:00
srdjan@google.com cacd63cf7b Improve indexOf for one byte string receiver to work with other string classes. 
Optimize access to core class’s class-ids.

R=zra@google.com

Review URL: https://codereview.chromium.org//47073009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29610 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-30 23:51:42 +00:00
srdjan@google.com 15d2afdca4 Fix performance degradation in string buffer benchmarks: concat in native instead of in Dart. 
R=zra@google.com

Review URL: https://codereview.chromium.org//52813002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29567 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-30 17:25:23 +00:00
srdjan@google.com a81288c8ca Improve string library performance. String concat and indexOf. 
Rename String concatAll to concatRange. Optimize concatRange for OneByteStrings (avoids natives), optimize indexOf for one character onByteStrings.

R=iposva@google.com

Review URL: https://codereview.chromium.org//42443002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29472 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-29 18:18:40 +00:00
srdjan@google.com 255ffb6947 Specialize string equality for various string classes. Add intrinsics for one/two-byte string equality. Improves sudoku_solver by 10%. 
R=regis@google.com, zra@google.com

Review URL: https://codereview.chromium.org//41573003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29266 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-25 18:00:27 +00:00
lrn@google.com ff1d105a0f Remove deprecated 'str' getter on Match. 
BUG= http://dartbug.com/12843
R=floitsch@google.com

Review URL: https://codereview.chromium.org//36073010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29167 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-24 12:06:41 +00:00
srdjan@google.com 1676113897 Fix runtimeType for strings, integers and double: return their interface type. 
R=asiva@google.com

Review URL: https://codereview.chromium.org//25674017

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28286 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-04 22:08:55 +00:00
iposva@google.com e7e2e4bf03 - Rename arrays to lists: 
_ObjectArray -> _List
  _GrowableObjectArray -> _GrowableList
  _ImmutableArray -> _ImmutableList

R=srdjan@google.com

Review URL: https://codereview.chromium.org//25813002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28189 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-03 00:15:14 +00:00
srdjan@google.com 30197aab9d Improve performance of string buffer by modifying concatAll native to allow growable array and an interval. Eliminate unnecessary check for String elements in release mode. 
R=asiva@google.com

Review URL: https://codereview.chromium.org//25087006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28102 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-01 16:48:12 +00:00
lrn@google.com df78198c50 Remove String.concat from implementation classes. 
It was removed from the interface a long time ago.

BUG= http://dartbug.com/13128
R=floitsch@google.com

Review URL: https://codereview.chromium.org//23464040

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27286 260f80e4-7a28-3924-810f-c04153c831b5
 2013-09-09 11:04:45 +00:00
lrn@google.com 3f23ba6d14 Fix implementations of Match too, to use "input", not "str". 
Fix accidental rename of str to src.

R=sgjesse@google.com

Review URL: https://codereview.chromium.org//23490008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26781 260f80e4-7a28-3924-810f-c04153c831b5
 2013-08-28 11:33:56 +00:00